October 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: fix SCCP_MAX_OPTIONAL_DATA 128
by laforge 22 Oct '25

22 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email ) Change subject: fix SCCP_MAX_OPTIONAL_DATA 128 ...................................................................... fix SCCP_MAX_OPTIONAL_DATA 128 Related: SYS#7600 Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c --- M include/osmocom/sccp/sccp_types.h M src/sccp_vty.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 4 files changed, 26 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/sccp/sccp_types.h b/include/osmocom/sccp/sccp_types.h index 5be0392..ab688b3 100644 --- a/include/osmocom/sccp/sccp_types.h +++ b/include/osmocom/sccp/sccp_types.h @@ -24,7 +24,25 @@ #include <osmocom/core/endian.h> #include <osmocom/core/utils.h> -#define SCCP_MAX_OPTIONAL_DATA 130 +/* ITU Q.713 3.16 Data is a variable-length IE, meaning it has two header + * octets: + * - one octet of "Parameter name code", + * - plus one octet of length. + * + * In + * - 4.2 CR, + * - 4.3 CC, + * - 4.4 CREF, + * - 4.5 RLSD, + * there are optional "Data" IEs with length indicated as "3-130" octets: the + * minimum of 3 stems from the two header octets plus one data octet. Note that + * when there are zero data octets, the entire "Data" IE is omitted. + * + * Hence, the maximum of 130 includes the two header octets, and the actual + * maximum data length is 128. + */ +#define SCCP_MAX_OPTIONAL_DATA 128 + #define SCCP_MAX_DATA 256 /* Table 1/Q.713 - SCCP message types */ diff --git a/src/sccp_vty.c b/src/sccp_vty.c index 5243346..6b40134 100644 --- a/src/sccp_vty.c +++ b/src/sccp_vty.c @@ -218,10 +218,10 @@ "Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages." " For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD" " messages without any payload, and send the data payload in a separate Data Form 1 message." - " ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 130 bytes for the 'Data' parameter. This limit can be" + " ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 128 bytes for the 'Data' parameter. This limit can be" " adjusted here. May be useful for interop with nonstandard SCCP peers.\n" "Set a non-standard maximum allowed number of bytes\n" - "Use the ITU-T Q.713 4.2 to 4.5 standard value of 130\n", + "Use the ITU-T Q.713 4.2 to 4.5 standard value of 128\n", CMD_ATTR_IMMEDIATE) { struct osmo_ss7_instance *ss7 = vty->index; diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 3f8dfaf..62ad287 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -714,11 +714,11 @@ <1-999999> Timer value, in seconds OsmoSTP(config-cs7)# sccp ? - max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 130 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. + max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 128 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. OsmoSTP(config-cs7)# sccp max-optional-data ? <0-999999> Set a non-standard maximum allowed number of bytes - standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 130 + standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 128 OsmoSTP(config-cs7)# show running-config ... !sccp max-optional-data @@ -749,7 +749,7 @@ OsmoSTP(config-cs7)# show running-config ... !sccp max-optional-data -OsmoSTP(config-cs7)# sccp max-optional-data 130 +OsmoSTP(config-cs7)# sccp max-optional-data 128 OsmoSTP(config-cs7)# show running-config ... !sccp max-optional-data diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index 2bf753d..581bc38 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -513,11 +513,11 @@ <1-999999> Timer value, in seconds ss7_asp_vty_test(config-cs7)# sccp ? - max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 130 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. + max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 128 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. ss7_asp_vty_test(config-cs7)# sccp max-optional-data ? <0-999999> Set a non-standard maximum allowed number of bytes - standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 130 + standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 128 ss7_asp_vty_test(config-cs7)# show running-config ... !sccp max-optional-data -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c Gerrit-Change-Number: 41192 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: fix SCCP_MAX_OPTIONAL_DATA 128
by laforge 22 Oct '25

22 Oct '25

Attention is currently required from: neels, osmith, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email ) Change subject: fix SCCP_MAX_OPTIONAL_DATA 128 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41192?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c Gerrit-Change-Number: 41192 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 09:08:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: scripts/reminder-extend-obs-key: fix typo
by osmith 22 Oct '25

22 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41239?usp=email ) Change subject: scripts/reminder-extend-obs-key: fix typo ...................................................................... scripts/reminder-extend-obs-key: fix typo One year is 365(.25) days, not 356. Fix that the alarm would have gone off 9 days later than expected. Change-Id: I8b46b6b18ce1dea01c5c6c0beb4f10e924f8e4bc --- M scripts/reminder-extend-obs-key.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/reminder-extend-obs-key.sh b/scripts/reminder-extend-obs-key.sh index 2eeebb0..2be25cf 100755 --- a/scripts/reminder-extend-obs-key.sh +++ b/scripts/reminder-extend-obs-key.sh @@ -10,7 +10,7 @@ EXPIRATION_DATE="$(gpg --show-keys public_key | grep -o 'expires: [0-9-]*' | cut -d ' ' -f2)" EXPIRATION_DATE_S="$(date -d "$EXPIRATION_DATE" +%s)" -ONE_YEAR_FROM_NOW="$(date -d "+356 days" +%Y-%m-%d)" +ONE_YEAR_FROM_NOW="$(date -d "+365 days" +%Y-%m-%d)" ONE_YEAR_FROM_NOW_S="$(date -d "$ONE_YEAR_FROM_NOW" +%s)" set +x -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8b46b6b18ce1dea01c5c6c0beb4f10e924f8e4bc Gerrit-Change-Number: 41239 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: scripts/reminder-extend-obs-key: fix typo
by fixeria 22 Oct '25

22 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41239?usp=email ) Change subject: scripts/reminder-extend-obs-key: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8b46b6b18ce1dea01c5c6c0beb4f10e924f8e4bc Gerrit-Change-Number: 41239 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 08:54:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add Raspbian:13
by osmith 22 Oct '25

22 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41237?usp=email ) Change subject: jobs/osmocom-obs-sync: add Raspbian:13 ...................................................................... jobs/osmocom-obs-sync: add Raspbian:13 Change-Id: Ib308d12cae2def42c3f1892f606e15c8aebfe140 --- M jobs/osmocom-obs-sync.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 7110b02..146efa3 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -40,6 +40,7 @@ Raspbian:10 Raspbian:11 Raspbian:12 + Raspbian:13 Ubuntu:22.04 Ubuntu:24.04 Ubuntu:25.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib308d12cae2def42c3f1892f606e15c8aebfe140 Gerrit-Change-Number: 41237 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: contrib/obs-mirror: add Raspbian_13
by osmith 22 Oct '25

22 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41238?usp=email ) Change subject: contrib/obs-mirror: add Raspbian_13 ...................................................................... contrib/obs-mirror: add Raspbian_13 Change-Id: I73e0dbb820935be2f2754a2e2b3e6b3bff409552 --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index 9665cb0..5031b57 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -4,6 +4,7 @@ latest/Debian_13 latest/Raspbian_11 latest/Raspbian_12 +latest/Raspbian_13 latest/xUbuntu_22.04 latest/xUbuntu_24.04 latest/xUbuntu_25.04 @@ -15,6 +16,7 @@ nightly/Debian_13 nightly/Raspbian_11 nightly/Raspbian_12 +nightly/Raspbian_13 nightly/xUbuntu_22.04 nightly/xUbuntu_24.04 nightly/xUbuntu_25.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I73e0dbb820935be2f2754a2e2b3e6b3bff409552 Gerrit-Change-Number: 41238 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add Raspbian:13
by fixeria 22 Oct '25

22 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41237?usp=email ) Change subject: jobs/osmocom-obs-sync: add Raspbian:13 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib308d12cae2def42c3f1892f606e15c8aebfe140 Gerrit-Change-Number: 41237 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 08:47:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: contrib/obs-mirror: add Raspbian_13
by fixeria 22 Oct '25

22 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41238?usp=email ) Change subject: contrib/obs-mirror: add Raspbian_13 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I73e0dbb820935be2f2754a2e2b3e6b3bff409552 Gerrit-Change-Number: 41238 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 08:47:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: add Raspbian:13
by fixeria 22 Oct '25

22 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41237?usp=email ) Change subject: jobs/osmocom-obs-sync: add Raspbian:13 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib308d12cae2def42c3f1892f606e15c8aebfe140 Gerrit-Change-Number: 41237 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 08:47:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: scripts/reminder-extend-obs-key: fix typo
by osmith 22 Oct '25

22 Oct '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41239?usp=email ) Change subject: scripts/reminder-extend-obs-key: fix typo ...................................................................... scripts/reminder-extend-obs-key: fix typo One year is 365(.25) days, not 356. Fix that the alarm would have gone off 9 days later than expected. Change-Id: I8b46b6b18ce1dea01c5c6c0beb4f10e924f8e4bc --- M scripts/reminder-extend-obs-key.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/39/41239/1 diff --git a/scripts/reminder-extend-obs-key.sh b/scripts/reminder-extend-obs-key.sh index 2eeebb0..2be25cf 100755 --- a/scripts/reminder-extend-obs-key.sh +++ b/scripts/reminder-extend-obs-key.sh @@ -10,7 +10,7 @@ EXPIRATION_DATE="$(gpg --show-keys public_key | grep -o 'expires: [0-9-]*' | cut -d ' ' -f2)" EXPIRATION_DATE_S="$(date -d "$EXPIRATION_DATE" +%s)" -ONE_YEAR_FROM_NOW="$(date -d "+356 days" +%Y-%m-%d)" +ONE_YEAR_FROM_NOW="$(date -d "+365 days" +%Y-%m-%d)" ONE_YEAR_FROM_NOW_S="$(date -d "$ONE_YEAR_FROM_NOW" +%s)" set +x -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41239?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8b46b6b18ce1dea01c5c6c0beb4f10e924f8e4bc Gerrit-Change-Number: 41239 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log October 2025