October 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: bsc: TC_lcs_loc_req_without_smlc: new test
by osmith 30 Oct '25

30 Oct '25

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email ) Change subject: bsc: TC_lcs_loc_req_without_smlc: new test ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 Gerrit-Change-Number: 41288 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 30 Oct 2025 08:10:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs: build binary packages earlier
by fixeria 29 Oct '25

29 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41286?usp=email ) Change subject: jobs/osmocom-obs: build binary packages earlier ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ief55cab9308503d582fcfe0c602c75bb48be7dae Gerrit-Change-Number: 41286 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Oct 2025 19:04:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: Don't crash on loc req with disabled SMLC
by fixeria 29 Oct '25

29 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41287?usp=email ) Change subject: Don't crash on loc req with disabled SMLC ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8a66f9decf9fff602f7fecfb71a78fab900066f Gerrit-Change-Number: 41287 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Oct 2025 16:59:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: TC_lcs_loc_req_without_smlc: new test
by osmith 29 Oct '25

29 Oct '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email ) Change subject: bsc: TC_lcs_loc_req_without_smlc: new test ...................................................................... bsc: TC_lcs_loc_req_without_smlc: new test Related: SYS#7714 Depends: osmo-bsc Ie8a66f9decf9fff602f7fecfb71a78fab900066f Change-Id: I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 --- M bsc/BSC_Tests.ttcn M library/Osmocom_VTY_Functions.ttcn 2 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/88/41288/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 156c8ef..dc59fcb 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9492,6 +9492,18 @@ f_vty_transceive(BSCVTY, "exit"); } +/* Enable/Disable SMLC via VTY */ +private function f_vty_enable_smlc(boolean enable) runs on test_CT { + f_vty_enter_cfg_smlc(BSCVTY); + if (enable) { + f_vty_transceive(BSCVTY, "enable"); + } else { + f_vty_transceive(BSCVTY, "no enable"); + } + f_vty_transceive(BSCVTY, "exit"); + f_vty_transceive(BSCVTY, "exit"); +} + /* Begin assignment procedure and send an EMERGENCY SETUP (RR) */ private function f_assignment_emerg_setup() runs on MSC_ConnHdlr { var PDU_ML3_MS_NW emerg_setup; @@ -11014,6 +11026,24 @@ f_shutdown_helper(); } +/* Ensure that Location Requests from MSC without SMLC configured lead to a + * proper error towards the MSC (SYS#7714) */ +private function f_tc_lcs_loc_req_without_smlc(charstring id) runs on MSC_ConnHdlr { + f_lcs_loc_req_for_active_ms(false); +} +testcase TC_lcs_loc_req_without_smlc() runs on test_CT { + var MSC_ConnHdlr vc_conn; + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + + f_init(1, true); + f_vty_enable_smlc(false); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_lcs_loc_req_without_smlc), pars); + vc_conn.done; + f_vty_enable_smlc(true); + f_shutdown_helper(); +} + /* Attempt Complete Layer 3 without any MSC available (OS#4832) */ private function f_tc_no_msc(charstring id) runs on MSC_ConnHdlr { f_MscConnHdlr_init(g_pars.media_nr, "127.0.0.2", "127.0.0.3", FR_AMR); @@ -12976,6 +13006,12 @@ execute( TC_emerg_call_and_lcs_loc_req() ); execute( TC_emerg_call_and_lcs_loc_req_early_lchan_rel_ind() ); execute( TC_emerg_call_and_lcs_loc_req_early_lchan_conn_fail() ); + + /* Remove "is nightly" check after osmo-bsc > 1.13 is released + * with Ie8a66f9decf9fff602f7fecfb71a78fab900066f */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_lcs_loc_req_without_smlc() ); + } } execute( TC_no_msc() ); diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn index dc87131..7dd5c59 100644 --- a/library/Osmocom_VTY_Functions.ttcn +++ b/library/Osmocom_VTY_Functions.ttcn @@ -154,6 +154,11 @@ f_vty_transceive(pt, "cs7 instance " & int2str(cs7_inst)); } +function f_vty_enter_cfg_smlc(TELNETasp_PT pt) { + f_vty_enter_config(pt); + f_vty_transceive(pt, "smlc"); +} + type record of charstring rof_charstring; function f_vty_config3(TELNETasp_PT pt, rof_charstring config_nodes, rof_charstring cmds) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 Gerrit-Change-Number: 41288 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: Don't crash on loc req with disabled SMLC
by osmith 29 Oct '25

29 Oct '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41287?usp=email ) Change subject: Don't crash on loc req with disabled SMLC ...................................................................... Don't crash on loc req with disabled SMLC Fix that OsmoBSC crashes when receiving a location request from the MSC while the SMLC is disabled. With this patch, a system failure is reported to the MSC and the following error message is logged: SUBSCR_CONN(msc0-conn1_subscr-IMSI-001019935148766)[0x59d28e261f60]{ACTIVE}: Lb link to SMLC is not ready (no RESET-ACK), cannot send BSSMAP-LE PERFORM LOCATION REQUEST with BSSLAP TA Layer3 Suggested-by: Harald Welte <laforge(a)osmocom.org> Related: SYS#7714 Related: osmo-ttcn3-hacks I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 Change-Id: Ie8a66f9decf9fff602f7fecfb71a78fab900066f --- M src/osmo-bsc/bssmap_reset.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/87/41287/1 diff --git a/src/osmo-bsc/bssmap_reset.c b/src/osmo-bsc/bssmap_reset.c index 018ecba..3c28186 100644 --- a/src/osmo-bsc/bssmap_reset.c +++ b/src/osmo-bsc/bssmap_reset.c @@ -240,6 +240,9 @@ bool bssmap_reset_is_conn_ready(const struct bssmap_reset *bssmap_reset) { + /* bssmap_reset is NULL if SMLC is not enabled in the config */ + if (bssmap_reset == NULL) + return false; return bssmap_reset->fi->state == BSSMAP_RESET_ST_CONN; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8a66f9decf9fff602f7fecfb71a78fab900066f Gerrit-Change-Number: 41287 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs: build binary packages earlier
by osmith 29 Oct '25

29 Oct '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41286?usp=email ) Change subject: jobs/osmocom-obs: build binary packages earlier ...................................................................... jobs/osmocom-obs: build binary packages earlier We have recently noticed that with current settings the nightly arm packages have still not finished the next morning. Schedule nightly OBS packages 2-3 hours earlier to avoid this. Change-Id: Ief55cab9308503d582fcfe0c602c75bb48be7dae --- M jobs/README.md M jobs/osmocom-obs.yml 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/86/41286/1 diff --git a/jobs/README.md b/jobs/README.md index 1997d33..bdc7993 100644 --- a/jobs/README.md +++ b/jobs/README.md @@ -153,10 +153,10 @@ ``` 18:00 - 21:00 OBS related + 18:00 osmocom-obs (new nightly binary packages start building on OBS!) 18:XX osmocom-obs-sync (sync Debian:12 etc. with openSUSE OBS) 19:XX osmocom-obs-check-new-distros 19:XX osmocom-obs-wireshark - 20:XX osmocom-obs (new binary packages start building on OBS!) 22:00 - 01:00 Jobs that don't need binary packages 22:XX coverity diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index fd0c1fe..1abcbfc 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -71,7 +71,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' triggers: - - timed: "H 20 * * *" + - timed: "00 18 * * *" publishers: - email: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ief55cab9308503d582fcfe0c602c75bb48be7dae Gerrit-Change-Number: 41286 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: fix sourcecode formatting
by dexter 28 Oct '25

28 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41284?usp=email ) Change subject: smdpp_Tests: fix sourcecode formatting ...................................................................... smdpp_Tests: fix sourcecode formatting Related: SYS#7339 Change-Id: Id7edf94858a952b22bd8b86957a05b18968e085e --- M smdpp/smdpp_Tests.ttcn 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn index 1210353..f079ab6 100644 --- a/smdpp/smdpp_Tests.ttcn +++ b/smdpp/smdpp_Tests.ttcn @@ -519,7 +519,6 @@ } ext_logInfo("HTTP client (ES2+) configured"); - return true; } @@ -567,7 +566,6 @@ } ext_logInfo("HTTP client (ES9+) configured"); - return true; } @@ -3048,7 +3046,6 @@ ext_logInfo("Step 2: Starting retry flow"); var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); - var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request(); var RemoteProfileProvisioningResponse authClientResp := f_es9p_transceive_success(authClientReq); var AuthenticateClientOk authClientOk := authClientResp.authenticateClientResponseEs9.authenticateClientOk; @@ -3227,8 +3224,7 @@ } var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); - - var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request("CC_REQUIRED_TEST"); + var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request("CC_REQUIRED_TEST"); var RemoteProfileProvisioningResponse authClientResp := f_es9p_transceive_success(authClientReq); var AuthenticateClientOk authClientOk := authClientResp.authenticateClientResponseEs9.authenticateClientOk; @@ -4225,7 +4221,6 @@ } var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); - var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request(); var RemoteProfileProvisioningResponse authClientResp := f_es9p_transceive_success(authClientReq); var AuthenticateClientOk authClientOk := authClientResp.authenticateClientResponseEs9.authenticateClientOk; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7edf94858a952b22bd8b86957a05b18968e085e Gerrit-Change-Number: 41284 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: fix sourcecode formatting
by dexter 28 Oct '25

28 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41284?usp=email ) Change subject: smdpp_Tests: fix sourcecode formatting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7edf94858a952b22bd8b86957a05b18968e085e Gerrit-Change-Number: 41284 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Oct 2025 17:34:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: fix typo
by dexter 28 Oct '25

28 Oct '25

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41283?usp=email ) Change subject: smdpp_Tests: fix typo ...................................................................... smdpp_Tests: fix typo Related: SYS#7339 Change-Id: I8c2dc134f78b2780641a82baf0cebbb3ffbf9150 --- M smdpp/smdpp_Tests.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/smdpp/smdpp_Tests.cfg b/smdpp/smdpp_Tests.cfg index 1b4fd99..49269c8 100644 --- a/smdpp/smdpp_Tests.cfg +++ b/smdpp/smdpp_Tests.cfg @@ -18,7 +18,7 @@ [TESTPORT_PARAMETERS] [MODULE_PARAMETERS] -# ES2+ specific parameters +# ES9+ specific parameters # smdpp_Tests.mp_es9plus_server_port_nist := 8000 # smdpp_Tests.mp_es9plus_server_port_brp := 8001 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c2dc134f78b2780641a82baf0cebbb3ffbf9150 Gerrit-Change-Number: 41283 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: fix typo
by dexter 28 Oct '25

28 Oct '25

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41283?usp=email ) Change subject: smdpp_Tests: fix typo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c2dc134f78b2780641a82baf0cebbb3ffbf9150 Gerrit-Change-Number: 41283 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Oct 2025 17:33:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0