October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: fix sourcecode formatting
by dexter 28 Oct '25

28 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41284?usp=email ) Change subject: smdpp_Tests: fix sourcecode formatting ...................................................................... smdpp_Tests: fix sourcecode formatting Related: SYS#7339 Change-Id: Id7edf94858a952b22bd8b86957a05b18968e085e --- M smdpp/smdpp_Tests.ttcn 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/84/41284/1 diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn index 1210353..f079ab6 100644 --- a/smdpp/smdpp_Tests.ttcn +++ b/smdpp/smdpp_Tests.ttcn @@ -519,7 +519,6 @@ } ext_logInfo("HTTP client (ES2+) configured"); - return true; } @@ -567,7 +566,6 @@ } ext_logInfo("HTTP client (ES9+) configured"); - return true; } @@ -3048,7 +3046,6 @@ ext_logInfo("Step 2: Starting retry flow"); var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); - var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request(); var RemoteProfileProvisioningResponse authClientResp := f_es9p_transceive_success(authClientReq); var AuthenticateClientOk authClientOk := authClientResp.authenticateClientResponseEs9.authenticateClientOk; @@ -3227,8 +3224,7 @@ } var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); - - var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request("CC_REQUIRED_TEST"); + var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request("CC_REQUIRED_TEST"); var RemoteProfileProvisioningResponse authClientResp := f_es9p_transceive_success(authClientReq); var AuthenticateClientOk authClientOk := authClientResp.authenticateClientResponseEs9.authenticateClientOk; @@ -4225,7 +4221,6 @@ } var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); - var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request(); var RemoteProfileProvisioningResponse authClientResp := f_es9p_transceive_success(authClientReq); var AuthenticateClientOk authClientOk := authClientResp.authenticateClientResponseEs9.authenticateClientOk; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41284?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7edf94858a952b22bd8b86957a05b18968e085e Gerrit-Change-Number: 41284 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: fix typo
by dexter 28 Oct '25

28 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41283?usp=email ) Change subject: smdpp_Tests: fix typo ...................................................................... smdpp_Tests: fix typo Related: SYS#7339 Change-Id: I8c2dc134f78b2780641a82baf0cebbb3ffbf9150 --- M smdpp/smdpp_Tests.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/41283/1 diff --git a/smdpp/smdpp_Tests.cfg b/smdpp/smdpp_Tests.cfg index 1b4fd99..49269c8 100644 --- a/smdpp/smdpp_Tests.cfg +++ b/smdpp/smdpp_Tests.cfg @@ -18,7 +18,7 @@ [TESTPORT_PARAMETERS] [MODULE_PARAMETERS] -# ES2+ specific parameters +# ES9+ specific parameters # smdpp_Tests.mp_es9plus_server_port_nist := 8000 # smdpp_Tests.mp_es9plus_server_port_brp := 8001 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c2dc134f78b2780641a82baf0cebbb3ffbf9150 Gerrit-Change-Number: 41283 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: optimize calling of f_init_esXplus
by dexter 28 Oct '25

28 Oct '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41285?usp=email ) Change subject: smdpp_Tests: optimize calling of f_init_esXplus ...................................................................... smdpp_Tests: optimize calling of f_init_esXplus When we call the f_init_esXplus functions we always check the return code to see if the initialization went ok. However in both functions we already set the verdict and in the ES2+ variant of the functions we already stop the MTC. Let's optimize the function calls so that we only call the function without checking the return code. Let's do all the error handling and the stopping of the MTC in inside f_init_esXplus. Related: SYS#7339 Change-Id: I64fc5a7eddd6c5aee8ce85dbfe56c076f3372f3d --- M smdpp/smdpp_Tests.ttcn 1 file changed, 79 insertions(+), 156 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/41285/1 diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn index f079ab6..276791d 100644 --- a/smdpp/smdpp_Tests.ttcn +++ b/smdpp/smdpp_Tests.ttcn @@ -491,7 +491,7 @@ /* RSP CLIENT WRAPPER FUNCTIONS */ // Initialize RSP client for ES2+ -function f_init_es2plus() runs on smdpp_ConnHdlr return boolean { +function f_init_es2plus() runs on smdpp_ConnHdlr { // Initialize RSP client using imported function from smdpp_Tests g_rsp_client_handle_es2p := smdpp_Tests.ext_RSPClient_create( mp_es2plus_server_fqdn, @@ -519,11 +519,10 @@ } ext_logInfo("HTTP client (ES2+) configured"); - return true; } // Initialize RSP client for ES9+ -private function f_init_es9plus() runs on smdpp_ConnHdlr return boolean { +private function f_init_es9plus() runs on smdpp_ConnHdlr { ext_logInfo("Initializing RSP client"); g_rsp_client_handle_es9p := ext_RSPClient_create( @@ -535,19 +534,19 @@ if (g_rsp_client_handle_es9p < 0) { setverdict(fail, "Failed to initialize RSP client for ES9+"); - return false; + mtc.stop; } if (ext_RSPClient_loadEUICCCertificate(g_rsp_client_handle_es9p, g_pars_smdpp.euicc_cert_path) != 0) { ext_logError("Failed to load eUICC certificate for ES9+"); f_rsp_client_cleanup(); - return false; + mtc.stop; } if (ext_RSPClient_loadEUICCKeyPair(g_rsp_client_handle_es9p, g_pars_smdpp.euicc_key_path) != 0) { ext_logError("Failed to load eUICC private key for ES9+"); f_rsp_client_cleanup(); - return false; + mtc.stop; } // Configure HTTP client @@ -562,11 +561,10 @@ if (result != 0) { ext_logError("Failed to configure HTTP client"); f_rsp_client_cleanup(); - return false; + mtc.stop; } ext_logInfo("HTTP client (ES9+) configured"); - return true; } private function f_rsp_client_cleanup() runs on smdpp_ConnHdlr { @@ -1815,10 +1813,8 @@ ) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: " & params.testName & " ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -2033,10 +2029,7 @@ ext_logInfo("=== Testing AuthenticateClient Error: " & test_name & " ==="); /* Initialize HTTP/TLS and RSP client */ - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + f_init_es9plus(); /* Step 1: InitiateAuthentication (normal) */ var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); @@ -2190,11 +2183,8 @@ ext_logInfo("=== Testing GetBoundProfilePackage Error: " & test_name & " ==="); - /* Initialize RSP client */ - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); /* Step 1: InitiateAuthentication */ var InitiateAuthenticationOkEs9 initAuthOk; @@ -2327,10 +2317,8 @@ private function f_initiateAuth_generic(charstring id, template (omit) octetstring version := omit, charstring testDescription, charstring successMessage, boolean checkPkid := false) runs on smdpp_ConnHdlr { ext_logInfo(testDescription); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var RemoteProfileProvisioningRequest authRequest := f_create_initiate_authentication_request(); @@ -2392,10 +2380,8 @@ private function f_TC_InitiateAuth_02_Uniqueness(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: InitiateAuthentication - Uniqueness of Transaction ID and Server Challenge ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); /* Step 1: First InitiateAuthentication request */ var RemoteProfileProvisioningRequest authRequest1 := f_create_initiate_authentication_request(); @@ -2410,11 +2396,7 @@ /* Step 2: Re-initialize TLS connection (simulated by re-init) */ f_rsp_client_cleanup(); - - if (not f_init_es9plus()) { - setverdict(fail, "RSP client re-initialization failed"); - return; - } + f_init_es9plus(); /* Step 3: Second InitiateAuthentication request */ var RemoteProfileProvisioningRequest authRequest2 := f_create_initiate_authentication_request(); @@ -2455,10 +2437,8 @@ private function f_TC_InitiateAuth_03_InvalidServerAddress(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: InitiateAuthentication - Invalid Server Address Error ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); /* Create request with invalid server address */ var RemoteProfileProvisioningRequest authRequest := f_create_initiate_authentication_request(); @@ -2523,10 +2503,8 @@ ) runs on smdpp_ConnHdlr { ext_logInfo(params.testName); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); /* retry scenarios */ var octetstring saved_euicc_otpk; @@ -2750,10 +2728,8 @@ ) runs on smdpp_ConnHdlr { ext_logInfo(testName); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus() if (requireCC) { g_pars_smdpp.cc_required := true; @@ -2885,10 +2861,8 @@ ext_logInfo("=== Testing AuthenticateClient Retry After Cancelled Session ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); /* Step 1: First session - will be cancelled */ ext_logInfo("Step 1: Starting first session (to be cancelled)"); @@ -2967,7 +2941,6 @@ } var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); - var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request(matchingId); var RemoteProfileProvisioningResponse authClientResp := f_es9p_transceive_success(authClientReq); var AuthenticateClientOk authClientOk := authClientResp.authenticateClientResponseEs9.authenticateClientOk; @@ -3035,10 +3008,8 @@ ) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: GetBoundProfilePackage Retry - " & test_description & " ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); ext_logInfo("Step 1: Initial session and cancellation"); var octetstring initial_smdp_otpk := f_perform_initial_session_and_cancel(); @@ -3218,10 +3189,8 @@ private function f_TC_GetBoundProfilePackage_Retry_09_ConfirmationCode(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: GetBoundProfilePackage - Confirmation Code Retry ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request("CC_REQUIRED_TEST"); @@ -3315,10 +3284,9 @@ integer reason, charstring reason_name ) runs on smdpp_ConnHdlr { - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus() var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); @@ -3397,10 +3365,9 @@ charstring id, CancelSessionReason reason ) runs on smdpp_ConnHdlr { - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus() ext_logInfo("=== Steps 1-3: InitiateAuth, AuthenticateClient, GetBoundProfilePackage ==="); var GetBoundProfilePackageOk packageOk := f_perform_session_through_getBoundProfilePackage(); @@ -3506,10 +3473,9 @@ CancelSessionErrorInjection err_injection, charstring test_description ) runs on smdpp_ConnHdlr { - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus() var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); @@ -3591,10 +3557,9 @@ CancelSessionErrorInjection err_injection, charstring test_description ) runs on smdpp_ConnHdlr { - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus() var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); @@ -3774,10 +3739,8 @@ ext_logInfo("Starting complete RSP flow test"); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus() ext_logInfo("=== Step 1: InitiateAuthentication ==="); @@ -4042,10 +4005,8 @@ ) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: HandleNotification - " & test_description & " ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); @@ -4174,10 +4135,8 @@ private function f_TC_HandleNotification_02_OtherSignedNotification(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: HandleNotification - OtherSignedNotification ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var NotificationMetadata notifMeta := { seqNumber := 2, /* Different sequence number from PIR */ @@ -4215,10 +4174,8 @@ ) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: GetBoundProfilePackage - " & test_description & " ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); var RemoteProfileProvisioningRequest authClientReq := f_create_authenticate_client_request(); @@ -4324,10 +4281,8 @@ private function f_TC_GetBoundProfilePackage_05_Metadata_Split(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: GetBoundProfilePackage - S-ENC/S-MAC with Metadata Split ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); /* Perform standard flow up to GetBoundProfilePackage */ var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); @@ -4363,10 +4318,8 @@ private function f_TC_InitiateAuth_04_UnsupportedPKID(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: InitiateAuthentication - Unsupported Public Key Identifiers Error ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var RemoteProfileProvisioningRequest authRequest := f_create_initiate_authentication_request(); /* unsupported PKIDs that server won't recognize */ @@ -4385,10 +4338,8 @@ private function f_TC_InitiateAuth_05_UnsupportedVersion(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: InitiateAuthentication - Unsupported Specification Version Error ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); /* version too low */ ext_logInfo("Testing with SGP.22 version too low (v1.0.0)"); @@ -4415,10 +4366,8 @@ private function f_TC_InitiateAuth_06_UnavailableServerAuthCert(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: InitiateAuthentication - Unavailable Server Auth Certificate Error ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var RemoteProfileProvisioningRequest authRequest := f_create_initiate_authentication_request(); /* we need to: @@ -4590,10 +4539,8 @@ private function f_TC_AuthenticateClient_19_Extended_UICC_Capability(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Extended UICC Capability ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -4623,10 +4570,8 @@ private function f_TC_AuthenticateClient_20_Extended_DeviceInfo(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Extended DeviceInfo ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -4678,10 +4623,8 @@ private function f_TC_AuthenticateClient_21_Extended_eUICCInfo2(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Extended eUICCInfo2 ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -4726,10 +4669,8 @@ private function f_TC_AuthenticateClient_Error_01_InvalidEUMCert(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Error: Invalid EUM Certificate ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -4752,10 +4693,8 @@ private function f_TC_AuthenticateClient_Error_02_ExpiredEUMCert(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Error: Expired EUM Certificate ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -4778,10 +4717,8 @@ private function f_TC_AuthenticateClient_Error_03_InvalidEUICCCert(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Error: Invalid eUICC Certificate ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -4804,10 +4741,8 @@ private function f_TC_AuthenticateClient_Error_04_ExpiredEUICCCert(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Error: Expired eUICC Certificate ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -4830,10 +4765,8 @@ private function f_TC_AuthenticateClient_Error_07_UnknownCIKey(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Error: Unknown CI Public Key ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var octetstring serverChallenge := f_performInitiateAuthentication(); @@ -4913,10 +4846,8 @@ * The profile has PPR1 set (disabling not allowed) but the eUICC reports PPR1 as forbidden * because an operational profile is already installed */ - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); var InitiateAuthenticationOkEs9 authOk := f_initiate_authentication_and_validate(); @@ -5034,10 +4965,8 @@ private function f_TC_AuthenticateClient_03_SecondAttempt_AfterInvalidMatchingID(charstring id) runs on smdpp_ConnHdlr { ext_logInfo("=== Test Case: AuthenticateClient - Second Attempt After Invalid MatchingID ==="); - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); /* Step IC1: PROC_ES9+_AUTH_CLIENT_FAIL_DEF_DP_USE_CASE_INVALID_MATCHING_ID */ ext_logInfo("Step IC1: First attempt with activation code matching ID (should fail)"); @@ -5726,15 +5655,9 @@ const charstring c_cert_path := "./test_certs/CERT_MNO_ECDSA_NIST.pem"; const charstring c_key_path := "./test_certs/SK_MNO_ECDSA_NIST.pem"; - if (not f_init_es9plus()) { - setverdict(fail, "RSP client initialization failed"); - return; - } - - if (not f_init_es2plus()) { - setverdict(fail, "RSP client initialization for ES2+ failed"); - return; - } + /* Initialize HTTP/TLS and RSP client */ + f_init_es9plus(); + f_init_es2plus(); // Step 1: Order profile via ES2+ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I64fc5a7eddd6c5aee8ce85dbfe56c076f3372f3d Gerrit-Change-Number: 41285 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()
by laforge 28 Oct '25

28 Oct '25

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email ) Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/6fae8eee_990c62a4?… : PS1, Line 10: too small, if headroom exceeds 65535. > I agree, our msgb length is constrained to 64k. Done File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/9a2e6fc4_e6502def?… : PS2, Line 193: return msgb_alloc_headroom_c(iofd, size + headroom, headroom, "osmo_io_msgb"); > I used some casting to make it clearer that there can't be an overflow. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Oct 2025 16:57:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()
by laforge 28 Oct '25

28 Oct '25

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email ) Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Oct 2025 16:57:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: doc/osmo-s1gw-cli.md: document {enb,erab}_delete
by laforge 28 Oct '25

28 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41278?usp=email ) Change subject: doc/osmo-s1gw-cli.md: document {enb,erab}_delete ...................................................................... doc/osmo-s1gw-cli.md: document {enb,erab}_delete Change-Id: Iec93f90be4c3989fcb98341581d36f4650028f37 Related: 998a7e0f ("[REST] Implement {Enb,Erab}Delete") --- M doc/osmo-s1gw-cli.md 1 file changed, 36 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/osmo-s1gw-cli.md b/doc/osmo-s1gw-cli.md index e160ffa..4a0bd22 100644 --- a/doc/osmo-s1gw-cli.md +++ b/doc/osmo-s1gw-cli.md @@ -254,6 +254,26 @@ To enable full traceback, run the following command: 'set debug true' ``` +### `enb_delete` + +Force disconnect an eNB. + +``` +Usage: enb_delete [-h] (-H HANDLE | -P PID | -G GENBID | --enb-sctp-aid AID | --mme-sctp-aid AID) + +Force disconnect an eNB + +optional arguments: + -h, --help show this help message and exit + +eNB ID: + -H, --handle HANDLE eNB handle (example: 0) + -P, --pid PID eNB process ID (example: 0.33.1) + -G, --genbid GENBID Global-eNB-ID (example: 262-42-1337) + --enb-sctp-aid AID eNB association identifier (example: 42) + --mme-sctp-aid AID MME association identifier (example: 42) +``` + ### `enb_erab_list` Get E-RAB list for a specific eNB. @@ -349,3 +369,19 @@ | A2U F-TEID | 0x02020001(a)127.0.2.2 | | U2A F-TEID | 0x00020001(a)127.0.0.2 | ``` + +### `erab_delete` + +Terminate an E-RAB FSM process. + +``` +Usage: erab_delete -P PID [-h] + +Terminate an E-RAB FSM process + +required arguments: + -P, --pid PID E-RAB process ID (example: 0.33.1) + +optional arguments: + -h, --help show this help message and exit +``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iec93f90be4c3989fcb98341581d36f4650028f37 Gerrit-Change-Number: 41278 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in ...osmo-s1gw[master]: doc/osmo-s1gw-cli.md: fix 'enb_list' command name
by laforge 28 Oct '25

28 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41277?usp=email ) Change subject: doc/osmo-s1gw-cli.md: fix 'enb_list' command name ...................................................................... doc/osmo-s1gw-cli.md: fix 'enb_list' command name Change-Id: I73495db795ef3c9f0eb07b85f18ca9de23fc048c Fixes: 15067454 ("[REST] Implement EnbList and EnbInfo") --- M doc/osmo-s1gw-cli.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/osmo-s1gw-cli.md b/doc/osmo-s1gw-cli.md index 2e99e7e..e160ffa 100644 --- a/doc/osmo-s1gw-cli.md +++ b/doc/osmo-s1gw-cli.md @@ -151,7 +151,7 @@ Heartbeat failed: timeout ``` -### `do_enb_list` +### `enb_list` Get a list of eNB connections. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I73495db795ef3c9f0eb07b85f18ca9de23fc048c Gerrit-Change-Number: 41277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in ...osmo-s1gw[master]: config/sys.config: separate GTP-U KPI and REST params
by laforge 28 Oct '25

28 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41279?usp=email ) Change subject: config/sys.config: separate GTP-U KPI and REST params ...................................................................... config/sys.config: separate GTP-U KPI and REST params Change-Id: I3804a0901e913e2be1c202d0e84372bc80621c1b --- M config/sys.config 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/config/sys.config b/config/sys.config index 5184ebb..920a30e 100644 --- a/config/sys.config +++ b/config/sys.config @@ -26,6 +26,8 @@ %% {gtpu_kpi_ul_addr, s1ap}, %% GTP-U UL address: s1ap | sctp (default: learn from S1AP) %% {gtpu_kpi_dl_addr, s1ap}, %% GTP-U DL address: s1ap | sctp (default: learn from S1AP) %% {gtpu_kpi_interval, 3000}, %% counter reporting interval (ms) +%% +%% REST interface configuration %% {rest_srv_port, 8080}, %% REST server port (default: 8080) %% {rest_srv_swagger_ui, true} %% REST Swagger UI (default: true) ]}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3804a0901e913e2be1c202d0e84372bc80621c1b Gerrit-Change-Number: 41279 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in ...osmo-s1gw[master]: osmo_s1gw: add set_env/2
by laforge 28 Oct '25

28 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41280?usp=email ) Change subject: osmo_s1gw: add set_env/2 ...................................................................... osmo_s1gw: add set_env/2 Change-Id: I6c88d004ad16d9bed5021f96a1cef2904c0a246a --- M src/osmo_s1gw.erl 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_s1gw.erl b/src/osmo_s1gw.erl index e90d927..4444fe0 100644 --- a/src/osmo_s1gw.erl +++ b/src/osmo_s1gw.erl @@ -35,6 +35,7 @@ -module(osmo_s1gw). -export([get_env/2, + set_env/2, get_priv/1, main/1]). @@ -53,6 +54,13 @@ application:get_env(?ENV_APP_NAME, Param, Default). +-spec set_env(Param, Value) -> ok + when Param :: atom(), + Value :: term(). +set_env(Param, Value) -> + application:set_env(?ENV_APP_NAME, Param, Value). + + -spec get_priv(Name) -> Path when Name :: file:filename_all(), Path :: file:filename_all(). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6c88d004ad16d9bed5021f96a1cef2904c0a246a Gerrit-Change-Number: 41280 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in ...osmo-s1gw[master]: osmo_s1gw: add set_env/2
by laforge 28 Oct '25

28 Oct '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41280?usp=email ) Change subject: osmo_s1gw: add set_env/2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6c88d004ad16d9bed5021f96a1cef2904c0a246a Gerrit-Change-Number: 41280 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Oct 2025 16:56:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0