Attention is currently required from: osmith.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41250?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: ES2Plus_Tests: cleanup/add module parameters
......................................................................
ES2Plus_Tests: cleanup/add module parameters
The ES2Plus_Tests only have minimal configuration options. Let's remove
hardcoded options and replace them with module parameters. Let's also
document the module parameters.
Change-Id: Ib8e128e4af8e819799c4d7ea3e6a36189462f382
Related: SYS#7339
---
M smdpp/ES2Plus_Tests.ttcn
1 file changed, 39 insertions(+), 17 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/41250/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41250?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib8e128e4af8e819799c4d7ea3e6a36189462f382
Gerrit-Change-Number: 41250
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41249?usp=email )
Change subject: smdpp_tests: extend comment with hint on CA cert locations
......................................................................
smdpp_tests: extend comment with hint on CA cert locations
Let's extend the comment around mp_es2plus_server_host and mention that
CA certfiicates should be made availablein /etc/ssl/certs. In case the
CA certificate is not present in /etc/ssl/certs, libcurl will refuse
to connect.
Change-Id: I58d4f35c8493a9f9531da8d7c565760a08101e35
Related: SYS#7339
---
M smdpp/smdpp_Tests.ttcn
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn
index 7a300a2..119ad08 100644
--- a/smdpp/smdpp_Tests.ttcn
+++ b/smdpp/smdpp_Tests.ttcn
@@ -383,7 +383,10 @@
var smdpp_ConnHdlrPars pars := {
/* Unfortunately the SMDP server FQDN cannot be made configurable via a module parameter since it always
* to match the FQDN in the test SSL certificates. To resolve the server FQDN to an IP address, an entry
- * in /etc/hosts is sufficient. */
+ * in /etc/hosts is sufficient. It should also be pointed out that this testsuite (libcurl) will also
+ * verify the presented server certificate against the related CA. To ensure that the server certificate
+ * verification is possible, ensure that the related CA certificates are made available in
+ * /etc/ssl/certs */
smdp_server_fqdn := "testsmdpplus1.example.com",
smdp_es2p_server_port := mp_es2plus_server_port,
cert_path := "./sgp26/CertificateIssuer",
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41249?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I58d4f35c8493a9f9531da8d7c565760a08101e35
Gerrit-Change-Number: 41249
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41249?usp=email )
Change subject: smdpp_tests: extend comment with hint on CA cert locations
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41249?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I58d4f35c8493a9f9531da8d7c565760a08101e35
Gerrit-Change-Number: 41249
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Oct 2025 06:16:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes