October 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: optimize calling of f_init_esXplus
by osmith 31 Oct '25

31 Oct '25

Attention is currently required from: Hoernchen, dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41285?usp=email ) Change subject: smdpp_Tests: optimize calling of f_init_esXplus ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I64fc5a7eddd6c5aee8ce85dbfe56c076f3372f3d Gerrit-Change-Number: 41285 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Oct 2025 12:36:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: smdpp_Tests: optimize calling of f_init_esXplus
by osmith 31 Oct '25

31 Oct '25

Attention is currently required from: Hoernchen, dexter. osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41285?usp=email ) Change subject: smdpp_Tests: optimize calling of f_init_esXplus ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I64fc5a7eddd6c5aee8ce85dbfe56c076f3372f3d Gerrit-Change-Number: 41285 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Oct 2025 12:34:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs: build binary packages earlier
by osmith 31 Oct '25

31 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41286?usp=email ) Change subject: jobs/osmocom-obs: build binary packages earlier ...................................................................... jobs/osmocom-obs: build binary packages earlier We have recently noticed that with current settings the nightly arm packages have still not finished the next morning. Schedule nightly OBS packages 2-3 hours earlier to avoid this. Change-Id: Ief55cab9308503d582fcfe0c602c75bb48be7dae --- M jobs/README.md M jobs/osmocom-obs.yml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/jobs/README.md b/jobs/README.md index 1997d33..bdc7993 100644 --- a/jobs/README.md +++ b/jobs/README.md @@ -153,10 +153,10 @@ ``` 18:00 - 21:00 OBS related + 18:00 osmocom-obs (new nightly binary packages start building on OBS!) 18:XX osmocom-obs-sync (sync Debian:12 etc. with openSUSE OBS) 19:XX osmocom-obs-check-new-distros 19:XX osmocom-obs-wireshark - 20:XX osmocom-obs (new binary packages start building on OBS!) 22:00 - 01:00 Jobs that don't need binary packages 22:XX coverity diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index fd0c1fe..1abcbfc 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -71,7 +71,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' triggers: - - timed: "H 20 * * *" + - timed: "00 18 * * *" publishers: - email: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ief55cab9308503d582fcfe0c602c75bb48be7dae Gerrit-Change-Number: 41286 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs: build binary packages earlier
by laforge 31 Oct '25

31 Oct '25

Attention is currently required from: daniel, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41286?usp=email ) Change subject: jobs/osmocom-obs: build binary packages earlier ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41286?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ief55cab9308503d582fcfe0c602c75bb48be7dae Gerrit-Change-Number: 41286 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Oct 2025 11:19:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: TC_lcs_loc_req_without_smlc: new test
by laforge 31 Oct '25

31 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email ) Change subject: bsc: TC_lcs_loc_req_without_smlc: new test ...................................................................... bsc: TC_lcs_loc_req_without_smlc: new test Related: SYS#7714 Depends: osmo-bsc Ie8a66f9decf9fff602f7fecfb71a78fab900066f Change-Id: I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 --- M bsc/BSC_Tests.ttcn M library/Osmocom_VTY_Functions.ttcn 2 files changed, 56 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 156c8ef..ef3867b 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9492,6 +9492,18 @@ f_vty_transceive(BSCVTY, "exit"); } +/* Enable/Disable SMLC via VTY */ +private function f_vty_enable_smlc(boolean enable) runs on test_CT { + f_vty_enter_cfg_smlc(BSCVTY); + if (enable) { + f_vty_transceive(BSCVTY, "enable"); + } else { + f_vty_transceive(BSCVTY, "no enable"); + } + f_vty_transceive(BSCVTY, "exit"); + f_vty_transceive(BSCVTY, "exit"); +} + /* Begin assignment procedure and send an EMERGENCY SETUP (RR) */ private function f_assignment_emerg_setup() runs on MSC_ConnHdlr { var PDU_ML3_MS_NW emerg_setup; @@ -11014,6 +11026,39 @@ f_shutdown_helper(); } +/* Ensure that Location Requests from MSC without SMLC configured lead to an + * error towards the MSC (SYS#7714) */ +private function f_tc_lcs_loc_req_without_smlc(charstring id) runs on MSC_ConnHdlr { + f_sleep(1.0); + + f_establish_fully(omit, omit); + f_bssap_le_register_imsi(g_pars.imsi, omit); + + BSSAP.send(valueof(ts_BSSMAP_Perform_Location_Request(ts_BSSMAP_Imsi(g_pars.imsi), + ts_CellId_CGI('262'H, '42'H, 23, 42)))); + + BSSAP.receive(tr_BSSMAP_Perform_Location_Response( + locationEstimate := omit, positioningData := omit, + lCS_Cause := tr_BSSMAP_LcsCause(BSSMAP_LCS_CAUSE_SYSTEM_FAILURE))); + + f_perform_clear(); + + f_sleep(2.0); + setverdict(pass); +} +testcase TC_lcs_loc_req_without_smlc() runs on test_CT { + var MSC_ConnHdlr vc_conn; + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + + f_init(1, true); + f_vty_enable_smlc(false); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_lcs_loc_req_without_smlc), pars); + vc_conn.done; + f_vty_enable_smlc(true); + f_shutdown_helper(); +} + /* Attempt Complete Layer 3 without any MSC available (OS#4832) */ private function f_tc_no_msc(charstring id) runs on MSC_ConnHdlr { f_MscConnHdlr_init(g_pars.media_nr, "127.0.0.2", "127.0.0.3", FR_AMR); @@ -12976,6 +13021,12 @@ execute( TC_emerg_call_and_lcs_loc_req() ); execute( TC_emerg_call_and_lcs_loc_req_early_lchan_rel_ind() ); execute( TC_emerg_call_and_lcs_loc_req_early_lchan_conn_fail() ); + + /* Remove "is nightly" check after osmo-bsc > 1.13 is released + * with Ie8a66f9decf9fff602f7fecfb71a78fab900066f */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_lcs_loc_req_without_smlc() ); + } } execute( TC_no_msc() ); diff --git a/library/Osmocom_VTY_Functions.ttcn b/library/Osmocom_VTY_Functions.ttcn index dc87131..7dd5c59 100644 --- a/library/Osmocom_VTY_Functions.ttcn +++ b/library/Osmocom_VTY_Functions.ttcn @@ -154,6 +154,11 @@ f_vty_transceive(pt, "cs7 instance " & int2str(cs7_inst)); } +function f_vty_enter_cfg_smlc(TELNETasp_PT pt) { + f_vty_enter_config(pt); + f_vty_transceive(pt, "smlc"); +} + type record of charstring rof_charstring; function f_vty_config3(TELNETasp_PT pt, rof_charstring config_nodes, rof_charstring cmds) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 Gerrit-Change-Number: 41288 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: TC_lcs_loc_req_without_smlc: new test
by laforge 31 Oct '25

31 Oct '25

Attention is currently required from: daniel, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email ) Change subject: bsc: TC_lcs_loc_req_without_smlc: new test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 Gerrit-Change-Number: 41288 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Oct 2025 11:19:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: Don't crash on loc req with disabled SMLC
by laforge 31 Oct '25

31 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41287?usp=email ) Change subject: Don't crash on loc req with disabled SMLC ...................................................................... Don't crash on loc req with disabled SMLC Fix that OsmoBSC crashes when receiving a location request from the MSC while the SMLC is disabled. With this patch, a system failure is reported to the MSC and the following error message is logged: SUBSCR_CONN(msc0-conn1_subscr-IMSI-001019935148766)[0x59d28e261f60]{ACTIVE}: Lb link to SMLC is not ready (no RESET-ACK), cannot send BSSMAP-LE PERFORM LOCATION REQUEST with BSSLAP TA Layer3 Suggested-by: Harald Welte <laforge(a)osmocom.org> Related: SYS#7714 Related: osmo-ttcn3-hacks I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 Change-Id: Ie8a66f9decf9fff602f7fecfb71a78fab900066f --- M src/osmo-bsc/bssmap_reset.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bssmap_reset.c b/src/osmo-bsc/bssmap_reset.c index 018ecba..3c28186 100644 --- a/src/osmo-bsc/bssmap_reset.c +++ b/src/osmo-bsc/bssmap_reset.c @@ -240,6 +240,9 @@ bool bssmap_reset_is_conn_ready(const struct bssmap_reset *bssmap_reset) { + /* bssmap_reset is NULL if SMLC is not enabled in the config */ + if (bssmap_reset == NULL) + return false; return bssmap_reset->fi->state == BSSMAP_RESET_ST_CONN; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8a66f9decf9fff602f7fecfb71a78fab900066f Gerrit-Change-Number: 41287 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bsc[master]: Don't crash on loc req with disabled SMLC
by laforge 31 Oct '25

31 Oct '25

Attention is currently required from: daniel, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41287?usp=email ) Change subject: Don't crash on loc req with disabled SMLC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8a66f9decf9fff602f7fecfb71a78fab900066f Gerrit-Change-Number: 41287 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Oct 2025 11:17:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: TC_lcs_loc_req_without_smlc: new test
by fixeria 30 Oct '25

30 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email ) Change subject: bsc: TC_lcs_loc_req_without_smlc: new test ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1cd7a7658b21d3eb04443a15ffd5ddf09b466af5 Gerrit-Change-Number: 41288 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Oct 2025 18:52:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-shell: update help strings for chv command parameter --pin-nr
by dexter 30 Oct '25

30 Oct '25

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41251?usp=email ) Change subject: pySim-shell: update help strings for chv command parameter --pin-nr ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I would rather prefer if we had something more user friendly, translating string names to pin number […] I also think that this should be more user friendly. I will see what I can do. Thanks for the hint with pySim.ts_102_221.pin_names. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41251?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b58c402d95cbc4fe690e6edb214829d463e9f2c Gerrit-Change-Number: 41251 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 30 Oct 2025 09:23:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0