dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41271?usp=email ) Change subject: smdp_Tests: rename and document custom_tls_cert module parameters ...................................................................... smdp_Tests: rename and document custom_tls_cert module parameters The module parameters mp_use_custom_tls_cert and mp_custom_tls_cert_path now only relate to ES9+, so let's add an appropriate prefix to make that clear. Let's also add an explanatory comment what those module parameters do. Change-Id: Ie37da6986410b663378531f4f0d50d95b3068964 Related: SYS#7339 --- M smdpp/smdpp_Tests.ttcn 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/41271/1 diff --git a/smdpp/smdpp_Tests.ttcn b/smdpp/smdpp_Tests.ttcn index 2b8768f..fcb542b 100644 --- a/smdpp/smdpp_Tests.ttcn +++ b/smdpp/smdpp_Tests.ttcn @@ -65,8 +65,12 @@ * mutual authentication. */ boolean mp_es2plus_use_mutual_tls := true; - boolean mp_use_custom_tls_cert := true; - charstring mp_custom_tls_cert_path := ""; // Empty means use cert pool only + /* Sets a custom TLS certificate to be used with ES9+. In case the cert path is left empty, the default cert pool + * (sgp26/DPtls) that is shipped with this testsuite is used. */ + /* FIXME: This option has no effect, CA certificates have to be placed into /etc/ssl/certs still. */ + boolean mp_es9plus_use_custom_tls_cert := true; + charstring mp_es9plus_custom_tls_cert_path := ""; /* Empty means use cert pool only */ + integer mp_es9plus_server_port_nist := 8000; integer mp_es9plus_server_port_brp := 8001; } @@ -551,8 +555,8 @@ // Configure HTTP client var integer result := ext_RSPClient_configureHttpClient( g_rsp_client_handle_es9p, - mp_use_custom_tls_cert, - mp_custom_tls_cert_path + mp_es9plus_use_custom_tls_cert, + mp_es9plus_custom_tls_cert_path ); if (result != 0) { @@ -561,7 +565,7 @@ return false; } - if (mp_use_custom_tls_cert) { + if (mp_es9plus_use_custom_tls_cert) { ext_logInfo("HTTP client configured - custom TLS: true"); } else { ext_logInfo("HTTP client configured - custom TLS: false"); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41271?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie37da6986410b663378531f4f0d50d95b3068964 Gerrit-Change-Number: 41271 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de>