August 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, laforge, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email ) Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 14:58:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: ara_m: use class byte of current lchan
by dexter 20 Aug '24

20 Aug '24

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ara_m: use class byte of current lchan ...................................................................... ara_m: use class byte of current lchan The ara_m commands use APDUs with a fix class byte (0x80). This means that all ARA-M related features only work in the basic logical channel. To fix this, let's compute the class byte for the current logical channel dynamically inside the send_apdu methods of SimCardCommands. This will fix the problem globally. Related: OS#6531 Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 --- M pySim/ara_m.py M pySim/commands.py 2 files changed, 25 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/37840/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10 Gerrit-Change-Number: 37840 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch'
by fixeria 20 Aug '24

20 Aug '24

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email ) Change subject: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9214fac4529aa460f2700f1f102013bb36aa47 Gerrit-Change-Number: 37879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Aug 2024 14:23:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch'
by laforge 20 Aug '24

20 Aug '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email ) Change subject: [cosmetic] core/socket.c: Fix indent of 'case' within 'switch' ...................................................................... [cosmetic] core/socket.c: Fix indent of 'case' within 'switch' Change-Id: I8f9214fac4529aa460f2700f1f102013bb36aa47 --- M src/core/socket.c 1 file changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/37879/1 diff --git a/src/core/socket.c b/src/core/socket.c index 97708a7..e394cf9 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -346,23 +346,23 @@ if (family == AF_UNSPEC) { for (rp = local; rp != NULL; rp = rp->ai_next) { switch (rp->ai_family) { - case AF_INET: - local_ipv4 = true; - break; - case AF_INET6: - local_ipv6 = true; - break; + case AF_INET: + local_ipv4 = true; + break; + case AF_INET6: + local_ipv6 = true; + break; } } for (rp = remote; rp != NULL; rp = rp->ai_next) { switch (rp->ai_family) { - case AF_INET: - remote_ipv4 = true; - break; - case AF_INET6: - remote_ipv6 = true; - break; + case AF_INET: + remote_ipv4 = true; + break; + case AF_INET6: + remote_ipv6 = true; + break; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9214fac4529aa460f2700f1f102013bb36aa47 Gerrit-Change-Number: 37879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: jenkins: use osmo-clean-workspace.sh before and after build
by fixeria 20 Aug '24

20 Aug '24

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37878?usp=email to look at the new patch set (#2). Change subject: jenkins: use osmo-clean-workspace.sh before and after build ...................................................................... jenkins: use osmo-clean-workspace.sh before and after build Related: osmo-ci.git I2409b2928b4d7ebbd6c005097d4ad7337307dd93 Change-Id: I5ebebfa27e4b0c7b2fb3aa60618a82c1bfdaa19a Fixes: OS#6546 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/78/37878/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5ebebfa27e4b0c7b2fb3aa60618a82c1bfdaa19a Gerrit-Change-Number: 37878 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: jenkins: use osmo-clean-workspace.sh before and after build
by fixeria 20 Aug '24

20 Aug '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37878?usp=email ) Change subject: jenkins: use osmo-clean-workspace.sh before and after build ...................................................................... jenkins: use osmo-clean-workspace.sh before and after build Related: osmo-ci.git I2409b2928b4d7ebbd6c005097d4ad7337307dd93 Change-Id: I5ebebfa27e4b0c7b2fb3aa60618a82c1bfdaa19a --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/78/37878/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a35241d..16ab1c4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -16,6 +16,8 @@ exit 1 fi +osmo-clean-workspace.sh + case "$JOB_TYPE" in "test") virtualenv -p python3 venv --system-site-packages @@ -72,3 +74,5 @@ echo "ERROR: JOB_TYPE has unexpected value '$JOB_TYPE'." exit 1 esac + +osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5ebebfa27e4b0c7b2fb3aa60618a82c1bfdaa19a Gerrit-Change-Number: 37878 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: Replace gprs_ra_id with modern osmo_routing_area_id
by lynxis lazus 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email ) Change subject: Replace gprs_ra_id with modern osmo_routing_area_id ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia41eb8f51d3836b1bc65325ff1ec6bdb16e20c7e Gerrit-Change-Number: 37860 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 12:11:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Use upstream titan.TestPorts.SIPmsg
by pespin 20 Aug '24

20 Aug '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37877?usp=email ) Change subject: deps/Makefile: Use upstream titan.TestPorts.SIPmsg ...................................................................... deps/Makefile: Use upstream titan.TestPorts.SIPmsg The patch we used from the sysmocom fork is now meged in upstream (same git commit hash), hence we can jump back to upstream. Related: SYS#6982 Change-Id: I8ca1252fd8710f50d8da5fb4fc105d29d9a506af --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/deps/Makefile b/deps/Makefile index 4220bca..bdec466 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -56,6 +56,7 @@ titan.TestPorts.LANL2asp \ titan.TestPorts.PCAPasp \ titan.TestPorts.PIPEasp \ + titan.TestPorts.SIPmsg \ titan.TestPorts.TELNETasp \ titan.TestPorts.TCPasp \ titan.TestPorts.UDPasp \ @@ -71,7 +72,6 @@ OSMOGITEA_REPOS= titan.ProtocolModules.BSSMAP \ titan.ProtocolModules.MAP \ titan.TestPorts.AF_PACKET \ - titan.TestPorts.SIPmsg \ titan.TestPorts.USB ALL_REPOS= $(ECLIPSEGITLAB_REPOS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ca1252fd8710f50d8da5fb4fc105d29d9a506af Gerrit-Change-Number: 37877 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Use upstream titan.TestPorts.SIPmsg
by fixeria 20 Aug '24

20 Aug '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37877?usp=email ) Change subject: deps/Makefile: Use upstream titan.TestPorts.SIPmsg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ca1252fd8710f50d8da5fb4fc105d29d9a506af Gerrit-Change-Number: 37877 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 12:04:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Use upstream titan.TestPorts.SIPmsg
by pespin 20 Aug '24

20 Aug '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37877?usp=email ) Change subject: deps/Makefile: Use upstream titan.TestPorts.SIPmsg ...................................................................... deps/Makefile: Use upstream titan.TestPorts.SIPmsg The patch we used from the sysmocom fork is now meged in upstream (same git commit hash), hence we can jump back to upstream. Related: SYS#6982 Change-Id: I8ca1252fd8710f50d8da5fb4fc105d29d9a506af --- M deps/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/37877/1 diff --git a/deps/Makefile b/deps/Makefile index 4220bca..bdec466 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -56,6 +56,7 @@ titan.TestPorts.LANL2asp \ titan.TestPorts.PCAPasp \ titan.TestPorts.PIPEasp \ + titan.TestPorts.SIPmsg \ titan.TestPorts.TELNETasp \ titan.TestPorts.TCPasp \ titan.TestPorts.UDPasp \ @@ -71,7 +72,6 @@ OSMOGITEA_REPOS= titan.ProtocolModules.BSSMAP \ titan.ProtocolModules.MAP \ titan.TestPorts.AF_PACKET \ - titan.TestPorts.SIPmsg \ titan.TestPorts.USB ALL_REPOS= $(ECLIPSEGITLAB_REPOS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ca1252fd8710f50d8da5fb4fc105d29d9a506af Gerrit-Change-Number: 37877 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2024