August 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra
by pespin 20 Aug '24

20 Aug '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email ) Change subject: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra ...................................................................... sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra This test reproduces a crash in osmo-sgsn, and fixed in osmo-sgsn.git Change-Id I5a4328c6e945b85dd815215724feecadba59c435. Related: OS#6441 Change-Id: I3ce02f30a1e5becb80ab2a29f6bf5d08dd45b79c --- M sgsn/SGSN_Tests.ttcn M sgsn/expected-results.xml 2 files changed, 55 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index cbf50dd..9a50297 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -18,6 +18,7 @@ import from Osmocom_Types all; import from GSM_Types all; import from Native_Functions all; +import from Misc_Helpers all; import from NS_Types all; import from NS_Emulation all; import from BSSGP_Types all; @@ -1904,7 +1905,6 @@ f_detach_mo(c_GMM_DTT_MO_GPRS, true, true); } - testcase TC_attach_rau_a_a() runs on test_CT { /* MS <-> SGSN: Successful Attach * MS -> SGSN: Routing Area Update Request @@ -1936,7 +1936,6 @@ f_detach_mo(c_GMM_DTT_MO_GPRS, true, true, 1); } - testcase TC_attach_rau_a_b() runs on test_CT { /* MS <-> SGSN: Successful Attach * MS -> SGSN: Routing Area _a_ Update Request @@ -1953,6 +1952,55 @@ f_cleanup(); } +/* MS fills wrong Old RA during 2nd RAU. SGSN rejects it. */ +private function f_TC_attach_rau_a_b_wrong_old_ra(charstring id) runs on BSSGP_ConnHdlr { + var integer ran_index := 1; + f_TC_attach(id); + + log("attach complete sending rau"); + f_routing_area_update(g_pars.ra); + + log("rau complete unregistering"); + f_bssgp_client_unregister(g_pars.imsi); + f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]); + + log("sending second RAU via different RA with wrong Old RA"); + var RoutingAreaIdentificationV wrong_old_ra := g_pars.ra; + wrong_old_ra.rac := int2oct((oct2int(wrong_old_ra.rac) + 5) / 3, 1); + f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, old_ra := wrong_old_ra), ran_index); + + timer T := 2.0; + T.start; + alt { + [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT); + [] BSSGP[ran_index].receive(tr_LLC_XID_MT_CMD(?, ?)) { + /* Ignore XID Reset */ + repeat; + } + [] T.timeout { + setverdict(fail, "Timeout rx RAU Reject"); + mtc.stop; + } + } + + f_detach_mo(c_GMM_DTT_MO_GPRS, true, true, ran_index := ran_index); +} +testcase TC_attach_rau_a_b_wrong_old_ra() runs on test_CT { + /* MS <-> SGSN: Successful Attach + * MS -> SGSN: Routing Area _a_ Update Request + * MS <- SGSN: Routing Area _a_ Update Accept + * MS -> SGSN: Routing Area _b_ Update Request (Wrong Old Routing Area) + * MS <- SGSN: Routing Area _b_ Update Reject + * MS -> SGSN: Detach (PowerOff) + */ + var BSSGP_ConnHdlr vc_conn; + f_init(); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_TC_attach_rau_a_b_wrong_old_ra), testcasename(), g_gb, 39); + vc_conn.done; + f_cleanup(); +} + private function f_TC_attach_gmm_attach_req_while_gmm_attach(charstring id) runs on BSSGP_ConnHdlr { var integer count_req := 0; var MobileIdentityLV mi; @@ -3177,6 +3225,10 @@ execute( TC_attach_rau() ); execute( TC_attach_rau_a_a() ); execute( TC_attach_rau_a_b() ); + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + /* Will double-free and crash osmo-sgsn <= 1.12.0 */ + execute( TC_attach_rau_a_b_wrong_old_ra() ); + } execute( TC_attach_usim_resync() ); execute( TC_attach_usim_a54_a54() ); execute( TC_attach_usim_a54_a53() ); diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index a29467d..40b6592 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -37,6 +37,7 @@ <testcase classname='SGSN_Tests' name='TC_attach_rau' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_rau_a_a' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_rau_a_b' time='MASKED'/> + <testcase classname='SGSN_Tests' name='TC_attach_rau_a_b_wrong_old_ra' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_usim_resync' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_usim_a54_a54' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_usim_a54_a53' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ce02f30a1e5becb80ab2a29f6bf5d08dd45b79c Gerrit-Change-Number: 37872 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra
by pespin 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email ) Change subject: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > It was mentioned in the ticket description: […] Ah my bad, I didn't see it with all the backtrace stuff. I'll just merge mine since it already contains the expected-results, the tests are basically the same with different name. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ce02f30a1e5becb80ab2a29f6bf5d08dd45b79c Gerrit-Change-Number: 37872 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra
by fixeria 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email ) Change subject: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra ...................................................................... Patch Set 1: Code-Review+1 Copied votes on follow-up patch sets have been updated: * Code-Review+1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN"). (1 comment) Patchset: PS1: > Ah I didn't see/remember it because afaict it was not listed in https://projects.osmocom. […] It was mentioned in the ticket description: """ I have fixed the regression in SGSN_Tests.TC_attach_rau_a_b and created a separate testcase reproducing the crash: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36625 sgsn: add TC_attach_rau_invalid_old_rai [NEW] """ and you even did code review 😄 I am fine merging your patch and abandoning mine, just wanted to clarify. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ce02f30a1e5becb80ab2a29f6bf5d08dd45b79c Gerrit-Change-Number: 37872 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: sgsn: Fix running with testenv.py podman setup
by pespin 20 Aug '24

20 Aug '24

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, lynxis lazus, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37862?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: sgsn: Fix running with testenv.py podman setup ...................................................................... sgsn: Fix running with testenv.py podman setup The initial testenv.py setup introduced in osmo-ttcn3-hacks.git 6baec93cb85fa8a0051e9aacd0178e90adbfdadc lacked some recent updates to the ttcn3 testsuite setup where a second IP address is added to the container in order to distinguish between RNC and CN in GTPU. Change-Id: Ia0af52f8b7d61c15bdf2b6152fae27dd003d00e8 --- M sgsn/SGSN_Tests.cfg M sgsn/osmo-stp.cfg 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/37862/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0af52f8b7d61c15bdf2b6152fae27dd003d00e8 Gerrit-Change-Number: 37862 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra
by pespin 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email ) Change subject: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > What do we do with https://gerrit.osmocom. […] Ah I didn't see/remember it because afaict it was not listed in https://projects.osmocom.org/issues/6441 I think mine is more complete since also has the expected-results.xml, and I already tested it with the osmo-sgsn patch, but as you prefer. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ce02f30a1e5becb80ab2a29f6bf5d08dd45b79c Gerrit-Change-Number: 37872 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:16:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: Fix ttcn3_compiler path under Archlinux
by pespin 20 Aug '24

20 Aug '24

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37861?usp=email ) Change subject: regen-makefile.sh: Fix ttcn3_compiler path under Archlinux ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6c5a954493d3de8b1c43e18348de63a65f58daef Gerrit-Change-Number: 37861 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: regen-makefile.sh: Fix ttcn3_compiler path under Archlinux
by pespin 20 Aug '24

20 Aug '24

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37861?usp=email ) Change subject: regen-makefile.sh: Fix ttcn3_compiler path under Archlinux ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37861/comment/867fa48e_68d2… : PS1, Line 9: The ttcn3 installation path > FYI: this package comes with: […] I created yesterday https://projects.osmocom.org/issues/6544, since envvars are not being passed with testenv.py. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6c5a954493d3de8b1c43e18348de63a65f58daef Gerrit-Change-Number: 37861 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:11:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email ) Change subject: sgsn: Introduce test TC_attach_rau_a_b_wrong_old_ra ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ce02f30a1e5becb80ab2a29f6bf5d08dd45b79c Gerrit-Change-Number: 37872 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 08:26:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: Replace gprs_ra_id with modern osmo_routing_area_id
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email ) Change subject: Replace gprs_ra_id with modern osmo_routing_area_id ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia41eb8f51d3836b1bc65325ff1ec6bdb16e20c7e Gerrit-Change-Number: 37860 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 08:25:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: tests: move pySim-trace test and its data into a sub directory
by fixeria 19 Aug '24

19 Aug '24

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37822?usp=email ) Change subject: tests: move pySim-trace test and its data into a sub directory ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: How about using a shorter name, i.e. `tests/trace`? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Gerrit-Change-Number: 37822 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Aug 2024 20:36:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log August 2024