August 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sccp[master]: ss7_as: Avoid dispatch event to asp with uninitialized FSM
by fixeria 20 Aug '24

20 Aug '24

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37876?usp=email ) Change subject: ss7_as: Avoid dispatch event to asp with uninitialized FSM ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d201a60ecd1a4d8a5aa87e1fdb236f755ec152b Gerrit-Change-Number: 37876 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 11:33:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sccp[master]: ss7_as: Avoid dispatch event to asp with uninitialized FSM
by pespin 20 Aug '24

20 Aug '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37876?usp=email ) Change subject: ss7_as: Avoid dispatch event to asp with uninitialized FSM ...................................................................... ss7_as: Avoid dispatch event to asp with uninitialized FSM It is expected that before being started (osmo_ss7_asp_restart() -> xua_asp_fsm_start()), an asp doesn't have an asp->fi pointer set. This is already checked in several places in code and even used to print "unitialized" state in vty introspection. If the asp was assigned to an as (eg through vty) before it was started, then it would print the error log: "Trying to dispatch event 17 to non-existent FSM instance!" Hence, check the fi is available. If it is not, it's totally fine not dispatching that event because it means the asp is still not started, and it will catch up taking the ipa-name from the when it is started. Related: OS#6356 Related: SYS#5914 Fixes: 57444690212b1576eaf0a7156448ba2d27c59050 Fixes: 65741dca056e3a16973ad156dd4c09760a6a945b Change-Id: I4d201a60ecd1a4d8a5aa87e1fdb236f755ec152b --- M src/osmo_ss7_as.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/76/37876/1 diff --git a/src/osmo_ss7_as.c b/src/osmo_ss7_as.c index 9d78897..9683e94 100644 --- a/src/osmo_ss7_as.c +++ b/src/osmo_ss7_as.c @@ -115,7 +115,8 @@ for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { if (!as->cfg.asps[i]) { as->cfg.asps[i] = asp; - osmo_fsm_inst_dispatch(asp->fi, XUA_ASP_E_AS_ASSIGNED, as); + if (asp->fi) + osmo_fsm_inst_dispatch(asp->fi, XUA_ASP_E_AS_ASSIGNED, as); return 0; } } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d201a60ecd1a4d8a5aa87e1fdb236f755ec152b Gerrit-Change-Number: 37876 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: gb: add bssgp_parse_cell_id2/bssgp_create_cell_id2
by lynxis lazus 20 Aug '24

20 Aug '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37794?usp=email ) Change subject: gb: add bssgp_parse_cell_id2/bssgp_create_cell_id2 ...................................................................... gb: add bssgp_parse_cell_id2/bssgp_create_cell_id2 Add bssgp_cell_id functions which use the new struct osmo_routing_area_id. Related: OS#6536 Change-Id: I6cdae75a32547968add2421a07d287a0a42bdbc0 --- M TODO-RELEASE M include/osmocom/gprs/gprs_bssgp.h M src/gb/gprs_bssgp.c M src/gb/libosmogb.map 4 files changed, 44 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..904d9e0 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +gb ADD add bssgp_parse_cell_id2/bssgp_create_cell_id2 diff --git a/include/osmocom/gprs/gprs_bssgp.h b/include/osmocom/gprs/gprs_bssgp.h index 6c04332..dff7268 100644 --- a/include/osmocom/gprs/gprs_bssgp.h +++ b/include/osmocom/gprs/gprs_bssgp.h @@ -182,6 +182,12 @@ int bssgp_create_cell_id(uint8_t *buf, const struct gprs_ra_id *raid, uint16_t cid); +int bssgp_parse_cell_id2(struct osmo_routing_area_id *raid, uint16_t *cid, + const uint8_t *buf, size_t buf_len); +int bssgp_create_cell_id2(uint8_t *buf, size_t buf_len, + const struct osmo_routing_area_id *raid, + uint16_t cid); + /* Wrapper around TLV parser to parse BSSGP IEs */ static inline int bssgp_tlv_parse(struct tlv_parsed *tp, const uint8_t *buf, int len) { diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c index 7abef80..d436f0a 100644 --- a/src/gb/gprs_bssgp.c +++ b/src/gb/gprs_bssgp.c @@ -354,6 +354,24 @@ return osmo_load16be(buf+6); } +/*! Parse the value of a BSSGP Cell identity (04.08 RAI + Cell Id) */ +int bssgp_parse_cell_id2(struct osmo_routing_area_id *raid, uint16_t *cid, + const uint8_t *buf, size_t buf_len) +{ + if (buf_len < 8) + return -EINVAL; + + /* 6 octets RAC */ + if (raid) + osmo_routing_area_id_decode(raid, buf, buf_len); + + /* 2 octets CID */ + if (cid) + *cid = osmo_load16be(buf + sizeof(struct gsm48_ra_id)); + + return 0; +} + int bssgp_create_cell_id(uint8_t *buf, const struct gprs_ra_id *raid, uint16_t cid) { @@ -365,6 +383,23 @@ return 8; } +/*! Encode the 04.08 RAI, Cell Id into BSSGP Cell identity */ +int bssgp_create_cell_id2(uint8_t *buf, size_t buf_len, + const struct osmo_routing_area_id *raid, + const uint16_t cid) +{ + if (buf_len < 8) + return -ENOMEM; + + /* 6 octets RAC */ + osmo_routing_area_id_encode_buf(buf, buf_len, raid); + + /* 2 octets CID */ + osmo_store16be(cid, buf + sizeof(struct gsm48_ra_id)); + + return 8; +} + /* Chapter 8.4 BVC-Reset Procedure */ static int bssgp_rx_bvc_reset(struct msgb *msg, struct tlv_parsed *tp, uint16_t ns_bvci) diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map index e5a5c8f..f1a6bd6 100644 --- a/src/gb/libosmogb.map +++ b/src/gb/libosmogb.map @@ -2,6 +2,7 @@ global: bssgp_cause_str; bssgp_create_cell_id; +bssgp_create_cell_id2; bssgp_create_rim_ri; bssgp_dec_app_err_cont_nacc; bssgp_dec_ran_inf_ack_rim_cont; @@ -32,6 +33,7 @@ bssgp_msgb_ra_put; bssgp_nacc_cause_strs; bssgp_parse_cell_id; +bssgp_parse_cell_id2; bssgp_parse_rim_pdu; bssgp_parse_rim_ri; bssgp_parse_rim_ra; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6cdae75a32547968add2421a07d287a0a42bdbc0 Gerrit-Change-Number: 37794 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: add convert functions for old gprs_ra_id and the new osmo_routing_are...
by lynxis lazus 20 Aug '24

20 Aug '24

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37831?usp=email ) Change subject: add convert functions for old gprs_ra_id and the new osmo_routing_area_id ...................................................................... add convert functions for old gprs_ra_id and the new osmo_routing_area_id There are some parts which still depend on the old gprs_ra_id (e.g. BSSGP, Iu). Related: OS#6536 Change-Id: Iaef54cac541913534af00f40483723e9952a6807 --- M TODO-RELEASE M include/osmocom/gsm/gsm48.h M src/gsm/gsm48.c M src/gsm/libosmogsm.map 4 files changed, 33 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 904d9e0..8a1e0dc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line gb ADD add bssgp_parse_cell_id2/bssgp_create_cell_id2 +gsm ADD add osmo_rai_to_gprs/gprs_rai_to_osmo diff --git a/include/osmocom/gsm/gsm48.h b/include/osmocom/gsm/gsm48.h index 00fb6f4..d36b85c 100644 --- a/include/osmocom/gsm/gsm48.h +++ b/include/osmocom/gsm/gsm48.h @@ -42,6 +42,8 @@ const char *osmo_rai_name(const struct gprs_ra_id *rai); char *osmo_rai_name_buf(char *buf, size_t buf_len, const struct gprs_ra_id *rai); char *osmo_rai_name_c(const void *ctx, const struct gprs_ra_id *rai); +void osmo_rai_to_gprs(struct gprs_ra_id *dest, const struct osmo_routing_area_id *src); +void gprs_rai_to_osmo(struct osmo_routing_area_id *dest, const struct gprs_ra_id *src); int gsm48_decode_lai(struct gsm48_loc_area_id *lai, uint16_t *mcc, uint16_t *mnc, uint16_t *lac) diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 64b1765..1201595 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -222,6 +222,34 @@ return osmo_rai_name_buf(buf, 32, rai); } +/*! Convert osmo_routing_area_id (new) into gprs_ra_id (old) */ +void osmo_rai_to_gprs(struct gprs_ra_id *dest, const struct osmo_routing_area_id *src) +{ + OSMO_ASSERT(src); + OSMO_ASSERT(dest); + + dest->mcc = src->lac.plmn.mcc; + dest->mnc = src->lac.plmn.mnc; + dest->mnc_3_digits = src->lac.plmn.mnc_3_digits; + + dest->lac = src->lac.lac; + dest->rac = src->rac; +} + +/*! Convert gprs_ra_id (old) into osmo_routing_area_id (new) */ +void gprs_rai_to_osmo(struct osmo_routing_area_id *dest, const struct gprs_ra_id *src) +{ + OSMO_ASSERT(src); + OSMO_ASSERT(dest); + + dest->lac.plmn.mcc = src->mcc; + dest->lac.plmn.mnc = src->mnc; + dest->lac.plmn.mnc_3_digits = src->mnc_3_digits; + + dest->lac.lac = src->lac; + dest->rac = src->rac; +} + /* FIXME: convert to value_string */ static const char *cc_state_names[32] = { "NULL", diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 2c4c621..3bc8309 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -487,6 +487,8 @@ osmo_rai_name2; osmo_rai_name2_buf; osmo_rai_name2_c; +osmo_rai_to_gprs; +gprs_rai_to_osmo; osmo_cgi_cmp; osmo_cgi_name; osmo_cgi_name_buf; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaef54cac541913534af00f40483723e9952a6807 Gerrit-Change-Number: 37831 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: add convert functions for old gprs_ra_id and the new osmo_routing_are...
by lynxis lazus 20 Aug '24

20 Aug '24

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/37831?usp=email ) Change subject: add convert functions for old gprs_ra_id and the new osmo_routing_area_id ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaef54cac541913534af00f40483723e9952a6807 Gerrit-Change-Number: 37831 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 10:43:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, pespin. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email ) Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/37874/comment/caaa80d1_dd2f0504?… : PS1, Line 19: > valid as a configured address. *This flag is useful on, for example, > so does that mean that if I have a system with no net card, then getaddrinfo() will fail to provide […] I guess we'd have to test that. File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/37874/comment/4ab292cc_ac1623b3?… : PS1, Line 85: rc = getaddrinfo(host, portbuf, &hints, &result); > what about, if result from getaddrinfo is empty (result==NULL), then call getaddrinfo again without […] That might be an option. The other option would be to keep the call as-is, but perform some manual post-processing of the result before passing it to the addrinfo_helper caller. I still think it's weird for getaddrinfo to ever return anything IPv6 on a system that has no CONFIG_INET6 in the kernel at all. I guess glibc simply doesn't care what the kernel supports or doesn't support. In any case, even if we fixed glibc, it would take ages to propagate. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 10:18:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by laforge 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, laforge. Hello Hoernchen, Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... core/socket.c: Fix socket binding on IPv4-only hosts Let's add the AI_ADDRCONFIG flag to prevent getaddrinfo() from returning IPv6 addresses on sytems that have no IPv6. From the manpage: > If hints.ai_flags includes the AI_ADDRCONFIG flag, then IPv4 > addresses are returned in the list pointed to by res only if the local > system has at least one IPv4 address configured, and IPv6 addresses are > returned only if the local system has at least one IPv6 address > configured. The loopback address is not considered for this case as > valid as a configured address. *This flag is useful on, for example, > IPv4-only systems, to ensure that getaddrinfo() does not return IPv6 > socket addresses that would always fail in connect(2) or bind(2).* Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Closes: OS#7074 --- M src/core/socket.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/37874/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-mgw[master]: tests/mgcp/mgcp_test: Add some extra asserts in code
by pespin 20 Aug '24

20 Aug '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37875?usp=email ) Change subject: tests/mgcp/mgcp_test: Add some extra asserts in code ...................................................................... tests/mgcp/mgcp_test: Add some extra asserts in code This makes it easier to catch possible failures while running the test, plus makes gcc on OpenSUSE_Factory happy and not warn. Related: OS#5044 Change-Id: I01c3c84e58a11055f0e0a6955016dc2489c73379 --- M tests/mgcp/mgcp_test.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/75/37875/1 diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index 21be037..de359d5 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -1208,7 +1208,9 @@ _conn = mgcp_conn_alloc(NULL, &endp, MGCP_CONN_TYPE_RTP, "test-connection"); + OSMO_ASSERT(_conn); conn = mgcp_conn_get_rtp(&endp, _conn->id); + OSMO_ASSERT(conn); state = &conn->state; packets_rx = rate_ctr_group_get_ctr(conn->ctrg, RTP_PACKETS_RX_CTR); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37875?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I01c3c84e58a11055f0e0a6955016dc2489c73379 Gerrit-Change-Number: 37875 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by pespin 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email ) Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... Patch Set 1: (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/37874/comment/39747c7c_0aedec02?… : PS1, Line 85: rc = getaddrinfo(host, portbuf, &hints, &result); what about, if result from getaddrinfo is empty (result==NULL), then call getaddrinfo again without AI_ADDRCONFIG in ai_flags? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:47:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: core/socket.c: Provide more context when printing error message
by laforge 20 Aug '24

20 Aug '24

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37818?usp=email ) Change subject: core/socket.c: Provide more context when printing error message ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I91b05d0520b5432ca301cf6fd34468c2f4ac9b72 Gerrit-Change-Number: 37818 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 09:44:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2024