Attention is currently required from: daniel, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email )
Change subject: Routing Area: Remove cells when NSEI becomes unavailable
......................................................................
Patch Set 3:
(2 comments)
File src/sgsn/gprs_routing_area.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17910):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37865/comment/10d6f82a_0182a056?us… :
PS3, Line 289: llist_for_each_entry_safe(ra, ra2, &sgsn_ra_ctx->ras, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17910):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37865/comment/dac7007b_7205a8ed?us… :
PS3, Line 290: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) {
space required before the open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I9f0386d9eb7f0cabaf0fde45f8e78b4ea28c67c5
Gerrit-Change-Number: 37865
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:19:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email )
Change subject: Routing Area: Remove cells when NSEI becomes unavailable
......................................................................
Patch Set 3:
(2 comments)
File src/sgsn/gprs_routing_area.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17909):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37865/comment/55476dad_360e2b15?us… :
PS3, Line 289: llist_for_each_entry_safe(ra, ra2, &sgsn_ra_ctx->ras, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17909):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37865/comment/5c17f4a2_48d79fe9?us… :
PS3, Line 290: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) {
space required before the open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I9f0386d9eb7f0cabaf0fde45f8e78b4ea28c67c5
Gerrit-Change-Number: 37865
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:18:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: add routing areas
......................................................................
Patch Set 3:
(11 comments)
File include/osmocom/sgsn/gprs_routing_area.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c1993493_cd188347?us… :
PS3, Line 70: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data);
space required before the open parenthesis '('
File src/sgsn/gprs_routing_area.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/4ccf8484_799e9b0b?us… :
PS3, Line 30: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/ad441ece_74622079?us… :
PS3, Line 95: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/34a39a6c_85abbe17?us… :
PS3, Line 111: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/541ba466_ea908351?us… :
PS3, Line 112: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/5f726bab_c1e0d3f5?us… :
PS3, Line 124: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/9ce6bc67_a1ff6478?us… :
PS3, Line 131: llist_for_each_entry_safe(cell, tmp, &ra->cells, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/aaaff72e_f3925af8?us… :
PS3, Line 157: return sgsn_ra_foreach_cell(ra, cb, cb_data);
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c2b3ea9f_f02825d3?us… :
PS3, Line 164: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/068e235f_2183b2e3?us… :
PS3, Line 179: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17908):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/3b56f7b7_c791067a?us… :
PS3, Line 183: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa
Gerrit-Change-Number: 37864
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: add routing areas
......................................................................
Patch Set 3:
(11 comments)
File include/osmocom/sgsn/gprs_routing_area.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/b7a6fce6_3ce3e22b?us… :
PS3, Line 70: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data);
space required before the open parenthesis '('
File src/sgsn/gprs_routing_area.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/9f343d45_b6a88a1d?us… :
PS3, Line 30: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/ebfd19c6_e08cf349?us… :
PS3, Line 95: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/ad3310bb_7d6bb7eb?us… :
PS3, Line 111: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/be8652bf_fd79f736?us… :
PS3, Line 112: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/9995ba96_2f6c02a2?us… :
PS3, Line 124: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/ef67dd7b_9be6dbfe?us… :
PS3, Line 131: llist_for_each_entry_safe(cell, tmp, &ra->cells, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/f4de5dbe_845d7de9?us… :
PS3, Line 157: return sgsn_ra_foreach_cell(ra, cb, cb_data);
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/523d30f4_108024e5?us… :
PS3, Line 164: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/b39c5e74_e474e33b?us… :
PS3, Line 179: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/dc254e1a_2c19c0a6?us… :
PS3, Line 183: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa
Gerrit-Change-Number: 37864
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email )
Change subject: Implement correct Routing Area based paging
......................................................................
Patch Set 4:
(1 comment)
File src/sgsn/gprs_routing_area.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17905):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/3b25e0e1_831f7862?us… :
PS4, Line 315: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f
Gerrit-Change-Number: 37866
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:16:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )
Change subject: GMM: split parsing of a RA Update Request in a separate file
......................................................................
Patch Set 4:
(4 comments)
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17904):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/7b6dfa3c_a6fe025e?us… :
PS4, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type);
Use %d instead of %i
File src/sgsn/gprs_gmm_util.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17904):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/635510b2_7b9e742c?us… :
PS4, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg))))
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17904):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/c5ebc7d8_8c2a7333?us… :
PS4, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17904):
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/59b94a74_2eb4f0b3?us… :
PS4, Line 115: if (ret < 0) {
braces {} are not necessary for single statement blocks
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d
Gerrit-Change-Number: 37869
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:16:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )
Change subject: GMM: split parsing of a RA Update Request in a separate file
......................................................................
Patch Set 4:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d
Gerrit-Change-Number: 37869
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:13:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email )
Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util
......................................................................
Patch Set 4:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I67dcdb986fd01dc093501d324b5c376246a5d30d
Gerrit-Change-Number: 37868
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:13:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email )
Change subject: Refactor diffing same GMM messages
......................................................................
Patch Set 4:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6
Gerrit-Change-Number: 37867
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:13:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: daniel, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email )
Change subject: Implement correct Routing Area based paging
......................................................................
Patch Set 4:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f
Gerrit-Change-Number: 37866
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Aug 2024 15:13:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No