Attention is currently required from: daniel, pespin.

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )

Change subject: GMM: split parsing of a RA Update Request in a separate file ......................................................................

Patch Set 4:

(4 comments)

File src/sgsn/gprs_gmm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17904): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/7b6dfa3c_a6fe025e?usp... : PS4, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type); Use %d instead of %i

File src/sgsn/gprs_gmm_util.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17904): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/635510b2_7b9e742c?usp... : PS4, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg)))) that open brace { should be on the previous line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17904): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/c5ebc7d8_8c2a7333?usp... : PS4, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17904): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/59b94a74_2eb4f0b3?usp... : PS4, Line 115: if (ret < 0) { braces {} are not necessary for single statement blocks