August 2024 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: jenkins: use osmo-clean-workspace.sh before and after build
by dexter 20 Aug '24

20 Aug '24

Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/37878?usp=email ) Change subject: jenkins: use osmo-clean-workspace.sh before and after build ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I think we should give this a try. In case there are performance issues, we can always revert the patch. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5ebebfa27e4b0c7b2fb3aa60618a82c1bfdaa19a Gerrit-Change-Number: 37878 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 16:06:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: tests: move pySim-trace test and its data into a sub directory
by dexter 20 Aug '24

20 Aug '24

Attention is currently required from: fixeria. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37822?usp=email ) Change subject: tests: move pySim-trace test and its data into a sub directory ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > How about using a shorter name, i.e. […] I thought about this too, but we should not be too unspecific. Actually I like it that the directory has the full name of the program. This makes it very clear for what exactly the tests are. (However, we might skip the "_test" suffix though) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Gerrit-Change-Number: 37822 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:45:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in osmo-sgsn[master]: add routing areas
by Jenkins Builder 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, lynxis lazus, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email ) Change subject: add routing areas ...................................................................... Patch Set 5: (11 comments) File include/osmocom/sgsn/gprs_routing_area.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/19728574_13a4d5e3?us… : PS5, Line 70: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data); space required before the open parenthesis '(' File src/sgsn/gprs_routing_area.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/7eada1b7_0e584088?us… : PS5, Line 30: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/5e317014_748efbf5?us… : PS5, Line 95: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/3e617727_c59cbc46?us… : PS5, Line 111: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/c3fc6454_a4d14037?us… : PS5, Line 112: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/af7e213b_2a18ecf6?us… : PS5, Line 124: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/bfa3f0a8_73c4aff2?us… : PS5, Line 131: llist_for_each_entry_safe(cell, tmp, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/256f387c_cfaaf312?us… : PS5, Line 157: return sgsn_ra_foreach_cell(ra, cb, cb_data); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/85f968aa_356b4a5c?us… : PS5, Line 164: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/2befa7be_7f8313db?us… : PS5, Line 179: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17917): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/9cdb9be8_010f094d?us… : PS5, Line 183: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:39:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: Routing Area: Remove cells when NSEI becomes unavailable
by Jenkins Builder 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, lynxis lazus, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email ) Change subject: Routing Area: Remove cells when NSEI becomes unavailable ...................................................................... Patch Set 5: (2 comments) File src/sgsn/gprs_routing_area.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17916): https://gerrit.osmocom.org/c/osmo-sgsn/+/37865/comment/fb819091_a14f306b?us… : PS5, Line 289: llist_for_each_entry_safe(ra, ra2, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17916): https://gerrit.osmocom.org/c/osmo-sgsn/+/37865/comment/7e99966e_d4f90432?us… : PS5, Line 290: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) { space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9f0386d9eb7f0cabaf0fde45f8e78b4ea28c67c5 Gerrit-Change-Number: 37865 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:39:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: GMM: split parsing of a RA Update Request in a separate file
by Jenkins Builder 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, lynxis lazus, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email ) Change subject: GMM: split parsing of a RA Update Request in a separate file ...................................................................... Patch Set 5: (4 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17914): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/a6fb0acc_80562939?us… : PS5, Line 1624: LOGMMCTXP(LOGL_NOTICE, mmctx, "Update type %i unsupported in Mode III, is your SI13 corrupt?\n", req.update_type); Use %d instead of %i File src/sgsn/gprs_gmm_util.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17914): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/d035f4b6_8f5d1808?us… : PS5, Line 98: if (msgb_l3len(msg) < (len + (cur - msgb_gmmh(msg)))) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17914): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/7d362860_9b81523e?us… : PS5, Line 108: if (msgb_l3len(msg) == mandatory_fields_len) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17914): https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/66c821b5_5987922c?us… : PS5, Line 115: if (ret < 0) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d Gerrit-Change-Number: 37869 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:39:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-sgsn[master]: Implement correct Routing Area based paging
by Jenkins Builder 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, lynxis lazus, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email ) Change subject: Implement correct Routing Area based paging ...................................................................... Patch Set 5: (1 comment) File src/sgsn/gprs_routing_area.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17913): https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/4a0d2eb5_b3776c0a?us… : PS5, Line 315: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I181da9f656e394ccfcb8999021a5b7e13ca0419f Gerrit-Change-Number: 37866 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:37:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-sgsn[master]: add routing areas
by lynxis lazus 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, lynxis lazus, pespin. Hello Jenkins Builder, daniel, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: add routing areas ...................................................................... add routing areas Add a routing area layer which tracks routing area and cells within a routing area. Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa --- M include/osmocom/sgsn/Makefile.am M include/osmocom/sgsn/debug.h A include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/Makefile.am M src/sgsn/gprs_bssgp.c A src/sgsn/gprs_routing_area.c M src/sgsn/sgsn_main.c M tests/sgsn/Makefile.am 8 files changed, 401 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/64/37864/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-sgsn[master]: Replace gprs_ra_id with modern osmo_routing_area_id
by pespin 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email ) Change subject: Replace gprs_ra_id with modern osmo_routing_area_id ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia41eb8f51d3836b1bc65325ff1ec6bdb16e20c7e Gerrit-Change-Number: 37860 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:21:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-sgsn[master]: Replace gprs_ra_id with modern osmo_routing_area_id
by pespin 20 Aug '24

20 Aug '24

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email ) Change subject: Replace gprs_ra_id with modern osmo_routing_area_id ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia41eb8f51d3836b1bc65325ff1ec6bdb16e20c7e Gerrit-Change-Number: 37860 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: core/socket.c: Fix socket binding on IPv4-only hosts
by pespin 20 Aug '24

20 Aug '24

Attention is currently required from: Hoernchen, laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email ) Change subject: core/socket.c: Fix socket binding on IPv4-only hosts ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0 Gerrit-Change-Number: 37874 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log August 2024