December 2024 - gerrit-log - lists.osmocom.org

[L] Change in libosmo-netif[master]: ipa: Add osmo_ipa_ka_fsm_inst APIs

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email ) Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File include/osmocom/netif/ipa.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39035/comment/d2093193_a003837… : PS3, Line 85: void *osmo_ipa_ka_fsm_get_data(const struct osmo_ipa_ka_fsm_inst *ka_fi); I would normally hand the data directly to the call-back as an argument to avoid the extra function call to a method like this in every call-back. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd Gerrit-Change-Number: 39035 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Dec 2024 21:36:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: ara_m: put hex string values in quotes

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39056?usp=email ) Change subject: ara_m: put hex string values in quotes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: why would we do this? Have we ever done so in other location? are we not always simply using hex-strings "as-is" e.g. for K, OPc, etc? It's not like those strings contain spaces or tabs... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia365e83638ff4f1b1a02e1671852cf2006f80c7f Gerrit-Change-Number: 39056 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Dec 2024 11:26:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

[M] Change in pysim[master]: ara_m: fix spec reference.

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39055?usp=email ) Change subject: ara_m: fix spec reference. ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77895f1b84126563380ce89aa07a3b448d8784a3 Gerrit-Change-Number: 39055 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Dec 2024 11:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[L] Change in libosmo-netif[master]: ipa: Add osmo_ipa_ka_fsm_inst APIs

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email ) Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd Gerrit-Change-Number: 39035 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 07 Dec 2024 15:48:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: server: Implement IPA server with osmo_stream

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39033?usp=email ) Change subject: server: Implement IPA server with osmo_stream ...................................................................... server: Implement IPA server with osmo_stream libosmo-abis is still needed since we are still using ipa_keepalive_fsm from there. This needs to be imported here or moved to libosmo-netif. Related: OS#5896 Change-Id: I6341612e41a0005de85f45fd6454bb954becb69c --- M src/server/rspro_server.c M src/server/rspro_server.h 2 files changed, 154 insertions(+), 57 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 5803c8a..c2001af 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -2,6 +2,7 @@ #include <string.h> #include <unistd.h> #include <pthread.h> +#include <errno.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/select.h> @@ -9,6 +10,7 @@ #include <osmocom/core/logging.h> #include <osmocom/core/socket.h> #include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/netif/ipa.h> #include <osmocom/abis/ipa.h> #include <osmocom/rspro/RsproPDU.h> @@ -60,7 +62,7 @@ } ipa_prepend_header_ext(msg_tx, IPAC_PROTO_EXT_RSPRO); ipa_prepend_header(msg_tx, IPAC_PROTO_OSMO); - ipa_server_conn_send(conn->peer, msg_tx); + osmo_stream_srv_send(conn->peer, msg_tx); } @@ -127,9 +129,10 @@ RsproPDU_t *resp = NULL; char ip_str[INET6_ADDRSTRLEN]; char port_str[6]; + int fd = osmo_stream_srv_get_fd(conn->peer); /* remote IP and port */ - osmo_sock_get_ip_and_port(conn->peer->ofd.fd, ip_str, sizeof(ip_str), + osmo_sock_get_ip_and_port(fd, ip_str, sizeof(ip_str), port_str, sizeof(port_str), false); switch (event) { @@ -174,9 +177,14 @@ * timeout, or to continue to operate. If we were to drop the old * connection, this could interrupt a perfectly working connection and opens * some kind of DoS. */ + char prev_ip_str[INET6_ADDRSTRLEN]; + char prev_port_str[6]; + int prev_fd = osmo_stream_srv_get_fd(previous_conn->peer); + osmo_sock_get_ip_and_port(prev_fd, prev_ip_str, sizeof(prev_ip_str), + prev_port_str, sizeof(prev_port_str), false); LOGPFSML(fi, LOGL_ERROR, "New client connection from %s:%s, but we already " - "have a connection from %s:%u. Dropping new connection.\n", - ip_str, port_str, previous_conn->peer->addr, previous_conn->peer->port); + "have a connection from %s:%s. Dropping new connection.\n", + ip_str, port_str, prev_ip_str, prev_port_str); resp = rspro_gen_ConnectClientRes(&conn->srv->comp_id, ResultCode_identityInUse); client_conn_send(conn, resp); osmo_fsm_inst_state_chg(fi, CLNTC_ST_REJECTED, 1, 2); @@ -218,14 +226,19 @@ /* check for unique-ness */ previous_conn = bankd_conn_by_id(conn->srv, conn->bank.bank_id); if (previous_conn && previous_conn != conn) { + char prev_ip_str[INET6_ADDRSTRLEN]; + char prev_port_str[6]; + int prev_fd = osmo_stream_srv_get_fd(previous_conn->peer); + osmo_sock_get_ip_and_port(prev_fd, prev_ip_str, sizeof(prev_ip_str), + prev_port_str, sizeof(prev_port_str), false); /* we're dropping the current (new) connection as we don't really know which * is the "right" one. Dropping the new gives the old connection time to * timeout, or to continue to operate. If we were to drop the old * connection, this could interrupt a perfectly working connection and opens * some kind of DoS. */ LOGPFSML(fi, LOGL_ERROR, "New bankd connection from %s:%s, but we already " - "have a connection from %s:%u. Dropping new connection.\n", - ip_str, port_str, previous_conn->peer->addr, previous_conn->peer->port); + "have a connection from %s:%s. Dropping new connection.\n", + ip_str, port_str, prev_ip_str, prev_port_str); resp = rspro_gen_ConnectBankRes(&conn->srv->comp_id, ResultCode_identityInUse); client_conn_send(conn, resp); osmo_fsm_inst_state_chg(fi, CLNTC_ST_REJECTED, 1, 2); @@ -307,8 +320,9 @@ bankd_port = 0; } else { /* obtain IP and port of bankd */ - rc = osmo_sock_get_ip_and_port(bankd_conn->peer->ofd.fd, ip_str, sizeof(ip_str), - port_str, sizeof(port_str), false); + rc = osmo_sock_get_ip_and_port(osmo_stream_srv_get_fd(bankd_conn->peer), + ip_str, sizeof(ip_str), + port_str, sizeof(port_str), false); if (rc < 0) { LOGPFSML(bankd_conn->fi, LOGL_ERROR, "Error during getpeername\n"); return; @@ -636,66 +650,127 @@ return 0; } -/* data was received from one of the client connections to the RSPRO socket */ -static int sock_read_cb(struct ipa_server_conn *peer, struct msgb *msg) +static int _ipa_srv_conn_ccm(struct rspro_client_conn *conn, struct msgb *msg) { - struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; - struct ipaccess_head_ext *he = (struct ipaccess_head_ext *) msgb_l2(msg); - struct rspro_client_conn *conn = peer->data; + struct tlv_parsed tlvp; + uint8_t msg_type; + struct ipaccess_unit unit_data = {}; + char *unitid; + int len, ret; + + OSMO_ASSERT(msgb_l2len(msg) > 0); + msg_type = msg->l2h[0]; + + switch (msg_type) { + case IPAC_MSGT_PING: + ret = ipa_ccm_send_pong(osmo_stream_srv_get_fd(conn->peer)); + if (ret < 0) { + LOGPFSML(conn->fi, LOGL_ERROR, "Cannot send PONG message. Reason: %s\n", strerror(errno)); + goto err; + } + return 0; + case IPAC_MSGT_PONG: + LOGPFSML(conn->fi, LOGL_DEBUG, "PONG!\n"); + ipa_keepalive_fsm_pong_received(conn->keepalive_fi); + return 0; + case IPAC_MSGT_ID_ACK: + LOGPFSML(conn->fi, LOGL_DEBUG, "ID_ACK? -> ACK!\n"); + ret = ipa_ccm_send_id_ack(osmo_stream_srv_get_fd(conn->peer)); + if (ret < 0) { + LOGPFSML(conn->fi, LOGL_ERROR, "Cannot send ID_ACK message. Reason: %s\n", strerror(errno)); + goto err; + } + return 0; + case IPAC_MSGT_ID_RESP: + ret = ipa_ccm_id_resp_parse(&tlvp, (const uint8_t *)msg->l2h+1, msgb_l2len(msg)-1); + if (ret < 0) { + LOGPFSML(conn->fi, LOGL_ERROR, "IPA CCM RESPonse with malformed TLVs\n"); + goto err; + } + if (!TLVP_PRESENT(&tlvp, IPAC_IDTAG_UNIT)) { + LOGPFSML(conn->fi, LOGL_ERROR, "IPA CCM RESP without unit ID\n"); + goto err; + } + len = TLVP_LEN(&tlvp, IPAC_IDTAG_UNIT); + if (len < 1) { + LOGPFSML(conn->fi, LOGL_ERROR, "IPA CCM RESP with short unit ID\n"); + goto err; + } + unitid = (char *) TLVP_VAL(&tlvp, IPAC_IDTAG_UNIT); + unitid[len-1] = '\0'; + ipa_parse_unitid(unitid, &unit_data); + break; + default: + LOGPFSML(conn->fi, LOGL_ERROR, "Unknown IPA message type\n"); + goto err; + } + + return 0; +err: + /* Connection and msgb destroyed by parent. */ + return -1; +} + +/* data was received from one of the client connections to the RSPRO socket */ +static int sock_read_cb(struct osmo_stream_srv *peer, int res, struct msgb *msg) +{ + enum ipaccess_proto ipa_proto = osmo_ipa_msgb_cb_proto(msg); + struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); RsproPDU_t *pdu; int rc; - if (msgb_length(msg) < sizeof(*hh)) - goto invalid; - msg->l2h = &hh->data[0]; - switch (hh->proto) { + if (res <= 0) { + LOGPFSML(conn->fi, LOGL_NOTICE, "failed reading from socket: %d\n", res); + goto err; + } + + switch (ipa_proto) { case IPAC_PROTO_IPACCESS: - rc = ipa_server_conn_ccm(peer, msg); + rc = _ipa_srv_conn_ccm(conn, msg); if (rc < 0) - break; - switch (hh->data[0]) { - case IPAC_MSGT_PONG: - ipa_keepalive_fsm_pong_received(conn->keepalive_fi); - rc = 0; - break; - default: - break; - } + goto err; break; case IPAC_PROTO_OSMO: - if (!he || msgb_l2len(msg)< sizeof(*he)) - goto invalid; - msg->l2h = &he->data[0]; - - switch (he->proto) { + switch (osmo_ipa_msgb_cb_proto_ext(msg)) { case IPAC_PROTO_EXT_RSPRO: pdu = rspro_dec_msg(msg); - if (!pdu) - goto invalid; - + if (!pdu) { + rc = -EIO; + break; + } rc = handle_rx_rspro(conn, pdu); ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); break; default: - goto invalid; + LOGPFSML(conn->fi, LOGL_ERROR, "Rx unexpected ipa proto ext: %d\n", + osmo_ipa_msgb_cb_proto_ext(msg)); + goto err; } break; default: - goto invalid; + LOGPFSML(conn->fi, LOGL_ERROR, "Rx unexpected ipa proto: %d\n", ipa_proto); + goto err; } + msgb_free(msg); return rc; -invalid: +err: msgb_free(msg); - return -1; + osmo_stream_srv_destroy(peer); + return -EBADF; } -static int sock_closed_cb(struct ipa_server_conn *peer) +static int sock_closed_cb(struct osmo_stream_srv *peer) { - struct rspro_client_conn *conn = peer->data; - if (conn->fi) + struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); + if (!conn) + return 0; /* rspro conn is already being destroyed, do nothing. */ + osmo_stream_srv_set_data(peer, NULL); + if (conn->fi) { + conn->peer = NULL; osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_TCP_DOWN, NULL); + } /* FIXME: who cleans up conn? */ /* ipa server code relases 'peer' just after this */ return 0; @@ -706,10 +781,16 @@ .wait_for_resp = 10, }; -/* a new TCP connection was accepted on the RSPRO server socket */ -static int accept_cb(struct ipa_server_link *link, int fd) +static void ipa_keepalive_send_cb(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg) { - struct rspro_server *srv = link->data; + struct osmo_stream_srv *srv = (struct osmo_stream_srv *)conn; + osmo_stream_srv_send(srv, msg); +} + +/* a new TCP connection was accepted on the RSPRO server socket */ +static int accept_cb(struct osmo_stream_srv_link *link, int fd) +{ + struct rspro_server *srv = osmo_stream_srv_link_get_data(link); struct rspro_client_conn *conn; conn = talloc_zero(srv, struct rspro_client_conn); @@ -717,9 +798,12 @@ conn->srv = srv; /* don't allocate peer under 'conn', as it must survive 'conn' during teardown */ - conn->peer = ipa_server_conn_create(link, link, fd, sock_read_cb, sock_closed_cb, conn); + conn->peer = osmo_stream_srv_create2(link, link, fd, conn); if (!conn->peer) goto out_err; + osmo_stream_srv_set_read_cb(conn->peer, sock_read_cb); + osmo_stream_srv_set_closed_cb(conn->peer, sock_closed_cb); + osmo_stream_srv_set_segmentation_cb(conn->peer, osmo_ipa_segmentation_cb); /* don't allocate 'fi' as slave from 'conn', as 'fi' needs to survive 'conn' during * teardown */ @@ -728,11 +812,12 @@ goto out_err_conn; /* use ipa_keepalive_fsm to periodically send an IPA_PING and expect a PONG in response */ - conn->keepalive_fi = ipa_server_conn_alloc_keepalive_fsm(conn->peer, &ka_params, NULL); + conn->keepalive_fi = ipa_generic_conn_alloc_keepalive_fsm(conn->peer, conn->peer, &ka_params, NULL); if (!conn->keepalive_fi) goto out_err_fi; /* ensure parent is notified once keepalive FSM instance is dying */ osmo_fsm_inst_change_parent(conn->keepalive_fi, conn->fi, CLNTC_E_KA_TIMEOUT); + ipa_keepalive_fsm_set_send_cb(conn->keepalive_fi, ipa_keepalive_send_cb); ipa_keepalive_fsm_start(conn->keepalive_fi); INIT_LLIST_HEAD(&conn->bank.maps_new); @@ -751,7 +836,7 @@ out_err_fi: osmo_fsm_inst_term(conn->fi, OSMO_FSM_TERM_ERROR, NULL); out_err_conn: - ipa_server_conn_destroy(conn->peer); + osmo_stream_srv_destroy(conn->peer); /* the above will free 'conn' down the chain */ return -1; out_err: @@ -824,8 +909,12 @@ static void rspro_client_conn_destroy(struct rspro_client_conn *conn) { /* this will internally call closed_cb() which will dispatch a TCP_DOWN event */ - ipa_server_conn_destroy(conn->peer); - conn->peer = NULL; + if (conn->peer) { + osmo_stream_srv_set_data(conn->peer, NULL); + osmo_stream_srv_destroy(conn->peer); + conn->peer = NULL; + return; + } /* else: destroy initiated by conn->peer's closed_cb(). */ /* ensure all slotmaps are unlinked + returned to NEW or deleted */ slotmaps_wrlock(conn->srv->slotmaps); @@ -854,18 +943,26 @@ INIT_LLIST_HEAD(&srv->banks); pthread_rwlock_unlock(&srv->rwlock); - srv->link = ipa_server_link_create(ctx, NULL, host, port, accept_cb, srv); + srv->link = osmo_stream_srv_link_create(ctx); if (!srv->link) goto out_free; - rc = ipa_server_link_open(srv->link); + osmo_stream_srv_link_set_proto(srv->link, IPPROTO_TCP); + osmo_stream_srv_link_set_addr(srv->link, host); + osmo_stream_srv_link_set_port(srv->link, port); + osmo_stream_srv_link_set_data(srv->link, srv); + osmo_stream_srv_link_set_nodelay(srv->link, true); + osmo_stream_srv_link_set_accept_cb(srv->link, accept_cb); + + + rc = osmo_stream_srv_link_open(srv->link); if (rc < 0) goto out_destroy; return srv; out_destroy: - ipa_server_link_destroy(srv->link); + osmo_stream_srv_link_destroy(srv->link); out_free: pthread_rwlock_destroy(&srv->rwlock); talloc_free(srv); @@ -877,7 +974,7 @@ { /* FIXME: clear all lists */ - ipa_server_link_destroy(srv->link); + osmo_stream_srv_link_destroy(srv->link); srv->link = NULL; pthread_rwlock_destroy(&srv->rwlock); talloc_free(srv); diff --git a/src/server/rspro_server.h b/src/server/rspro_server.h index 6dd498e..4843821 100644 --- a/src/server/rspro_server.h +++ b/src/server/rspro_server.h @@ -3,13 +3,13 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/select.h> #include <osmocom/core/fsm.h> -#include <osmocom/abis/ipa.h> +#include <osmocom/netif/stream.h> #include "rspro_util.h" #include "slotmap.h" struct rspro_server { - struct ipa_server_link *link; + struct osmo_stream_srv_link *link; /* list of rspro_client_conn */ struct llist_head connections; struct llist_head clients; @@ -30,7 +30,7 @@ /* back-pointer to rspro_server */ struct rspro_server *srv; /* reference to the underlying IPA server connection */ - struct ipa_server_conn *peer; + struct osmo_stream_srv *peer; /* FSM instance for this connection */ struct osmo_fsm_inst *fi; /* remote component identity (after it has been received) */ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6341612e41a0005de85f45fd6454bb954becb69c Gerrit-Change-Number: 39033 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: rspro: use osmo_stream to handle IPA connection

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email ) Change subject: rspro: use osmo_stream to handle IPA connection ...................................................................... rspro: use osmo_stream to handle IPA connection libosmo-abis is still needed since we are still using ipa_keepalive_fsm from there. This needs to be imported here or moved to libosmo-netif. Related: OS#5896 Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a --- M configure.ac M debian/control M src/Makefile.am M src/bankd/Makefile.am M src/bankd/bankd_main.c M src/client/Makefile.am M src/rspro_client_fsm.c M src/rspro_client_fsm.h M src/server/Makefile.am 9 files changed, 147 insertions(+), 52 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 0529ff2..0296197 100644 --- a/configure.ac +++ b/configure.ac @@ -35,7 +35,8 @@ PKG_CHECK_MODULES(OSMOCORE, libosmocore >= 1.6.0) PKG_CHECK_MODULES(OSMOGSM, libosmogsm >= 0.11.0) -PKG_CHECK_MODULES(OSMOABIS, libosmoabis >= 0.8.0) +PKG_CHECK_MODULES(OSMONETIF, libosmo-netif >= 1.5.0) +PKG_CHECK_MODULES(OSMOABIS, libosmoabis >= 1.6.0) AC_ARG_ENABLE([remsim-server],[AS_HELP_STRING([--disable-remsim-server], [Build osmo-remsim-server])], [osmo_ac_build_server="$enableval"],[osmo_ac_build_server="yes"]) diff --git a/debian/control b/debian/control index b3204fc..1d6d7b3 100644 --- a/debian/control +++ b/debian/control @@ -10,7 +10,8 @@ osmo-gsm-manuals-dev, libcsv-dev, libosmocore-dev (>= 1.6.0), - libosmo-abis-dev, + libosmo-abis-dev (>= 1.6.0), + libosmo-netif-dev (>= 1.5.0), libosmo-simtrace2-dev (>= 0.8.0), libpcsclite-dev, libusb-1.0-0-dev, diff --git a/src/Makefile.am b/src/Makefile.am index 7c00395..6bb3d79 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -12,6 +12,7 @@ -I$(top_builddir)/include \ -I$(top_srcdir)/include/osmocom/rspro \ $(OSMOABIS_CFLAGS) \ + $(OSMONETIF_CFLAGS) \ $(OSMOGSM_CFLAGS) \ $(OSMOCORE_CFLAGS) \ $(NULL) @@ -19,7 +20,7 @@ RSPRO_LIBVERSION=2:0:0 lib_LTLIBRARIES = libosmo-rspro.la libosmo_rspro_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RSPRO_LIBVERSION) -# OSMOGSM_LIBS, OSMOABIS_LIBS not needed, we don't use any of its symbols, only the header above +# OSMOABIS_LIBS, OSMONETIF_LIBS, OSMOGSM_LIBS not needed, we don't use any of its symbols, only the header above libosmo_rspro_la_LIBADD = $(OSMOCORE_LIBS) \ rspro/libosmo-asn1-rspro.la libosmo_rspro_la_SOURCES = rspro_util.c asn1c_helpers.c diff --git a/src/bankd/Makefile.am b/src/bankd/Makefile.am index 98edf8e..d5eee87 100644 --- a/src/bankd/Makefile.am +++ b/src/bankd/Makefile.am @@ -4,6 +4,7 @@ -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ $(OSMOABIS_CFLAGS) \ + $(OSMONETIF_CFLAGS) \ $(OSMOGSM_CFLAGS) \ $(OSMOCORE_CFLAGS) \ $(PCSC_CFLAGS) \ @@ -24,6 +25,7 @@ bankd_main.c bankd_pcsc.c gsmtap.c osmo_remsim_bankd_LDADD = $(top_builddir)/src/libosmo-rspro.la \ $(OSMOABIS_LIBS) \ + $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ $(PCSC_LIBS) \ diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 212e606..c406415 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -32,6 +32,7 @@ #include <netdb.h> #include <osmocom/core/socket.h> +#include <osmocom/core/select.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/logging.h> #include <osmocom/core/application.h> diff --git a/src/client/Makefile.am b/src/client/Makefile.am index d5c263f..dc61196 100644 --- a/src/client/Makefile.am +++ b/src/client/Makefile.am @@ -4,6 +4,7 @@ -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ $(OSMOABIS_CFLAGS) \ + $(OSMONETIF_CFLAGS) \ $(OSMOGSM_CFLAGS) \ $(OSMOCORE_CFLAGS) \ $(PCSC_CFLAGS) $(USB_CFLAGS) \ @@ -17,6 +18,7 @@ osmo_remsim_client_shell_CFLAGS = $(AM_CFLAGS) osmo_remsim_client_shell_LDADD = $(top_builddir)/src/libosmo-rspro.la \ $(OSMOABIS_LIBS) \ + $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ $(NULL) @@ -35,6 +37,7 @@ libifd_remsim_client_la_LDFLAGS = -no-undefined libifd_remsim_client_la_LIBADD = $(top_builddir)/src/libosmo-rspro.la \ $(OSMOABIS_LIBS) \ + $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ $(NULL) @@ -48,6 +51,7 @@ osmo_remsim_client_st2_CFLAGS = $(AM_CFLAGS) osmo_remsim_client_st2_LDADD = $(top_builddir)/src/libosmo-rspro.la \ $(OSMOABIS_LIBS) \ + $(OSMONETIF_LIBS) \ $(OSMOSIMTRACE2_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 351c642..dcde0e4 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -25,12 +25,16 @@ #include <talloc.h> #include <osmocom/core/logging.h> +#include <osmocom/core/select.h> #include <osmocom/core/utils.h> #include <osmocom/core/msgb.h> #include <osmocom/core/fsm.h> - -#include <osmocom/abis/ipa.h> #include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/netif/stream.h> +#include <osmocom/netif/ipa.h> + +/* libosmo-abis still needed for ipa_keepalive_fsm: */ +#include <osmocom/abis/ipa.h> #include "debug.h" #include "asn1c_helpers.h" @@ -73,15 +77,15 @@ * remsim-bankd for their RSPRO control connection to remsim-server. ***********************************************************************/ -static void push_and_send(struct ipa_client_conn *ipa, struct msgb *msg_tx) +static void push_and_send(struct osmo_stream_cli *cli, struct msgb *msg_tx) { ipa_prepend_header_ext(msg_tx, IPAC_PROTO_EXT_RSPRO); ipa_prepend_header(msg_tx, IPAC_PROTO_OSMO); - ipa_client_conn_send(ipa, msg_tx); + osmo_stream_cli_send(cli, msg_tx); /* msg_tx is now queued and will be freed. */ } -static int ipa_client_conn_send_rspro(struct ipa_client_conn *ipa, RsproPDU_t *rspro) +static int cli_conn_send_rspro(struct osmo_stream_cli *cli, RsproPDU_t *rspro) { struct msgb *msg = rspro_enc_msg(rspro); if (!msg) { @@ -90,14 +94,14 @@ ASN_STRUCT_FREE(asn_DEF_RsproPDU, rspro); return -1; } - push_and_send(ipa, msg); + push_and_send(cli, msg); return 0; } static int _server_conn_send_rspro(struct rspro_server_conn *srvc, RsproPDU_t *rspro) { LOGPFSML(srvc->fi, LOGL_DEBUG, "Tx RSPRO %s\n", rspro_msgt_name(rspro)); - return ipa_client_conn_send_rspro(srvc->conn, rspro); + return cli_conn_send_rspro(srvc->conn, rspro); } int server_conn_send_rspro(struct rspro_server_conn *srvc, RsproPDU_t *rspro) @@ -139,35 +143,101 @@ { 0, NULL } }; -static void srvc_updown_cb(struct ipa_client_conn *conn, int up) +static int srvc_connect_cb(struct osmo_stream_cli *cli) { - struct rspro_server_conn *srvc = conn->data; - - LOGPFSML(srvc->fi, LOGL_NOTICE, "RSPRO link to %s:%d %s\n", - conn->addr, conn->port, up ? "UP" : "DOWN"); - - osmo_fsm_inst_dispatch(srvc->fi, up ? SRVC_E_TCP_UP: SRVC_E_TCP_DOWN, 0); + struct rspro_server_conn *srvc = osmo_stream_cli_get_data(cli); + LOGPFSML(srvc->fi, LOGL_NOTICE, "RSPRO link to %s:%d UP\n", srvc->server_host, srvc->server_port); + osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_TCP_UP, 0); + return 0; } -static int srvc_read_cb(struct ipa_client_conn *conn, struct msgb *msg) +static int srvc_disconnect_cb(struct osmo_stream_cli *cli) { - struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; - struct ipaccess_head_ext *he = (struct ipaccess_head_ext *) msgb_l2(msg); - struct rspro_server_conn *srvc = conn->data; + struct rspro_server_conn *srvc = osmo_stream_cli_get_data(cli); + + LOGPFSML(srvc->fi, LOGL_NOTICE, "RSPRO link to %s:%d DOWN\n", srvc->server_host, srvc->server_port); + osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_TCP_DOWN, 0); + return 0; +} + +static struct msgb *ipa_bts_id_ack(void) +{ + struct msgb *nmsg2; + nmsg2 = ipa_msg_alloc(0); + if (!nmsg2) + return NULL; + msgb_v_put(nmsg2, IPAC_MSGT_ID_ACK); + ipa_prepend_header(nmsg2, IPAC_PROTO_IPACCESS); + return nmsg2; +} + +static int _ipaccess_bts_handle_ccm(struct osmo_stream_cli *cli, struct rspro_server_conn *srvc, struct msgb *msg) +{ + /* special handling for IPA CCM. */ + if (osmo_ipa_msgb_cb_proto(msg) != IPAC_PROTO_IPACCESS) + return 0; + + int ret = 0; + const uint8_t *data = msgb_l2(msg); + int len = msgb_l2len(msg); + OSMO_ASSERT(len > 0); + uint8_t msg_type = *data; + + /* ping, pong and acknowledgment cases. */ + struct osmo_fd tmp_ofd = { .fd = osmo_stream_cli_get_fd(cli) }; + OSMO_ASSERT(tmp_ofd.fd >= 0); + ret = ipa_ccm_rcvmsg_bts_base(msg, &tmp_ofd); + if (ret < 0) + goto err; + + /* this is a request for identification from the BSC. */ + if (msg_type == IPAC_MSGT_ID_GET) { + struct msgb *rmsg; + LOGPFSML(srvc->fi, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", + srvc->ipa_dev.site_id, srvc->ipa_dev.bts_id, srvc->ipa_dev.trx_id); + rmsg = ipa_ccm_make_id_resp_from_req(&srvc->ipa_dev, data + 1, len - 1); + if (!rmsg) { + LOGPFSML(srvc->fi, LOGL_ERROR, "Failed parsing ID_GET message.\n"); + goto err; + } + osmo_stream_cli_send(cli, rmsg); + + /* send ID_ACK. */ + rmsg = ipa_bts_id_ack(); + if (!rmsg) { + LOGPFSML(srvc->fi, LOGL_ERROR, "Failed allocating ID_ACK message.\n"); + goto err; + } + osmo_stream_cli_send(cli, rmsg); + } + return 1; + +err: + return -1; +} + +static int srvc_read_cb(struct osmo_stream_cli *cli, int res, struct msgb *msg) +{ + enum ipaccess_proto ipa_proto = osmo_ipa_msgb_cb_proto(msg); + struct rspro_server_conn *srvc = osmo_stream_cli_get_data(cli); RsproPDU_t *pdu; int rc; - if (msgb_length(msg) < sizeof(*hh)) - goto invalid; - msg->l2h = &hh->data[0]; - switch (hh->proto) { + if (res <= 0) { + LOGPFSML(srvc->fi, LOGL_NOTICE, "failed reading from socket: %d\n", res); + goto err; + } + + switch (ipa_proto) { case IPAC_PROTO_IPACCESS: - rc = ipaccess_bts_handle_ccm(srvc->conn, &srvc->ipa_dev, msg); + OSMO_ASSERT(msgb_l2len(msg) > 0); + uint8_t msg_type = msg->l2h[0]; + rc = _ipaccess_bts_handle_ccm(srvc->conn, srvc, msg); if (rc < 0) { msgb_free(msg); break; } - switch (hh->data[0]) { + switch (msg_type) { case IPAC_MSGT_PONG: ipa_keepalive_fsm_pong_received(srvc->keepalive_fi); rc = 0; @@ -177,10 +247,7 @@ } break; case IPAC_PROTO_OSMO: - if (!he || msgb_l2len(msg) < sizeof(*he)) - goto invalid; - msg->l2h = &he->data[0]; - switch (he->proto) { + switch (osmo_ipa_msgb_cb_proto_ext(msg)) { case IPAC_PROTO_EXT_RSPRO: LOGPFSML(srvc->fi, LOGL_DEBUG, "Received RSPRO %s\n", msgb_hexdump(msg)); pdu = rspro_dec_msg(msg); @@ -192,20 +259,20 @@ ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); break; default: - goto invalid; + goto err; } break; default: - goto invalid; + goto err; } msgb_free(msg); return rc; -invalid: - LOGPFSML(srvc->fi, LOGL_ERROR, "Error decoding PDU\n"); +err: msgb_free(msg); - return -1; + osmo_stream_cli_close(cli); + return -EBADF; } static const struct ipa_keepalive_params ka_params = { @@ -294,8 +361,7 @@ if (res != ResultCode_ok) { LOGPFSML(fi, LOGL_ERROR, "Rx RSPRO connectClientRes(result=%s), closing\n", asn_enum_name(&asn_DEF_ResultCode, res)); - ipa_client_conn_close(srvc->conn); - osmo_fsm_inst_dispatch(fi, SRVC_E_TCP_DOWN, NULL); + osmo_stream_cli_close(srvc->conn); } else { /* somehow notify the main code? */ osmo_fsm_inst_state_chg(fi, SRVC_ST_CONNECTED, 0, 0); @@ -341,6 +407,12 @@ osmo_fsm_inst_dispatch(fi->proc.parent, srvc->parent_disc_evt, NULL); } +static void ipa_keepalive_send_cb(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg) +{ + struct osmo_stream_cli *cli = (struct osmo_stream_cli *)conn; + osmo_stream_cli_send(cli, msg); +} + static int ipa_kaepalive_timeout_cb(struct osmo_fsm_inst *ka_fi, void *conn) { struct osmo_fsm_inst *fi = ka_fi->proc.parent; @@ -360,8 +432,7 @@ if (srvc->conn) { LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to server\n"); - ipa_client_conn_close(srvc->conn); - ipa_client_conn_destroy(srvc->conn); + osmo_stream_cli_destroy(srvc->conn); srvc->conn = NULL; } @@ -387,24 +458,39 @@ LOGPFSML(fi, LOGL_INFO, "Creating TCP connection to server at %s:%u\n", srvc->server_host, srvc->server_port); - srvc->conn = ipa_client_conn_create2(fi, NULL, 0, NULL, 0, srvc->server_host, srvc->server_port, - srvc_updown_cb, srvc_read_cb, NULL, srvc); + srvc->conn = osmo_stream_cli_create(fi); if (!srvc->conn) { LOGPFSML(fi, LOGL_FATAL, "Unable to create socket: %s\n", strerror(errno)); exit(1); } - srvc->keepalive_fi = ipa_client_conn_alloc_keepalive_fsm(srvc->conn, &ka_params, fi->id); + osmo_stream_cli_set_name(srvc->conn, fi->id); + osmo_stream_cli_set_data(srvc->conn, srvc); + osmo_stream_cli_set_addr(srvc->conn, srvc->server_host); + osmo_stream_cli_set_port(srvc->conn, srvc->server_port); + osmo_stream_cli_set_proto(srvc->conn, IPPROTO_TCP); + osmo_stream_cli_set_nodelay(srvc->conn, true); + + /* Reconnect is handled by upper layers: */ + osmo_stream_cli_set_reconnect_timeout(srvc->conn, -1); + + osmo_stream_cli_set_segmentation_cb(srvc->conn, osmo_ipa_segmentation_cb); + osmo_stream_cli_set_connect_cb(srvc->conn, srvc_connect_cb); + osmo_stream_cli_set_disconnect_cb(srvc->conn, srvc_disconnect_cb); + osmo_stream_cli_set_read_cb2(srvc->conn, srvc_read_cb); + + srvc->keepalive_fi = ipa_generic_conn_alloc_keepalive_fsm(srvc->conn, srvc->conn, &ka_params, fi->id); if (!srvc->keepalive_fi) { LOGPFSM(fi, "Unable to create keepalive FSM\n"); exit(1); } + ipa_keepalive_fsm_set_send_cb(srvc->keepalive_fi, ipa_keepalive_send_cb); ipa_keepalive_fsm_set_timeout_cb(srvc->keepalive_fi, ipa_kaepalive_timeout_cb); /* ensure parent is notified once keepalive FSM instance is dying */ osmo_fsm_inst_change_parent(srvc->keepalive_fi, srvc->fi, SRVC_E_KA_TERMINATED); /* Attempt to connect TCP socket */ - rc = ipa_client_conn_open(srvc->conn); + rc = osmo_stream_cli_open(srvc->conn); if (rc < 0) { LOGPFSML(fi, LOGL_FATAL, "Unable to connect RSPRO to %s:%u - %s\n", srvc->server_host, srvc->server_port, strerror(errno)); @@ -446,8 +532,7 @@ } if (srvc->conn) { LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to server\n"); - ipa_client_conn_close(srvc->conn); - ipa_client_conn_destroy(srvc->conn); + osmo_stream_cli_destroy(srvc->conn); srvc->conn = NULL; } osmo_fsm_inst_state_chg(fi, SRVC_ST_INIT, 0, 0); @@ -472,8 +557,7 @@ break; case 1: /* no ClientConnectRes received: disconnect + reconnect */ - ipa_client_conn_close(srvc->conn); - osmo_fsm_inst_dispatch(fi, SRVC_E_TCP_DOWN, NULL); + osmo_stream_cli_close(srvc->conn); break; default: OSMO_ASSERT(0); diff --git a/src/rspro_client_fsm.h b/src/rspro_client_fsm.h index 55fe4a4..152ae5c 100644 --- a/src/rspro_client_fsm.h +++ b/src/rspro_client_fsm.h @@ -1,7 +1,8 @@ #pragma once #include <osmocom/core/fsm.h> -#include <osmocom/abis/ipa.h> +#include <osmocom/gsm/ipa.h> +#include <osmocom/netif/stream.h> #include <osmocom/rspro/RsproPDU.h> #include "rspro_util.h" @@ -17,12 +18,10 @@ SRVC_E_RSPRO_TX /* transmit a RSPRO PDU to the peer */ }; -struct rspro_server_conn; - /* representing a client-side connection to a RSPRO server */ struct rspro_server_conn { /* state */ - struct ipa_client_conn *conn; + struct osmo_stream_cli *conn; struct osmo_fsm_inst *fi; struct osmo_fsm_inst *keepalive_fi; int (*handle_rx)(struct rspro_server_conn *conn, const RsproPDU_t *pdu); diff --git a/src/server/Makefile.am b/src/server/Makefile.am index 15ae31b..5a1908a 100644 --- a/src/server/Makefile.am +++ b/src/server/Makefile.am @@ -5,6 +5,7 @@ -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ $(OSMOABIS_CFLAGS) \ + $(OSMONETIF_CFLAGS) \ $(OSMOGSM_CFLAGS) \ $(OSMOCORE_CFLAGS) \ $(ULFIUS_CFLAGS) \ @@ -20,6 +21,7 @@ ../rspro_util.c ../slotmap.c ../debug.c osmo_remsim_server_LDADD = $(top_builddir)/src/libosmo-rspro.la \ $(OSMOABIS_LIBS) \ + $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ $(ULFIUS_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a Gerrit-Change-Number: 39023 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[osmith/1.12.3]: Bump version: 1.12.2.6-d24f → 1.12.3

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39052?usp=email ) Change subject: Bump version: 1.12.2.6-d24f → 1.12.3 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I961534bb0970e934f2201767a47fdbb17576c015 Gerrit-Change-Number: 39052 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 23:11:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-bsc[osmith/1.12.3]: ipaccess-config: Remove unused function ipaccess_bts_handle_ccm()

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39051?usp=email ) Change subject: ipaccess-config: Remove unused function ipaccess_bts_handle_ccm() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39051?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I126014eed2196e9fe03c65dff7bb384ac81f39f8 Gerrit-Change-Number: 39051 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 23:11:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[L] Change in osmo-bsc[osmith/1.12.3]: ipaccess-config: Use own e1_input ipaccess driver

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39050?usp=email ) Change subject: ipaccess-config: Use own e1_input ipaccess driver ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I4d26876ce7d75a78f03c4fa66233550baf4fa7d5 Gerrit-Change-Number: 39050 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 23:11:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-bsc[osmith/1.12.3]: Drop use of libosmo-abis osmocom/abis/ipaccess.h

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39049?usp=email ) Change subject: Drop use of libosmo-abis osmocom/abis/ipaccess.h ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I5f9daaf7789a56a08d2ec24b5e25e2e3b65b8b5b Gerrit-Change-Number: 39049 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 23:11:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024