December 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[osmith/1.12.3]: Drop use of libosmo-abis osmocom/abis/ipaccess.h

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39049?usp=email ) Change subject: Drop use of libosmo-abis osmocom/abis/ipaccess.h ...................................................................... Drop use of libosmo-abis osmocom/abis/ipaccess.h That header is only really used to provide an old hack for ipaccess-proxy tool in openbsc.h/osmo-bsc.h, and will be deprecated soon. src/ipaccess/ipaccess-config.c already has an explicit extern declaration for ipacces_fd_cb() anyway, so drop the header in advance. Take the chance to organize a bit better the includes based on dependency chain. Change-Id: I5f9daaf7789a56a08d2ec24b5e25e2e3b65b8b5b (cherry picked from commit 1ca1a295ec91def8c09b3f62183be1d3982dd6f3) --- M src/ipaccess/ipaccess-config.c M src/ipaccess/ipaccess-proxy.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/bts_osmobts.c M src/osmo-bsc/e1_config.c 5 files changed, 30 insertions(+), 34 deletions(-) Approvals: osmith: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 720837e..15dcc54 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -40,21 +40,21 @@ #include <osmocom/core/application.h> #include <osmocom/core/select.h> #include <osmocom/core/timer.h> -#include <osmocom/bsc/ipaccess.h> +#include <osmocom/core/talloc.h> +#include <osmocom/gsm/protocol/gsm_12_21.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/abis/abis.h> #include <osmocom/abis/e1_input.h> +#include <osmocom/bsc/ipaccess.h> #include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/signal.h> #include <osmocom/bsc/debug.h> #include <osmocom/bsc/network_listen.h> -#include <osmocom/abis/ipaccess.h> #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/signal.h> #include <osmocom/bsc/debug.h> #include <osmocom/bsc/network_listen.h> -#include <osmocom/core/talloc.h> -#include <osmocom/abis/abis.h> -#include <osmocom/gsm/protocol/gsm_12_21.h> #include <osmocom/bsc/bss.h> #include <osmocom/bsc/bts.h> diff --git a/src/ipaccess/ipaccess-proxy.c b/src/ipaccess/ipaccess-proxy.c index 62e79cd..e659708 100644 --- a/src/ipaccess/ipaccess-proxy.c +++ b/src/ipaccess/ipaccess-proxy.c @@ -37,18 +37,18 @@ #define _GNU_SOURCE #include <getopt.h> -#include <osmocom/bsc/gsm_data.h> #include <osmocom/core/application.h> #include <osmocom/core/select.h> -#include <osmocom/gsm/tlv.h> #include <osmocom/core/msgb.h> -#include <osmocom/gsm/ipa.h> -#include <osmocom/abis/ipa.h> -#include <osmocom/abis/ipaccess.h> -#include <osmocom/bsc/debug.h> -#include <osmocom/bsc/ipaccess.h> #include <osmocom/core/socket.h> #include <osmocom/core/talloc.h> +#include <osmocom/gsm/tlv.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/gsm/ipa.h> +#include <osmocom/abis/ipa.h> +#include <osmocom/bsc/gsm_data.h> +#include <osmocom/bsc/debug.h> +#include <osmocom/bsc/ipaccess.h> /* one instance of an ip.access protocol proxy */ struct ipa_proxy { diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index b0532e5..9ce7a45 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -25,25 +25,23 @@ #include <osmocom/gsm/tlv.h> -#include <osmocom/bsc/gsm_data.h> -#include <osmocom/bsc/signal.h> -#include <osmocom/bsc/abis_nm.h> -#include <osmocom/abis/e1_input.h> -#include <osmocom/gsm/tlv.h> #include <osmocom/core/msgb.h> #include <osmocom/core/socket.h> #include <osmocom/core/stat_item.h> #include <osmocom/core/talloc.h> #include <osmocom/core/utils.h> +#include <osmocom/core/logging.h> +#include <osmocom/gsm/tlv.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/gsm/ipa.h> +#include <osmocom/abis/e1_input.h> +#include <osmocom/abis/subchan_demux.h> #include <osmocom/bsc/gsm_data.h> +#include <osmocom/bsc/signal.h> #include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/abis_rsl.h> #include <osmocom/bsc/abis_osmo.h> #include <osmocom/bsc/debug.h> -#include <osmocom/abis/subchan_demux.h> -#include <osmocom/gsm/ipa.h> -#include <osmocom/abis/ipaccess.h> -#include <osmocom/core/logging.h> #include <osmocom/bsc/ipaccess.h> #include <osmocom/bsc/bts_ipaccess_nanobts_omlattr.h> #include <osmocom/bsc/paging.h> diff --git a/src/osmo-bsc/bts_osmobts.c b/src/osmo-bsc/bts_osmobts.c index 9312a2a..1df9497 100644 --- a/src/osmo-bsc/bts_osmobts.c +++ b/src/osmo-bsc/bts_osmobts.c @@ -24,21 +24,19 @@ #include <osmocom/gsm/tlv.h> +#include <osmocom/core/msgb.h> +#include <osmocom/core/talloc.h> +#include <osmocom/core/logging.h> +#include <osmocom/gsm/tlv.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/abis/e1_input.h> +#include <osmocom/abis/subchan_demux.h> #include <osmocom/bsc/gsm_data.h> #include <osmocom/bsc/signal.h> #include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/bts.h> -#include <osmocom/abis/e1_input.h> -#include <osmocom/gsm/tlv.h> -#include <osmocom/core/msgb.h> -#include <osmocom/core/talloc.h> -#include <osmocom/bsc/gsm_data.h> -#include <osmocom/bsc/abis_nm.h> #include <osmocom/bsc/abis_rsl.h> #include <osmocom/bsc/debug.h> -#include <osmocom/abis/subchan_demux.h> -#include <osmocom/abis/ipaccess.h> -#include <osmocom/core/logging.h> extern struct gsm_bts_model bts_model_nanobts; diff --git a/src/osmo-bsc/e1_config.c b/src/osmo-bsc/e1_config.c index dbea3e9..aaf8b70 100644 --- a/src/osmo-bsc/e1_config.c +++ b/src/osmo-bsc/e1_config.c @@ -23,11 +23,11 @@ #include <time.h> #include <netinet/in.h> -#include <osmocom/bsc/gsm_data.h> -#include <osmocom/abis/e1_input.h> -#include <osmocom/bsc/misdn.h> -#include <osmocom/abis/ipaccess.h> #include <osmocom/core/talloc.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/abis/e1_input.h> +#include <osmocom/bsc/gsm_data.h> +#include <osmocom/bsc/misdn.h> #include <osmocom/bsc/debug.h> #include <osmocom/bsc/abis_rsl.h> #include <osmocom/bsc/bts.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I5f9daaf7789a56a08d2ec24b5e25e2e3b65b8b5b Gerrit-Change-Number: 39049 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[osmith/1.12.3]: ipaccess-config: Remove unused function ipaccess_bts_handle_ccm()

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39051?usp=email ) Change subject: ipaccess-config: Remove unused function ipaccess_bts_handle_ccm() ...................................................................... ipaccess-config: Remove unused function ipaccess_bts_handle_ccm() This function actually slippted in unintentionally when copying the ipaccess driver from libosmo-abis.git as a base for the ipaccess-config driver. That function is actually not used either by libosmo-abis driver, but was left there as a backward compatible API. Fixes: 76b863eb47ecaaf22fb4ca6ecd19f94a05b2ed5c Change-Id: I126014eed2196e9fe03c65dff7bb384ac81f39f8 (cherry picked from commit 7067255b8486a299fc67312819641f813c6099d6) --- M src/ipaccess/ipaccess-config-e1-driver.c 1 file changed, 0 insertions(+), 68 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c index 1303d43..71e70e1 100644 --- a/src/ipaccess/ipaccess-config-e1-driver.c +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -207,71 +207,6 @@ return rc; } -int ipaccess_bts_handle_ccm(struct ipa_client_conn *link, - struct ipaccess_unit *dev, struct msgb *msg) -{ - struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; - - /* special handling for IPA CCM. */ - if (hh->proto != IPAC_PROTO_IPACCESS) - return 0; - - int ret = 0; - uint8_t *data = msgb_l2(msg); - int len = msgb_l2len(msg); - OSMO_ASSERT(len > 0); - uint8_t msg_type = *data; - /* line might not exist if != bsc||bts */ - - /* ping, pong and acknowledgment cases. */ - ret = ipa_ccm_rcvmsg_bts_base(msg, link->ofd); - if (ret < 0) - goto err; - - /* this is a request for identification from the BSC. */ - if (msg_type == IPAC_MSGT_ID_GET) { - struct msgb *rmsg; - /* The ipaccess_unit dev holds generic identity for the whole - * line, hence no trx_id. Patch ipaccess_unit during call to - * ipa_ccm_make_id_resp_from_req() to identify this TRX: */ - int store_trx_nr = dev->trx_id; - if (link->ofd->priv_nr >= E1INP_SIGN_RSL) - dev->trx_id = link->ofd->priv_nr - E1INP_SIGN_RSL; - else - dev->trx_id = 0; - LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", - dev->site_id, dev->bts_id, dev->trx_id); - rmsg = ipa_ccm_make_id_resp_from_req(dev, data + 1, len - 1); - dev->trx_id = store_trx_nr; - if (!rmsg) { - LOGP(DLINP, LOGL_ERROR, "Failed parsing ID_GET message.\n"); - goto err; - } - - ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len); - if (ret != rmsg->len) { - LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP message. Reason: %s\n", - strerror(errno)); - msgb_free(rmsg); - goto err; - } - msgb_free(rmsg); - - /* send ID_ACK. */ - ret = ipa_ccm_send_id_ack(link->ofd->fd); - if (ret <= 0) { - LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK message. Reason: %s\n", - strerror(errno)); - goto err; - } - } - return 1; - -err: - ipa_client_conn_close(link); - return -1; -} - static struct msgb *ipa_bts_id_ack(void) { struct msgb *nmsg2; @@ -294,9 +229,6 @@ LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP_NODELAY: %s\n", strerror(errno)); } -/* Same as ipaccess_bts_handle_ccm(), but using an osmo_stream_cli as backend - * instead of ipa_client_conn. - * The old ipaccess_bts_handle_ccm() needs to be kept as it's a public API. */ static int _ipaccess_bts_handle_ccm(struct osmo_stream_cli *cli, struct ipaccess_unit *dev, struct msgb *msg) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39051?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I126014eed2196e9fe03c65dff7bb384ac81f39f8 Gerrit-Change-Number: 39051 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[L] Change in osmo-bsc[osmith/1.12.3]: ipaccess-config: Use own e1_input ipaccess driver

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39050?usp=email ) Change subject: ipaccess-config: Use own e1_input ipaccess driver ...................................................................... ipaccess-config: Use own e1_input ipaccess driver Since osmo-bsc.git creation from openbsc.git around 10 years ago, a reference was kept in osmo-bsc/ipaccess/ipaccess-config.c to ipa specific code in the ipaccess e1_input stack of libosmo-abis.git (ipaccess_fd_cb()). Back at that time that was already considered to be an ugly hack, as mentioned in include/osmocom/abis/ipaccess.h exporting that function. This was done because ipaccess-config is quite different in several aspects wrt to usual ipaccess based bts/osmo-bsc ipaccess lines: * nanoBTS acts as TCP server and ipaccess-client as TCP client. * TCP port 3006 is used instead of usual OML 3002. * IPA handshake is actually also different, since despite nanoBTS being the server it doesn't really trigger an IPA ID GET which need to answer. Instead, upon ipaccess-config connecting, it will send an IPA ID ACK and wait to receive an IP ID ACK itself before start transmitting OML to ipaccess-config. Due to all those differences, it really makes no sense to keep support for this setup in the more usual bts<->bsc Abis e1line ipaccess driver present in libosmo-abis.git. Instead, this patch adds a new ipaccess-config-e1-driver.c which implements a libosmo-abis e1_input line driver which works for this specific service. libosmo-abis.git src/input/ipaccess.c from Change-Id Idf241c8f2fdb86d090d4132a9b316b7236402232 is used as a base, further simplifying it by removing stuff not really needed like BTS/BSC role, tcp keepalive, tcp socket stats, etc. Related: SYS#7063 Related: OS#5755 Related: OS#5756 Change-Id: I4d26876ce7d75a78f03c4fa66233550baf4fa7d5 (cherry picked from commit 76b863eb47ecaaf22fb4ca6ecd19f94a05b2ed5c) --- M src/ipaccess/Makefile.am A src/ipaccess/ipaccess-config-e1-driver.c M src/ipaccess/ipaccess-config.c 3 files changed, 558 insertions(+), 57 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/ipaccess/Makefile.am b/src/ipaccess/Makefile.am index 9bd648d..52bfed4 100644 --- a/src/ipaccess/Makefile.am +++ b/src/ipaccess/Makefile.am @@ -41,6 +41,7 @@ ipaccess_config_SOURCES = \ ipaccess-config.c \ + ipaccess-config-e1-driver.c \ ipaccess-firmware.c \ network_listen.c \ stubs.c \ diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c new file mode 100644 index 0000000..1303d43 --- /dev/null +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -0,0 +1,544 @@ +/* OpenBSC Abis input driver for ip.access */ + +/* (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * (C) 2009-2021 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2010 by Holger Hans Peter Freyther + * (C) 2010 by On-Waves + * + * All Rights Reserved + * + * SPDX-License-Identifier: AGPL-3.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <stdio.h> +#include <unistd.h> +#include <stdlib.h> +#include <stdbool.h> +#include <errno.h> +#include <netinet/tcp.h> +#include <string.h> +#include <time.h> +#include <fcntl.h> +#include <sys/socket.h> +#include <sys/ioctl.h> +#include <arpa/inet.h> + +#include <osmocom/core/select.h> +#include <osmocom/core/msgb.h> +#include <osmocom/core/macaddr.h> +#include <osmocom/core/logging.h> +#include <osmocom/core/talloc.h> +#include <osmocom/core/socket.h> +#include <osmocom/core/backtrace.h> +#include <osmocom/core/fsm.h> +#include <osmocom/core/signal.h> +#include <osmocom/gsm/tlv.h> +#include <osmocom/gsm/protocol/ipaccess.h> +#include <osmocom/gsm/ipa.h> +#include <osmocom/netif/stream.h> +#include <osmocom/netif/ipa.h> +#include <osmocom/abis/e1_input.h> +#include <osmocom/abis/ipa.h> + +/* default port at BTS for incoming connections */ +#define IPACCESS_BTS_LISTEN_OML_PORT 3006 + +/* global parameters of IPA input driver */ +struct ipaccess_config_proto_pars { + uint8_t dscp; + uint8_t priority; +}; +struct ipaccess_config_pars { + struct ipaccess_config_proto_pars oml; + struct ipaccess_config_proto_pars rsl; + char *connect_addr; +}; +struct ipaccess_config_pars g_e1inp_ipaccess_config_pars; + +static void *tall_ipa_ctx; + +struct ipaccess_line { + bool line_already_initialized; + struct osmo_stream_cli *ipa_cli[NUM_E1_TS]; /* 0=OML, 1+N=TRX_N */ +}; + +static int e1inp_int_snd_event(struct e1inp_ts *ts, struct e1inp_sign_link *link, int evt) +{ + struct input_signal_data isd; + isd.line = ts->line; + isd.ts_nr = ts->num; + isd.link_type = link->type; + isd.trx = link->trx; + isd.tei = link->tei; + isd.sapi = link->sapi; + + /* report further upwards */ + osmo_signal_dispatch(SS_L_INPUT, evt, &isd); + return 0; +} + +static inline struct e1inp_ts *ipaccess_line_ts(struct osmo_fd *bfd, struct e1inp_line *line) +{ + if (bfd->priv_nr == E1INP_SIGN_OML) + return e1inp_line_ipa_oml_ts(line); + else + return e1inp_line_ipa_rsl_ts(line, bfd->priv_nr - E1INP_SIGN_RSL); +} + + +static void _ipaccess_bts_down_cb(struct osmo_stream_cli *cli) +{ + struct e1inp_ts *e1i_ts = osmo_stream_cli_get_data(cli); + struct e1inp_line *line = e1i_ts->line; + + if (line->ops->sign_link_down) + line->ops->sign_link_down(line); +} + +/* See how ts->num is assigned in e1inp_line_create: line->ts[i].num = i+1; +* As per e1inp_line_ipa_oml_ts(), first TS in line (ts->num=1) is OML. +* As per e1inp_line_ipa_rsl_ts(), second TS in line (ts->num>=2) is RSL. +*/ +static inline enum e1inp_sign_type ipaccess_e1i_ts_sign_type(const struct e1inp_ts *e1i_ts) +{ + OSMO_ASSERT(e1i_ts->num != 0); + if (e1i_ts->num == 1) + return E1INP_SIGN_OML; + return E1INP_SIGN_RSL; +} + +static inline unsigned int ipaccess_e1i_ts_trx_nr(const struct e1inp_ts *e1i_ts) +{ + enum e1inp_sign_type sign_type = ipaccess_e1i_ts_sign_type(e1i_ts); + if (sign_type == E1INP_SIGN_OML) + return 0; /* OML uses trx_nr=0 */ + OSMO_ASSERT(sign_type == E1INP_SIGN_RSL); + /* e1i_ts->num >= 2: */ + return e1i_ts->num - 2; +} + +static inline struct osmo_stream_cli *ipaccess_bts_e1i_ts_stream_cli(const struct e1inp_ts *e1i_ts) +{ + OSMO_ASSERT(e1i_ts); + struct ipaccess_line *il = e1i_ts->line->driver_data; + OSMO_ASSERT(il); + struct osmo_stream_cli *cli = il->ipa_cli[e1i_ts->num - 1]; + OSMO_ASSERT(cli); + return cli; +} + +static void ipaccess_close(struct e1inp_sign_link *sign_link) +{ + struct e1inp_ts *e1i_ts = sign_link->ts; + struct osmo_fd *bfd = &e1i_ts->driver.ipaccess.fd; + struct osmo_stream_cli *cli; + + e1inp_int_snd_event(e1i_ts, sign_link, S_L_INP_TEI_DN); + /* the first e1inp_sign_link_destroy call closes the socket. */ + + cli = ipaccess_bts_e1i_ts_stream_cli(e1i_ts); + osmo_stream_cli_close(cli); + bfd->fd = -1; /* Compatibility with older implementations */ +} + +static bool e1i_ts_has_pending_tx_msgs(struct e1inp_ts *e1i_ts) +{ + struct e1inp_sign_link *link; + llist_for_each_entry(link, &e1i_ts->sign.sign_links, list) { + if (!llist_empty(&link->tx_list)) + return true; + } + return false; +} + +static int ipaccess_bts_send_msg(struct e1inp_ts *e1i_ts, + struct e1inp_sign_link *sign_link, + struct osmo_stream_cli *cli, + struct msgb *msg) +{ + switch (sign_link->type) { + case E1INP_SIGN_OML: + case E1INP_SIGN_RSL: + case E1INP_SIGN_OSMO: + break; + default: + msgb_free(msg); + return -EINVAL; + } + + msg->l2h = msg->data; + ipa_prepend_header(msg, sign_link->tei); + + LOGPITS(e1i_ts, DLMI, LOGL_DEBUG, "TX: %s\n", osmo_hexdump(msg->l2h, msgb_l2len(msg))); + osmo_stream_cli_send(cli, msg); + return 0; +} + +/* msg was enqueued in sign_link->tx_list. + * Pop it from that list, submit it to osmo_stream_cli: */ +static int ts_want_write(struct e1inp_ts *e1i_ts) +{ + int rc = 0; + struct osmo_stream_cli *cli = ipaccess_bts_e1i_ts_stream_cli(e1i_ts); + + /* get the next msg for this timeslot */ + while (e1i_ts_has_pending_tx_msgs(e1i_ts)) { + struct e1inp_sign_link *sign_link = NULL; + struct msgb *msg; + msg = e1inp_tx_ts(e1i_ts, &sign_link); + OSMO_ASSERT(msg); + OSMO_ASSERT(sign_link); + rc |= ipaccess_bts_send_msg(e1i_ts, sign_link, cli, msg); + } + return rc; +} + +int ipaccess_bts_handle_ccm(struct ipa_client_conn *link, + struct ipaccess_unit *dev, struct msgb *msg) +{ + struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; + + /* special handling for IPA CCM. */ + if (hh->proto != IPAC_PROTO_IPACCESS) + return 0; + + int ret = 0; + uint8_t *data = msgb_l2(msg); + int len = msgb_l2len(msg); + OSMO_ASSERT(len > 0); + uint8_t msg_type = *data; + /* line might not exist if != bsc||bts */ + + /* ping, pong and acknowledgment cases. */ + ret = ipa_ccm_rcvmsg_bts_base(msg, link->ofd); + if (ret < 0) + goto err; + + /* this is a request for identification from the BSC. */ + if (msg_type == IPAC_MSGT_ID_GET) { + struct msgb *rmsg; + /* The ipaccess_unit dev holds generic identity for the whole + * line, hence no trx_id. Patch ipaccess_unit during call to + * ipa_ccm_make_id_resp_from_req() to identify this TRX: */ + int store_trx_nr = dev->trx_id; + if (link->ofd->priv_nr >= E1INP_SIGN_RSL) + dev->trx_id = link->ofd->priv_nr - E1INP_SIGN_RSL; + else + dev->trx_id = 0; + LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", + dev->site_id, dev->bts_id, dev->trx_id); + rmsg = ipa_ccm_make_id_resp_from_req(dev, data + 1, len - 1); + dev->trx_id = store_trx_nr; + if (!rmsg) { + LOGP(DLINP, LOGL_ERROR, "Failed parsing ID_GET message.\n"); + goto err; + } + + ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len); + if (ret != rmsg->len) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP message. Reason: %s\n", + strerror(errno)); + msgb_free(rmsg); + goto err; + } + msgb_free(rmsg); + + /* send ID_ACK. */ + ret = ipa_ccm_send_id_ack(link->ofd->fd); + if (ret <= 0) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK message. Reason: %s\n", + strerror(errno)); + goto err; + } + } + return 1; + +err: + ipa_client_conn_close(link); + return -1; +} + +static struct msgb *ipa_bts_id_ack(void) +{ + struct msgb *nmsg2; + nmsg2 = ipa_msg_alloc(0); + if (!nmsg2) + return NULL; + msgb_v_put(nmsg2, IPAC_MSGT_ID_ACK); + ipa_prepend_header(nmsg2, IPAC_PROTO_IPACCESS); + return nmsg2; +} + +static void update_fd_settings(struct e1inp_line *line, int fd) +{ + int ret; + int val; + + val = 1; + ret = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &val, sizeof(val)); + if (ret < 0) + LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP_NODELAY: %s\n", strerror(errno)); +} + +/* Same as ipaccess_bts_handle_ccm(), but using an osmo_stream_cli as backend + * instead of ipa_client_conn. + * The old ipaccess_bts_handle_ccm() needs to be kept as it's a public API. */ +static int _ipaccess_bts_handle_ccm(struct osmo_stream_cli *cli, + struct ipaccess_unit *dev, struct msgb *msg) +{ + /* special handling for IPA CCM. */ + if (osmo_ipa_msgb_cb_proto(msg) != IPAC_PROTO_IPACCESS) + return 0; + + int ret = 0; + const uint8_t *data = msgb_l2(msg); + int len = msgb_l2len(msg); + OSMO_ASSERT(len > 0); + uint8_t msg_type = *data; + struct e1inp_ts *e1i_ts = osmo_stream_cli_get_data(cli); + /* line might not exist if != bsc||bts */ + + /* ping, pong and acknowledgment cases. */ + struct osmo_fd tmp_ofd = { .fd = osmo_stream_cli_get_fd(cli) }; + OSMO_ASSERT(tmp_ofd.fd >= 0); + ret = ipa_ccm_rcvmsg_bts_base(msg, &tmp_ofd); + if (ret < 0) + goto err; + + /* this is a request for identification from the BSC. */ + if (msg_type == IPAC_MSGT_ID_GET) { + struct msgb *rmsg; + /* The ipaccess_unit dev holds generic identity for the whole + * line, hence no trx_id. Patch ipaccess_unit during call to + * ipa_ccm_make_id_resp_from_req() to identify this TRX: */ + int store_trx_nr = dev->trx_id; + dev->trx_id = ipaccess_e1i_ts_trx_nr(e1i_ts); + LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", + dev->site_id, dev->bts_id, dev->trx_id); + rmsg = ipa_ccm_make_id_resp_from_req(dev, data + 1, len - 1); + dev->trx_id = store_trx_nr; + if (!rmsg) { + LOGP(DLINP, LOGL_ERROR, "Failed parsing ID_GET message.\n"); + goto err; + } + osmo_stream_cli_send(cli, rmsg); + + /* send ID_ACK. */ + rmsg = ipa_bts_id_ack(); + if (!rmsg) { + LOGP(DLINP, LOGL_ERROR, "Failed allocating ID_ACK message.\n"); + goto err; + } + osmo_stream_cli_send(cli, rmsg); + } + return 1; + +err: + return -1; +} + +static int ipaccess_bts_read_cb(struct osmo_stream_cli *cli, int res, struct msgb *msg) +{ + enum ipaccess_proto ipa_proto = osmo_ipa_msgb_cb_proto(msg); + struct e1inp_ts *e1i_ts = osmo_stream_cli_get_data(cli); + struct e1inp_line *line = e1i_ts->line; + struct e1inp_sign_link *sign_link; + int ret; + + if (res <= 0) { + LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, "failed reading from socket: %d\n", res); + goto err; + } + + /* special handling for IPA CCM. */ + if (ipa_proto == IPAC_PROTO_IPACCESS) { + uint8_t msg_type = *(msg->l2h); + /* this is a request for identification from the BSC. */ + if (msg_type == IPAC_MSGT_ID_GET) { + if (!line->ops->sign_link_up) { + LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, + "Unable to set signal link, closing socket.\n"); + goto err; + } + } + } + + /* core CCM handling */ + ret = _ipaccess_bts_handle_ccm(cli, line->ops->cfg.ipa.dev, msg); + if (ret < 0) + goto err; + + if (ret == 1 && ipa_proto == IPAC_PROTO_IPACCESS) { + uint8_t msg_type = *(msg->l2h); + if (msg_type == IPAC_MSGT_ID_GET) { + enum e1inp_sign_type sign_type = ipaccess_e1i_ts_sign_type(e1i_ts); + unsigned int trx_nr = ipaccess_e1i_ts_trx_nr(e1i_ts); + sign_link = line->ops->sign_link_up(line->ops->cfg.ipa.dev, + line, sign_type + trx_nr); + if (sign_link == NULL) { + LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, + "Unable to set signal link, closing socket.\n"); + goto err; + } + } + msgb_free(msg); + return ret; + } + + /* look up for some existing signaling link. */ + sign_link = e1inp_lookup_sign_link(e1i_ts, ipa_proto, 0); + if (sign_link == NULL) { + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "no matching signalling link for " + "ipa_proto=0x%02x\n", ipa_proto); + goto err; + } + msg->dst = sign_link; + + /* XXX better use e1inp_ts_rx? */ + if (!line->ops->sign_link) { + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "Fix your application, " + "no action set for signalling messages.\n"); + goto err; + } + return line->ops->sign_link(msg); + +err: + msgb_free(msg); + osmo_stream_cli_close(cli); + return -EBADF; +} + +static int ipaccess_bts_connect_cb(struct osmo_stream_cli *cli) +{ + struct e1inp_ts *e1i_ts = osmo_stream_cli_get_data(cli); + struct e1inp_line *line = e1i_ts->line; + struct msgb *rmsg; + + update_fd_settings(line, osmo_stream_cli_get_fd(cli)); + + /* send ID_ACK. */ + rmsg = ipa_bts_id_ack(); + if (!rmsg) { + LOGP(DLINP, LOGL_ERROR, "Failed allocating ID_ACK message.\n"); + return 0; + } + osmo_stream_cli_send(cli, rmsg); + return 0; +} + +static int ipaccess_bts_disconnect_cb(struct osmo_stream_cli *cli) +{ + _ipaccess_bts_down_cb(cli); + return 0; +} + +static int ipaccess_line_update(struct e1inp_line *line) +{ + int ret = -ENOENT; + struct ipaccess_line *il; + + if (!line->driver_data) + line->driver_data = talloc_zero(line, struct ipaccess_line); + + if (!line->driver_data) { + LOGPIL(line, DLINP, LOGL_ERROR, "ipaccess: OOM in line update\n"); + return -ENOMEM; + } + il = line->driver_data; + + /* We only initialize this line once. */ + if (il->line_already_initialized) + return 0; + + struct osmo_stream_cli *cli; + struct e1inp_ts *e1i_ts = e1inp_line_ipa_oml_ts(line); + char cli_name[128]; + + LOGPITS(e1i_ts, DLINP, LOGL_NOTICE, "enabling ipaccess BTS mode, " + "OML connecting to %s:%u\n", g_e1inp_ipaccess_config_pars.connect_addr, IPACCESS_BTS_LISTEN_OML_PORT); + + /* Drop previous line */ + if (il->ipa_cli[0]) { + osmo_stream_cli_close(il->ipa_cli[0]); + e1i_ts->driver.ipaccess.fd.fd = -1; + osmo_stream_cli_destroy(il->ipa_cli[0]); + il->ipa_cli[0] = NULL; + } + + e1inp_ts_config_sign(e1i_ts, line); + + cli = osmo_stream_cli_create(tall_ipa_ctx); + OSMO_ASSERT(cli); + + snprintf(cli_name, sizeof(cli_name), "ts-%u-%u-oml", line->num, e1i_ts->num); + osmo_stream_cli_set_name(cli, cli_name); + osmo_stream_cli_set_data(cli, e1i_ts); + osmo_stream_cli_set_addr(cli, g_e1inp_ipaccess_config_pars.connect_addr); + osmo_stream_cli_set_port(cli, IPACCESS_BTS_LISTEN_OML_PORT); + osmo_stream_cli_set_proto(cli, IPPROTO_TCP); + osmo_stream_cli_set_nodelay(cli, true); + osmo_stream_cli_set_priority(cli, g_e1inp_ipaccess_config_pars.oml.dscp); + osmo_stream_cli_set_ip_dscp(cli, g_e1inp_ipaccess_config_pars.oml.priority); + + /* Reconnect is handled by upper layers: */ + osmo_stream_cli_set_reconnect_timeout(cli, -1); + + osmo_stream_cli_set_segmentation_cb(cli, osmo_ipa_segmentation_cb); + osmo_stream_cli_set_connect_cb(cli, ipaccess_bts_connect_cb); + osmo_stream_cli_set_disconnect_cb(cli, ipaccess_bts_disconnect_cb); + osmo_stream_cli_set_read_cb2(cli, ipaccess_bts_read_cb); + + if (osmo_stream_cli_open(cli)) { + LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "cannot open OML BTS link: %s\n", strerror(errno)); + osmo_stream_cli_destroy(cli); + return -EIO; + } + + /* Compatibility with older ofd based implementation. osmo-bts accesses + * this fd directly in get_signlink_remote_ip() and get_rsl_local_ip() */ + e1i_ts->driver.ipaccess.fd.fd = osmo_stream_cli_get_fd(cli); + + il->ipa_cli[0] = cli; + ret = 0; + + il->line_already_initialized = true; + return ret; +} + +static struct e1inp_driver ipaccess_config_driver = { + .name = "ipaccess-config", + .want_write = ts_want_write, + .line_update = ipaccess_line_update, + .close = ipaccess_close, + .default_delay = 0, + .has_keepalive = 0, +}; + +void e1inp_ipaccess_config_init(void *ctx) +{ + tall_ipa_ctx = talloc_named_const(ctx, 1, "ipaccess-config"); + e1inp_driver_register(&ipaccess_config_driver); + + g_e1inp_ipaccess_config_pars.connect_addr = talloc_strdup(tall_ipa_ctx, "127.0.0.1"); +} + +void e1inp_ipaccess_config_set_connect_addr(const char *connect_addr) +{ + osmo_talloc_replace_string(tall_ipa_ctx, + &g_e1inp_ipaccess_config_pars.connect_addr, + connect_addr); +} diff --git a/src/ipaccess/ipaccess-config.c b/src/ipaccess/ipaccess-config.c index 15dcc54..a576ebc 100644 --- a/src/ipaccess/ipaccess-config.c +++ b/src/ipaccess/ipaccess-config.c @@ -79,53 +79,15 @@ static struct abis_nm_sw_desc *sw_load1 = NULL; static struct abis_nm_sw_desc *sw_load2 = NULL; -extern int ipaccess_fd_cb(struct osmo_fd *bfd, unsigned int what); extern struct e1inp_line_ops ipaccess_e1inp_line_ops; -/* Actively connect to a BTS. Currently used by ipaccess-config.c */ -static int ipaccess_connect(struct e1inp_line *line, struct sockaddr_in *sa) -{ - struct e1inp_ts *e1i_ts = &line->ts[0]; - struct osmo_fd *bfd = &e1i_ts->driver.ipaccess.fd; - int ret, on = 1; +/* Functions from ipaccess-config-e1-driver.c: */ +extern void e1inp_ipaccess_config_init(void *ctx); +extern void e1inp_ipaccess_config_set_connect_addr(const char *connect_addr); - bfd->fd = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP); - bfd->cb = ipaccess_fd_cb; - bfd->when = OSMO_FD_READ | OSMO_FD_WRITE; - bfd->data = line; - bfd->priv_nr = E1INP_SIGN_OML; - - if (bfd->fd < 0) { - LOGP(DLINP, LOGL_ERROR, "could not create TCP socket.\n"); - return -EIO; - } - - ret = setsockopt(bfd->fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)); - if (ret < 0) { - LOGP(DLINP, LOGL_ERROR, "could not set socket option\n"); - close(bfd->fd); - return -EIO; - } - - ret = connect(bfd->fd, (struct sockaddr *) sa, sizeof(*sa)); - if (ret < 0) { - LOGP(DLINP, LOGL_ERROR, "could not connect socket\n"); - close(bfd->fd); - return ret; - } - - ret = osmo_fd_register(bfd); - if (ret < 0) { - LOGP(DLINP, LOGL_ERROR, "unable to register socket fd\n"); - close(bfd->fd); - return ret; - } - return ret; - //return e1inp_line_register(line); -} /* configure pseudo E1 line in ip.access style and connect to BTS */ -static int ia_config_connect(struct gsm_bts *bts, struct sockaddr_in *sin) +static int ia_config_connect(struct gsm_bts *bts, const char *bts_ip) { struct e1inp_line *line; struct e1inp_ts *sign_ts, *rsl_ts; @@ -135,13 +97,17 @@ if (!line) return -ENOMEM; - line->driver = e1inp_driver_find("ipa"); - if (!line->driver) { - fprintf(stderr, "cannot `ipa' driver, giving up.\n"); + e1inp_ipaccess_config_init(tall_bsc_ctx); + e1inp_ipaccess_config_set_connect_addr(bts_ip); + + line = e1inp_line_create(0, "ipaccess-config"); + if (!line) { + fprintf(stderr, "cannot create line with `ipaccess-config' driver, giving up.\n"); return -EINVAL; } e1inp_line_bind_ops(line, &ipaccess_e1inp_line_ops); e1_set_pcap_fd2(line, -1); /* Disable writing to pcap */ + e1inp_line_update(line); sign_ts = e1inp_line_ipa_oml_ts(line); rsl_ts = e1inp_line_ipa_rsl_ts(line, 0); @@ -164,11 +130,7 @@ bts->osmo_link = osmo_link; bts->c0->rsl_link_primary = rsl_link; - /* default port at BTS for incoming connections is 3006 */ - if (sin->sin_port == 0) - sin->sin_port = htons(3006); - - return ipaccess_connect(line, sin); + return 0; } /* @@ -1030,7 +992,6 @@ int main(int argc, char **argv) { struct gsm_bts *bts; - struct sockaddr_in sin; char *bts_ip; int rc, option_index = 0, stream_id = 0xff; @@ -1203,17 +1164,12 @@ if (!quiet) printf("Trying to connect to ip.access BTS %s...\n", bts_ip); - memset(&sin, 0, sizeof(sin)); - sin.sin_family = AF_INET; - inet_aton(bts_ip, &sin.sin_addr); - rc = ia_config_connect(bts, &sin); + rc = ia_config_connect(bts, bts_ip); if (rc < 0) { perror("Error connecting to the BTS"); exit(1); } - bts->oml_link->ts->sign.delay = 10; - bts->c0->rsl_link_primary->ts->sign.delay = 10; while (1) { rc = osmo_select_main(0); if (rc < 0) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I4d26876ce7d75a78f03c4fa66233550baf4fa7d5 Gerrit-Change-Number: 39050 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-gprs[master]: gitignore: remove debian section

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39046?usp=email ) Change subject: gitignore: remove debian section ...................................................................... gitignore: remove debian section Having 'debian/libosmo-gprs-llc*' and similar in gitignore leads to unexpected behavior when making releases: * When bumping libversion, we need to rename related install files, e.g.: debian/libosmo-gprs-llc0.install -> debian/libosmo-gprs-llc1.install * "git add -A" will not add the new files, instead they just show up as deleted * this is easy to miss among the other changes, and it leads to a potentially confusing build error: dpkg-shlibdeps: error: cannot find library libosmo-gprs-llc.so.1 needed by debian/libosmo-gprs-gmm1/usr/lib/x86_64-linux-gnu/libosmo-gprs-gmm.so.1.0.0 (ELF format: 'elf64-x86-64' abi: '0201003e00000000'; RPATH: '') Remove the entire debian dir from gitignore, it is not worth having it in there. Change-Id: I508242eef770c6fa467f5371587491147e9fc5eb --- M .gitignore 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/.gitignore b/.gitignore index ee800c0..020b541 100644 --- a/.gitignore +++ b/.gitignore @@ -31,15 +31,6 @@ ltmain.sh m4/*.m4 -# debian build products -debian/libosmo-gprs-rlcmac* -debian/libosmo-gprs-llc* -debian/libosmo-csn1* -debian/autoreconf.* -debian/.debhelper -debian/files -debian/tmp - # testsuite tests/atconfig tests/package.m4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I508242eef770c6fa467f5371587491147e9fc5eb Gerrit-Change-Number: 39046 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[L] Change in libosmo-gprs[master]: Bump version: 0.1.0 → 0.2.0

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39039?usp=email ) Change subject: Bump version: 0.1.0 → 0.2.0 ...................................................................... Bump version: 0.1.0 → 0.2.0 Change-Id: I5acd9c05030e13df79833f280af72f14b4eb04ec --- M TODO-RELEASE M configure.ac M debian/changelog M debian/control R debian/libosmo-csn1-1.install R debian/libosmo-gprs-gmm1.install R debian/libosmo-gprs-llc1.install R debian/libosmo-gprs-rlcmac1.install R debian/libosmo-gprs-sm1.install R debian/libosmo-gprs-sndcp1.install M src/csn1/Makefile.am M src/gmm/Makefile.am M src/llc/Makefile.am M src/rlcmac/Makefile.am M src/sm/Makefile.am M src/sndcp/Makefile.am 16 files changed, 399 insertions(+), 29 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index 60f6474..71f9726 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,6 +7,5 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore >1.8.0 gsm_fn2rfn(), gsm_rfn2fn() libosmocore >1.10.0 enum gsm48_gprs_ie_mm: GSM48_IE_GMM_UE_NET_CAP, GSM48_IE_GMM_VD_PREF_UE_USAGE libosmocore >1.10.0 remove "Remove after depending on libosmocore > 1.10.0" code in gmm_pdu.c diff --git a/configure.ac b/configure.ac index cb212cd..cb10e57 100644 --- a/configure.ac +++ b/configure.ac @@ -36,8 +36,8 @@ PKG_PROG_PKG_CONFIG([0.20]) dnl checks for libraries -PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.7.0) -PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.7.0) +PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.10.0) +PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.10.0) dnl checks for header files AC_HEADER_STDC diff --git a/debian/changelog b/debian/changelog index e16789e..79ca518 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,4 +1,375 @@ -libosmo-gprs (0.1.0) UNRELEASED; urgency=low +libosmo-gprs (0.2.0) unstable; urgency=medium + + [ Vadim Yanitskiy ] + * debian/control: fix missing/misplaced commas in dependencies + * debian/compat: bump debhelper compatibility level: 9 -> 10 + * update git URLs (git -> https; gitea) + * tests/rlcmac: fix incorrect RLCMACTest.{ok,err} paths in EXTRA_DIST + * tests/testsuite.at: remove $OSMO_QEMU, it's not used + * debian: clarify license/copyright for CSN.1 codec by ST-Ericsson + * configure.ac: do require unused dlopen + * configure: generate libosmo-gprs.spec from libosmo-gprs.spec.in + * contrib/libosmo-gprs.spec.in: properly define RPM packages + * csn1: #include <stddef.h> in csn1.h for offsetof() + * csn1: cosmetic: coding style improvements for #defines + * csn1: add CSN_DESCR_EXTERN for extern declarations + * rlcmac: fix using incomplete type 'struct value_string' + * Add .checkpatch.conf with project specific linter config + * libosmo-{csn1,gprs-rlcmac}.pc.in: add missing Requires + * rlcmac: make logging category configurable + * rlcmac: split gprs_rlcmac.c onto ts_44_{060,018}.c + * rlcmac: split ts_24_008.c out of ts_44_060.c + * rlcmac: add osmo_gprs_rlcmac_decode_si13ro() + * rlcmac/ts_44_018: add missing M_PADDING_BITS to SI_13_t + * Initial libosmo-gprs-llc library skeleton + * llc: check-in basic LLC definitions from osmo-sgsn.git + * llc: ensure all symbols have 'osmo_gprs_llc_' prefix + * llc: enum osmo_gprs_llc_sapi: fix spec reference + * llc: enum osmo_gprs_llc_primitive: drop Req/Ind/Rsp/Cnf + * llc: add missing LLGMM primitive types + * llc: add missing LLE <-> (RLC/MAC,BSSGP) primitives + * llc: add definitions from 3GPP TS 44.064 section 6.4 + * llc: import FCS (CRC24) calculation API from osmo-sgsn.git + * llc: add -export-symbols-regex '^osmo_' to CFLAGS + * llc: implement LLC PDU codec based on code from osmo-sgsn.git + * llc: re-define value-string API as static inline functions + * llc: add struct value_string osmo_gprs_llc_sapi_names[] + * llc: osmo_gprs_llc_hdr_dump[_buf](): also print SAPI name + * tests: reorganize llc/rlcmac specific dirs and files + * llc: separate enum osmo_gprs_llc_primitive to llc_prim.h + * llc: rename enum osmo_gprs_llc_{primitive->prim_type} + * llc: add definitions of service primitive parameters + * llc: make logging category configurable + * .gitignore: add missing debian/libosmo-gprs-llc* + * llc: fix warning: 'struct msgb' declared inside parameter list + * llc: add value-string for enum osmo_gprs_llc_xid_type + * llc: add missing enum osmo_gprs_llc_xid_type values + * llc: implement Exchange Identification (XID) codec + * tests/llc/pdu_codec_test: use const char * const + * tests/rlcmac/ts_44_018_test: do not depend on libosmogsm + * contrib/jenkins.sh: build with --enable-werror + * Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition + * rlcmac: add decoder and test vectors for IA Rest Octets + * rlcmac: fix coding of EGPRS Packet Uplink Assignment in IA RestOctets + * rlcmac: rename s/IA_EGPRS_00_t/IA_EGPRS_PktUlAss_t/ + * rlcmac: implement the missing IA_MultiBlock_PktDlAss_t + * rlcmac: remove unneeded includes + * rlcmac: use OSMO_ASSERT instead of plain assert() + * rlcmac: rename s/SI_13_t/SI13_RestOctets_t/ + * tests/rlcmac: make linter happy: use const char * const + * rlcmac/sched: use TDMA Fn macros from libosmogsm + * rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK + * {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS + * tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS + * tests/llc: local libs must be first in *_LDADD + * rlcmac: cosmetic: use ARRAY_SIZE() in dl_tbf_dl_slotmask() + * rlcmac: cosmetic: use ARRAY_SIZE() in handle_pkt_dl_ass() + * rlcmac: fix handling of TIMESLOT_ALLOCATION in handle_pkt_dl_ass() + * rlcmac: do not attempt to decode PTCCH/D blocks, discard them + * rlcmac: fix wrong MSGT_PACKET_{RESOURCE_REQUEST->DOWNLINK_ACK_NACK} + * rlcmac: fix st_new_on_enter(): actually release the TBF + * rlcmac: fix typo in TBF CFG logging messages + * rlcmac: cfg_ul_tbf_req: indicate USF for each active timeslot + * copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH + * rlcmac: add OSMO_GPRS_RLCMAC_L1CTL_PDCH_{ESTABLISH,RELEASE}.req + * doc: add PDCH timing diagram illustrating UL/DL delay + * README.md: upade the list of libraries + * rlcmac: l1ctl_prim: add 'start_rfn' field to cfg_{ul,dl}_tbf_req + * rlcmac: deal with RACH retransmissions (drop rach_req_ra) + * rlcmac: migrate from fn_cmp() to gsm0502_fncmp() + * sm_ms_fsm: fix double timer_cb assignment + * llc: fix unsigned rc in gprs_llc_lle_tx_xid_resp() + * llc: fix l3par check in gprs_llc_lle_generate_xid() + * build: include README.md into the release tarball + * rlcmac: add definition for OSMO_GPRS_RLCMAC_L1CTL_PDCH_DATA | Cnf + * rlcmac: refactor gprs_rlcmac_rlc_ul_window_move_window() + + [ Pau Espin Pedrol ] + * llc: fix typo: OSMO_GPRS_LLC_SAPI_SNDCP{12->11} + * llc: libosmo-gprs-llc.pc.in: add 'Requires.private: talloc' + * llc: add libosmogsm dependency + * llc: add enum osmo_gprs_llc_{location,prim_sap} + * llc: split up enum osmo_gprs_llc_prim_type + * llc: rework logging, add LOGLLC macro + * llc: Proper separation of public & private APIs, Introduce llc_prim API + * llc: Initialize gprs_cipher + * osmo_gprs_llc_bssgp_prim: cell_id is always RAI + CI + * sndcp: Initial libosmo-gprs-sndcp support + * tests/llc: Test gprs_llc_is_retransmit() + * sndcp: Fix wrong field used printing nsapi + * sndcp: Fix wrong prim op passed in osmo_gprs_sndcp_prim_alloc_sn_xid_rsp() + * sndcp: Initial support for async SN-XID.ind and SN-XID.rsp + * llc: Log error loading gprs chiper plugins + * llc: Allow app provided callbacks to retain ownership of passed primitive + * sndcp: Fix missing dep link against libmath + * llc: Initial support for GRR-UNITDATA.ind/req + * llc: Fix spec references pointing to SNDCP instead of LLC + * rlcmac: Support extending log categories in the future + * rlcmac: Introduce primitives for SAPs towards higher layers + * rlcmac: Enqueue LLC PDUs based on RadioPriority and SAPI + * rlcmac: Rename gprs_rlcmac.h -> csn1_defs.h + * rlcmac: Rename ts_*.c -> csn1_ts_*.c + * rlcmac: Move spec related definitions for general use to types.h + * rlcmac: Refactor msg_type enums and value_string + * rlcmac: Fix prim memleak passing GRR-UNITDATA.req + * rlcmac: llc_queue: Make sure queue is cleared before freeing mem + * sndcp: Add missing osmocom/core/endian.h include + * rlcmac: Introduce lower primitive layer API + * rlcmac: Initial implementation of UL TBF assignment and scheduler + * rlcmac: Make sure entities are freed if lib is re-initialized + * rlcmac: Initial ul_tbf data support + * rlcmac: Implement GMMRR-ASSIGN.req + * rlcmac: Introduce DL TBF creation through PCH ImmAss + * rlcmac: Implement initial DL rx data path + * rlcmac: Introduce initial poll answer infrastructure + * rlcmac: Implement Tx of DL ACK/NACK + * rlcmac: llc_queue: Fix access to null msgb during dequeue + * rlcmac: tests: Validate Tx of second RLC/MAC block containing GMM Attach + * rlcmac: Implement Rx of UL ACK/NACK + * rlcmac: tbf_ul: Fix wrong function called looking up msg size + * rlcmac: tbf_*: Unlink the freeing tbf from its gre + * rlcmac: Implement T3164 + * rlcmac: Implement T3166 + * rlcmac: Handle SI13 from L1CTL + * rlcmac: tbf_ul: Allow sending UL data if in state FINISHED + * rlcmac: Implement N3104 + * rlcmac: ul_tbf: Append TLLI when in contention resolution + * rlcmac: ul_tbf: Answer Pkt Ul Ack/Nack poll with Pkt Ctrl Ack + * rlcmac: tbf_dl: Fix msgb null ptr access if dl block contains several LLC frames + * rlcmac: Fix null ptr access in dl_tbf object + * rlcmac: Implement T3168 (Pkt Res Req timeout 2phase access) + * rlcmac: ul_tbf: Submit event FIST_UL_DATA_SENT before LAST_UL_DATA_SENT + * rlcmac: ul_tbf: Fail if data block CV=0 retransmitted > 4 times + * rlcmac: Use finished UL TBF to request a new one after Final UL ACK/NACK + * rlcmac: ul_tbf: Fix ul_state wrong check + * rlcmac: ul_tbf_fsm: rework Rx UL ACK/NACK fsm events + * rlcmac: Implement T3182 + * tbf_dl: Fix state_fsm instance not freed + * rlcmac: Fill radio_priority in Dl Ack/Nack Channel Request Description + * rlcmac: Fix gprs_rlcmac_ul_tbf_in_contention_resolution() for 1phase access + * rlcmac: tbf_ul: Fix TI bit never set when encoding the block + * tbf_ul: Fix contention_resolution check for 2phase access + * rlcmac: dl_tbf: Improve logic requesting a new UL TBF + * rlcmac: tbf_ul_ass_fsm: Drop dummy event GPRS_RLCMAC_TBF_UL_ASS_EV_FOOBAR + * rlcmac: Fix several ptr bugs looking up ul tbf upon rx PktUlAss + * rlcmac: Ignore DATA.ind with len=0 + * rlcmac: Lower logging rx prim from lower layers + * rlcmac: ul_tbf: Implement support for TBF Starting Time + * rlcmac: rlcmac_dec.c: Add missing headers + * rlcmac: Log tx of primitive to lower layers + * rlcmac: gprs_rlcmac_prim_call_down/up_cb(): Avoid propagating rc=1 + * rlcmac: Move create_pkt_ctrl_ack() to tbf base class + * rlcmac: Log sched of PktCtrlAck requested by UL ASS poll + * rlcmac: Implement DL TBF CCCH & PACCH allocation with TBF Starting Time + * llc: Avoid propagating rc=1 + * sndcp: Avoid propagating rc=1 + * rlcmac: tbf_ul_ass_fsm: Fix missing break statement + * Create skeleton for libosmo-gprs-gmm + * rlcmac: Release pending polls in pdch_ul when freeing tbf + * gmm: Initial implementation of GPRS Attach + * gmm: Initial implementation of GPRS Detach + * rlcmac: Fix DL_ASS polls removed when UL TBF released + * rlcmac: gprs_rlcmac_tbf_free():Call proper free function for DL TBF + * rlcmac: Release UL_TBF L1CTL resources upon free + * gmm: Several fixes to GMMSM prim alloc functions + * gmm: Free ms_fsm when freeing gmme + * gmm: Free allocated GMMEs when freeing main context + * llc: Free allocated LLMEs when freeing main context + * Introduce libosmo-gprs-sm + * Fix typo LLGM -> LLGMM + * gmm: Implement T3310 (Tattach) + * gmm: Implement rx Attach Reject + * Rename internal g_ctx -> g_{layer_name}_ctx + * sm: Fix typo in LOGMS macro + * sndcp: Fix potential null ptr access if SNE not found + * tests/sndcp: Fix incorrect check comparing against wrong SAPI + * sndcp: Allocate snme->comp.{data,proto} during snme alloc + * llc: Implement some parts of LL-ESTABLISH.req/cnf + * sm: Fix swapped endianness in struct gprs_sm_pdp_addr + * sm: Start using SNSM SAP + * sndcp: Test MS vs NET paths separately and implement missing prims for MS + * sm: Parse PDP address in rx PDP Ctx Accept + * sm: Handle radio_prio,qos,llc_sapi in rx PDP Ctx Accept + * sm: Handle PCO in rx PDP Ctx Accept + * gmm: Fix typo triggering assert on T3310 timeout + * gmm: Allow cb callers to take ownsership of msgb primitive + * sm: Destroy PDP Context if activation fails + * sm: Fix potential null access due to missing check + * sm: Fill gmmsm.establish_req.attach_with_imsi + * gmm: Append 'P-TMSI type' IE to GPRS Attach Req when needed + * gmm: Provide allocated P-TMSI in GMMREG-ATTACH.cnf + * gmm, rlcmac: Properly handle P-TMSI vs TLLI + * gmm: Print IMSI and TLLI in LOGGMME macro + * gmm: Increase log level of Rx msg log lines + * gmm: Introduce SIM_AUTH primitive to resolve authentication + * llc: Log received wrong FCS field + * llc: Fix N(U) wrongly reset during LLGM-ASSIGN.req + * gmm: Switch state before announcing events to user + * gmm: Directly confirm GMMSM-Establish.req if already attached + * gmm: Fix typo in param name passed to logging macro + * gmm: Rework sess_id to identify one GMME + * gmm: Implement GMMSM-UNITDATA.ind + * sm: Fix encoding of dynamic IP address in PDPActCtxReq + * sm: Implement rx Act PDP Ctx Rej + * sm: Avoid freeing the SME object too quickly + * llc: use GRR instead of BSSGP to tx XID.req in MS mode + * sndcp: Allow cb users taking ownership of primitives + * sndcp: Initiate LL-XID.req only if we have something to send at L3 + * sm: Fix pdp_act_cnf.accepted flag value swapped + * gmm: Fix false positive compilation error with gcc 13.1.1 + * tests/gmm: Avoid printing rej_cause if GMMSM-Establish.cnf outcome is accepted + * gmm: Provide allocated PTMSI & TLLI to upper layers + * sm: Use & forward to upper layers the PTMSI & TLLI received from GMM + * grr,bssgp,llc,sndcp: Define qos_params + * sm: Fix APN IE content not transmitted in Act PDP Ctx Req + * gmm: Allow passing old RAI during attach + * sm: Allow passing old RAI during attach + * gmm: Provide RAI obtained from network + * sm: Provide RAI obtained from network + * rlcmac: Fix TFI not assigned during UL TBF CCCH ImmAss + * gmm: Forward forth and back the P-TMSI signature + * sm: Forward forth and back the P-TMSI signature + * gmmrr: Add new LLC_TRANSMITTED.ind + * gmm: Introduce APIs & unit test to enc/dec GPRS Timer IE + * gmm: Initial implementation of READY timer + * gmm: Initial implementation of T3312 + * llc: Add APIs to submit LLGM-trigger/suspend/resume.req primitives + * gmm: Implement periodic RAU procedure + * rlcmac: Add APIs to decode P1/P2 Rest Octets + * Fix typo llgm -> llgmm everywhere + * llc: Implement LLGM-TRIGGER.req + * gmm: Implement GMMR-PAGE.ind + * gmm: Provide rlcmac with IMSI & PTMSI information + * rlcmac: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2 + * gmm: Implement P-TMSI Reallocation Cmd/Compl + * gmm: Stop READY timer upon receiving force_stdby IE + * rlcmac: P1,P2 Rest Octets: Add missing final padding to definitions + * gmm: Implement submitting GMMSM-RELEASE.ind when MS becomes detached + * gmm: Implement rx GMM STATUS msg + * gmm: Initial implementation of rx GMM Information msg + * gmm: Rename s/ciph_auth/auth_ciph/ + * gmm: Tx Auth & Ciph Failure + * gmm: Initial implementation of T3166, rx Auth & Ciph Reject + * gmm: Fix typo checking IE presence in Rx Attach Rej + * gmm: Implement rx RAU Reject + * rlcmac: Avoid generating UL data if no data to be sent available + * sm: Handle GMMSM-Release.ind + * gmm: Avoid submitting GMMSM-Release.ind if no session was requested + * rlcmac: Implement UL TBF Countdown procedure + * rlcmac: tbf_ul: Handle SBA from CCCH Imm Ass + * rlcmac: Submit UL block to lower layers before freeing TBF + * rlcmac: BS_CV_MAX=0 should be interpreted as =1 when calculating N3104_MAX + * rlcmac: tbf_fsl_fsm: Expect ev LAST_DL_DATA_RECVD in state FINISHED + * rlcmac: tbf_dl: Fix typo in event name + * rlcmac: Rework tbf destructor to signal free() to its gre object + * rlcmac: tbf_ul: Move to packet-idle state when T3164 triggers + * rlcmac: defer going to pkt_idle_timer after freeing TBF + * rlcmac: tbf_dl: Implement T3190 + * rlcmac: tbf_dl: Implement T3192 + * gmm: Accept event LOW_LVL_FAIL in RAU/SR_INITIATED states + * cosmetic: gmm: fix spec reference format + * cosmetic: gmm: Fix typo in comment + * rlcmac: Introduce L1CTL-CCCH_READY.ind primitive + * gmm: Make OSMO_GPRS_GMM_TLLI_UNASSIGNED def publicly available + * gmm: Store received PDP Ctx Status and List of Receive N-PDU Numbers + * gmm: Fix typos in test + * gmm: Document spec ref regarding Receive N-PDU Numbers IE in RAU Compl + * gmm: Introduce GMMSM-Modify.ind primitive + * sm: Handle GMMSM-MODIFY.ind primitive + * sndcp: Answer SNSM-DEACTIVATE.ind with .resp + * llc: Introduce LL-ASSIGN.ind + * sndcp: Handle LL-ASSIGN.ind + * rlcmac: tbf_ul: Free TBF if submitting RACH.req fails + * rlcmac: Fix null ptr dereference + * rlcmac: Fix LOGPTBFDL macro log category + * rlcmac: Log SSN and FINAL_ACK when preparing PKT DL ACK/NACK msg + * rlcmac: rlc_window_dl: Fix RBB generation + * rlcmac: Mark received BSNs falling out of the V(N)/RBB when V(R) is raised + * rlcmac: Log LLC PDUs enqueued in llc_queue + * rlcmac: ul_tbf: Move logic selecting proper queue to helper function + * rlcmac: Avoid discard packets when in Countdown procedure + * rlcmac: Apply tx_cs requested by the network through PKT UL ACK/NACK + * rlcmac: recalculate CV as needed when already in Countdown procedure + * llc: xid: Introduce some helper internal functions to make code easier to follow + * llc: Introduce function to log XID fields and use upon Rx/Tx + * llc: Apply N201-I & N201-U requested by the network + * llc: Submit LL-XID-IND to L3 if N201-U or N201-I changes + * sndcp: Update n201_u & n201_i indicatd by LLC layer + * llc: Set proper SAPI when transmitting UNITDATA.req to GRR/BSSGP + * sndcp: Initialize N201-U & N201-I to default settings + * cosmetic: sm: Fix wrong reference in comment + * sm: Forward RadioPrio & QoS in SNSM-Activate.ind + * sndcp: Use radio_prio assigned by SM when submitting LLC unitdata.req + * llc: Set proper Radio Priority when submitting GRR-UNITDATA.req + * sm: Introduce APIs to enc/dec QoS Profile + * sndcp: Forward QoS params from SM to LLC + * rlcmac: Use enum gprs_rlcmac_radio_priority internally everywhere + * rlcmac: Initial selection of packet-access-procedure mode based on originating cause + * llc: Fix potential null ptr dereference in LL-Xid.Ind + * gmm: Several fixes for radio_prio + * rlcmac: Fix OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED declared in wrong offset + * rlcmac: keep looking up GRE based on old TLLI + * llc: Log rx PDUs with invalid FCS + * llc: Silently discard UI Dummy commands + * rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI + * llc,sndcp: Add missing hex prefix to log line printing TLLI + * rlcmac: Fix Starting Time rfn->fn calculation + * rlcmac: ul_tbf: Factor out function configuring TBF to lower layers + * rlcmac: ul_tbf: Implement TBF_Starting time (phase1) + * tbf_ul_ass: Don't check USF during SingleBlock Allocation + * rlcmac: Move FN related helper functions to private header inside libosmo-gprs + * rlcmac: Several fixes and improvements to have 2phase access working + * tbf_ul_ass_fsm: Listen only on 1 TS for PKT UL ASS when assignment done from DL TBF + * rlcmac: Log RTS.ind + * rlcmac: tbf_dl: Log with FN request of UL TBF through PKT DL ACK/NACK + * rlcmac: Fix compilation error 'rlcmac_prim may be used uninitialized' + * rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) + * rlcmac: tbf_ul_ass_fsm: Fix state not reset after first UL-TBF re-assignment + * rlcmac: tbf_ul_ass_fsm: Fix 'sba' field wrongly reset to true + * rlcmac: tbf_ul_ass_fsm: Fix logic delay starting time + * tbf_ul_fsm: Avoid freeing tbf after 4 CV=0 retrans in acknowledged mode + * rlcmac: Avoid re-arming T3182 in TBF Acknowledged mode + * rlcmac: tests: Account for T3180 existance in test_ul_tbf_t3182_timeout + * rlcmac: tests: Account for T3180 existance in test_ul_tbf_t3166_timeout + * rlcmac: ul_tbf: Implement T3180 + * cosmetic: tbf_ul_fsm: add missing state to tdef_state_timeout array + * rlcmac: Add new structure to allow passing FN+TN to TBF handling functions + * rlcmac: ul_tbf: Register UL ACK/NACK poll inside FSM + * Delay deleting UL TBF until last Pkt Ctrl Ack is fully transmitted + * rlcmac: Implement RLC_OCTET_COUNT in DL ACK/NACK + * rlcmac: tbf_ul: Fix wrong parenthesis around macro + * tests: rlcmac: Reproduce bug encoding 2 llc frames in 1 rlc block + * rlcmac: Fix Last RLC block (CV=0) not encoding >1 LLC frames + * tbf_ul: Clean and assert code path generating new UL data block + * gmm: Introduce interface GMMBSSGP + * gmm: Rename gmm_prim_test -> gmm_prim_ms_test + * tests/gmm: Introduce skeleton for gmm_prim_network tests + * llc: Mark old/current tlli as all 1's when unassigning LLME + * gmm: gprs_gmm_att_tlvdef: Sort based on enum gsm48_gprs_ie_mm order + * gmm: gprs_gmm_att_tlvdef: Add missing definitions from current enum gsm48_gprs_ie_mm + * gmm: gprs_gmm_att_tlvdef: Add newer definitions from current enum gsm48_gprs_ie_mm + + [ Max ] + * Debian: fix broken SNDCP install + + [ Oliver Smith ] + * Run struct_endianness.py + * debian: set compat level to 10 + * contrib: remove rpm spec file + * debian/control: add missing deps to -dev pkgs + * libosmo-gprs-*.pc.in: add libtalloc-dev + * Make compatible with libosmocore >= 9.0.0 + + [ Eric Wild ] + * configure.ac: fix libtool issue with clang and sanitizer + + [ Harald Welte ] + * Add funding link to github mirror + * README.md: Improve formatting + + -- Oliver Smith <osmith(a)sysmocom.de> Thu, 05 Dec 2024 13:17:34 +0100 + +libosmo-gprs (0.1.0) unstable; urgency=low Create new Debian package. diff --git a/debian/control b/debian/control index 9e05d2d..e0e80bc 100644 --- a/debian/control +++ b/debian/control @@ -9,13 +9,13 @@ automake, libtool, git, - libosmocore-dev (>= 1.7.0) + libosmocore-dev (>= 1.10.0) Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/osmocom/libosmo-gprs Vcs-Browser: https://gitea.osmocom.org/osmocom/libosmo-gprs Homepage: https://projects.osmocom.org/projects/libosmo-gprs -Package: libosmo-csn1-0 +Package: libosmo-csn1-1 Section: libs Architecture: any Multi-Arch: same @@ -31,7 +31,7 @@ Architecture: any Section: debug Multi-Arch: same -Depends: libosmo-csn1-0 (= ${binary:Version}), +Depends: libosmo-csn1-1 (= ${binary:Version}), ${misc:Depends} Description: Debug symbols for the Osmocom CSN.1 codec library @@ -39,12 +39,12 @@ Architecture: any Multi-Arch: same Section: libdevel -Depends: libosmo-csn1-0 (= ${binary:Version}), +Depends: libosmo-csn1-1 (= ${binary:Version}), libosmocore-dev, ${misc:Depends} Description: Development headers and libraries for the Osmocom CSN.1 codec -Package: libosmo-gprs-gmm0 +Package: libosmo-gprs-gmm1 Section: libs Architecture: any Multi-Arch: same @@ -57,7 +57,7 @@ Architecture: any Section: debug Multi-Arch: same -Depends: libosmo-gprs-gmm0 (= ${binary:Version}), +Depends: libosmo-gprs-gmm1 (= ${binary:Version}), ${misc:Depends} Description: Debug symbols for libosmo-gprs-gmm @@ -65,13 +65,13 @@ Architecture: any Multi-Arch: same Section: libdevel -Depends: libosmo-gprs-gmm0 (= ${binary:Version}), +Depends: libosmo-gprs-gmm1 (= ${binary:Version}), libosmocore-dev, libtalloc-dev, ${misc:Depends} Description: Development headers and libraries for libosmo-gprs-gmm -Package: libosmo-gprs-llc0 +Package: libosmo-gprs-llc1 Section: libs Architecture: any Multi-Arch: same @@ -84,7 +84,7 @@ Architecture: any Section: debug Multi-Arch: same -Depends: libosmo-gprs-llc0 (= ${binary:Version}), +Depends: libosmo-gprs-llc1 (= ${binary:Version}), ${misc:Depends} Description: Debug symbols for libosmo-gprs-llc @@ -92,13 +92,13 @@ Architecture: any Multi-Arch: same Section: libdevel -Depends: libosmo-gprs-llc0 (= ${binary:Version}), +Depends: libosmo-gprs-llc1 (= ${binary:Version}), libosmocore-dev, libtalloc-dev, ${misc:Depends} Description: Development headers and libraries for libosmo-gprs-llc -Package: libosmo-gprs-rlcmac0 +Package: libosmo-gprs-rlcmac1 Section: libs Architecture: any Multi-Arch: same @@ -111,7 +111,7 @@ Architecture: any Section: debug Multi-Arch: same -Depends: libosmo-gprs-rlcmac0 (= ${binary:Version}), +Depends: libosmo-gprs-rlcmac1 (= ${binary:Version}), ${misc:Depends} Description: Debug symbols for libosmo-gprs-rlcmac @@ -119,13 +119,13 @@ Architecture: any Multi-Arch: same Section: libdevel -Depends: libosmo-gprs-rlcmac0 (= ${binary:Version}), +Depends: libosmo-gprs-rlcmac1 (= ${binary:Version}), libosmocore-dev, libtalloc-dev, ${misc:Depends} Description: Development headers and libraries for libosmo-gprs-rlcmac -Package: libosmo-gprs-sndcp0 +Package: libosmo-gprs-sndcp1 Section: libs Architecture: any Multi-Arch: same @@ -138,7 +138,7 @@ Architecture: any Section: debug Multi-Arch: same -Depends: libosmo-gprs-sndcp0 (= ${binary:Version}), +Depends: libosmo-gprs-sndcp1 (= ${binary:Version}), ${misc:Depends} Description: Debug symbols for libosmo-gprs-sndcp @@ -146,13 +146,13 @@ Architecture: any Multi-Arch: same Section: libdevel -Depends: libosmo-gprs-sndcp0 (= ${binary:Version}), +Depends: libosmo-gprs-sndcp1 (= ${binary:Version}), libosmocore-dev, libtalloc-dev, ${misc:Depends} Description: Development headers and libraries for libosmo-gprs-sndcp -Package: libosmo-gprs-sm0 +Package: libosmo-gprs-sm1 Section: libs Architecture: any Multi-Arch: same @@ -165,7 +165,7 @@ Architecture: any Section: debug Multi-Arch: same -Depends: libosmo-gprs-sm0 (= ${binary:Version}), +Depends: libosmo-gprs-sm1 (= ${binary:Version}), ${misc:Depends} Description: Debug symbols for libosmo-gprs-sm @@ -173,7 +173,7 @@ Architecture: any Multi-Arch: same Section: libdevel -Depends: libosmo-gprs-sm0 (= ${binary:Version}), +Depends: libosmo-gprs-sm1 (= ${binary:Version}), libosmocore-dev, libtalloc-dev, ${misc:Depends} diff --git a/debian/libosmo-csn1-0.install b/debian/libosmo-csn1-1.install similarity index 100% rename from debian/libosmo-csn1-0.install rename to debian/libosmo-csn1-1.install diff --git a/debian/libosmo-gprs-gmm0.install b/debian/libosmo-gprs-gmm1.install similarity index 100% rename from debian/libosmo-gprs-gmm0.install rename to debian/libosmo-gprs-gmm1.install diff --git a/debian/libosmo-gprs-llc0.install b/debian/libosmo-gprs-llc1.install similarity index 100% rename from debian/libosmo-gprs-llc0.install rename to debian/libosmo-gprs-llc1.install diff --git a/debian/libosmo-gprs-rlcmac0.install b/debian/libosmo-gprs-rlcmac1.install similarity index 100% rename from debian/libosmo-gprs-rlcmac0.install rename to debian/libosmo-gprs-rlcmac1.install diff --git a/debian/libosmo-gprs-sm0.install b/debian/libosmo-gprs-sm1.install similarity index 100% rename from debian/libosmo-gprs-sm0.install rename to debian/libosmo-gprs-sm1.install diff --git a/debian/libosmo-gprs-sndcp0.install b/debian/libosmo-gprs-sndcp1.install similarity index 100% rename from debian/libosmo-gprs-sndcp0.install rename to debian/libosmo-gprs-sndcp1.install diff --git a/src/csn1/Makefile.am b/src/csn1/Makefile.am index ea8f784..be4fa08 100644 --- a/src/csn1/Makefile.am +++ b/src/csn1/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=0:0:0 +LIBVERSION=1:0:0 AM_CPPFLAGS = \ $(all_includes) \ diff --git a/src/gmm/Makefile.am b/src/gmm/Makefile.am index 2aa8bb4..cc8a254 100644 --- a/src/gmm/Makefile.am +++ b/src/gmm/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=0:0:0 +LIBVERSION=1:0:0 AM_CPPFLAGS = \ $(all_includes) \ diff --git a/src/llc/Makefile.am b/src/llc/Makefile.am index 1549c4c..1145ad6 100644 --- a/src/llc/Makefile.am +++ b/src/llc/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=0:0:0 +LIBVERSION=1:0:0 AM_CPPFLAGS = \ $(all_includes) \ diff --git a/src/rlcmac/Makefile.am b/src/rlcmac/Makefile.am index b31dc9d..5c49f1c 100644 --- a/src/rlcmac/Makefile.am +++ b/src/rlcmac/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=0:0:0 +LIBVERSION=1:0:0 AM_CPPFLAGS = \ $(all_includes) \ diff --git a/src/sm/Makefile.am b/src/sm/Makefile.am index 83b19de..769f31a 100644 --- a/src/sm/Makefile.am +++ b/src/sm/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=0:0:0 +LIBVERSION=1:0:0 AM_CPPFLAGS = \ $(all_includes) \ diff --git a/src/sndcp/Makefile.am b/src/sndcp/Makefile.am index f3ec7b5..aff6bfa 100644 --- a/src/sndcp/Makefile.am +++ b/src/sndcp/Makefile.am @@ -1,7 +1,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=0:0:0 +LIBVERSION=1:0:0 AM_CPPFLAGS = \ $(all_includes) \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I5acd9c05030e13df79833f280af72f14b4eb04ec Gerrit-Change-Number: 39039 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[L] Change in libosmo-gprs[master]: Bump version: 0.1.0 → 0.2.0

by osmith

Attention is currently required from: daniel, dexter, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39039?usp=email ) Change subject: Bump version: 0.1.0 → 0.2.0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I5acd9c05030e13df79833f280af72f14b4eb04ec Gerrit-Change-Number: 39039 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 09:36:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email ) Change subject: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719 Gerrit-Change-Number: 39042 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Dec 2024 21:38:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email ) Change subject: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a Gerrit-Change-Number: 39041 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Dec 2024 21:37:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: Drop dependency on libosmo-abis

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39045?usp=email ) Change subject: Drop dependency on libosmo-abis ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7658b0c92c589b24a9f2bfe101ada5fc0077059f Gerrit-Change-Number: 39045 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Dec 2024 21:37:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[L] Change in libosmo-gprs[master]: Bump version: 0.1.0 → 0.2.0

by laforge

Attention is currently required from: daniel, dexter, osmith, pespin. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39039?usp=email ) Change subject: Bump version: 0.1.0 → 0.2.0 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I5acd9c05030e13df79833f280af72f14b4eb04ec Gerrit-Change-Number: 39039 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 Dec 2024 21:36:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024