December 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-abis[master]: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email ) Change subject: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a Gerrit-Change-Number: 39041 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 11:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email ) Change subject: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a Gerrit-Change-Number: 39041 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 11:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[L] Change in libosmo-netif[master]: ipa: Add osmo_ipa_ka_fsm_inst APIs

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email ) Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd Gerrit-Change-Number: 39035 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 11:13:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: ara_m fix export of AID-REF-DO (empty)

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39057?usp=email ) Change subject: ara_m fix export of AID-REF-DO (empty) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I771d5e860b12215280e3d0a8c314ce843fe0d6a2 Gerrit-Change-Number: 39057 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 11:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.4]: ipaccess_line_update: drop set_priority and set_ip_dscp

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email ) Change subject: ipaccess_line_update: drop set_priority and set_ip_dscp ...................................................................... ipaccess_line_update: drop set_priority and set_ip_dscp Do not run osmo_stream_cli_set_priority() and osmo_stream_cli_set_ip_dscp() in ipaccess_line_update(). These functions are not available yet in libosmo-netif 1.5.x and cause the build to fail. g_e1inp_ipaccess_config_pars.oml.dscp and g_e1inp_ipaccess_config_pars.oml.priority are not set anyway, so this makes no functional difference. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823 --- M src/ipaccess/ipaccess-config-e1-driver.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c index 71e70e1..48992c5 100644 --- a/src/ipaccess/ipaccess-config-e1-driver.c +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -423,8 +423,6 @@ osmo_stream_cli_set_port(cli, IPACCESS_BTS_LISTEN_OML_PORT); osmo_stream_cli_set_proto(cli, IPPROTO_TCP); osmo_stream_cli_set_nodelay(cli, true); - osmo_stream_cli_set_priority(cli, g_e1inp_ipaccess_config_pars.oml.dscp); - osmo_stream_cli_set_ip_dscp(cli, g_e1inp_ipaccess_config_pars.oml.priority); /* Reconnect is handled by upper layers: */ osmo_stream_cli_set_reconnect_timeout(cli, -1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.4 Gerrit-Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823 Gerrit-Change-Number: 39058 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.4]: Bump version: 1.12.3.1-b7fe1 → 1.12.4

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39059?usp=email ) Change subject: Bump version: 1.12.3.1-b7fe1 → 1.12.4 ...................................................................... Bump version: 1.12.3.1-b7fe1 → 1.12.4 Change-Id: I01f7a7078007415dd08704b82ec901d46be06da1 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index af3c097..6bcd78c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-bsc (1.12.4) unstable; urgency=medium + + * ipaccess_line_update: drop set_priority and set_ip_dscp + + -- Oliver Smith <osmith(a)sysmocom.de> Mon, 09 Dec 2024 11:46:07 +0100 + osmo-bsc (1.12.3) unstable; urgency=medium [ Oliver Smith ] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39059?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.4 Gerrit-Change-Id: I01f7a7078007415dd08704b82ec901d46be06da1 Gerrit-Change-Number: 39059 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.4]: Bump version: 1.12.3.1-b7fe1 → 1.12.4

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39059?usp=email ) Change subject: Bump version: 1.12.3.1-b7fe1 → 1.12.4 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39059?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.4 Gerrit-Change-Id: I01f7a7078007415dd08704b82ec901d46be06da1 Gerrit-Change-Number: 39059 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 10:49:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.4]: ipaccess_line_update: drop set_priority and set_ip_dscp

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email ) Change subject: ipaccess_line_update: drop set_priority and set_ip_dscp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.4 Gerrit-Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823 Gerrit-Change-Number: 39058 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 10:49:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.4]: Bump version: 1.12.3.1-b7fe1 → 1.12.4

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39059?usp=email ) Change subject: Bump version: 1.12.3.1-b7fe1 → 1.12.4 ...................................................................... Bump version: 1.12.3.1-b7fe1 → 1.12.4 Change-Id: I01f7a7078007415dd08704b82ec901d46be06da1 --- M debian/changelog 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/59/39059/1 diff --git a/debian/changelog b/debian/changelog index af3c097..6bcd78c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +osmo-bsc (1.12.4) unstable; urgency=medium + + * ipaccess_line_update: drop set_priority and set_ip_dscp + + -- Oliver Smith <osmith(a)sysmocom.de> Mon, 09 Dec 2024 11:46:07 +0100 + osmo-bsc (1.12.3) unstable; urgency=medium [ Oliver Smith ] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39059?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.4 Gerrit-Change-Id: I01f7a7078007415dd08704b82ec901d46be06da1 Gerrit-Change-Number: 39059 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.4]: ipaccess_line_update: drop set_priority and set_ip_dscp

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email ) Change subject: ipaccess_line_update: drop set_priority and set_ip_dscp ...................................................................... ipaccess_line_update: drop set_priority and set_ip_dscp Do not run osmo_stream_cli_set_priority() and osmo_stream_cli_set_ip_dscp() in ipaccess_line_update(). These functions are not available yet in libosmo-netif 1.5.x and cause the build to fail. g_e1inp_ipaccess_config_pars.oml.dscp and g_e1inp_ipaccess_config_pars.oml.priority are not set anyway, so this makes no functional difference. Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823 --- M src/ipaccess/ipaccess-config-e1-driver.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/39058/1 diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c index 71e70e1..48992c5 100644 --- a/src/ipaccess/ipaccess-config-e1-driver.c +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -423,8 +423,6 @@ osmo_stream_cli_set_port(cli, IPACCESS_BTS_LISTEN_OML_PORT); osmo_stream_cli_set_proto(cli, IPPROTO_TCP); osmo_stream_cli_set_nodelay(cli, true); - osmo_stream_cli_set_priority(cli, g_e1inp_ipaccess_config_pars.oml.dscp); - osmo_stream_cli_set_ip_dscp(cli, g_e1inp_ipaccess_config_pars.oml.priority); /* Reconnect is handled by upper layers: */ osmo_stream_cli_set_reconnect_timeout(cli, -1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39058?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.4 Gerrit-Change-Id: Ic46af94db8e0d821c5ca559e96c72d5041d32823 Gerrit-Change-Number: 39058 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024