December 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: ara_m: put hex string values in quotes

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39056?usp=email ) Change subject: ara_m: put hex string values in quotes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > why would we do this? Have we ever done so in other location? are we not always simply using hex-str […] Its due to an aesthetic conflict with the patch after this one. The problem is with the option --aid. When I want to put an empty AID, I must write --aid "". and then I have "" on one option and not on the others. I don't think that this looks very good, that is why I thought that we should put all parameters in "" by default. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia365e83638ff4f1b1a02e1671852cf2006f80c7f Gerrit-Change-Number: 39056 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Dec 2024 10:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

6 months, 2 weeks

1
0
0 0

[M] Change in pysim[master]: ara_m: fix spec reference.

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39055?usp=email ) Change subject: ara_m: fix spec reference. ...................................................................... ara_m: fix spec reference. there are multiple references to a specification "SEID". As it seems this is a reference to the GlobalPlatform "Secure Element Access Control" spec, which has the document reference "GPD_SPE_013". Let's use "GPD_SPE_013" to referene the spec. Related: SYS#6681 Change-Id: I77895f1b84126563380ce89aa07a3b448d8784a3 --- M pySim/ara_m.py 1 file changed, 31 insertions(+), 31 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ara_m.py b/pySim/ara_m.py index d25d0e8..f4da31d 100644 --- a/pySim/ara_m.py +++ b/pySim/ara_m.py @@ -38,17 +38,17 @@ class AidRefDO(BER_TLV_IE, tag=0x4f): - # SEID v1.1 Table 6-3 + # GPD_SPE_013 v1.1 Table 6-3 _construct = HexAdapter(GreedyBytes) class AidRefEmptyDO(BER_TLV_IE, tag=0xc0): - # SEID v1.1 Table 6-3 + # GPD_SPE_013 v1.1 Table 6-3 pass class DevAppIdRefDO(BER_TLV_IE, tag=0xc1): - # SEID v1.1 Table 6-4 + # GPD_SPE_013 v1.1 Table 6-4 _construct = HexAdapter(GreedyBytes) @@ -58,12 +58,12 @@ class RefDO(BER_TLV_IE, tag=0xe1, nested=[AidRefDO, AidRefEmptyDO, DevAppIdRefDO, PkgRefDO]): - # SEID v1.1 Table 6-5 + # GPD_SPE_013 v1.1 Table 6-5 pass class ApduArDO(BER_TLV_IE, tag=0xd0): - # SEID v1.1 Table 6-8 + # GPD_SPE_013 v1.1 Table 6-8 def _from_bytes(self, do: bytes): if len(do) == 1: if do[0] == 0x00: @@ -108,7 +108,7 @@ class NfcArDO(BER_TLV_IE, tag=0xd1): - # SEID v1.1 Table 6-9 + # GPD_SPE_013 v1.1 Table 6-9 _construct = Struct('nfc_event_access_rule' / Enum(Int8ub, never=0, always=1)) @@ -120,122 +120,122 @@ class ArDO(BER_TLV_IE, tag=0xe3, nested=[ApduArDO, NfcArDO, PermArDO]): - # SEID v1.1 Table 6-7 + # GPD_SPE_013 v1.1 Table 6-7 pass class RefArDO(BER_TLV_IE, tag=0xe2, nested=[RefDO, ArDO]): - # SEID v1.1 Table 6-6 + # GPD_SPE_013 v1.1 Table 6-6 pass class ResponseAllRefArDO(BER_TLV_IE, tag=0xff40, nested=[RefArDO]): - # SEID v1.1 Table 4-2 + # GPD_SPE_013 v1.1 Table 4-2 pass class ResponseArDO(BER_TLV_IE, tag=0xff50, nested=[ArDO]): - # SEID v1.1 Table 4-3 + # GPD_SPE_013 v1.1 Table 4-3 pass class ResponseRefreshTagDO(BER_TLV_IE, tag=0xdf20): - # SEID v1.1 Table 4-4 + # GPD_SPE_013 v1.1 Table 4-4 _construct = Struct('refresh_tag'/HexAdapter(Bytes(8))) class DeviceInterfaceVersionDO(BER_TLV_IE, tag=0xe6): - # SEID v1.1 Table 6-12 + # GPD_SPE_013 v1.1 Table 6-12 _construct = Struct('major'/Int8ub, 'minor'/Int8ub, 'patch'/Int8ub) class DeviceConfigDO(BER_TLV_IE, tag=0xe4, nested=[DeviceInterfaceVersionDO]): - # SEID v1.1 Table 6-10 + # GPD_SPE_013 v1.1 Table 6-10 pass class ResponseDeviceConfigDO(BER_TLV_IE, tag=0xff7f, nested=[DeviceConfigDO]): - # SEID v1.1 Table 5-14 + # GPD_SPE_013 v1.1 Table 5-14 pass class AramConfigDO(BER_TLV_IE, tag=0xe5, nested=[DeviceInterfaceVersionDO]): - # SEID v1.1 Table 6-11 + # GPD_SPE_013 v1.1 Table 6-11 pass class ResponseAramConfigDO(BER_TLV_IE, tag=0xdf21, nested=[AramConfigDO]): - # SEID v1.1 Table 4-5 + # GPD_SPE_013 v1.1 Table 4-5 pass class CommandStoreRefArDO(BER_TLV_IE, tag=0xf0, nested=[RefArDO]): - # SEID v1.1 Table 5-2 + # GPD_SPE_013 v1.1 Table 5-2 pass class CommandDelete(BER_TLV_IE, tag=0xf1, nested=[AidRefDO, AidRefEmptyDO, RefDO, RefArDO]): - # SEID v1.1 Table 5-4 + # GPD_SPE_013 v1.1 Table 5-4 pass class CommandUpdateRefreshTagDO(BER_TLV_IE, tag=0xf2): - # SEID V1.1 Table 5-6 + # GPD_SPE_013 V1.1 Table 5-6 pass class CommandRegisterClientAidsDO(BER_TLV_IE, tag=0xf7, nested=[AidRefDO, AidRefEmptyDO]): - # SEID v1.1 Table 5-7 + # GPD_SPE_013 v1.1 Table 5-7 pass class CommandGet(BER_TLV_IE, tag=0xf3, nested=[AidRefDO, AidRefEmptyDO]): - # SEID v1.1 Table 5-8 + # GPD_SPE_013 v1.1 Table 5-8 pass class CommandGetAll(BER_TLV_IE, tag=0xf4): - # SEID v1.1 Table 5-9 + # GPD_SPE_013 v1.1 Table 5-9 pass class CommandGetClientAidsDO(BER_TLV_IE, tag=0xf6): - # SEID v1.1 Table 5-10 + # GPD_SPE_013 v1.1 Table 5-10 pass class CommandGetNext(BER_TLV_IE, tag=0xf5): - # SEID v1.1 Table 5-11 + # GPD_SPE_013 v1.1 Table 5-11 pass class CommandGetDeviceConfigDO(BER_TLV_IE, tag=0xf8): - # SEID v1.1 Table 5-12 + # GPD_SPE_013 v1.1 Table 5-12 pass class ResponseAracAidDO(BER_TLV_IE, tag=0xff70, nested=[AidRefDO, AidRefEmptyDO]): - # SEID v1.1 Table 5-13 + # GPD_SPE_013 v1.1 Table 5-13 pass class BlockDO(BER_TLV_IE, tag=0xe7): - # SEID v1.1 Table 6-13 + # GPD_SPE_013 v1.1 Table 6-13 _construct = Struct('offset'/Int16ub, 'length'/Int8ub) -# SEID v1.1 Table 4-1 +# GPD_SPE_013 v1.1 Table 4-1 class GetCommandDoCollection(TLV_IE_Collection, nested=[RefDO, DeviceConfigDO]): pass -# SEID v1.1 Table 4-2 +# GPD_SPE_013 v1.1 Table 4-2 class GetResponseDoCollection(TLV_IE_Collection, nested=[ResponseAllRefArDO, ResponseArDO, ResponseRefreshTagDO, ResponseAramConfigDO]): pass -# SEID v1.1 Table 5-1 +# GPD_SPE_013 v1.1 Table 5-1 class StoreCommandDoCollection(TLV_IE_Collection, nested=[BlockDO, CommandStoreRefArDO, CommandDelete, CommandUpdateRefreshTagDO, CommandRegisterClientAidsDO, @@ -244,7 +244,7 @@ pass -# SEID v1.1 Section 5.1.2 +# GPD_SPE_013 v1.1 Section 5.1.2 class StoreResponseDoCollection(TLV_IE_Collection, nested=[ResponseAllRefArDO, ResponseAracAidDO, ResponseDeviceConfigDO]): pass -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I77895f1b84126563380ce89aa07a3b448d8784a3 Gerrit-Change-Number: 39055 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: fix usage of bts number in PCUIF_TXT_IND

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964?usp=email ) Change subject: PCUIF: fix usage of bts number in PCUIF_TXT_IND ...................................................................... Patch Set 1: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964/comment/0eee7a3b_f13d… : PS1, Line 5449: /* At this point, a real PCU would not have any BTS context yet. This means that the receiving process is > In this situation the 0 is just a placeholder. Yes, I know, but this fact is totally unrelated to the fact that "PCU doesn't have any BTS context yet"...? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93de261fc77806b2f817e0d30cb1b0d377ed0dbb Gerrit-Change-Number: 38964 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Dec 2024 10:19:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719 Related: OS#5896 Depends: libosmo-netif.git Change-Id I5c36e06e0dc29ec4679b20ad6c426f051b659acd --- M TODO-RELEASE M include/osmocom/abis/e1_input.h M src/input/ipaccess.c 3 files changed, 43 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/39042/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719 Gerrit-Change-Number: 39042 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[L] Change in libosmo-netif[master]: ipa: Add osmo_ipa_ka_fsm_inst APIs

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email ) Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs ...................................................................... Patch Set 4: (1 comment) File include/osmocom/netif/ipa.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39035/comment/b312d658_cde3d09… : PS3, Line 85: void *osmo_ipa_ka_fsm_get_data(const struct osmo_ipa_ka_fsm_inst *ka_fi); > I would normally hand the data directly to the call-back as an argument to avoid the extra function […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd Gerrit-Change-Number: 39035 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Dec 2024 10:03:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

6 months, 2 weeks

1
0
0 0

[L] Change in libosmo-netif[master]: ipa: Add osmo_ipa_ka_fsm_inst APIs

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: ipa: Add osmo_ipa_ka_fsm_inst APIs ...................................................................... ipa: Add osmo_ipa_ka_fsm_inst APIs This new object and its APIs are meant to replace ipa_keepalive_fsm_* APIs from libosmo-abis, because: 1- libosmo-abis is not the proper place to have IPA generic code, since other protocols than Abis also use IPA underneath. 2- the existing API in libosmo-abis is actually a set of 3 interfaces, 2 of which rely on ipa_client_conn and ipa_server_conn, which are provided by libosmo-abis itself and which will eventually be deprecated. Hence, only the "generic" one is actually reimplemented here, so it is backend agnsotic. A notable difference from the FSM implementation in libosmo-abis is that this fsm instnace object doesn't terminate itself, but leaves the decision to the user, in order to allow for more flexibility during object destruction. Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd --- M TODO-RELEASE M include/osmocom/netif/ipa.h M src/Makefile.am A src/ipa_keepalive.c 4 files changed, 379 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/39035/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c36e06e0dc29ec4679b20ad6c426f051b659acd Gerrit-Change-Number: 39035 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[osmith/1.12.3]: Bump version: 1.12.2.6-d24f → 1.12.3

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39052?usp=email ) Change subject: Bump version: 1.12.2.6-d24f → 1.12.3 ...................................................................... Bump version: 1.12.2.6-d24f → 1.12.3 Related: OS#6617 Change-Id: I961534bb0970e934f2201767a47fdbb17576c015 --- M debian/changelog 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index a05f00c..af3c097 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,17 @@ +osmo-bsc (1.12.3) unstable; urgency=medium + + [ Oliver Smith ] + * contrib/jenkins: libosmo-sccp -> libosmo-sigtran + + [ Pau Espin Pedrol ] + * jenkins.sh: libosmo-netif no longer depends on libosmo-abis + * ipaccess-proxy: Fix wrong cb function passed + * Drop use of libosmo-abis osmocom/abis/ipaccess.h + * ipaccess-config: Use own e1_input ipaccess driver + * ipaccess-config: Remove unused function ipaccess_bts_handle_ccm() + + -- Oliver Smith <osmith(a)sysmocom.de> Fri, 06 Dec 2024 13:22:04 +0100 + osmo-bsc (1.12.2) unstable; urgency=medium [ Oliver Smith ] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I961534bb0970e934f2201767a47fdbb17576c015 Gerrit-Change-Number: 39052 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39053?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran ...................................................................... contrib/jenkins: libosmo-sccp -> libosmo-sigtran Change-Id: I4146c4594a45c9e10b051774affe9aaffa95d314 (cherry picked from commit 56fa819a99019272b2f76631f4404a964276663f) --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 01b0d33..6828016 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -56,7 +56,7 @@ osmo-build-dep.sh libosmo-abis osmo-build-dep.sh libosmo-netif -osmo-build-dep.sh libosmo-sccp +osmo-build-dep.sh libosmo-sigtran osmo-build-dep.sh osmo-mgw # Additional configure options and depends -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I4146c4594a45c9e10b051774affe9aaffa95d314 Gerrit-Change-Number: 39053 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: ipaccess-proxy: Fix wrong cb function passed

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39048?usp=email ) Change subject: ipaccess-proxy: Fix wrong cb function passed ...................................................................... ipaccess-proxy: Fix wrong cb function passed It makes no sense that ipaccess-proxy is using the ipaccess_fd_cb() function from libosmo-abis, since that function expects an e1_input ipaccess driver to be set up by the app, which ipaccess-proxy never sets up. Furthermore, even the data pointer being passed doesn't match the one expected by the callback. This seems to be a bug introduced 10 years ago in osmo-bsc.git eb623019382fdbff36fb8a72052732e225aef67e, where the name of the private function callback used by ipaccess-proxy was changed to proxy_ipaccess_fd_cb() to avoid colliding with the ipaccess_fd_cb() from libosmo-abis, but only 1 of the 2 references was changed at the time, leaving the other one pointing to the wrong function. Fixes: eb623019382fdbff36fb8a72052732e225aef67e Change-Id: I1702d9913a462a36e4b78b503a8338ae2ad140b1 (cherry picked from commit eb08b4ce41aa323532a7cc845eb6d236f65a6afb) --- M src/ipaccess/ipaccess-proxy.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Verified diff --git a/src/ipaccess/ipaccess-proxy.c b/src/ipaccess/ipaccess-proxy.c index 7ede283..62e79cd 100644 --- a/src/ipaccess/ipaccess-proxy.c +++ b/src/ipaccess/ipaccess-proxy.c @@ -1021,7 +1021,7 @@ } bfd = &ipc->fd; - osmo_fd_setup(bfd, ret, OSMO_FD_READ | OSMO_FD_WRITE, ipaccess_fd_cb, ipc, priv_nr); + osmo_fd_setup(bfd, ret, OSMO_FD_READ | OSMO_FD_WRITE, proxy_ipaccess_fd_cb, ipc, priv_nr); ret = setsockopt(bfd->fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)); if (ret < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I1702d9913a462a36e4b78b503a8338ae2ad140b1 Gerrit-Change-Number: 39048 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: jenkins.sh: libosmo-netif no longer depends on libosmo-abis

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39054?usp=email ) Change subject: jenkins.sh: libosmo-netif no longer depends on libosmo-abis ...................................................................... jenkins.sh: libosmo-netif no longer depends on libosmo-abis Change-Id: Idcd6aecd9bd50b43e3c16c6f636151bb7958b06f Depends: libosmo-abis.git Change-Id I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif.git Change-Id I13d6e88158f6d9ce017986283183ee9c2cc68cae (cherry picked from commit 6a4e24fb381b3c9fd97cd5ffba1cff31be244899) --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 6828016..9f9d2f7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -54,8 +54,8 @@ export LD_LIBRARY_PATH="$inst/lib" export PATH="$inst/bin:$PATH" +osmo-build-dep.sh libosmo-netif "" --disable-doxygen osmo-build-dep.sh libosmo-abis -osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sigtran osmo-build-dep.sh osmo-mgw -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: Idcd6aecd9bd50b43e3c16c6f636151bb7958b06f Gerrit-Change-Number: 39054 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024