December 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[osmith/1.12.3]: ipaccess-proxy: Fix wrong cb function passed

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39048?usp=email ) Change subject: ipaccess-proxy: Fix wrong cb function passed ...................................................................... Patch Set 2: Verified+1 (1 comment) Patchset: PS2: CI is expected to fail here, passes later on in this patch series -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I1702d9913a462a36e4b78b503a8338ae2ad140b1 Gerrit-Change-Number: 39048 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 12:30:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: jenkins.sh: libosmo-netif no longer depends on libosmo-abis

by osmith

osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39054?usp=email ) Change subject: jenkins.sh: libosmo-netif no longer depends on libosmo-abis ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: Idcd6aecd9bd50b43e3c16c6f636151bb7958b06f Gerrit-Change-Number: 39054 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: jenkins.sh: libosmo-netif no longer depends on libosmo-abis

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39054?usp=email ) Change subject: jenkins.sh: libosmo-netif no longer depends on libosmo-abis ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: CI is expected to fail here, passes later on in this patch series -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: Idcd6aecd9bd50b43e3c16c6f636151bb7958b06f Gerrit-Change-Number: 39054 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 12:30:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran

by osmith

osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39053?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I4146c4594a45c9e10b051774affe9aaffa95d314 Gerrit-Change-Number: 39053 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39053?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran ...................................................................... Patch Set 1: Verified+1 (1 comment) Patchset: PS1: CI is expected to fail here, passes later on in this patch series -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I4146c4594a45c9e10b051774affe9aaffa95d314 Gerrit-Change-Number: 39053 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 12:30:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-bsc[osmith/1.12.3]: Bump version: 1.12.2.6-d24f → 1.12.3

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39052?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Bump version: 1.12.2.6-d24f → 1.12.3 ...................................................................... Bump version: 1.12.2.6-d24f → 1.12.3 Related: OS#6617 Change-Id: I961534bb0970e934f2201767a47fdbb17576c015 --- M debian/changelog 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/39052/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I961534bb0970e934f2201767a47fdbb17576c015 Gerrit-Change-Number: 39052 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: contrib/jenkins: libosmo-sccp -> libosmo-sigtran

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39053?usp=email ) Change subject: contrib/jenkins: libosmo-sccp -> libosmo-sigtran ...................................................................... contrib/jenkins: libosmo-sccp -> libosmo-sigtran Change-Id: I4146c4594a45c9e10b051774affe9aaffa95d314 (cherry picked from commit 56fa819a99019272b2f76631f4404a964276663f) --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/53/39053/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 01b0d33..6828016 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -56,7 +56,7 @@ osmo-build-dep.sh libosmo-abis osmo-build-dep.sh libosmo-netif -osmo-build-dep.sh libosmo-sccp +osmo-build-dep.sh libosmo-sigtran osmo-build-dep.sh osmo-mgw # Additional configure options and depends -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I4146c4594a45c9e10b051774affe9aaffa95d314 Gerrit-Change-Number: 39053 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bsc[osmith/1.12.3]: jenkins.sh: libosmo-netif no longer depends on libosmo-abis

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39054?usp=email ) Change subject: jenkins.sh: libosmo-netif no longer depends on libosmo-abis ...................................................................... jenkins.sh: libosmo-netif no longer depends on libosmo-abis Change-Id: Idcd6aecd9bd50b43e3c16c6f636151bb7958b06f Depends: libosmo-abis.git Change-Id I079dc3999de508301dd37ed03e399356a58d3cab Depends: libosmo-netif.git Change-Id I13d6e88158f6d9ce017986283183ee9c2cc68cae (cherry picked from commit 6a4e24fb381b3c9fd97cd5ffba1cff31be244899) --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/54/39054/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 6828016..9f9d2f7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -54,8 +54,8 @@ export LD_LIBRARY_PATH="$inst/lib" export PATH="$inst/bin:$PATH" +osmo-build-dep.sh libosmo-netif "" --disable-doxygen osmo-build-dep.sh libosmo-abis -osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sigtran osmo-build-dep.sh osmo-mgw -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: Idcd6aecd9bd50b43e3c16c6f636151bb7958b06f Gerrit-Change-Number: 39054 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-bsc[osmith/1.12.3]: ipaccess-config: Remove unused function ipaccess_bts_handle_ccm()

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39051?usp=email ) Change subject: ipaccess-config: Remove unused function ipaccess_bts_handle_ccm() ...................................................................... ipaccess-config: Remove unused function ipaccess_bts_handle_ccm() This function actually slippted in unintentionally when copying the ipaccess driver from libosmo-abis.git as a base for the ipaccess-config driver. That function is actually not used either by libosmo-abis driver, but was left there as a backward compatible API. Fixes: 76b863eb47ecaaf22fb4ca6ecd19f94a05b2ed5c Change-Id: I126014eed2196e9fe03c65dff7bb384ac81f39f8 (cherry picked from commit 7067255b8486a299fc67312819641f813c6099d6) --- M src/ipaccess/ipaccess-config-e1-driver.c 1 file changed, 0 insertions(+), 68 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/39051/1 diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c index 1303d43..71e70e1 100644 --- a/src/ipaccess/ipaccess-config-e1-driver.c +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -207,71 +207,6 @@ return rc; } -int ipaccess_bts_handle_ccm(struct ipa_client_conn *link, - struct ipaccess_unit *dev, struct msgb *msg) -{ - struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; - - /* special handling for IPA CCM. */ - if (hh->proto != IPAC_PROTO_IPACCESS) - return 0; - - int ret = 0; - uint8_t *data = msgb_l2(msg); - int len = msgb_l2len(msg); - OSMO_ASSERT(len > 0); - uint8_t msg_type = *data; - /* line might not exist if != bsc||bts */ - - /* ping, pong and acknowledgment cases. */ - ret = ipa_ccm_rcvmsg_bts_base(msg, link->ofd); - if (ret < 0) - goto err; - - /* this is a request for identification from the BSC. */ - if (msg_type == IPAC_MSGT_ID_GET) { - struct msgb *rmsg; - /* The ipaccess_unit dev holds generic identity for the whole - * line, hence no trx_id. Patch ipaccess_unit during call to - * ipa_ccm_make_id_resp_from_req() to identify this TRX: */ - int store_trx_nr = dev->trx_id; - if (link->ofd->priv_nr >= E1INP_SIGN_RSL) - dev->trx_id = link->ofd->priv_nr - E1INP_SIGN_RSL; - else - dev->trx_id = 0; - LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", - dev->site_id, dev->bts_id, dev->trx_id); - rmsg = ipa_ccm_make_id_resp_from_req(dev, data + 1, len - 1); - dev->trx_id = store_trx_nr; - if (!rmsg) { - LOGP(DLINP, LOGL_ERROR, "Failed parsing ID_GET message.\n"); - goto err; - } - - ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len); - if (ret != rmsg->len) { - LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP message. Reason: %s\n", - strerror(errno)); - msgb_free(rmsg); - goto err; - } - msgb_free(rmsg); - - /* send ID_ACK. */ - ret = ipa_ccm_send_id_ack(link->ofd->fd); - if (ret <= 0) { - LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK message. Reason: %s\n", - strerror(errno)); - goto err; - } - } - return 1; - -err: - ipa_client_conn_close(link); - return -1; -} - static struct msgb *ipa_bts_id_ack(void) { struct msgb *nmsg2; @@ -294,9 +229,6 @@ LOGPIL(line, DLINP, LOGL_ERROR, "Failed to set TCP_NODELAY: %s\n", strerror(errno)); } -/* Same as ipaccess_bts_handle_ccm(), but using an osmo_stream_cli as backend - * instead of ipa_client_conn. - * The old ipaccess_bts_handle_ccm() needs to be kept as it's a public API. */ static int _ipaccess_bts_handle_ccm(struct osmo_stream_cli *cli, struct ipaccess_unit *dev, struct msgb *msg) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39051?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I126014eed2196e9fe03c65dff7bb384ac81f39f8 Gerrit-Change-Number: 39051 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-bsc[osmith/1.12.3]: Bump version: 1.12.2.4-08b4 → 1.12.3

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39052?usp=email ) Change subject: Bump version: 1.12.2.4-08b4 → 1.12.3 ...................................................................... Bump version: 1.12.2.4-08b4 → 1.12.3 Change-Id: I961534bb0970e934f2201767a47fdbb17576c015 --- M debian/changelog 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/39052/1 diff --git a/debian/changelog b/debian/changelog index a05f00c..056e491 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +osmo-bsc (1.12.3) unstable; urgency=medium + + [ Pau Espin Pedrol ] + * ipaccess-proxy: Fix wrong cb function passed + * Drop use of libosmo-abis osmocom/abis/ipaccess.h + * ipaccess-config: Use own e1_input ipaccess driver + * ipaccess-config: Remove unused function ipaccess_bts_handle_ccm() + + -- Oliver Smith <osmith(a)sysmocom.de> Fri, 06 Dec 2024 13:08:31 +0100 + osmo-bsc (1.12.2) unstable; urgency=medium [ Oliver Smith ] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: osmith/1.12.3 Gerrit-Change-Id: I961534bb0970e934f2201767a47fdbb17576c015 Gerrit-Change-Number: 39052 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024