December 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-remsim[master]: Makefile:am: Improve formatting and order of CFLAGS and LIBS

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email ) Change subject: Makefile:am: Improve formatting and order of CFLAGS and LIBS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia766a09103d2216258a83cc98899e6cae4b0351d Gerrit-Change-Number: 39020 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 10:18:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: fix usage of bts number in PCUIF_TXT_IND

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964?usp=email ) Change subject: PCUIF: fix usage of bts number in PCUIF_TXT_IND ...................................................................... Patch Set 1: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964/comment/3789ef87_9db7… : PS1, Line 5449: /* At this point, a real PCU would not have any BTS context yet. This means that the receiving process is > I'm failing to see the relation between "PCU not having any BTS contenxt yet" and the fact that we s […] In this situation the 0 is just a placeholder. It could be any value, the receiving process will ignore it based on the type of the indication. (This is a design problem in the PCUIF protocol, the filed must be present and there is no way to tell if the value in this field makes sense or not.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93de261fc77806b2f817e0d30cb1b0d377ed0dbb Gerrit-Change-Number: 38964 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Dec 2024 09:52:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: rspro: use osmo_stream to handle IPA connection

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email ) Change subject: rspro: use osmo_stream to handle IPA connection ...................................................................... Patch Set 6: (1 comment) File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/758a97bf_e60d01c3?… : PS6, Line 226: if (res <= 0) { > Is it safe to call `osmo_ipa_msgb_cb_proto()` before this check? Yes, we are simply accessing msgb->cb in the end. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a Gerrit-Change-Number: 39023 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 22:35:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: rspro: use osmo_stream to handle IPA connection

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email ) Change subject: rspro: use osmo_stream to handle IPA connection ...................................................................... Patch Set 6: (1 comment) File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/63134d8b_33ded6d8?… : PS6, Line 174: _ipaccess_bts_handle_ccm > It's not the first time I am seeing this (or similar) code. […] There used to be some and tbh ended up being not that useful, because in the end it really needs to interact a lot with related stuff, like lower level osmo_stream, upper level FSMs like keepalive, etc. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a Gerrit-Change-Number: 39023 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 22:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: Drop dependency on libosmo-abis

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39045?usp=email ) Change subject: Drop dependency on libosmo-abis ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7658b0c92c589b24a9f2bfe101ada5fc0077059f Gerrit-Change-Number: 39045 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 19:28:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: server: Implement IPA server with osmo_stream

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39033?usp=email ) Change subject: server: Implement IPA server with osmo_stream ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6341612e41a0005de85f45fd6454bb954becb69c Gerrit-Change-Number: 39033 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 19:24:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: rspro: use osmo_stream to handle IPA connection

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email ) Change subject: rspro: use osmo_stream to handle IPA connection ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File src/rspro_client_fsm.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/5c1fb954_b8edd3af?… : PS6, Line 174: _ipaccess_bts_handle_ccm It's not the first time I am seeing this (or similar) code. Can we have it in a library somewhere? https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/58a99e96_35190fe6?… : PS6, Line 226: if (res <= 0) { Is it safe to call `osmo_ipa_msgb_cb_proto()` before this check? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a Gerrit-Change-Number: 39023 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 19:20:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: Makefile:am: Improve formatting and order of CFLAGS and LIBS

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email ) Change subject: Makefile:am: Improve formatting and order of CFLAGS and LIBS ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia766a09103d2216258a83cc98899e6cae4b0351d Gerrit-Change-Number: 39020 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Dec 2024 19:10:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39044?usp=email ) Change subject: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm still having some weird issues with output stopping while running REMSIM_tests (server) with this one, so marking as WIP for now. Maybe somebody knowing better osmo-remsim can give them a try. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id9784c69f1524872053436b59712f67ad5fbfe94 Gerrit-Change-Number: 39044 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 05 Dec 2024 18:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 3 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: Drop dependency on libosmo-abis

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39045?usp=email ) Change subject: Drop dependency on libosmo-abis ...................................................................... Drop dependency on libosmo-abis Change-Id: I7658b0c92c589b24a9f2bfe101ada5fc0077059f --- M configure.ac M contrib/jenkins.sh M debian/control M src/Makefile.am M src/bankd/Makefile.am M src/client/Makefile.am M src/server/Makefile.am 7 files changed, 2 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/45/39045/1 diff --git a/configure.ac b/configure.ac index 0296197..ad2dcdb 100644 --- a/configure.ac +++ b/configure.ac @@ -36,7 +36,6 @@ PKG_CHECK_MODULES(OSMOCORE, libosmocore >= 1.6.0) PKG_CHECK_MODULES(OSMOGSM, libosmogsm >= 0.11.0) PKG_CHECK_MODULES(OSMONETIF, libosmo-netif >= 1.5.0) -PKG_CHECK_MODULES(OSMOABIS, libosmoabis >= 1.6.0) AC_ARG_ENABLE([remsim-server],[AS_HELP_STRING([--disable-remsim-server], [Build osmo-remsim-server])], [osmo_ac_build_server="$enableval"],[osmo_ac_build_server="yes"]) diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 2aa56a4..bfc4f57 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -1,5 +1,5 @@ #!/bin/sh -# jenkins build helper script for libosmo-abis. This is how we build on jenkins.osmocom.org +# jenkins build helper script for osmo-remsim. This is how we build on jenkins.osmocom.org # # environment variables: # * WITH_MANUALS: build manual PDFs if set to "1" @@ -30,7 +30,6 @@ osmo-build-dep.sh libosmocore "" --disable-doxygen osmo-build-dep.sh libosmo-netif "" --disable-doxygen -osmo-build-dep.sh libosmo-abis osmo-build-dep.sh simtrace2 # Additional configure options and depends diff --git a/debian/control b/debian/control index 1d6d7b3..3e98465 100644 --- a/debian/control +++ b/debian/control @@ -10,7 +10,6 @@ osmo-gsm-manuals-dev, libcsv-dev, libosmocore-dev (>= 1.6.0), - libosmo-abis-dev (>= 1.6.0), libosmo-netif-dev (>= 1.5.0), libosmo-simtrace2-dev (>= 0.8.0), libpcsclite-dev, diff --git a/src/Makefile.am b/src/Makefile.am index 6bb3d79..c2551a9 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -11,7 +11,6 @@ -I$(top_srcdir)/include \ -I$(top_builddir)/include \ -I$(top_srcdir)/include/osmocom/rspro \ - $(OSMOABIS_CFLAGS) \ $(OSMONETIF_CFLAGS) \ $(OSMOGSM_CFLAGS) \ $(OSMOCORE_CFLAGS) \ @@ -20,7 +19,7 @@ RSPRO_LIBVERSION=2:0:0 lib_LTLIBRARIES = libosmo-rspro.la libosmo_rspro_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RSPRO_LIBVERSION) -# OSMOABIS_LIBS, OSMONETIF_LIBS, OSMOGSM_LIBS not needed, we don't use any of its symbols, only the header above +# OSMONETIF_LIBS, OSMOGSM_LIBS not needed, we don't use any of its symbols, only the header above libosmo_rspro_la_LIBADD = $(OSMOCORE_LIBS) \ rspro/libosmo-asn1-rspro.la libosmo_rspro_la_SOURCES = rspro_util.c asn1c_helpers.c diff --git a/src/bankd/Makefile.am b/src/bankd/Makefile.am index d5eee87..1e2db28 100644 --- a/src/bankd/Makefile.am +++ b/src/bankd/Makefile.am @@ -3,7 +3,6 @@ -I$(top_builddir)/include \ -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ - $(OSMOABIS_CFLAGS) \ $(OSMONETIF_CFLAGS) \ $(OSMOGSM_CFLAGS) \ $(OSMOCORE_CFLAGS) \ @@ -24,7 +23,6 @@ osmo_remsim_bankd_SOURCES = ../slotmap.c ../rspro_client_fsm.c ../debug.c \ bankd_main.c bankd_pcsc.c gsmtap.c osmo_remsim_bankd_LDADD = $(top_builddir)/src/libosmo-rspro.la \ - $(OSMOABIS_LIBS) \ $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ diff --git a/src/client/Makefile.am b/src/client/Makefile.am index dc61196..6c7abc6 100644 --- a/src/client/Makefile.am +++ b/src/client/Makefile.am @@ -3,7 +3,6 @@ -I/$(top_builddir)/include \ -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ - $(OSMOABIS_CFLAGS) \ $(OSMONETIF_CFLAGS) \ $(OSMOGSM_CFLAGS) \ $(OSMOCORE_CFLAGS) \ @@ -17,7 +16,6 @@ remsim_client.c main_fsm.c ../rspro_client_fsm.c ../debug.c osmo_remsim_client_shell_CFLAGS = $(AM_CFLAGS) osmo_remsim_client_shell_LDADD = $(top_builddir)/src/libosmo-rspro.la \ - $(OSMOABIS_LIBS) \ $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ @@ -36,7 +34,6 @@ libifd_remsim_client_la_CPPFLAGS = $(PCSC_CFLAGS) libifd_remsim_client_la_LDFLAGS = -no-undefined libifd_remsim_client_la_LIBADD = $(top_builddir)/src/libosmo-rspro.la \ - $(OSMOABIS_LIBS) \ $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ @@ -50,7 +47,6 @@ osmo_remsim_client_st2_CPPFLAGS = -DUSB_SUPPORT -DSIMTRACE_SUPPORT osmo_remsim_client_st2_CFLAGS = $(AM_CFLAGS) osmo_remsim_client_st2_LDADD = $(top_builddir)/src/libosmo-rspro.la \ - $(OSMOABIS_LIBS) \ $(OSMONETIF_LIBS) \ $(OSMOSIMTRACE2_LIBS) \ $(OSMOGSM_LIBS) \ diff --git a/src/server/Makefile.am b/src/server/Makefile.am index 5a1908a..308c8f7 100644 --- a/src/server/Makefile.am +++ b/src/server/Makefile.am @@ -4,7 +4,6 @@ -I$(top_builddir)/include \ -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ - $(OSMOABIS_CFLAGS) \ $(OSMONETIF_CFLAGS) \ $(OSMOGSM_CFLAGS) \ $(OSMOCORE_CFLAGS) \ @@ -20,7 +19,6 @@ osmo_remsim_server_SOURCES = remsim_server.c rspro_server.c rest_api.c \ ../rspro_util.c ../slotmap.c ../debug.c osmo_remsim_server_LDADD = $(top_builddir)/src/libosmo-rspro.la \ - $(OSMOABIS_LIBS) \ $(OSMONETIF_LIBS) \ $(OSMOGSM_LIBS) \ $(OSMOCORE_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I7658b0c92c589b24a9f2bfe101ada5fc0077059f Gerrit-Change-Number: 39045 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024