December 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-remsim[master]: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39044?usp=email ) Change subject: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif Related: OS#5896 Depends: libosmo-netif.git Change-Id I5c36e06e0dc29ec4679b20ad6c426f051b659acd Change-Id: Id9784c69f1524872053436b59712f67ad5fbfe94 --- M TODO-RELEASE M src/client/client.h M src/client/user_simtrace2.c M src/rspro_client_fsm.c M src/rspro_client_fsm.h M src/server/rspro_server.c M src/server/rspro_server.h 7 files changed, 70 insertions(+), 60 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/44/39044/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 7aeffd4..730a421 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmocore > 1.9.0 working (compiling) gsmtap_inst_fd2() libosmo-simtrace2 >= 0.9.0 required to compile (sim presence polarity) +libosmo-netif >1.5.1 osmo_ipa_ka_fsm_inst APIs diff --git a/src/client/client.h b/src/client/client.h index df95312..6ec94b7 100644 --- a/src/client/client.h +++ b/src/client/client.h @@ -2,7 +2,6 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/fsm.h> -#include <osmocom/abis/ipa.h> #include <osmocom/rspro/RsproPDU.h> #include "rspro_util.h" diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 65d4cde..2535efb 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -22,6 +22,7 @@ #include <libusb.h> #include <osmocom/core/fsm.h> +#include <osmocom/core/select.h> #include <osmocom/core/utils.h> #include <osmocom/usb/libusb.h> diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index dcde0e4..a740afd 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -33,9 +33,6 @@ #include <osmocom/netif/stream.h> #include <osmocom/netif/ipa.h> -/* libosmo-abis still needed for ipa_keepalive_fsm: */ -#include <osmocom/abis/ipa.h> - #include "debug.h" #include "asn1c_helpers.h" #include "rspro_client_fsm.h" @@ -137,7 +134,6 @@ OSMO_VALUE_STRING(SRVC_E_TCP_UP), OSMO_VALUE_STRING(SRVC_E_TCP_DOWN), OSMO_VALUE_STRING(SRVC_E_KA_TIMEOUT), - OSMO_VALUE_STRING(SRVC_E_KA_TERMINATED), OSMO_VALUE_STRING(SRVC_E_CLIENT_CONN_RES), OSMO_VALUE_STRING(SRVC_E_RSPRO_TX), { 0, NULL } @@ -156,6 +152,13 @@ struct rspro_server_conn *srvc = osmo_stream_cli_get_data(cli); LOGPFSML(srvc->fi, LOGL_NOTICE, "RSPRO link to %s:%d DOWN\n", srvc->server_host, srvc->server_port); + + if (srvc->ka_fi) { + osmo_ipa_ka_fsm_stop(srvc->ka_fi); + osmo_ipa_ka_fsm_free(srvc->ka_fi); + srvc->ka_fi = NULL; + } + osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_TCP_DOWN, 0); return 0; } @@ -239,7 +242,7 @@ } switch (msg_type) { case IPAC_MSGT_PONG: - ipa_keepalive_fsm_pong_received(srvc->keepalive_fi); + osmo_ipa_ka_fsm_pong_received(srvc->ka_fi); rc = 0; break; default: @@ -275,11 +278,6 @@ return -EBADF; } -static const struct ipa_keepalive_params ka_params = { - .interval = 30, - .wait_for_resp = 10, -}; - static int64_t get_monotonic_ms(void) { struct timespec t; @@ -334,7 +332,7 @@ struct rspro_server_conn *srvc = (struct rspro_server_conn *) fi->priv; RsproPDU_t *pdu; - ipa_keepalive_fsm_start(srvc->keepalive_fi); + osmo_ipa_ka_fsm_start(srvc->ka_fi); if (srvc->own_comp_id.type == ComponentType_remsimClient) pdu = rspro_gen_ConnectClientReq(&srvc->own_comp_id, srvc->clslot); @@ -407,29 +405,25 @@ osmo_fsm_inst_dispatch(fi->proc.parent, srvc->parent_disc_evt, NULL); } -static void ipa_keepalive_send_cb(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg) +static int ipa_keepalive_send_cb(struct osmo_ipa_ka_fsm_inst *ka_fi, struct msgb *msg) { - struct osmo_stream_cli *cli = (struct osmo_stream_cli *)conn; + struct osmo_stream_cli *cli = osmo_ipa_ka_fsm_get_data(ka_fi); osmo_stream_cli_send(cli, msg); + return 0; } -static int ipa_kaepalive_timeout_cb(struct osmo_fsm_inst *ka_fi, void *conn) +static int ipa_keepalive_timeout_cb(struct osmo_ipa_ka_fsm_inst *ka_fi) { - struct osmo_fsm_inst *fi = ka_fi->proc.parent; - osmo_fsm_inst_dispatch(fi, SRVC_E_KA_TIMEOUT, NULL); - return 0; /* we will explicitly terminate it */ + struct osmo_stream_cli *cli = osmo_ipa_ka_fsm_get_data(ka_fi); + struct rspro_server_conn *srvc = osmo_stream_cli_get_data(cli); + osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_KA_TIMEOUT, NULL); + return 0; } static void srvc_st_reestablish_delay_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct rspro_server_conn *srvc = (struct rspro_server_conn *) fi->priv; - if (srvc->keepalive_fi) { - ipa_keepalive_fsm_stop(srvc->keepalive_fi); - osmo_fsm_inst_term(srvc->keepalive_fi, OSMO_FSM_TERM_REGULAR, NULL); - srvc->keepalive_fi = NULL; - } - if (srvc->conn) { LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to server\n"); osmo_stream_cli_destroy(srvc->conn); @@ -449,6 +443,7 @@ OSMO_ASSERT(0); } } + static void srvc_st_reestablish_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct rspro_server_conn *srvc = (struct rspro_server_conn *) fi->priv; @@ -461,7 +456,7 @@ srvc->conn = osmo_stream_cli_create(fi); if (!srvc->conn) { LOGPFSML(fi, LOGL_FATAL, "Unable to create socket: %s\n", strerror(errno)); - exit(1); + goto err_exit; } osmo_stream_cli_set_name(srvc->conn, fi->id); @@ -479,15 +474,16 @@ osmo_stream_cli_set_disconnect_cb(srvc->conn, srvc_disconnect_cb); osmo_stream_cli_set_read_cb2(srvc->conn, srvc_read_cb); - srvc->keepalive_fi = ipa_generic_conn_alloc_keepalive_fsm(srvc->conn, srvc->conn, &ka_params, fi->id); - if (!srvc->keepalive_fi) { + srvc->ka_fi = osmo_ipa_ka_fsm_alloc(srvc->conn, fi->id); + if (!srvc->ka_fi) { LOGPFSM(fi, "Unable to create keepalive FSM\n"); - exit(1); + goto err_free_cli; } - ipa_keepalive_fsm_set_send_cb(srvc->keepalive_fi, ipa_keepalive_send_cb); - ipa_keepalive_fsm_set_timeout_cb(srvc->keepalive_fi, ipa_kaepalive_timeout_cb); - /* ensure parent is notified once keepalive FSM instance is dying */ - osmo_fsm_inst_change_parent(srvc->keepalive_fi, srvc->fi, SRVC_E_KA_TERMINATED); + osmo_ipa_ka_fsm_set_data(srvc->ka_fi, srvc->conn); + osmo_ipa_ka_fsm_set_ping_interval(srvc->ka_fi, 30); + osmo_ipa_ka_fsm_set_pong_timeout(srvc->ka_fi, 10); + osmo_ipa_ka_fsm_set_send_cb(srvc->ka_fi, ipa_keepalive_send_cb); + osmo_ipa_ka_fsm_set_timeout_cb(srvc->ka_fi, ipa_keepalive_timeout_cb); /* Attempt to connect TCP socket */ rc = osmo_stream_cli_open(srvc->conn); @@ -495,8 +491,17 @@ LOGPFSML(fi, LOGL_FATAL, "Unable to connect RSPRO to %s:%u - %s\n", srvc->server_host, srvc->server_port, strerror(errno)); /* FIXME: retry? Timer? Abort? */ - OSMO_ASSERT(0); + goto err_free_ka_fi; } + +err_free_ka_fi: + osmo_ipa_ka_fsm_free(srvc->ka_fi); + srvc->ka_fi = NULL; +err_free_cli: + osmo_stream_cli_destroy(srvc->conn); + srvc->conn = NULL; +err_exit: + exit(1); } static void srvc_st_reestablish(struct osmo_fsm_inst *fi, uint32_t event, void *data) @@ -525,11 +530,6 @@ srvc_do_reestablish(fi); break; case SRVC_E_DISCONNECT: - if (srvc->keepalive_fi) { - ipa_keepalive_fsm_stop(srvc->keepalive_fi); - osmo_fsm_inst_term(srvc->keepalive_fi, OSMO_FSM_TERM_REGULAR, NULL); - srvc->keepalive_fi = NULL; - } if (srvc->conn) { LOGPFSML(fi, LOGL_INFO, "Destroying existing connection to server\n"); osmo_stream_cli_destroy(srvc->conn); diff --git a/src/rspro_client_fsm.h b/src/rspro_client_fsm.h index 152ae5c..6ac40e5 100644 --- a/src/rspro_client_fsm.h +++ b/src/rspro_client_fsm.h @@ -13,7 +13,6 @@ SRVC_E_TCP_UP, SRVC_E_TCP_DOWN, SRVC_E_KA_TIMEOUT, - SRVC_E_KA_TERMINATED, SRVC_E_CLIENT_CONN_RES, SRVC_E_RSPRO_TX /* transmit a RSPRO PDU to the peer */ }; @@ -23,7 +22,7 @@ /* state */ struct osmo_stream_cli *conn; struct osmo_fsm_inst *fi; - struct osmo_fsm_inst *keepalive_fi; + struct osmo_ipa_ka_fsm_inst *ka_fi; int (*handle_rx)(struct rspro_server_conn *conn, const RsproPDU_t *pdu); /* index into k_reestablish_delay[] for this connection */ diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index c2001af..0910358 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -11,7 +11,6 @@ #include <osmocom/core/socket.h> #include <osmocom/gsm/protocol/ipaccess.h> #include <osmocom/netif/ipa.h> -#include <osmocom/abis/ipa.h> #include <osmocom/rspro/RsproPDU.h> @@ -164,9 +163,7 @@ rspro2client_slot(&conn->client.slot, cclreq->clientSlot); osmo_fsm_inst_update_id_f(fi, "C%u:%u", conn->client.slot.client_id, conn->client.slot.slot_nr); - osmo_fsm_inst_update_id_f(conn->keepalive_fi, "C%u:%u", - conn->client.slot.client_id, - conn->client.slot.slot_nr); + osmo_ipa_ka_fsm_set_id(conn->ka_fi, fi->id); LOGPFSML(fi, LOGL_INFO, "Client connected from %s:%s\n", ip_str, port_str); /* check for unique-ness */ @@ -214,7 +211,7 @@ conn->bank.bank_id = cbreq->bankId; conn->bank.num_slots = cbreq->numberOfSlots; osmo_fsm_inst_update_id_f(fi, "B%u", conn->bank.bank_id); - osmo_fsm_inst_update_id_f(conn->keepalive_fi, "B%u", conn->bank.bank_id); + osmo_ipa_ka_fsm_set_id(conn->ka_fi, fi->id); LOGPFSML(fi, LOGL_INFO, "Bankd connected from %s:%s\n", ip_str, port_str); if (!strncmp(ip_str, "127.", 4)) { @@ -671,7 +668,7 @@ return 0; case IPAC_MSGT_PONG: LOGPFSML(conn->fi, LOGL_DEBUG, "PONG!\n"); - ipa_keepalive_fsm_pong_received(conn->keepalive_fi); + osmo_ipa_ka_fsm_pong_received(conn->ka_fi); return 0; case IPAC_MSGT_ID_ACK: LOGPFSML(conn->fi, LOGL_DEBUG, "ID_ACK? -> ACK!\n"); @@ -767,6 +764,11 @@ if (!conn) return 0; /* rspro conn is already being destroyed, do nothing. */ osmo_stream_srv_set_data(peer, NULL); + if (conn->ka_fi) { + osmo_ipa_ka_fsm_stop(conn->ka_fi); + osmo_ipa_ka_fsm_free(conn->ka_fi); + conn->ka_fi = NULL; + } if (conn->fi) { conn->peer = NULL; osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_TCP_DOWN, NULL); @@ -776,17 +778,22 @@ return 0; } -static const struct ipa_keepalive_params ka_params = { - .interval = 30, - .wait_for_resp = 10, -}; - -static void ipa_keepalive_send_cb(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg) +static int ipa_keepalive_send_cb(struct osmo_ipa_ka_fsm_inst *ka_fi, struct msgb *msg) { - struct osmo_stream_srv *srv = (struct osmo_stream_srv *)conn; + struct osmo_stream_srv *srv = osmo_ipa_ka_fsm_get_data(ka_fi); osmo_stream_srv_send(srv, msg); + return 0; } +static int ipa_keepalive_timeout_cb(struct osmo_ipa_ka_fsm_inst *ka_fi) +{ + struct osmo_stream_srv *peer = osmo_ipa_ka_fsm_get_data(ka_fi); + struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); + osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_KA_TIMEOUT, NULL); + return 0; +} + + /* a new TCP connection was accepted on the RSPRO server socket */ static int accept_cb(struct osmo_stream_srv_link *link, int fd) { @@ -812,13 +819,15 @@ goto out_err_conn; /* use ipa_keepalive_fsm to periodically send an IPA_PING and expect a PONG in response */ - conn->keepalive_fi = ipa_generic_conn_alloc_keepalive_fsm(conn->peer, conn->peer, &ka_params, NULL); - if (!conn->keepalive_fi) + conn->ka_fi = osmo_ipa_ka_fsm_alloc(conn->peer, conn->fi->id); + if (!conn->ka_fi) goto out_err_fi; - /* ensure parent is notified once keepalive FSM instance is dying */ - osmo_fsm_inst_change_parent(conn->keepalive_fi, conn->fi, CLNTC_E_KA_TIMEOUT); - ipa_keepalive_fsm_set_send_cb(conn->keepalive_fi, ipa_keepalive_send_cb); - ipa_keepalive_fsm_start(conn->keepalive_fi); + osmo_ipa_ka_fsm_set_data(conn->ka_fi, conn->peer); + osmo_ipa_ka_fsm_set_ping_interval(conn->ka_fi, 30); + osmo_ipa_ka_fsm_set_pong_timeout(conn->ka_fi, 10); + osmo_ipa_ka_fsm_set_send_cb(conn->ka_fi, ipa_keepalive_send_cb); + osmo_ipa_ka_fsm_set_timeout_cb(conn->ka_fi, ipa_keepalive_timeout_cb); + osmo_ipa_ka_fsm_start(conn->ka_fi); INIT_LLIST_HEAD(&conn->bank.maps_new); INIT_LLIST_HEAD(&conn->bank.maps_unack); diff --git a/src/server/rspro_server.h b/src/server/rspro_server.h index 4843821..1bef81f 100644 --- a/src/server/rspro_server.h +++ b/src/server/rspro_server.h @@ -4,6 +4,7 @@ #include <osmocom/core/select.h> #include <osmocom/core/fsm.h> #include <osmocom/netif/stream.h> +#include <osmocom/netif/ipa.h> #include "rspro_util.h" #include "slotmap.h" @@ -36,7 +37,7 @@ /* remote component identity (after it has been received) */ struct app_comp_id comp_id; /* keep-alive handling FSM */ - struct osmo_fsm_inst *keepalive_fi; + struct osmo_ipa_ka_fsm_inst *ka_fi; struct { struct llist_head maps_new; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id9784c69f1524872053436b59712f67ad5fbfe94 Gerrit-Change-Number: 39044 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email ) Change subject: input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c ...................................................................... input: Move ipaccess_bts_handle_ccm() ipaccess.c -> ipa.c This function is no longer used in ipaccess.c, and actually relates to IPA generic code which still exists in ipa.c, hence move it there. Moreover, the function is declared in the "abis/ipa.h" public header, not the "abis/ipaccess.h" header (which was already deprecated). Once moved and it becomes clear this is not used in the e1_line ipaccess driver and hence the "if (line) { ... ipa pong ... } code branch in the function can be dropped, since it won't ever be executed. Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a --- M src/input/ipa.c M src/input/ipaccess.c 2 files changed, 66 insertions(+), 72 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/41/39041/1 diff --git a/src/input/ipa.c b/src/input/ipa.c index f49d0dc..073c1ff 100644 --- a/src/input/ipa.c +++ b/src/input/ipa.c @@ -582,3 +582,69 @@ msgb_enqueue(&conn->tx_queue, msg); osmo_fd_write_enable(&conn->ofd); } + +/* Kept for bacward compat since this is a public API. Will be deprecated at + * some point withthe rest of ipa_client_conn. */ +int ipaccess_bts_handle_ccm(struct ipa_client_conn *link, + struct ipaccess_unit *dev, struct msgb *msg) +{ + struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; + + /* special handling for IPA CCM. */ + if (hh->proto != IPAC_PROTO_IPACCESS) + return 0; + + int ret = 0; + uint8_t *data = msgb_l2(msg); + int len = msgb_l2len(msg); + OSMO_ASSERT(len > 0); + uint8_t msg_type = *data; + + /* ping, pong and acknowledgment cases. */ + ret = ipa_ccm_rcvmsg_bts_base(msg, link->ofd); + if (ret < 0) + goto err; + + /* this is a request for identification from the BSC. */ + if (msg_type == IPAC_MSGT_ID_GET) { + struct msgb *rmsg; + /* The ipaccess_unit dev holds generic identity for the whole + * line, hence no trx_id. Patch ipaccess_unit during call to + * ipa_ccm_make_id_resp_from_req() to identify this TRX: */ + int store_trx_nr = dev->trx_id; + if (link->ofd->priv_nr >= E1INP_SIGN_RSL) + dev->trx_id = link->ofd->priv_nr - E1INP_SIGN_RSL; + else + dev->trx_id = 0; + LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", + dev->site_id, dev->bts_id, dev->trx_id); + rmsg = ipa_ccm_make_id_resp_from_req(dev, data + 1, len - 1); + dev->trx_id = store_trx_nr; + if (!rmsg) { + LOGP(DLINP, LOGL_ERROR, "Failed parsing ID_GET message.\n"); + goto err; + } + + ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len); + if (ret != rmsg->len) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP message. Reason: %s\n", + strerror(errno)); + msgb_free(rmsg); + goto err; + } + msgb_free(rmsg); + + /* send ID_ACK. */ + ret = ipa_ccm_send_id_ack(link->ofd->fd); + if (ret <= 0) { + LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK message. Reason: %s\n", + strerror(errno)); + goto err; + } + } + return 1; + +err: + ipa_client_conn_close(link); + return -1; +} diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 6110004..c47c6fb 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -772,78 +772,6 @@ return 0; } -int ipaccess_bts_handle_ccm(struct ipa_client_conn *link, - struct ipaccess_unit *dev, struct msgb *msg) -{ - struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; - - /* special handling for IPA CCM. */ - if (hh->proto != IPAC_PROTO_IPACCESS) - return 0; - - int ret = 0; - uint8_t *data = msgb_l2(msg); - int len = msgb_l2len(msg); - OSMO_ASSERT(len > 0); - uint8_t msg_type = *data; - /* line might not exist if != bsc||bts */ - struct e1inp_line *line = link->line; - - /* peek the pong for our keepalive fsm */ - if (line && msg_type == IPAC_MSGT_PONG) { - struct osmo_fsm_inst *ka_fsm = ipaccess_line_ts(link->ofd, line)->driver.ipaccess.ka_fsm; - ipa_keepalive_fsm_pong_received(ka_fsm); - } - - /* ping, pong and acknowledgment cases. */ - ret = ipa_ccm_rcvmsg_bts_base(msg, link->ofd); - if (ret < 0) - goto err; - - /* this is a request for identification from the BSC. */ - if (msg_type == IPAC_MSGT_ID_GET) { - struct msgb *rmsg; - /* The ipaccess_unit dev holds generic identity for the whole - * line, hence no trx_id. Patch ipaccess_unit during call to - * ipa_ccm_make_id_resp_from_req() to identify this TRX: */ - int store_trx_nr = dev->trx_id; - if (link->ofd->priv_nr >= E1INP_SIGN_RSL) - dev->trx_id = link->ofd->priv_nr - E1INP_SIGN_RSL; - else - dev->trx_id = 0; - LOGP(DLINP, LOGL_NOTICE, "received ID_GET for unit ID %u/%u/%u\n", - dev->site_id, dev->bts_id, dev->trx_id); - rmsg = ipa_ccm_make_id_resp_from_req(dev, data + 1, len - 1); - dev->trx_id = store_trx_nr; - if (!rmsg) { - LOGP(DLINP, LOGL_ERROR, "Failed parsing ID_GET message.\n"); - goto err; - } - - ret = ipa_send(link->ofd->fd, rmsg->data, rmsg->len); - if (ret != rmsg->len) { - LOGP(DLINP, LOGL_ERROR, "cannot send ID_RESP message. Reason: %s\n", - strerror(errno)); - msgb_free(rmsg); - goto err; - } - msgb_free(rmsg); - - /* send ID_ACK. */ - ret = ipa_ccm_send_id_ack(link->ofd->fd); - if (ret <= 0) { - LOGP(DLINP, LOGL_ERROR, "cannot send ID_ACK message. Reason: %s\n", - strerror(errno)); - goto err; - } - } - return 1; - -err: - ipa_client_conn_close(link); - return -1; -} - static struct msgb *ipa_bts_id_ack(void) { struct msgb *nmsg2; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2378227515315e7fc0bd0844a1dc4f85e54b455a Gerrit-Change-Number: 39041 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in libosmo-abis[master]: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email ) Change subject: ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif ...................................................................... ipaccess: Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719 Related: OS#5896 Depends: libosmo-netif.git Change-Id I5c36e06e0dc29ec4679b20ad6c426f051b659acd --- M TODO-RELEASE M include/osmocom/abis/e1_input.h M src/input/ipaccess.c 3 files changed, 43 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/39042/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index bcd3c56..4cf9cea 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -12,3 +12,4 @@ libosmo-netif >1.5.0 use osmo_stream_cli_set_priority(), osmo_stream_cli_set_ip_dscp() libosmocore >1.10.0 bigger iofd tx_queue.max_length default value libosmo-abis API break Remove ipaccess_fd_cb() +libosmo-netif >1.5.1 osmo_ipa_ka_fsm_inst APIs diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index 13008f8..c3f7da9 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -9,6 +9,7 @@ #include <osmocom/core/timer.h> #include <osmocom/core/msgb.h> #include <osmocom/core/select.h> +#include <osmocom/netif/ipa.h> #include <osmocom/gsm/i460_mux.h> #include <osmocom/abis/subchan_demux.h> #include <osmocom/abis/lapd.h> @@ -130,7 +131,7 @@ /* ip.access driver has one fd for each ts */ struct osmo_fd fd; /* ipa keep-alive */ - struct osmo_fsm_inst *ka_fsm; + struct osmo_ipa_ka_fsm_inst *ka_fsm; } ipaccess; struct { /* DAHDI driver has one fd for each ts */ diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index c47c6fb..d2b8fe8 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -80,52 +80,58 @@ static inline void ipaccess_keepalive_fsm_cleanup(struct e1inp_ts *e1i_ts) { - struct osmo_fsm_inst *ka_fsm; + struct osmo_ipa_ka_fsm_inst *ka_fsm; ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; if (ka_fsm) { - osmo_fsm_inst_term(ka_fsm, OSMO_FSM_TERM_REQUEST, NULL); e1i_ts->driver.ipaccess.ka_fsm = NULL; + osmo_ipa_ka_fsm_stop(ka_fsm); + osmo_ipa_ka_fsm_free(ka_fsm); } } -static void ipa_bsc_keepalive_write_server_cb(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg) +static int ipa_bsc_keepalive_send_cb(struct osmo_ipa_ka_fsm_inst *ka_fi, struct msgb *msg) { - struct osmo_stream_srv *srv = (struct osmo_stream_srv *)conn; + struct osmo_stream_srv *srv = osmo_ipa_ka_fsm_get_data(ka_fi); osmo_stream_srv_send(srv, msg); + return 0; } -static int ipa_bsc_keepalive_timeout_cb(struct osmo_fsm_inst *fi, void *data) +static int ipa_bsc_keepalive_timeout_cb(struct osmo_ipa_ka_fsm_inst *ka_fi) { - struct osmo_stream_srv *srv = (struct osmo_stream_srv *)data; + struct osmo_stream_srv *srv = osmo_ipa_ka_fsm_get_data(ka_fi); osmo_stream_srv_destroy(srv); - return 1; + return 0; } static void ipaccess_bsc_keepalive_fsm_alloc(struct e1inp_ts *e1i_ts, struct osmo_stream_srv *conn, const char *id) { struct e1inp_line *line = e1i_ts->line; - struct osmo_fsm_inst *ka_fsm; + struct osmo_ipa_ka_fsm_inst *ka_fsm; ipaccess_keepalive_fsm_cleanup(e1i_ts); if (!line->ipa_kap) return; - ka_fsm = ipa_generic_conn_alloc_keepalive_fsm(conn, conn, line->ipa_kap, id); + ka_fsm = osmo_ipa_ka_fsm_alloc(conn, id); e1i_ts->driver.ipaccess.ka_fsm = ka_fsm; if (!ka_fsm) { LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "Failed to allocate IPA keepalive FSM\n"); return; } - - ipa_keepalive_fsm_set_timeout_cb(ka_fsm, ipa_bsc_keepalive_timeout_cb); - ipa_keepalive_fsm_set_send_cb(ka_fsm, ipa_bsc_keepalive_write_server_cb); - ipa_keepalive_fsm_start(ka_fsm); + osmo_ipa_ka_fsm_set_ping_interval(ka_fsm, line->ipa_kap->interval); + osmo_ipa_ka_fsm_set_pong_timeout(ka_fsm, line->ipa_kap->wait_for_resp); + osmo_ipa_ka_fsm_set_data(ka_fsm, conn); + osmo_ipa_ka_fsm_set_send_cb(ka_fsm, ipa_bsc_keepalive_send_cb); + osmo_ipa_ka_fsm_set_timeout_cb(ka_fsm, ipa_bsc_keepalive_timeout_cb); + osmo_ipa_ka_fsm_start(ka_fsm); } -static void ipa_bts_keepalive_write_client_cb(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg) { - struct osmo_stream_cli *cli = (struct osmo_stream_cli *)conn; +static int ipa_bts_keepalive_send_cb(struct osmo_ipa_ka_fsm_inst *ka_fi, struct msgb *msg) +{ + struct osmo_stream_cli *cli = osmo_ipa_ka_fsm_get_data(ka_fi); osmo_stream_cli_send(cli, msg); + return 0; } static void _ipaccess_bts_down_cb(struct osmo_stream_cli *cli) @@ -138,30 +144,33 @@ line->ops->sign_link_down(line); } -static int ipa_bts_keepalive_timeout_cb(struct osmo_fsm_inst *fi, void *conn) { - struct osmo_stream_cli *cli = (struct osmo_stream_cli *)conn; +static int ipa_bts_keepalive_timeout_cb(struct osmo_ipa_ka_fsm_inst *ka_fi) +{ + struct osmo_stream_cli *cli = osmo_ipa_ka_fsm_get_data(ka_fi); _ipaccess_bts_down_cb(cli); - return 1; + return 0; } static void ipaccess_bts_keepalive_fsm_alloc(struct e1inp_ts *e1i_ts, struct osmo_stream_cli *client, const char *id) { struct e1inp_line *line = e1i_ts->line; - struct osmo_fsm_inst *ka_fsm; + struct osmo_ipa_ka_fsm_inst *ka_fsm; OSMO_ASSERT(e1i_ts->driver.ipaccess.ka_fsm == NULL); if (!line->ipa_kap) return; - ka_fsm = ipa_generic_conn_alloc_keepalive_fsm(client, client, line->ipa_kap, id); + ka_fsm = osmo_ipa_ka_fsm_alloc(client, id); e1i_ts->driver.ipaccess.ka_fsm = ka_fsm; if (!ka_fsm) { LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "Failed to allocate IPA keepalive FSM\n"); return; } - - ipa_keepalive_fsm_set_timeout_cb(ka_fsm, ipa_bts_keepalive_timeout_cb); - ipa_keepalive_fsm_set_send_cb(ka_fsm, ipa_bts_keepalive_write_client_cb); + osmo_ipa_ka_fsm_set_ping_interval(ka_fsm, line->ipa_kap->interval); + osmo_ipa_ka_fsm_set_pong_timeout(ka_fsm, line->ipa_kap->wait_for_resp); + osmo_ipa_ka_fsm_set_data(ka_fsm, client); + osmo_ipa_ka_fsm_set_send_cb(ka_fsm, ipa_bts_keepalive_send_cb); + osmo_ipa_ka_fsm_set_timeout_cb(ka_fsm, ipa_bts_keepalive_timeout_cb); } /* See how ts->num is assigned in e1inp_line_create: line->ts[i].num = i+1; @@ -224,12 +233,12 @@ struct e1inp_sign_link *sign_link; char *unitid; int len, ret; - struct osmo_fsm_inst *ka_fsm; + struct osmo_ipa_ka_fsm_inst *ka_fsm; /* peek the pong for our keepalive fsm */ ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; if (ka_fsm && msg_type == IPAC_MSGT_PONG) - ipa_keepalive_fsm_pong_received(ka_fsm); + osmo_ipa_ka_fsm_pong_received(ka_fsm); /* Handle IPA PING, PONG and ID_ACK messages. */ ret = ipa_ccm_rcvmsg_base(msg, bfd); @@ -364,13 +373,13 @@ struct e1inp_ts *e1i_ts = sign_link->ts; struct osmo_fd *bfd = &e1i_ts->driver.ipaccess.fd; struct e1inp_line *line = e1i_ts->line; - struct osmo_fsm_inst *ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; + struct osmo_ipa_ka_fsm_inst *ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; struct osmo_stream_cli *cli; struct osmo_stream_srv *conn; /* depending on caller the fsm might be dead */ if (ka_fsm) - ipa_keepalive_fsm_stop(ka_fsm); + osmo_ipa_ka_fsm_stop(ka_fsm); e1inp_int_snd_event(e1i_ts, sign_link, S_L_INP_TEI_DN); /* the first e1inp_sign_link_destroy call closes the socket. */ @@ -804,8 +813,8 @@ /* peek the pong for our keepalive fsm */ if (line && msg_type == IPAC_MSGT_PONG) { - struct osmo_fsm_inst *ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; - ipa_keepalive_fsm_pong_received(ka_fsm); + struct osmo_ipa_ka_fsm_inst *ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; + osmo_ipa_ka_fsm_pong_received(ka_fsm); } /* ping, pong and acknowledgment cases. */ @@ -922,11 +931,11 @@ { struct e1inp_ts *e1i_ts = osmo_stream_cli_get_data(cli); struct e1inp_line *line = e1i_ts->line; - struct osmo_fsm_inst *ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; + struct osmo_ipa_ka_fsm_inst *ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; update_fd_settings(line, osmo_stream_cli_get_fd(cli)); if (ka_fsm && line->ipa_kap) - ipa_keepalive_fsm_start(ka_fsm); + osmo_ipa_ka_fsm_start(ka_fsm); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39042?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I6164a44847fcd88d08c77f977d928c2fdf657719 Gerrit-Change-Number: 39042 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-abis[master]: WIP: input: Get rid of abis/ipa.h dependency in e1_input.h and ipacce...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39043?usp=email ) Change subject: WIP: input: Get rid of abis/ipa.h dependency in e1_input.h and ipaccess.c ...................................................................... WIP: input: Get rid of abis/ipa.h dependency in e1_input.h and ipaccess.c abis/ipa.h will eventually be deprecated. The only current use of abis/ipa.h in libosmo-abis itself is the struct struct ipa_keepalive_params. TODO: Since it's a pointer in abis/ipa.h, it can be moved to a seprate internal header and use it internally. Change-Id: I4efb11ae44c28c4f56f71f5797966f6106493f2b --- M include/osmocom/abis/e1_input.h M src/input/ipaccess.c 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/43/39043/1 diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index c3f7da9..66985ea 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -40,6 +40,7 @@ E1I_CTR_REMOVED, }; +struct ipa_keepalive_params; struct e1inp_ts; struct vty; diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index d2b8fe8..62dc43c 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -54,7 +54,6 @@ #include <osmocom/netif/stream.h> #include <osmocom/netif/ipa.h> #include <osmocom/abis/e1_input.h> -#include <osmocom/abis/ipa.h> /* global parameters of IPA input driver */ struct ipa_pars g_e1inp_ipaccess_pars; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4efb11ae44c28c4f56f71f5797966f6106493f2b Gerrit-Change-Number: 39043 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-remsim[master]: rspro: use osmo_stream to handle IPA connection

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: rspro: use osmo_stream to handle IPA connection ...................................................................... rspro: use osmo_stream to handle IPA connection libosmo-abis is still needed since we are still using ipa_keepalive_fsm from there. This needs to be imported here or moved to libosmo-netif. Related: OS#5896 Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a --- M configure.ac M debian/control M src/Makefile.am M src/bankd/Makefile.am M src/bankd/bankd_main.c M src/client/Makefile.am M src/rspro_client_fsm.c M src/rspro_client_fsm.h M src/server/Makefile.am 9 files changed, 147 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/23/39023/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a Gerrit-Change-Number: 39023 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

6 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: README.md update / re-wording

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39040?usp=email ) Change subject: README.md update / re-wording ...................................................................... README.md update / re-wording Let's give a better description of what the project is all about, and differentiate reading/exploring any SIM from writing/updating a special programmable one where you know the ADM credentials. Change-Id: Ied2a9626594e9735d92d4eabe6c6b90f92aa2909 --- M README.md 1 file changed, 21 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/README.md b/README.md index 2c7a6c8..8773356 100644 --- a/README.md +++ b/README.md @@ -1,16 +1,29 @@ -pySim - Read, Write and Browse Programmable SIM/USIM/ISIM/HPSIM Cards -===================================================================== +pySim - Tools for reading, decoding, browsing SIM/USIM/ISIM/HPSIM/eUICC Cards +============================================================================= -This repository contains a number of Python programs that can be used -to read, program (write) and browse all fields/parameters/files on -SIM/USIM/ISIM/HPSIM cards used in 3GPP cellular networks from 2G to 5G. +This repository contains a number of Python programs related to working with +subscriber identity modules of cellular networks, including but not limited +to SIM, UICC, USIM, ISIM, HPSIMs and eUICCs. + +* `pySim-shell.py` can be used to interactively explore, read and decode contents + of any of the supported card models / card applications. Furthermore, if + you have the credentials to your card (ADM PIN), you can also write to the card, + i.e. edit its contents. +* `pySim-read.py` and `pySim-prog.py` are _legacy_ tools for batch programming + some very common parameters to an entire batch of programmable cards +* `pySim-trace.py` is a tool to do an in-depth decode of SIM card protocol traces + such as those obtained by [Osmocom SIMtrace2](https://osmocom.org/projects/simtrace2/wiki) + or [osmo-qcdiag](https://osmocom.org/projects/osmo-qcdiag/wiki). +* `osmo-smdpp.py` is a proof-of-concept GSMA SGP.22 Consumer eSIM SM-DP+ for lab/research +* there are more related tools, particularly in the `contrib` directory. Note that the access control configuration of normal production cards issue by operators will restrict significantly which files a normal user can read, and particularly write to. The full functionality of pySim hence can only be used with on so-called -programmable SIM/USIM/ISIM/HPSIM cards. +programmable SIM/USIM/ISIM/HPSIM cards, such as the various +[sysmocom programmable card products](https://shop.sysmocom.de/SIM/). Such SIM/USIM/ISIM/HPSIM cards are special cards, which - unlike those issued by regular commercial operators - come with the kind of keys that @@ -49,9 +62,9 @@ ---------------------------- While you will find a lot of online resources still describing the use of -pySim-prog.py and pySim-read.py, those tools are considered legacy by +`pySim-prog.py` and `pySim-read.py`, those tools are considered legacy by now and have by far been superseded by the much more capable -pySim-shell. We strongly encourage users to adopt pySim-shell, unless +`pySim-shell.py`. We strongly encourage users to adopt pySim-shell, unless they have very specific requirements like batch programming of large quantities of cards, which is about the only remaining use case for the legacy tools. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied2a9626594e9735d92d4eabe6c6b90f92aa2909 Gerrit-Change-Number: 39040 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

6 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: README.md update / re-wording

by laforge

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/39040?usp=email ) Change subject: README.md update / re-wording ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied2a9626594e9735d92d4eabe6c6b90f92aa2909 Gerrit-Change-Number: 39040 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 05 Dec 2024 17:15:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: assign random TEID-C to Context Req/Resp/Ack messages

by fixeria

Attention is currently required from: daniel, lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email ) Change subject: SGSN: assign random TEID-C to Context Req/Resp/Ack messages ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icac28280a810e8d24eeeaaae1fb1a15278fde8da Gerrit-Change-Number: 38921 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Dec 2024 17:02:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: Context Req In: use correct TEID-C

by fixeria

Attention is currently required from: daniel, lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920?usp=email ) Change subject: SGSN: Context Req In: use correct TEID-C ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I84dc7dda8ee1227edd68d1482a4c5bf267c16418 Gerrit-Change-Number: 38920 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Dec 2024 17:01:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...

by fixeria

Attention is currently required from: laforge, lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 7: Code-Review+2 (1 comment) File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/84bda002_7d18… : PS4, Line 358: as_gmm_auth > Thanks for explaining and sorry for not responding earlier. I understand the difference now. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Dec 2024 17:00:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024