December 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email ) Change subject: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/39062/comment/50ce3f2c_2a65572d?… : PS1, Line 7: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. > I'll improve the commit message more. Done https://gerrit.osmocom.org/c/libosmocore/+/39062/comment/e6c94296_edad1504?… : PS1, Line 9: SNS Add can't fail with Unknown IP Endpoint. > not sure what you mean here and the relation to the patch. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d Gerrit-Change-Number: 39062 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 18:02:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.

by lynxis lazus

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email to look at the new patch set (#2). Change subject: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. ...................................................................... Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. The List of IP4/6 Elements should be only present on a SNS Ack if the procedure fails with cause code Unknown IP Endpoint. However ns2 code appended the List always to the SNS Ack. Remove List of IP4/6 Elements from SNS Add, it can't fail with Unknown IP Endpoint. Remove List of IP4/6 Elements from SNS Change Weight success case. Related: OS#6611 Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d --- M src/gb/gprs_ns2_sns.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/39062/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d Gerrit-Change-Number: 39062 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: bankd: Add -T and -e cmdline params

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email ) Change subject: bankd: Add -T and -e cmdline params ...................................................................... bankd: Add -T and -e cmdline params Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf --- M src/bankd/bankd_main.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/34/39134/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index a7e02b3..d96d49c 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -303,6 +303,8 @@ " -g --gsmtap-ip A.B.C.D Enable GSMTAP and send APDU traces to given IP\n" " -G --gsmtap-slot <0-1023> Limit tracing to given bank slot, only (default: all slots)\n" " -L --disable-color Disable colors for logging to stderr\n" +" -T --timestamp Prefix every log line with a timestamp\n" +" -e --log-level number Set a global loglevel.\n" ); } @@ -328,10 +330,12 @@ { "gsmtap-ip", 1, 0, 'g' }, { "gsmtap-slot", 1, 0, 'G' }, { "disable-color", 0, 0, 'L' }, + { "timestamp", 0, 0, 'T' }, + { "log-level", 1, 0, 'e' }, { 0, 0, 0, 0 } }; - c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:L", long_options, &option_index); + c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:LTe:", long_options, &option_index); if (c == -1) break; @@ -380,6 +384,12 @@ case 'L': log_set_use_color(osmo_stderr_target, 0); break; + case 'T': + log_set_print_timestamp(osmo_stderr_target, 1); + break; + case 'e': + log_set_log_level(osmo_stderr_target, atoi(optarg)); + break; } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf Gerrit-Change-Number: 39134 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: remsim: Enable debug output of bankd

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email ) Change subject: remsim: Enable debug output of bankd ...................................................................... remsim: Enable debug output of bankd Change-Id: Idc1ed4b9419735170cac92916073757da01691ed --- M remsim/testenv_bankd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/39133/1 diff --git a/remsim/testenv_bankd.cfg b/remsim/testenv_bankd.cfg index 04baeaf..62ac07b 100644 --- a/remsim/testenv_bankd.cfg +++ b/remsim/testenv_bankd.cfg @@ -8,7 +8,7 @@ package=pcscd [bankd] -program=osmo-remsim-bankd -d DMAIN:1 -i 127.0.0.10 -I 127.0.0.30 +program=osmo-remsim-bankd -d DMAIN,1:DST2,1:DRSPRO,1:DREST,1:DSLOTMAP,1:DBANKDW,1:DGSMTAP,1:DLINP,1 -i 127.0.0.10 -I 127.0.0.30 make=osmo-remsim package=osmo-remsim-bankd copy=bankd/bankd_pcsc_slots.csv -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc1ed4b9419735170cac92916073757da01691ed Gerrit-Change-Number: 39133 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: Several logging improvements

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email ) Change subject: Several logging improvements ...................................................................... Several logging improvements Improve logging in several places which proved to be usfeful while analyzing behavior of the program. Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0 --- M src/bankd/bankd_main.c M src/rspro_client_fsm.c M src/server/rspro_server.c 3 files changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/32/39132/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index cd68073..a7e02b3 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -420,12 +420,15 @@ signal(SIGMAPADD, handle_sig_mapadd); signal(SIGUSR1, handle_sig_usr1); + LOGP(DMAIN, LOGL_INFO, "Reading PCSC slots...\n"); /* Np lock or mutex required for the pcsc_slot_names list, as this is only * read once during bankd initialization, when the worker threads haven't * started yet */ rc = bankd_pcsc_read_slotnames(g_bankd, "bankd_pcsc_slots.csv"); - if (rc) + if (rc) { + fprintf(stderr, "ERROR: reading PCSC slots\n"); exit(1); + } /* Connection towards remsim-server */ rc = server_conn_fsm_alloc(g_bankd, srvc); @@ -436,6 +439,8 @@ osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_ESTABLISH, NULL); /* create listening socket for inbound client connections */ + LOGP(DMAIN, LOGL_INFO, "Initiating listen TCP socket at %s:%d\n", + g_bind_ip ? g_bind_ip : "INADDR_ANY", g_bind_port); rc = osmo_sock_init(AF_INET, SOCK_STREAM, IPPROTO_TCP, g_bind_ip, g_bind_port, OSMO_SOCK_F_BIND); if (rc < 0) { fprintf(stderr, "Unable to create TCP socket at %s:%d: %s\n", @@ -446,6 +451,7 @@ /* initialize gsmtap, if required */ if (g_bankd->cfg.gsmtap_host) { + LOGP(DMAIN, LOGL_INFO, "Initiating GSMTAP\n"); rc = bankd_gsmtap_init(g_bankd->cfg.gsmtap_host); if (rc < 0) { fprintf(stderr, "Unable to open GSMTAP\n"); @@ -456,6 +462,7 @@ /* create worker threads: One per reader/slot! */ for (i = 0; i < g_bankd->srvc.bankd.num_slots; i++) { struct bankd_worker *w; + LOGP(DMAIN, LOGL_INFO, "Initiating worker %d\n", i); w = bankd_create_worker(g_bankd, i); if (!w) { fprintf(stderr, "Error creating bankd worker thread\n"); @@ -463,12 +470,10 @@ } } - while (1) { - if (terminate) - break; + while (!terminate) { osmo_select_main(0); } - + LOGP(DMAIN, LOGL_NOTICE, "Terminated\n"); talloc_free(g_bankd); exit(0); } diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 03dbe15..d847f3b 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -502,6 +502,7 @@ osmo_stream_cli_destroy(srvc->conn); srvc->conn = NULL; err_exit: + LOGPFSML(fi, LOGL_FATAL, "exit(1)\n"); exit(1); } diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 0936238..77b727e 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -780,6 +780,8 @@ static int ipa_keepalive_send_cb(struct osmo_ipa_ka_fsm_inst *ka_fi, struct msgb *msg, void *data) { struct osmo_stream_srv *srv = data; + struct rspro_client_conn *conn = osmo_stream_srv_get_data(srv); + LOGPFSML(conn->fi, LOGL_INFO, "Tx IPA PING\n"); osmo_stream_srv_send(srv, msg); return 0; } @@ -788,6 +790,7 @@ { struct osmo_stream_srv *peer = data; struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); + LOGPFSML(conn->fi, LOGL_NOTICE, "IPA PONG Timeout\n"); osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_KA_TIMEOUT, NULL); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0 Gerrit-Change-Number: 39132 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: rspro_client_fsm: Fix missing return

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email ) Change subject: rspro_client_fsm: Fix missing return ...................................................................... rspro_client_fsm: Fix missing return Recent commit added error return code paths through goto labels at the end, but forgot to add a return statement to avoid running onto them during normal code flow. Fixes: 8cfe1d808a57a0a877e934e0435651a6b792db8d Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 29e0287..6a48ce4 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -493,6 +493,7 @@ /* FIXME: retry? Timer? Abort? */ goto err_free_ka_fi; } + return; err_free_ka_fi: osmo_ipa_ka_fsm_free(srvc->ka_fi); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc Gerrit-Change-Number: 39131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: rspro_client_fsm: Fix missing return

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email ) Change subject: rspro_client_fsm: Fix missing return ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Merging this to get bankd ttcn3 tests to work again. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc Gerrit-Change-Number: 39131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 17:49:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: rspro_client_fsm: Fix missing return

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email ) Change subject: rspro_client_fsm: Fix missing return ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc Gerrit-Change-Number: 39131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 17:48:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: rspro_client_fsm: Fix missing return

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email ) Change subject: rspro_client_fsm: Fix missing return ...................................................................... rspro_client_fsm: Fix missing return Recent commit added error return code paths through goto labels at the end, but forgot to add a return statement to avoid running onto them during normal code flow. Fixes: 8cfe1d808a57a0a877e934e0435651a6b792db8d Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/31/39131/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 29e0287..6a48ce4 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -493,6 +493,7 @@ /* FIXME: retry? Timer? Abort? */ goto err_free_ka_fi; } + return; err_free_ka_fi: osmo_ipa_ka_fsm_free(srvc->ka_fi); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I813432d42135b5f3f086ad93bd63bfa39f4becbc Gerrit-Change-Number: 39131 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: cosmetic: rspro_client_fsm: Document event handled in all_state

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39130?usp=email ) Change subject: cosmetic: rspro_client_fsm: Document event handled in all_state ...................................................................... cosmetic: rspro_client_fsm: Document event handled in all_state Change-Id: Id03be7d67bb2530bbefb2a886a175f9a4a4d3cd8 --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/30/39130/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 29e0287..868d2ab 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -321,7 +321,7 @@ static void srvc_st_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) { switch (event) { - case SRVC_E_ESTABLISH: + case SRVC_E_ESTABLISH: /* Handled in all_state */ default: OSMO_ASSERT(0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id03be7d67bb2530bbefb2a886a175f9a4a4d3cd8 Gerrit-Change-Number: 39130 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024