December 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Allow client to trigger SCCP CC if automatic CC was di...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39120?usp=email ) Change subject: RAN_Emulation: Allow client to trigger SCCP CC if automatic CC was disabled ...................................................................... RAN_Emulation: Allow client to trigger SCCP CC if automatic CC was disabled This allows users of RAN_Emulation to trigger events in between CR transmited and CC being receied at the IUT. Change-Id: I117c8fde118b488b011e381d51eed378d2f3ff0e --- M library/RAN_Emulation.ttcnpp 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index 5eb14de..294954d 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -72,6 +72,10 @@ port RAN_PROC_PT BSSAP_PROC; } +/* we tell SCCP that connection (rx CR) was confirmed (tx CC) */ +type record MSC_CONN_PRIM_CONNECT_RES { +}; + /* SCCP tell us that connection was released */ type record MSC_CONN_PRIM_DISC_IND { }; @@ -87,11 +91,19 @@ /* Auxiliary primitive that can happen on the port between per-connection client and this dispatcher */ type union RAN_Conn_Prim { + MSC_CONN_PRIM_CONNECT_RES connect_res, MSC_CONN_PRIM_DISC_IND disc_ind, MSC_CONN_PRIM_DISC_REQ disc_req, MSC_CONN_PRIM_CONF_IND conf_ind } +template (present) RAN_Conn_Prim tr_MSC_CONN_PRIM_CONNECT_RES := { + connect_res := ? +} +template (value) RAN_Conn_Prim ts_MSC_CONN_PRIM_CONNECT_RES := { + connect_res := {} +} + template (present) RAN_Conn_Prim tr_MSC_CONN_PRIM_DISC_IND := { disc_ind := ? } @@ -1113,6 +1125,13 @@ RANAP.send(ranap_ud); } + /* Connect Confirm client -> SCCP */ + [] CLIENT.receive(tr_MSC_CONN_PRIM_CONNECT_RES) -> value ran_conn_prim sender vc_conn { + var integer conn_id := f_conn_id_by_comp(vc_conn); + /* confirm connection establishment */ + RANAP.send(ts_RANAP_CONNECT_res(conn_id, omit)); + } + /* Disconnect request client -> SCCP */ [] CLIENT.receive(tr_MSC_CONN_PRIM_DISC_REQ) -> value ran_conn_prim sender vc_conn { var integer conn_id := f_conn_id_by_comp(vc_conn); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I117c8fde118b488b011e381d51eed378d2f3ff0e Gerrit-Change-Number: 39120 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: Fix template restriction in template param

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39122?usp=email ) Change subject: hnbgw: Fix template restriction in template param ...................................................................... hnbgw: Fix template restriction in template param Change-Id: I946f21f6d662d889095199c268d2586aea55c821 --- M hnbgw/ConnHdlr.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 44e4cce..dec5463 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -399,7 +399,7 @@ } /* send RANAP on Iuh and expect it to show up on Iu */ -function f_iuh2iu_connect(template (present) RANAP_PDU tx, template RANAP_PDU exp_rx := omit) +function f_iuh2iu_connect(template (value) RANAP_PDU tx, template RANAP_PDU exp_rx := omit) runs on ConnHdlr return RANAP_PDU { var RANAP_PDU rx; timer T := 5.0; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I946f21f6d662d889095199c268d2586aea55c821 Gerrit-Change-Number: 39122 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_{cs,ps}_rua_disconnect_during_sccp_cr_cc

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39121?usp=email ) Change subject: hnbgw: Introduce test TC_{cs,ps}_rua_disconnect_during_sccp_cr_cc ...................................................................... hnbgw: Introduce test TC_{cs,ps}_rua_disconnect_during_sccp_cr_cc Related: SYS#7208 Change-Id: Ie4fe4aaf77017f7191cf000331e452cded56cf25 --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 45 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index ab6a09e..939a608 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1429,6 +1429,46 @@ f_tc_ranap_creq_cref(8, true); } +/* scenario: HNB transmits RUA Disconnect while conn is still being established + * on SCCP side (HNBGW sent CR, waiting for CC from CN). */ +private function f_tc_rua_disconnect_during_sccp_cr_cc(charstring id) runs on ConnHdlr { + /* HNB->MSC: InitialUE */ + f_iuh2iu_connect(f_build_initial_ue(g_pars)); + + /* CREQ was received at CN, now HNB decides to disconnect the RUA conn: */ + RUA.send(RUA_Disc_Req:{{misc:=unspecified}, omit}); + + /* Let some time for RUA Disconnect to reach the HNBGW: */ + f_sleep(1.0); + + /* Now tx SCCP CC from CN to HNBGW: */ + BSSAP.send(ts_MSC_CONN_PRIM_CONNECT_RES); + + /* now that SCCP conn is connected, HNBGW should tear it down because the RUA conn was released in previous step: */ + BSSAP.receive(tr_MSC_CONN_PRIM_DISC_IND); + /* Let RAN_Emulation some time to answer RLSD with RLC: */ + f_sleep(1.0); +} +private function f_TC_rua_disconnect_during_sccp_cr_cc(boolean is_ps) runs on test_CT { + var ConnHdlr vc_conn; + g_num_hnbs := 1; + /* Instruct RAN_Emulation to avoid accepting the conn, we'll trigger an + * SCCP CREF by sending a DISC REQ primitive in ConnHdlr. */ + g_ran_ops.ranap_connect_ind_auto_res := false; + f_init(); + + vc_conn := f_start_handler_with_pars(refers(f_tc_rua_disconnect_during_sccp_cr_cc), f_TestHdlrParams(6, is_ps)); + vc_conn.done; + + f_shutdown_helper(); +} +testcase TC_cs_rua_disconnect_during_sccp_cr_cc() runs on test_CT { + f_TC_rua_disconnect_during_sccp_cr_cc(false); +} +testcase TC_ps_rua_disconnect_during_sccp_cr_cc() runs on test_CT { + f_TC_rua_disconnect_during_sccp_cr_cc(true); +} + /* Scenario: HNB tears down the RUA/Iu conn by first sending RUA_DATA[RANAP * IuReleaseReq], followed shortly by a RUA Disconnect with no RANAP and * Cause!=Normal. HNBGW should release the SCCP connection through RLSD since it's @@ -2450,6 +2490,8 @@ execute(TC_ranap_ps_mo_disconnect()); execute(TC_ranap_cs_creq_cref()); execute(TC_ranap_ps_creq_cref()); + execute(TC_ps_rua_disconnect_during_sccp_cr_cc()); + execute(TC_cs_rua_disconnect_during_sccp_cr_cc()); execute(TC_cs_iu_release_req_rua_disconnect()); execute(TC_ps_iu_release_req_rua_disconnect()); execute(TC_ps_rab_assignment()); diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index ad5a0f5..655db84 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='56' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='58' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='HNBGW_Tests' name='TC_hnb_register' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate_reuse_sctp_assoc' time='MASKED'/> @@ -25,6 +25,8 @@ <testcase classname='HNBGW_Tests' name='TC_ranap_ps_mo_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_cs_creq_cref' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_creq_cref' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ps_rua_disconnect_during_sccp_cr_cc' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_cs_rua_disconnect_during_sccp_cr_cc' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_cs_iu_release_req_rua_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_iu_release_req_rua_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4fe4aaf77017f7191cf000331e452cded56cf25 Gerrit-Change-Number: 39121 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: Fix template restriction in template param

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39122?usp=email ) Change subject: hnbgw: Fix template restriction in template param ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I946f21f6d662d889095199c268d2586aea55c821 Gerrit-Change-Number: 39122 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 14:03:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_{cs,ps}_rua_disconnect_during_sccp_cr_cc

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39121?usp=email ) Change subject: hnbgw: Introduce test TC_{cs,ps}_rua_disconnect_during_sccp_cr_cc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4fe4aaf77017f7191cf000331e452cded56cf25 Gerrit-Change-Number: 39121 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 14:03:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Allow client to trigger SCCP CC if automatic CC was di...

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39120?usp=email ) Change subject: RAN_Emulation: Allow client to trigger SCCP CC if automatic CC was disabled ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I117c8fde118b488b011e381d51eed378d2f3ff0e Gerrit-Change-Number: 39120 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 14:03:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Allow client to trigger SCCP CC if automatic CC was di...

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39120?usp=email ) Change subject: RAN_Emulation: Allow client to trigger SCCP CC if automatic CC was disabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I117c8fde118b488b011e381d51eed378d2f3ff0e Gerrit-Change-Number: 39120 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 13:55:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-hnbgw[master]: map_sccp: Fix crash during ev MAP_SCCP_EV_RAN_DISC in st MAP_SCCP_ST_...

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39119?usp=email ) Change subject: map_sccp: Fix crash during ev MAP_SCCP_EV_RAN_DISC in st MAP_SCCP_ST_WAIT_CC ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If53dbd6b5a8abffcf94e6d666209954f17e9f9d7 Gerrit-Change-Number: 39119 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 13:52:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sccp: Initial testenv

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123?usp=email ) Change subject: sccp: Initial testenv ...................................................................... Patch Set 1: (1 comment) File sccp/testenv.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123/comment/8824e802_5c08… : PS1, Line 6: program=~/.cache/osmo-ttcn3-testenv/podman/make/libosmo-sigtran/examples/.libs/sccp_demo_user -l 127.0.0.2 -r 127.0.0.1 -C sccp_demo_user.cfg > this will need to be adjusted, so it works the following too: […] Yeah this was a quick work so I can at least run with my git repos quickly. Feel free to take over. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I616425d729dda342e78537c6b7256d5dddebaa88 Gerrit-Change-Number: 39123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 13:48:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sccp: Initial testenv

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123?usp=email ) Change subject: sccp: Initial testenv ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File sccp/testenv.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123/comment/d4ce8a8e_728d… : PS1, Line 6: program=~/.cache/osmo-ttcn3-testenv/podman/make/libosmo-sigtran/examples/.libs/sccp_demo_user -l 127.0.0.2 -r 127.0.0.1 -C sccp_demo_user.cfg this will need to be adjusted, so it works the following too: * without podman * with --binary-repo but I can do that in a follow-up patch, having this as initial version is fine IMHO -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I616425d729dda342e78537c6b7256d5dddebaa88 Gerrit-Change-Number: 39123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Dec 2024 13:46:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024