Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: ttcn3-remsim: Enable debug output of bankd
......................................................................
ttcn3-remsim: Enable debug output of bankd
Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e
---
M ttcn3-remsim-test/jenkins.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/39129/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e
Gerrit-Change-Number: 39129
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39127?usp=email )
Change subject: testenv: Log return code of unexpected end of process
......................................................................
testenv: Log return code of unexpected end of process
This providing further information, for instance if the process actually
exited due to a signal (rc < 0) or due to exiting on its own (rc >= 0).
While at it, rewrite the log line since a process exiting doesn't
necessarily mean it crashed.
Change-Id: I7bbee6ad8e114eeb1ef348184158230b53d0f3cf
---
M _testenv/testenv/daemons.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/39127/1
diff --git a/_testenv/testenv/daemons.py b/_testenv/testenv/daemons.py
index 86f3979..da8248e 100644
--- a/_testenv/testenv/daemons.py
+++ b/_testenv/testenv/daemons.py
@@ -107,9 +107,11 @@
def check_if_crashed():
crashed = False
+ returncode = None
for daemon_name, daemon_proc in daemons.items():
if not testenv.testsuite.is_running(daemon_proc.pid):
crashed = True
+ returncode = daemon_proc.poll()
break
if not crashed:
return
@@ -118,10 +120,10 @@
testenv.coredump.get_from_coredumpctl()
if current_test:
- logging.error(f"{daemon_name} crashed during {current_test}!")
+ logging.error(f"{daemon_name} unexpected exit during {current_test}! rc={returncode}")
testenv.testsuite.wait_until_test_stopped()
else:
- logging.error(f"{daemon_name} crashed!")
+ logging.error(f"{daemon_name} unexpected exit! rc={returncode}")
sys.exit(1)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39127?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7bbee6ad8e114eeb1ef348184158230b53d0f3cf
Gerrit-Change-Number: 39127
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email )
Change subject: Bump version: 0.1.1.112-9c90 → 0.2.0
......................................................................
Patch Set 1:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/osmo-upf/+/39125/comment/8754ee15_bf504962?usp… :
PS1, Line 40: 10
> do we need those large jumps? I didn't see any TODO-RELEASE items requiring any update of libosmocor […]
With libosmocore 1.6.0 and libosmo-pfcp 0.1.0 as previously in configure.ac, libosmo-pfcp failed to build due to DLPFCP not being defined. I've bumped it to libosmocore 1.7.0 first, but then the build failed due to osmo_gtlvs_decode not being available (also used in libosmo-pfcp).
I figured it would be easiest to just bump to latest versions instead, where it builds for sure.
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I772edbd17fcac0da597c30eecefa54f9fd8c3ed3
Gerrit-Change-Number: 39125
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 11 Dec 2024 16:16:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: osmith.
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email )
Change subject: Bump version: 0.1.1.112-9c90 → 0.2.0
......................................................................
Patch Set 1:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/osmo-upf/+/39125/comment/1c3062fc_b226cfcf?usp… :
PS1, Line 40: 10
do we need those large jumps? I didn't see any TODO-RELEASE items requiring any update of libosmocore etc?
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39125?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I772edbd17fcac0da597c30eecefa54f9fd8c3ed3
Gerrit-Change-Number: 39125
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Dec 2024 16:07:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email )
Change subject: sccp: Let some time for SCCP RLC to reach IUT before finishing test
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Related to failures spotted in:
https://jenkins.osmocom.org/jenkins/job/ttcn3-sccp-test/1804/
@laforge@osmocom.org since you know better about the Layer Manager in there, please have a quick look at whether it is expected that in sccp_demo_user the release of the only SCTP connection (and hence only used ASP) is not automatically releasing the SCCP-SCOC object, which is at DISCONN_PEND state at the time.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf
Gerrit-Change-Number: 39126
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 11 Dec 2024 16:05:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email )
Change subject: sccp: Let some time for SCCP RLC to reach IUT before finishing test
......................................................................
sccp: Let some time for SCCP RLC to reach IUT before finishing test
Otherwise tear down of the test component immediatelly afterwards
creates a race condition where sometimes the RLC message is not sent
before closing the socket.
As a result, the SCCP-SCOC stays in DISCONN_PEND until T(rel) fires a
while afterwards, generating a new RLSD in a follow-up test, disrupting
expectancies of that unrelated test.
Since sccp_demo_user doesn't implement a Layer Manager, the recv() 0
from the socket doesn't automatically tear down the SCCP conn, since it
could have several ASPs:
"""
0: asp-asp-srv-client: ss7_asp_xua_srv_conn_rx_cb(): sctp_recvmsg() returned 0 (flags=0x80)
...
asp-srv-client: connection closed
XUA_ASP(asp-srv-client){ASP_ACTIVE}: Received Event SCTP-COMM_DOWN.ind
XUA_ASP(asp-srv-client){ASP_ACTIVE}: state_chg to ASP_DOWN
XUA_AS(as-srv-client){AS_ACTIVE}: Received Event ASPAS-ASP_DOWN.ind
XUA_AS(as-srv-client){AS_ACTIVE}: state_chg to AS_PENDING
Delivering N-PCSTATE.indication to SCCP User 'SCCP Management'
Ignoring SCCP user primitive N-PCSTATE.indication
[Here same 2 lines for SCCP User 'refuser', 'echo', 'callback', 'test_client_vty']
XUA_ASP(asp-srv-client){ASP_DOWN}: No Layer Manager, dropping M-ASP_DOWN.indication
XUA_ASP(asp-srv-client){ASP_DOWN}: No Layer Manager, dropping M-SCTP_RELEASE.indication
"""
Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf
---
M sccp/SCCP_Tests_RAW.ttcn
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/39126/1
diff --git a/sccp/SCCP_Tests_RAW.ttcn b/sccp/SCCP_Tests_RAW.ttcn
index f1f602c..5d5b0ab 100644
--- a/sccp/SCCP_Tests_RAW.ttcn
+++ b/sccp/SCCP_Tests_RAW.ttcn
@@ -252,6 +252,8 @@
log("Waiting for RLSD");
f_exp_sccp(tr_SCCP_RLSD(remote_lref, g_own_lref, hex2int('0D'H))); /* Cause: Expiration of Rx Inactivity Timer */
f_send_sccp(ts_SCCP_RLC(g_own_lref, remote_lref));
+ /* Let some time for peer to receive the RLC */
+ f_sleep(1.0);
setverdict(pass);
}
@@ -325,6 +327,8 @@
self.stop;
}
}
+ /* Let some time for peer to receive the RLC */
+ f_sleep(1.0);
}
private function f_tx_xudt_exp(SCCP_PAR_Address calling, SCCP_PAR_Address called, octetstring data) runs on SCCP_Test_RAW_CT {
@@ -521,7 +525,8 @@
var template (present) integer cause := ?;
f_exp_sccp(tr_SCCP_RLSD(remote_lref, g_own_lref, cause));
f_send_sccp(ts_SCCP_RLC(g_own_lref, remote_lref));
-
+ /* Let some time for peer to receive the RLC */
+ f_sleep(1.0);
setverdict(pass);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf
Gerrit-Change-Number: 39126
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>