December 2024 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email ) Change subject: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File src/erab_fsm.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116/comment/78090285_9942… : PS3, Line 78: -type mod_kind() :: setup_rsp | would be far easier to figure out all these values in code if they were prefixed with "mod_kind_" https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116/comment/9f3e13c4_b4db… : PS3, Line 323: ok probably easier to match upon return if you return {ok, undefined}? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I24d57ea390d71b640cb42046a8658e9d30670682 Gerrit-Change-Number: 39116 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 11:47:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: remsim: Enable debug output of bankd

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email ) Change subject: remsim: Enable debug output of bankd ...................................................................... remsim: Enable debug output of bankd Change-Id: Idc1ed4b9419735170cac92916073757da01691ed --- M remsim/testenv_bankd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/remsim/testenv_bankd.cfg b/remsim/testenv_bankd.cfg index 04baeaf..62ac07b 100644 --- a/remsim/testenv_bankd.cfg +++ b/remsim/testenv_bankd.cfg @@ -8,7 +8,7 @@ package=pcscd [bankd] -program=osmo-remsim-bankd -d DMAIN:1 -i 127.0.0.10 -I 127.0.0.30 +program=osmo-remsim-bankd -d DMAIN,1:DST2,1:DRSPRO,1:DREST,1:DSLOTMAP,1:DBANKDW,1:DGSMTAP,1:DLINP,1 -i 127.0.0.10 -I 127.0.0.30 make=osmo-remsim package=osmo-remsim-bankd copy=bankd/bankd_pcsc_slots.csv -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc1ed4b9419735170cac92916073757da01691ed Gerrit-Change-Number: 39133 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Log return code of unexpected end of process

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39127?usp=email ) Change subject: testenv: Log return code of unexpected end of process ...................................................................... testenv: Log return code of unexpected end of process This providing further information, for instance if the process actually exited due to a signal (rc < 0) or due to exiting on its own (rc >= 0). While at it, rewrite the log line since a process exiting doesn't necessarily mean it crashed. Change-Id: I7bbee6ad8e114eeb1ef348184158230b53d0f3cf --- M _testenv/testenv/daemons.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/_testenv/testenv/daemons.py b/_testenv/testenv/daemons.py index 86f3979..da8248e 100644 --- a/_testenv/testenv/daemons.py +++ b/_testenv/testenv/daemons.py @@ -107,9 +107,11 @@ def check_if_crashed(): crashed = False + returncode = None for daemon_name, daemon_proc in daemons.items(): if not testenv.testsuite.is_running(daemon_proc.pid): crashed = True + returncode = daemon_proc.poll() break if not crashed: return @@ -118,10 +120,10 @@ testenv.coredump.get_from_coredumpctl() if current_test: - logging.error(f"{daemon_name} crashed during {current_test}!") + logging.error(f"{daemon_name} unexpected exit during {current_test}! rc={returncode}") testenv.testsuite.wait_until_test_stopped() else: - logging.error(f"{daemon_name} crashed!") + logging.error(f"{daemon_name} unexpected exit! rc={returncode}") sys.exit(1) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bbee6ad8e114eeb1ef348184158230b53d0f3cf Gerrit-Change-Number: 39127 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email ) Change subject: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. ...................................................................... Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. The List of IP4/6 Elements should be only present on a SNS Ack if the procedure fails with cause code Unknown IP Endpoint. However ns2 code appended the List always to the SNS Ack. Remove List of IP4/6 Elements from SNS Add, it can't fail with Unknown IP Endpoint. Remove List of IP4/6 Elements from SNS Change Weight success case. Related: OS#6611 Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d --- M src/gb/gprs_ns2_sns.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c index 29ccfb0..4a9bb18 100644 --- a/src/gb/gprs_ns2_sns.c +++ b/src/gb/gprs_ns2_sns.c @@ -1268,7 +1268,7 @@ } /* TODO: correct behaviour is to answer to the *same* NSVC from which the SNS_ADD was received */ - ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, v4_list, num_v4, v6_list, num_v6); + ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, NULL, 0, NULL, 0); gprs_ns2_start_alive_all_nsvcs(gss->nse); } @@ -1440,7 +1440,8 @@ ns2_tx_sns_ack(gss->sns_nsvc, trans_id, &cause, NULL, 0, NULL, 0); return; } - ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, v4_list, num_v4, v6_list, num_v6); + + ns2_tx_sns_ack(gss->sns_nsvc, trans_id, NULL, NULL, 0, NULL, 0); } static void ns2_sns_st_configured(struct osmo_fsm_inst *fi, uint32_t event, void *data) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d Gerrit-Change-Number: 39062 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success.

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email ) Change subject: Gb/NS: SNS: SNS Ack don't add List of IP4/6 Elements on success. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39062?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If99b204a9d754323e53746b31bc13df53a653b7d Gerrit-Change-Number: 39062 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Dec 2024 10:53:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: remsim: bankd: Install vsmartcard before running testenv

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email ) Change subject: remsim: bankd: Install vsmartcard before running testenv ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @osmith@sysmocom. […] Well done! Yeah it's better to do this once in _testenv/data/podman/Dockerfile. I'll adjust the patch to do that. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5ba5075eff4955354fa25d1c605f277e8a6962a Gerrit-Change-Number: 39135 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 09:25:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: remsim: Enable debug output of bankd

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email ) Change subject: remsim: Enable debug output of bankd ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc1ed4b9419735170cac92916073757da01691ed Gerrit-Change-Number: 39133 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 09:24:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Log return code of unexpected end of process

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39127?usp=email ) Change subject: testenv: Log return code of unexpected end of process ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7bbee6ad8e114eeb1ef348184158230b53d0f3cf Gerrit-Change-Number: 39127 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 09:24:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email ) Change subject: erab_fsm: implement E-RAB MODIFY Req/Rsp procedure ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I24d57ea390d71b640cb42046a8658e9d30670682 Gerrit-Change-Number: 39116 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 12 Dec 2024 07:47:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: remsim: Enable debug output of bankd

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email ) Change subject: remsim: Enable debug output of bankd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc1ed4b9419735170cac92916073757da01691ed Gerrit-Change-Number: 39133 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 06:47:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024