December 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-mgw[master]: mgcp-client: Fix wrong value passed to strerror()

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39137?usp=email ) Change subject: mgcp-client: Fix wrong value passed to strerror() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibc278199bc8f66e5521bff72bad150f44716f3eb Gerrit-Change-Number: 39137 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 13:09:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgcp-client: Fix wrong value passed to strerror()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39137?usp=email ) Change subject: mgcp-client: Fix wrong value passed to strerror() ...................................................................... mgcp-client: Fix wrong value passed to strerror() errno is positive, hence we need to change the value of "res" being passed to strerror(). While at it, use thread-safe variant strerror_r(). Change-Id: Ibc278199bc8f66e5521bff72bad150f44716f3eb --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/37/39137/1 diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index bcd1268..e577b34 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -786,8 +786,10 @@ struct mgcp_client *mgcp = osmo_iofd_get_data(iofd); if (res <= 0) { + char errbuf[128] = ""; + strerror_r(-res, errbuf, sizeof(errbuf)); LOGPMGW(mgcp, LOGL_ERROR, "Failed to read: %s: %d='%s'\n", - osmo_iofd_get_name(iofd), res, strerror(res)); + osmo_iofd_get_name(iofd), res, errbuf); msgb_free(msg); return; @@ -822,8 +824,10 @@ struct mgcp_client *mgcp = osmo_iofd_get_data(iofd); if (OSMO_UNLIKELY(res != msg->len)) { + char errbuf[128] = ""; + strerror_r(-res, errbuf, sizeof(errbuf)); LOGPMGW(mgcp, LOGL_ERROR, "Failed to Tx MGCP: %s: %d='%s'; msg: len=%u '%s'...\n", - osmo_iofd_get_name(mgcp->iofd), res, strerror(res), + osmo_iofd_get_name(mgcp->iofd), res, errbuf, msg->len, osmo_escape_str((const char *)msg->data, OSMO_MIN(42, msg->len))); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibc278199bc8f66e5521bff72bad150f44716f3eb Gerrit-Change-Number: 39137 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Log ip_addr+port of srv_link failing to start

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39136?usp=email ) Change subject: ipaccess: Log ip_addr+port of srv_link failing to start ...................................................................... ipaccess: Log ip_addr+port of srv_link failing to start Change-Id: Ic879e4fac19311f952e71264fac6ea4239cc4409 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/36/39136/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index a8e4cc4..5cb1123 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -981,7 +981,8 @@ osmo_stream_srv_link_set_accept_cb(oml_link, ipaccess_bsc_oml_accept_cb); if (osmo_stream_srv_link_open(oml_link)) { - LOGPIL(line, DLINP, LOGL_ERROR, "cannot open OML BTS link: %s\n", strerror(errno)); + LOGPIL(line, DLINP, LOGL_ERROR, "cannot open OML BTS link %s:%u (%s)\n", + ipa, IPA_TCP_PORT_OML, strerror(errno)); osmo_stream_srv_link_destroy(oml_link); return -EIO; } @@ -998,7 +999,8 @@ osmo_stream_srv_link_set_accept_cb(rsl_link, ipaccess_bsc_rsl_accept_cb); if (osmo_stream_srv_link_open(rsl_link)) { - LOGPIL(line, DLINP, LOGL_ERROR, "cannot open RSL BTS link: %s\n", strerror(errno)); + LOGPIL(line, DLINP, LOGL_ERROR, "cannot open RSL BTS link %s:%u (%s)\n", + ipa, IPA_TCP_PORT_RSL, strerror(errno)); osmo_stream_srv_link_destroy(rsl_link); return -EIO; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic879e4fac19311f952e71264fac6ea4239cc4409 Gerrit-Change-Number: 39136 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: bankd: Fix typo in fprintf string output

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39128?usp=email ) Change subject: bankd: Fix typo in fprintf string output ...................................................................... bankd: Fix typo in fprintf string output Change-Id: I8115c01c0a4af9919543cc167c4de54caaed3f16 --- M src/bankd/bankd_main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index c406415..cd68073 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -448,7 +448,7 @@ if (g_bankd->cfg.gsmtap_host) { rc = bankd_gsmtap_init(g_bankd->cfg.gsmtap_host); if (rc < 0) { - fprintf(stderr, "Unable to open GSMTAP"); + fprintf(stderr, "Unable to open GSMTAP\n"); exit(1); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39128?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8115c01c0a4af9919543cc167c4de54caaed3f16 Gerrit-Change-Number: 39128 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: cosmetic: rspro_client_fsm: Document event handled in all_state

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39130?usp=email ) Change subject: cosmetic: rspro_client_fsm: Document event handled in all_state ...................................................................... cosmetic: rspro_client_fsm: Document event handled in all_state Change-Id: Id03be7d67bb2530bbefb2a886a175f9a4a4d3cd8 --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 6a48ce4..03dbe15 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -321,7 +321,7 @@ static void srvc_st_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) { switch (event) { - case SRVC_E_ESTABLISH: + case SRVC_E_ESTABLISH: /* Handled in all_state */ default: OSMO_ASSERT(0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id03be7d67bb2530bbefb2a886a175f9a4a4d3cd8 Gerrit-Change-Number: 39130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: bankd: Add -T and -e cmdline params

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email ) Change subject: bankd: Add -T and -e cmdline params ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf Gerrit-Change-Number: 39134 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 12:24:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: Several logging improvements

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email ) Change subject: Several logging improvements ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0 Gerrit-Change-Number: 39132 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 12:23:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: cosmetic: rspro_client_fsm: Document event handled in all_state

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39130?usp=email ) Change subject: cosmetic: rspro_client_fsm: Document event handled in all_state ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id03be7d67bb2530bbefb2a886a175f9a4a4d3cd8 Gerrit-Change-Number: 39130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 12:22:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-remsim[master]: bankd: Fix typo in fprintf string output

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39128?usp=email ) Change subject: bankd: Fix typo in fprintf string output ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39128?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8115c01c0a4af9919543cc167c4de54caaed3f16 Gerrit-Change-Number: 39128 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 12:22:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: handle E-RAB MODIFY REQ/RSP

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39117?usp=email ) Change subject: s1ap_proxy: handle E-RAB MODIFY REQ/RSP ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I057a1c58d0c6ad04c00ad3ea4c68230d8632a07e Gerrit-Change-Number: 39117 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 11:50:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024