December 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: osmo_io: Log current queue length upon enqueue failure

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39140?usp=email ) Change subject: osmo_io: Log current queue length upon enqueue failure ...................................................................... osmo_io: Log current queue length upon enqueue failure Change-Id: Ia712af2041241ea6aa0e03818908fd295d157fd2 --- M src/core/osmo_io.c 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index d1767d2..e109cdf 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -209,8 +209,11 @@ */ int iofd_txqueue_enqueue(struct osmo_io_fd *iofd, struct iofd_msghdr *msghdr) { - if (iofd->tx_queue.current_length >= iofd->tx_queue.max_length) + if (iofd->tx_queue.current_length >= iofd->tx_queue.max_length) { + LOGPIO(iofd, LOGL_ERROR, "enqueueing message failed (queue full, %u msgs). Rejecting msgb\n", + iofd->tx_queue.current_length); return -ENOSPC; + } llist_add_tail(&msghdr->list, &iofd->tx_queue.msg_queue); iofd->tx_queue.current_length++; @@ -520,7 +523,6 @@ rc = iofd_txqueue_enqueue(iofd, msghdr); if (rc < 0) { iofd_msghdr_free(msghdr); - LOGPIO(iofd, LOGL_ERROR, "enqueueing message failed (%d). Rejecting msgb\n", rc); return rc; } @@ -596,7 +598,6 @@ rc = iofd_txqueue_enqueue(iofd, msghdr); if (rc < 0) { iofd_msghdr_free(msghdr); - LOGPIO(iofd, LOGL_ERROR, "enqueueing message failed (%d). Rejecting msgb\n", rc); return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia712af2041241ea6aa0e03818908fd295d157fd2 Gerrit-Change-Number: 39140 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: osmo_io: Log current queue length upon enqueue failure

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39140?usp=email ) Change subject: osmo_io: Log current queue length upon enqueue failure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia712af2041241ea6aa0e03818908fd295d157fd2 Gerrit-Change-Number: 39140 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 19:02:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgcp-client: Fix wrong value passed to strerror()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39137?usp=email ) Change subject: mgcp-client: Fix wrong value passed to strerror() ...................................................................... mgcp-client: Fix wrong value passed to strerror() errno is positive, hence we need to change the value of "res" being passed to strerror(). While at it, use thread-safe variant strerror_r(). Change-Id: Ibc278199bc8f66e5521bff72bad150f44716f3eb --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index bcd1268..e577b34 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -786,8 +786,10 @@ struct mgcp_client *mgcp = osmo_iofd_get_data(iofd); if (res <= 0) { + char errbuf[128] = ""; + strerror_r(-res, errbuf, sizeof(errbuf)); LOGPMGW(mgcp, LOGL_ERROR, "Failed to read: %s: %d='%s'\n", - osmo_iofd_get_name(iofd), res, strerror(res)); + osmo_iofd_get_name(iofd), res, errbuf); msgb_free(msg); return; @@ -822,8 +824,10 @@ struct mgcp_client *mgcp = osmo_iofd_get_data(iofd); if (OSMO_UNLIKELY(res != msg->len)) { + char errbuf[128] = ""; + strerror_r(-res, errbuf, sizeof(errbuf)); LOGPMGW(mgcp, LOGL_ERROR, "Failed to Tx MGCP: %s: %d='%s'; msg: len=%u '%s'...\n", - osmo_iofd_get_name(mgcp->iofd), res, strerror(res), + osmo_iofd_get_name(mgcp->iofd), res, errbuf, msg->len, osmo_escape_str((const char *)msg->data, OSMO_MIN(42, msg->len))); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibc278199bc8f66e5521bff72bad150f44716f3eb Gerrit-Change-Number: 39137 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgcp-client: Fix wrong value passed to strerror()

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39137?usp=email ) Change subject: mgcp-client: Fix wrong value passed to strerror() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39137?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibc278199bc8f66e5521bff72bad150f44716f3eb Gerrit-Change-Number: 39137 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 19:02:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Log ip_addr+port of srv_link failing to start

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39136?usp=email ) Change subject: ipaccess: Log ip_addr+port of srv_link failing to start ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic879e4fac19311f952e71264fac6ea4239cc4409 Gerrit-Change-Number: 39136 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 19:01:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: bankd: Add -T and -e cmdline params

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email ) Change subject: bankd: Add -T and -e cmdline params ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think the documentation in doc/manuals/chapters/remsim-bankd.adoc needs an update, too? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf Gerrit-Change-Number: 39134 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 19:00:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sccp: Initial testenv

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123?usp=email ) Change subject: sccp: Initial testenv ...................................................................... sccp: Initial testenv Change-Id: I616425d729dda342e78537c6b7256d5dddebaa88 --- A sccp/sccp_demo_user.cfg A sccp/testenv.cfg 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/sccp/sccp_demo_user.cfg b/sccp/sccp_demo_user.cfg new file mode 100644 index 0000000..80afec3 --- /dev/null +++ b/sccp/sccp_demo_user.cfg @@ -0,0 +1,17 @@ +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 + +log stderr + logging filter all 1 + logging color 1 + logging print level 1 + logging print category 1 + logging print category-hex 0 + logging print file basename last + logging print extended-timestamp 1 + logging level set-all debug + +line vty + no login + bind 127.0.0.2 diff --git a/sccp/testenv.cfg b/sccp/testenv.cfg new file mode 100644 index 0000000..44ba8ce --- /dev/null +++ b/sccp/testenv.cfg @@ -0,0 +1,9 @@ +[testsuite] +program=SCCP_Tests +config=SCCP_Tests.cfg + +[sccp_demo_user] +program=~/.cache/osmo-ttcn3-testenv/podman/make/libosmo-sigtran/examples/.libs/sccp_demo_user -l 127.0.0.2 -r 127.0.0.1 -C sccp_demo_user.cfg +make=libosmo-sigtran +package=no +copy=sccp_demo_user.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I616425d729dda342e78537c6b7256d5dddebaa88 Gerrit-Change-Number: 39123 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sccp: Initial testenv

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123?usp=email ) Change subject: sccp: Initial testenv ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I616425d729dda342e78537c6b7256d5dddebaa88 Gerrit-Change-Number: 39123 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 19:00:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

[S] Change in osmo-remsim[master]: Several logging improvements

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email ) Change subject: Several logging improvements ...................................................................... Patch Set 1: (2 comments) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39132/comment/a777f498_c830f25d?… : PS1, Line 429: fprintf(stderr, "ERROR: reading PCSC slots\n"); this s ounds like it's an error related to the PC/SC driver. In reality it's an error reading a CSV file mapping PC/SC slots to internal slot numbers. The message should refer to the CSV file, IMHO. File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/39132/comment/e7f35e46_2ac5a4c6?… : PS1, Line 784: , I'd say this is DEBUG level. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0 Gerrit-Change-Number: 39132 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 18:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 2 weeks

1
0
0 0

[XS] Change in docker-playground[master]: ttcn3-remsim: Enable debug output of bankd

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email ) Change subject: ttcn3-remsim: Enable debug output of bankd ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e Gerrit-Change-Number: 39129 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Dec 2024 18:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024