December 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: Check for protocol extension bit in message type at a central location

by jolly

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email ) Change subject: Check for protocol extension bit in message type at a central location ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38579?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iae41bc6a2e9fd85583509b6c6154dd5a935fb5df Gerrit-Change-Number: 38579 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Dec 2024 08:20:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

6 months, 1 week

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email ) Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... Patch Set 5: (1 comment) File gtp/gsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38930/comment/aaa68ec8_1c077ba5?us… : PS3, Line 592: tall_gsn_ctx > slight naming inconsistency: The name of the context is "libgtp" (which is a specific library, likel […] not sure if you missed this content as there were two new versions without addressing it in code or as a comment here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 15 Dec 2024 12:15:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

6 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: library/s1ap: add E-RAB MODIFY IND/CNF templates

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144?usp=email ) Change subject: library/s1ap: add E-RAB MODIFY IND/CNF templates ...................................................................... Patch Set 1: (4 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/1232f1db_aa4e… : PS1, Line 1962: template (omit) E_RABNotToBeModifiedListBearerModInd rab_no_modify_items) > := omit It's already `omit` in the template using this helper, I see no point assigning default values here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/e5a01bb7_432e… : PS1, Line 1999: template E_RABNotToBeModifiedListBearerModInd rab_no_modify_items) > := * Likewise, see the template using this helper. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/06175ee6_d699… : PS1, Line 2147: template (omit) E_RABModifyListBearerModConf rab_modified_items, > := omit x3 Likewise, it's a private helper function. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/4051abfe_dcd6… : PS1, Line 2197: template E_RABModifyListBearerModConf rab_modified_items, > := * x3 Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2dd3d420ebfaf37fefa1d33a40176ec57fee5619 Gerrit-Change-Number: 39144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Dec 2024 07:29:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email ) Change subject: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid ...................................................................... Patch Set 3: (1 comment) File src/libvlr/vlr.c: https://gerrit.osmocom.org/c/osmo-msc/+/38487/comment/05ba3d3d_f49c4ba5?usp… : PS3, Line 1613: if (vsub->lu_fsm) > when terminating, the lu_fsm is setting itself to null. May be worth adding a comment here then. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaea7d37cfa439fd1adea7440409f6248aef947ef Gerrit-Change-Number: 38487 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 14 Dec 2024 22:19:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email ) Change subject: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid ...................................................................... Patch Set 3: (1 comment) File src/libvlr/vlr.c: https://gerrit.osmocom.org/c/osmo-msc/+/38487/comment/8fd58918_43287fb0?usp… : PS3, Line 1613: if (vsub->lu_fsm) > may make sense to set them to NULL too? Can be done in a follow-up patch. when terminating, the lu_fsm is setting itself to null. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaea7d37cfa439fd1adea7440409f6248aef947ef Gerrit-Change-Number: 38487 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Dec 2024 22:17:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: handle E-RAB MODIFY REQ/RSP

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39117?usp=email ) Change subject: s1ap_proxy: handle E-RAB MODIFY REQ/RSP ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39117/comment/d8a0d9f5_ceb2… : PS4, Line 9: TODO: add unit tests! what about this? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I057a1c58d0c6ad04c00ad3ea4c68230d8632a07e Gerrit-Change-Number: 39117 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 1 week

1
0
0 0

[M] Change in ...osmo-s1gw[master]: erab_fsm: implement E-RAB MODIFY Ind/Cnf procedure

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39147?usp=email ) Change subject: erab_fsm: implement E-RAB MODIFY Ind/Cnf procedure ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39147?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I750ada0a5a21edc8bc06d567c8000b6304966474 Gerrit-Change-Number: 39147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:54:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: add constants for PFCP FAR IDs

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39079?usp=email ) Change subject: s1gw: add constants for PFCP FAR IDs ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib25e5cc9ca21047f9884e1c13d0861bf4f7251a1 Gerrit-Change-Number: 39079 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:47:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: library/s1ap: add E-RAB MODIFY IND/CNF templates

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144?usp=email ) Change subject: library/s1ap: add E-RAB MODIFY IND/CNF templates ...................................................................... Patch Set 1: Code-Review+1 (4 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/8b2311c4_0f89… : PS1, Line 1962: template (omit) E_RABNotToBeModifiedListBearerModInd rab_no_modify_items) := omit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/1fd3de42_b329… : PS1, Line 1999: template E_RABNotToBeModifiedListBearerModInd rab_no_modify_items) := * https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/45edeabd_35f0… : PS1, Line 2147: template (omit) E_RABModifyListBearerModConf rab_modified_items, := omit x3 https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/1e997e7a_3ff0… : PS1, Line 2197: template E_RABModifyListBearerModConf rab_modified_items, := * x3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2dd3d420ebfaf37fefa1d33a40176ec57fee5619 Gerrit-Change-Number: 39144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:45:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email ) Change subject: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/libvlr/vlr.c: https://gerrit.osmocom.org/c/osmo-msc/+/38487/comment/ada8ae3d_7309279a?usp… : PS3, Line 1613: if (vsub->lu_fsm) may make sense to set them to NULL too? Can be done in a follow-up patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaea7d37cfa439fd1adea7440409f6248aef947ef Gerrit-Change-Number: 38487 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:41:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024