Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39146?usp=email )
Change subject: cbsp_link: set name on stream
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39146?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia0873ea26a4ef5678fc571e40391d04a2757a7bc
Gerrit-Change-Number: 39146
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Dec 2024 08:52:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has submitted this change. ( https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email )
Change subject: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls()
......................................................................
mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls()
The msisdns to use actually depen on external configuration. Hence allow
passing an initial MSIDN to incrementally setup calls.
Take the chance to match the default msisdn first value with abis-load-test.
Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52
---
M mncc_mt_loadgen.py
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
pespin: Verified
diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py
index 8e7a65b..1a4a998 100755
--- a/mncc_mt_loadgen.py
+++ b/mncc_mt_loadgen.py
@@ -178,10 +178,16 @@
call_conn.start_call(msisdn_called, msisdn_calling, codec)
return call_conn
-def calls(nr, ramp=1.0, codec='GSM_FR'):
+def calls(nr, ramp=1.0, codec='GSM_FR', first_msisdn_called='402965200501'):
+ first_msisdn_called_int = int(first_msisdn_called)
+ needed_len = len(str(first_msisdn_called_int + (nr-1)))
+ # If user passed a longer zero-preffixed input, take it into account:
+ if len(first_msisdn_called) > needed_len:
+ needed_len = len(first_msisdn_called)
for i in range(nr):
- a = 90001 + i
- a = str(a)
+ a = str(first_msisdn_called_int + i)
+ # prepend with zeros as needed:
+ a = a.zfill(needed_len)
print("%d: mt_call(%r)" % (i, a))
mt_call(a, codec=codec)
time.sleep(ramp)
@@ -189,9 +195,9 @@
log.info("")
log.info("")
log.info("Start a single call by typing:")
-log.info(" mt_call('90001')")
+log.info(" mt_call('402965200501')")
log.info("With a specific codec (default is 'GSM_FR'):")
-log.info(" mt_call('90001', codec='GSM_EFR')")
+log.info(" mt_call('402965200501', codec='GSM_EFR')")
log.info("Start multiple calls with (e.g. 4 calls with EFR):")
log.info(" calls(4, codec='GSM_EFR')")
log.info("")
--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52
Gerrit-Change-Number: 39143
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39149?usp=email )
Change subject: pcap-server: Take into account PDU len when calculating pcap max-size
......................................................................
pcap-server: Take into account PDU len when calculating pcap max-size
We never want to overpass the configured max-size.
Change-Id: I666830fbbc23ce34007d45bbf8c7a13a1f2a93ea
---
M src/osmo_server_network.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/49/39149/1
diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c
index b566bd2..41d0b3f 100644
--- a/src/osmo_server_network.c
+++ b/src/osmo_server_network.c
@@ -234,7 +234,7 @@
}
off_t cur = lseek(conn->local_fd, 0, SEEK_CUR);
- if (cur > conn->server->max_size) {
+ if (cur + data->len > conn->server->max_size) {
LOGP(DSERVER, LOGL_NOTICE, "Rolling over file for %s\n", conn->name);
restart_pcap(conn);
} else if (conn->last_write.tm_mday != tm->tm_mday ||
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39149?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I666830fbbc23ce34007d45bbf8c7a13a1f2a93ea
Gerrit-Change-Number: 39149
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email )
Change subject: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls()
......................................................................
Patch Set 1:
(1 comment)
File mncc_mt_loadgen.py:
https://gerrit.osmocom.org/c/mncc-python/+/39143/comment/e188830a_fbf3661a?… :
PS1, Line 185: if len(first_msisdn_called) > needed_len:
> Can this if condition ever be true? as I understand it, nr is always >= 1. […]
nr=3 first_msisdn_called='00000', so that it produces:
"00000"
"00001"
"00002"
instead of
"0"
"1"
"2"
--
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52
Gerrit-Change-Number: 39143
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Dec 2024 10:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>