December 2024 - gerrit-log - lists.osmocom.org

[XS] Change in dahdi-linux[master]: voicebus: Don't check BAR0 is an IO resource

by pespin

Attention is currently required from: tnt. pespin has posted comments on this change by tnt. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email ) Change subject: voicebus: Don't check BAR0 is an IO resource ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Gerrit-Change-Number: 39153 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 17 Dec 2024 10:05:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[S] Change in osmo-pcap[master]: tests/Makefile.am: Fix trailing whitespace

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39152?usp=email ) Change subject: tests/Makefile.am: Fix trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I121a0d596a645e6c70b5c9d2ff394d263d2a1dc4 Gerrit-Change-Number: 39152 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 10:01:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[S] Change in osmo-pcap[master]: pcap-server: New vty command 'no max-file-size'

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39151?usp=email ) Change subject: pcap-server: New vty command 'no max-file-size' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39151?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I54f1f0e2976ea235e92a1c527fa80f18ae166992 Gerrit-Change-Number: 39151 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 10:01:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[S] Change in osmo-pcap[master]: pcap-server: Move write checks to reopen pcap into helper functions

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39150?usp=email ) Change subject: pcap-server: Move write checks to reopen pcap into helper functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Icc2a8e424b166863afa9f8704fd48d35528972df Gerrit-Change-Number: 39150 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 10:00:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: pcap-server: Take into account PDU len when calculating pcap max-size

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39149?usp=email ) Change subject: pcap-server: Take into account PDU len when calculating pcap max-size ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39149?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I666830fbbc23ce34007d45bbf8c7a13a1f2a93ea Gerrit-Change-Number: 39149 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Dec 2024 10:00:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in dahdi-linux[master]: dahdi-base: Allow reselection of the same clock master

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change by tnt. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email ) Change subject: dahdi-base: Allow reselection of the same clock master ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Gerrit-Change-Number: 39154 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 17 Dec 2024 09:59:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in dahdi-linux[master]: voicebus: Don't check BAR0 is an IO resource

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change by tnt. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email ) Change subject: voicebus: Don't check BAR0 is an IO resource ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Gerrit-Change-Number: 39153 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 17 Dec 2024 09:59:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in dahdi-linux[master]: voicebus: Don't check BAR0 is an IO resource

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email ) Change subject: voicebus: Don't check BAR0 is an IO resource ...................................................................... voicebus: Don't check BAR0 is an IO resource BAR0 isn't actually _used_ by anything, all commnication goes through BAR1 which is MMIO. So that check just prevents it to work on devices that don't support IO transactions at all (like RPi5) but for no good reason. Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> --- M drivers/dahdi/voicebus/voicebus.c 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/53/39153/1 diff --git a/drivers/dahdi/voicebus/voicebus.c b/drivers/dahdi/voicebus/voicebus.c index 8a1f7a6..eb110ea 100644 --- a/drivers/dahdi/voicebus/voicebus.c +++ b/drivers/dahdi/voicebus/voicebus.c @@ -1794,11 +1794,6 @@ goto cleanup; } - if (0 == (pci_resource_flags(vb->pdev, 0)&IORESOURCE_IO)) { - dev_err(&vb->pdev->dev, "BAR0 is not IO Memory.\n"); - retval = -EIO; - goto cleanup; - } vb->iobase = pci_iomap(vb->pdev, 1, 0); if (request_mem_region(pci_resource_start(vb->pdev, 1), pci_resource_len(vb->pdev, 1), -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I3c6fe1664e8dc3f158c64d16640b912fa5a4d12e Gerrit-Change-Number: 39153 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com>

6 months, 1 week

1
0
0 0

[XS] Change in dahdi-linux[master]: dahdi-base: Allow reselection of the same clock master

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email ) Change subject: dahdi-base: Allow reselection of the same clock master ...................................................................... dahdi-base: Allow reselection of the same clock master __dahdi_find_master_span is called from a bunch of different places, like when a span comes on-line, this is to potentially select a new master. However the way it's written now, when it's called, it will ALWAYS tried to find a DIFFERENT master than what is selected now if there is another available, no matter is the current one is earlier in the list. Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> --- M drivers/dahdi/dahdi-base.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/54/39154/1 diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index ef29c4b..43948bd 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -3995,8 +3995,6 @@ continue; if (!can_provide_timing(s)) continue; - if (master_span == s) - continue; master_span = s; break; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ibe2365953c5ac7f3dcc7c10526b9eb797ea320ee Gerrit-Change-Number: 39154 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com>

6 months, 1 week

1
0
0 0

[XS] Change in osmo-bsc[master]: cbsp_link: set name on stream

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39146?usp=email ) Change subject: cbsp_link: set name on stream ...................................................................... cbsp_link: set name on stream Otherwise it's difficult to identify it in logs eg. during reconnect. Change-Id: Ia0873ea26a4ef5678fc571e40391d04a2757a7bc --- M src/osmo-bsc/cbsp_link.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c index 9e17ef3..3a86ea3 100644 --- a/src/osmo-bsc/cbsp_link.c +++ b/src/osmo-bsc/cbsp_link.c @@ -121,6 +121,7 @@ osmo_sock_get_name2(fd)); return -1; } + osmo_stream_srv_set_name(srv, "cbsp"); osmo_stream_srv_set_read_cb(srv, cbsp_srv_read_cb); osmo_stream_srv_set_closed_cb(srv, cbsp_srv_closed_cb); osmo_stream_srv_set_segmentation_cb(srv, osmo_cbsp_segmentation_cb); @@ -240,6 +241,8 @@ OSMO_SOCKADDR_STR_FMT_ARGS(&cbc->client.remote_addr)); if (!cbc->client.cli) { cbc->client.cli = osmo_stream_cli_create(cbc); + OSMO_ASSERT(cbc->client.cli); + osmo_stream_cli_set_name(cbc->client.cli, "cbsp"); osmo_stream_cli_set_data(cbc->client.cli, cbc); osmo_stream_cli_set_connect_cb(cbc->client.cli, cbsp_client_connect_cb); osmo_stream_cli_set_disconnect_cb(cbc->client.cli, cbsp_client_disconnect_cb); @@ -273,6 +276,8 @@ if (!cbc->server.link) { LOGP(DCBS, LOGL_NOTICE, "Creating CBSP Server\n"); cbc->server.link = osmo_stream_srv_link_create(cbc); + OSMO_ASSERT(cbc->server.link); + osmo_stream_srv_link_set_name(cbc->server.link, "cbsp"); osmo_stream_srv_link_set_data(cbc->server.link, cbc); osmo_stream_srv_link_set_accept_cb(cbc->server.link, cbsp_srv_link_accept_cb); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39146?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia0873ea26a4ef5678fc571e40391d04a2757a7bc Gerrit-Change-Number: 39146 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024