December 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ggsn[master]: gtp: Rework gtp_resp() into gtp_resp_pdp()

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38933?usp=email ) Change subject: gtp: Rework gtp_resp() into gtp_resp_pdp() ...................................................................... Patch Set 5: (1 comment) File gtp/gtp.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38933/comment/7ffc582a_abbacf51?us… : PS3, Line 132: static int gtp_resp(struct gsn_t *gsn, union gtp_packet *packet, int len, struct sockaddr_in *peer, int fd, uint16_t seq, uint64_t tid, uint16_t flow, uint32_t tei); > This is not needed afaict. Still not addressed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38933?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Id9ff95e0e2a10a22e65ecf42b2a2b06a0f2d1a45 Gerrit-Change-Number: 38933 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:40:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email ) Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Patchset: PS4: > ack Done File gtp/gsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/38930/comment/a6e6a5e0_e68b1298?us… : PS4, Line 119: TALLOC_CTX *tall_gsn_ctx = NULL; > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:38:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Set name on oml and rsl stream listen socket

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/39148?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ipaccess: Set name on oml and rsl stream listen socket ...................................................................... ipaccess: Set name on oml and rsl stream listen socket Change-Id: I0b96605aa5012ee3eafa405172ac06cb1c7e7c33 --- M src/input/ipaccess.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/48/39148/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0b96605aa5012ee3eafa405172ac06cb1c7e7c33 Gerrit-Change-Number: 39148 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[S] Change in mncc-python[master]: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls()

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email ) Change subject: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls() ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52 Gerrit-Change-Number: 39143 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:25:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in mncc-python[master]: cosmetic: mncc_mt_loadgen.py: Fix trailing whitespace

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/mncc-python/+/39142?usp=email ) Change subject: cosmetic: mncc_mt_loadgen.py: Fix trailing whitespace ...................................................................... cosmetic: mncc_mt_loadgen.py: Fix trailing whitespace Change-Id: I8581e7837df29daa2a0fd1676cc730345872b0d5 --- M mncc_mt_loadgen.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Verified diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py index 9a88066..8e7a65b 100755 --- a/mncc_mt_loadgen.py +++ b/mncc_mt_loadgen.py @@ -148,7 +148,7 @@ self.mncc_act.tell({'type': 'send', 'msg': mncc_rtp_conn}) elif message['type'] == 'call_state_change': if message['new_state'] == 'NULL': - # Call FSM has reached the NULL state again (call terminated) + # Call FSM has reached the NULL state again (call terminated) # on_stop() will clean up the RTP connection at rtpsource self.stop() -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I8581e7837df29daa2a0fd1676cc730345872b0d5 Gerrit-Change-Number: 39142 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[XS] Change in mncc-python[master]: cosmetic: mncc_mt_loadgen.py: Fix trailing whitespace

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/mncc-python/+/39142?usp=email ) Change subject: cosmetic: mncc_mt_loadgen.py: Fix trailing whitespace ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I8581e7837df29daa2a0fd1676cc730345872b0d5 Gerrit-Change-Number: 39142 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 14 Dec 2024 21:25:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email ) Change subject: vlr: on subscriber disconnect, check if LU & Auth FSM are even valid ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaea7d37cfa439fd1adea7440409f6248aef947ef Gerrit-Change-Number: 38487 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 14 Dec 2024 02:12:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

6 months, 1 week

1
0
0 0

[M] Change in osmo-ggsn[master]: gtpie: add gtp_encaps a modern encapsulation method

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/39032?usp=email ) Change subject: gtpie: add gtp_encaps a modern encapsulation method ...................................................................... Patch Set 2: (1 comment) File gtp/gtpie.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20594): https://gerrit.osmocom.org/c/osmo-ggsn/+/39032/comment/1fa36a38_00f14626?us… : PS2, Line 954: * \returns 0 on sucess; 2 for out-of-space 'sucess' may be misspelled - perhaps 'success'? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/39032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8bb086c568e07052c52d880df06049490346e91e Gerrit-Change-Number: 39032 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 14 Dec 2024 01:32:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 months, 1 week

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp_new(): use talloc instead of calloc/free

by lynxis lazus

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gtp_new(): use talloc instead of calloc/free ...................................................................... gtp_new(): use talloc instead of calloc/free Required for SGSN Context Req fsm which is using talloc. Adds a new api to set the global gsn talloc context via gtp_set_talloc_ctx() Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b --- M TODO-RELEASE M gtp/gsn.c M include/osmocom/gtp/gsn.h 3 files changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/30/38930/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b Gerrit-Change-Number: 38930 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[S] Change in mncc-python[master]: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email ) Change subject: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52 Gerrit-Change-Number: 39143 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 19:22:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024