December 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_modify_ind_cnf[_multi]

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39145?usp=email ) Change subject: s1gw: add TC_e_rab_modify_ind_cnf[_multi] ...................................................................... s1gw: add TC_e_rab_modify_ind_cnf[_multi] Test the E-RAB Modify procedure (eNB initiated), which is defined in 3GPP TS 36.413 section 8.2.4. Change-Id: Iec95ca0ecf37290bddfbefce1861f8ae66bf4db1 --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn M s1gw/expected-results.xml 3 files changed, 271 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/39145/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 6e5ba99..5c57af4 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -290,6 +290,7 @@ ERabParams a2u, /* Access -> UPF params */ ERabParams u2a, /* UPF -> Access params */ ERabParams u2cm, /* UPF -> Core params (modified) */ + ERabParams u2am, /* UPF -> Access params (modified) */ OCT8 pfcp_loc_seid, OCT8 pfcp_rem_seid optional }; @@ -518,6 +519,164 @@ return pdu; } +function f_ConnHdlr_tx_erab_modify_ind(in ERabIdList erabs_modified, + in ERabIdList erabs_not_modified := {}) +runs on ConnHdlr { + var template (value) E_RABToBeModifiedListBearerModInd items_modified; + var template (omit) E_RABNotToBeModifiedListBearerModInd items_not_modified := omit; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var template (value) E_RABToBeModifiedItemBearerModInd item; + var integer erab_idx := erabs_modified[i]; + var ERabParams epars := g_pars.erabs[erab_idx].u2am; + + item := ts_E_RABToBeModifiedItemBearerModInd(rab_id := g_pars.erabs[erab_idx].erab_id, + tla := oct2bit(f_inet_addr(epars.tla)), + gtp_teid := epars.teid); + + items_modified[i] := ts_E_RABToBeModifiedListBearerModInd(item)[0]; + } + + for (var integer i := 0; i < lengthof(erabs_not_modified); i := i + 1) { + var template (value) E_RABNotToBeModifiedItemBearerModInd item; + var integer erab_idx := erabs_not_modified[i]; + var ERabParams epars := g_pars.erabs[erab_idx].u2a; + + item := ts_E_RABNotToBeModifiedItemBearerModInd(rab_id := g_pars.erabs[erab_idx].erab_id, + tla := oct2bit(f_inet_addr(epars.tla)), + gtp_teid := epars.teid); + + items_not_modified[i] := ts_E_RABNotToBeModifiedListBearerModInd(item)[0]; + } + + f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_RABModifyInd(g_pars.mme_ue_id, enb_ue_id, + rab_do_modify_items := items_modified, + rab_no_modify_items := items_not_modified)); +} + +function f_ConnHdlr_rx_erab_modify_ind(in ERabIdList erabs_modified, + in ERabIdList erabs_not_modified := {}) +runs on ConnHdlr return S1AP_PDU { + var template (present) E_RABToBeModifiedListBearerModInd items_modified; + var template E_RABNotToBeModifiedListBearerModInd items_not_modified := omit; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var S1AP_PDU pdu; + + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var template (present) E_RABToBeModifiedItemBearerModInd item; + var integer erab_idx := erabs_modified[i]; + var ERabParams epars := g_pars.erabs[erab_idx].c2u; + + item := tr_E_RABToBeModifiedItemBearerModInd(rab_id := g_pars.erabs[erab_idx].erab_id, + tla := oct2bit(f_inet_addr(epars.tla)), + gtp_teid := epars.teid); + + items_modified[i] := tr_E_RABToBeModifiedListBearerModInd(item)[0]; + } + + for (var integer i := 0; i < lengthof(erabs_not_modified); i := i + 1) { + var template (present) E_RABNotToBeModifiedItemBearerModInd item; + var integer erab_idx := erabs_not_modified[i]; + var ERabParams epars := g_pars.erabs[erab_idx].c2u; + + item := tr_E_RABNotToBeModifiedItemBearerModInd(rab_id := g_pars.erabs[erab_idx].erab_id, + tla := oct2bit(f_inet_addr(epars.tla)), + gtp_teid := epars.teid); + + items_not_modified[i] := tr_E_RABNotToBeModifiedListBearerModInd(item)[0]; + } + + f_ConnHdlr_rx_s1ap_from_enb(pdu, tr_S1AP_RABModifyInd(g_pars.mme_ue_id, enb_ue_id, + rab_do_modify_items := items_modified, + rab_no_modify_items := items_not_modified)); + return pdu; +} + +function f_ConnHdlr_tx_erab_modify_cnf(in ERabIdList erabs_modified := {}, + in ERabIdList erabs_not_modified := {}, + in ERabIdList erabs_release := {}) +runs on ConnHdlr { + var template (omit) E_RABModifyListBearerModConf items_modified := omit; + var template (omit) E_RABList items_not_modified := omit; + var template (omit) E_RABList items_release := omit; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var template (value) E_RABModifyItemBearerModConf item; + var integer erab_idx := erabs_modified[i]; + + item := ts_E_RABModifyItemBearerModConf(rab_id := g_pars.erabs[erab_idx].erab_id); + items_modified[i] := ts_E_RABModifyListBearerModConf(item)[0]; + } + + for (var integer i := 0; i < lengthof(erabs_not_modified); i := i + 1) { + var template (value) E_RABItem item; + var integer erab_idx := erabs_not_modified[i]; + + item := ts_E_RABItem(rab_id := g_pars.erabs[erab_idx].erab_id, + cause := { transport := transport_resource_unavailable }); + items_not_modified[i] := ts_E_RABList(item)[0]; + } + + for (var integer i := 0; i < lengthof(erabs_release); i := i + 1) { + var template (value) E_RABItem item; + var integer erab_idx := erabs_release[i]; + + item := ts_E_RABItem(rab_id := g_pars.erabs[erab_idx].erab_id, + cause := { transport := transport_resource_unavailable }); + items_release[i] := ts_E_RABList(item)[0]; + } + + f_ConnHdlr_tx_s1ap_from_mme(ts_S1AP_RABModifyCnf(g_pars.mme_ue_id, enb_ue_id, + rab_modified_items := items_modified, + rab_failed_items := items_not_modified, + rab_release_items := items_release)); +} + +function f_ConnHdlr_rx_erab_modify_cnf(in ERabIdList erabs_modified := {}, + in ERabIdList erabs_not_modified := {}, + in ERabIdList erabs_release := {}) +runs on ConnHdlr return S1AP_PDU { + var template E_RABModifyListBearerModConf items_modified := omit; + var template E_RABList items_not_modified := omit; + var template E_RABList items_release := omit; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var S1AP_PDU pdu; + + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var template (present) E_RABModifyItemBearerModConf item; + var integer erab_idx := erabs_modified[i]; + + item := tr_E_RABModifyItemBearerModConf(rab_id := g_pars.erabs[erab_idx].erab_id); + items_modified[i] := tr_E_RABModifyListBearerModConf(item)[0]; + } + + for (var integer i := 0; i < lengthof(erabs_not_modified); i := i + 1) { + var template (present) E_RABItem item; + var integer erab_idx := erabs_not_modified[i]; + + item := tr_E_RABItem(rab_id := g_pars.erabs[erab_idx].erab_id, + cause := { transport := transport_resource_unavailable }); + items_not_modified[i] := tr_E_RABList(item)[0]; + } + + for (var integer i := 0; i < lengthof(erabs_release); i := i + 1) { + var template (present) E_RABItem item; + var integer erab_idx := erabs_release[i]; + + item := tr_E_RABItem(rab_id := g_pars.erabs[erab_idx].erab_id, + cause := { transport := transport_resource_unavailable }); + items_release[i] := tr_E_RABList(item)[0]; + } + + f_ConnHdlr_rx_s1ap_from_mme(pdu, tr_S1AP_RABModifyCnf(g_pars.mme_ue_id, enb_ue_id, + rab_modified_items := items_modified, + rab_failed_items := items_not_modified, + rab_release_items := items_release)); + return pdu; +} + private function f_ts_E_RABList(in ERabList erabs, S1AP_IEs.Cause cause) return template (value) E_RABList { @@ -962,6 +1121,64 @@ f_ConnHdlr_rx_erab_modify_rsp(erabs_modified, erabs_failed); } +function f_ConnHdlr_erab_modify_ind(in ERabIdList erabs_modified, + in ERabIdList erabs_not_modified := {}) +runs on ConnHdlr { + log("[eNB -> S1GW] -> MME: E-RAB MODIFICATION INDICATION"); + f_ConnHdlr_tx_erab_modify_ind(erabs_modified, erabs_not_modified); + /* Expect the S1GW to modify FARs (id=1) of the respective PFCP sessions */ + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var E_RAB_ID erab_idx := erabs_modified[i]; + var ERab erab := g_pars.erabs[erab_idx]; + + log("UPF <- S1GW: PFCP Session Modification Request for E-RAB ID ", erab.erab_id); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_modify_req(epars := erab.u2am, + seid := erab.pfcp_loc_seid, + far_id := c_PFCP_FAR_ID_C2A); + log("UPF -> S1GW: PFCP Session Modification Response for E-RAB ID ", erab.erab_id); + f_ConnHdlr_tx_session_modify_resp(erab, pdu); + } + log("eNB -> [S1GW -> MME]: E-RAB MODIFICATION INDICATION"); + f_ConnHdlr_rx_erab_modify_ind(erabs_modified, erabs_not_modified); +} + +function f_ConnHdlr_erab_modify_cnf(in ERabIdList erabs_modified := {}, + in ERabIdList erabs_not_modified := {}, + in ERabIdList erabs_release := {}) +runs on ConnHdlr { + log("eNB <- [S1GW <- MME]: E-RAB MODIFICATION CONFIRMATION"); + f_ConnHdlr_tx_erab_modify_cnf(erabs_modified, erabs_not_modified, erabs_release); + /* For successfully modified E-RABs, U2AM becomes U2A */ + for (var integer i := 0; i < lengthof(erabs_modified); i := i + 1) { + var E_RAB_ID erab_id := erabs_modified[i]; + g_pars.erabs[erab_id].u2a := g_pars.erabs[erab_id].u2am; + } + /* Expect the S1GW to modify (revert) FARs (id=1) for failed E-RABs (if any) */ + for (var integer i := 0; i < lengthof(erabs_not_modified); i := i + 1) { + var E_RAB_ID erab_idx := erabs_not_modified[i]; + var ERab erab := g_pars.erabs[erab_idx]; + + log("UPF <- S1GW: PFCP Session Modification Request for E-RAB ID ", erab.erab_id); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_modify_req(epars := erab.u2a, + seid := erab.pfcp_loc_seid, + far_id := c_PFCP_FAR_ID_C2A); + log("UPF -> S1GW: PFCP Session Modification Response for E-RAB ID ", erab.erab_id); + f_ConnHdlr_tx_session_modify_resp(erab, pdu); + } + /* Expect the S1GW to delete sessions for released E-RABs (if any) */ + if (lengthof(erabs_release) > 0) { + var ERabList erabs; + + for (var integer i := 0; i < lengthof(erabs_release); i := i + 1) { + var E_RAB_ID erab_idx := erabs_release[i]; + erabs[i] := g_pars.erabs[erab_idx]; + } + f_ConnHdlr_session_delete(erabs); + } + log("[eNB <- S1GW] <- MME: E-RAB MODIFICATION CONFIRMATION"); + f_ConnHdlr_rx_erab_modify_cnf(erabs_modified, erabs_not_modified, erabs_release); +} + function f_ConnHdlr_erab_release_cmd(inout ERabList erabs, S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) runs on ConnHdlr { diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 8b821bc..6d7cba8 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -159,6 +159,7 @@ a2u := {'0202'O & uid, "127.0.2.2"}, u2a := {'0002'O & uid, "127.0.0.2"}, u2cm := {'0011'O & uid, "127.127.0.1"}, + u2am := {'0022'O & uid, "127.127.0.2"}, pfcp_loc_seid := seid_prefix & uid, pfcp_rem_seid := omit /* assigned by S1GW */ }; @@ -471,6 +472,54 @@ f_TC_e_rab_modify_req_rsp_exec(num_enbs := mp_multi_enb_num); } +/* Test E-RAB MODIFICATION Ind/Cnf procedure */ +function f_TC_e_rab_modify_ind_cnf(charstring id) runs on ConnHdlr { + f_ConnHdlr_s1ap_register(g_pars.genb_id); + f_ConnHdlr_s1ap_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); + f_ConnHdlr_s1ap_setup(g_pars.genb_id); + + f_ConnHdlr_erab_setup_req(g_pars.erabs); + f_ConnHdlr_erab_setup_rsp(g_pars.erabs); + + /* eNB wants to modify all E-RABs but E-RAB 4 */ + f_ConnHdlr_erab_modify_ind(erabs_modified := {0, 1, 2, 3}, + erabs_not_modified := {4}); + /* MME modifies E-RABs 1 and 3, but not E-RAB 0 and 2 */ + f_ConnHdlr_erab_modify_cnf(erabs_modified := {1, 3}, + erabs_not_modified := {0, 2}); + + /* For the sake of fun, test forwarding of an empty confirmation, + * which is expected to be forwarded unmodified */ + f_ConnHdlr_erab_modify_cnf(); + + f_ConnHdlr_erab_release_cmd(g_pars.erabs); + f_ConnHdlr_erab_release_rsp(g_pars.erabs); + + f_ConnHdlr_s1ap_disconnect(); + f_ConnHdlr_s1ap_unregister(g_pars.genb_id); +} +private function f_TC_e_rab_modify_ind_cnf_exec(integer num_enbs) +runs on test_CT { + var ConnHdlrList vc_conns; + + f_init(); + + for (var integer i := 0; i < num_enbs; i := i + 1) { + var ConnHdlrPars pars := valueof(t_ConnHdlrPars(i, num_erabs := 5)); + vc_conns[i] := f_ConnHdlr_spawn(refers(f_TC_e_rab_modify_ind_cnf), pars); + } + + f_ConnHdlrList_all_done(vc_conns); +} +/* 5 E-RABs at a time, single eNB */ +testcase TC_e_rab_modify_ind_cnf() runs on test_CT { + f_TC_e_rab_modify_ind_cnf_exec(num_enbs := 1); +} +/* 5 E-RABs at a time, multiple eNB connections */ +testcase TC_e_rab_modify_ind_cnf_multi() runs on test_CT { + f_TC_e_rab_modify_ind_cnf_exec(num_enbs := mp_multi_enb_num); +} + /* Test INITIAL CONTEXT SETUP procedure (successful case) */ function f_TC_initial_ctx_setup(charstring id) runs on ConnHdlr { f_ConnHdlr_s1ap_register(g_pars.genb_id); @@ -591,6 +640,8 @@ execute( TC_e_rab_setup_failure() ); execute( TC_e_rab_modify_req_rsp() ); execute( TC_e_rab_modify_req_rsp_multi() ); + execute( TC_e_rab_modify_ind_cnf() ); + execute( TC_e_rab_modify_ind_cnf_multi() ); execute( TC_initial_ctx_setup() ); execute( TC_initial_ctx_setup3() ); execute( TC_initial_ctx_setup_multi() ); diff --git a/s1gw/expected-results.xml b/s1gw/expected-results.xml index 911dda8..8d07117 100644 --- a/s1gw/expected-results.xml +++ b/s1gw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='S1GW_Tests' tests='18' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='S1GW_Tests' tests='20' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='S1GW_Tests' name='TC_setup' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_setup_multi' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_conn_term_by_mme' time='MASKED'/> @@ -12,6 +12,8 @@ <testcase classname='S1GW_Tests' name='TC_e_rab_setup_failure' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_e_rab_modify_req_rsp' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_e_rab_modify_req_rsp_multi' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_e_rab_modify_ind_cnf' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_e_rab_modify_ind_cnf_multi' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_initial_ctx_setup' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_initial_ctx_setup3' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_initial_ctx_setup_multi' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39145?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec95ca0ecf37290bddfbefce1861f8ae66bf4db1 Gerrit-Change-Number: 39145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[S] Change in mncc-python[master]: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email ) Change subject: mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls() ...................................................................... mncc_mt_loadgen.py: Allow configuring first_msisdn_called in calls() The msisdns to use actually depen on external configuration. Hence allow passing an initial MSIDN to incrementally setup calls. Take the chance to match the default msisdn first value with abis-load-test. Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52 --- M mncc_mt_loadgen.py 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/43/39143/1 diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py index 8e7a65b..1a4a998 100755 --- a/mncc_mt_loadgen.py +++ b/mncc_mt_loadgen.py @@ -178,10 +178,16 @@ call_conn.start_call(msisdn_called, msisdn_calling, codec) return call_conn -def calls(nr, ramp=1.0, codec='GSM_FR'): +def calls(nr, ramp=1.0, codec='GSM_FR', first_msisdn_called='402965200501'): + first_msisdn_called_int = int(first_msisdn_called) + needed_len = len(str(first_msisdn_called_int + (nr-1))) + # If user passed a longer zero-preffixed input, take it into account: + if len(first_msisdn_called) > needed_len: + needed_len = len(first_msisdn_called) for i in range(nr): - a = 90001 + i - a = str(a) + a = str(first_msisdn_called_int + i) + # prepend with zeros as needed: + a = a.zfill(needed_len) print("%d: mt_call(%r)" % (i, a)) mt_call(a, codec=codec) time.sleep(ramp) @@ -189,9 +195,9 @@ log.info("") log.info("") log.info("Start a single call by typing:") -log.info(" mt_call('90001')") +log.info(" mt_call('402965200501')") log.info("With a specific codec (default is 'GSM_FR'):") -log.info(" mt_call('90001', codec='GSM_EFR')") +log.info(" mt_call('402965200501', codec='GSM_EFR')") log.info("Start multiple calls with (e.g. 4 calls with EFR):") log.info(" calls(4, codec='GSM_EFR')") log.info("") -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39143?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I2dd6b96ea2da117d67a368bc076969f25fa61a52 Gerrit-Change-Number: 39143 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[XS] Change in mncc-python[master]: cosmetic: mncc_mt_loadgen.py: Fix trailing whitespace

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/mncc-python/+/39142?usp=email ) Change subject: cosmetic: mncc_mt_loadgen.py: Fix trailing whitespace ...................................................................... cosmetic: mncc_mt_loadgen.py: Fix trailing whitespace Change-Id: I8581e7837df29daa2a0fd1676cc730345872b0d5 --- M mncc_mt_loadgen.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/mncc-python refs/changes/42/39142/1 diff --git a/mncc_mt_loadgen.py b/mncc_mt_loadgen.py index 9a88066..8e7a65b 100755 --- a/mncc_mt_loadgen.py +++ b/mncc_mt_loadgen.py @@ -148,7 +148,7 @@ self.mncc_act.tell({'type': 'send', 'msg': mncc_rtp_conn}) elif message['type'] == 'call_state_change': if message['new_state'] == 'NULL': - # Call FSM has reached the NULL state again (call terminated) + # Call FSM has reached the NULL state again (call terminated) # on_stop() will clean up the RTP connection at rtpsource self.stop() -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/39142?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I8581e7837df29daa2a0fd1676cc730345872b0d5 Gerrit-Change-Number: 39142 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: sccp: Let some time for SCCP RLC to reach IUT before finishing test

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email ) Change subject: sccp: Let some time for SCCP RLC to reach IUT before finishing test ...................................................................... sccp: Let some time for SCCP RLC to reach IUT before finishing test Otherwise tear down of the test component immediatelly afterwards creates a race condition where sometimes the RLC message is not sent before closing the socket. As a result, the SCCP-SCOC stays in DISCONN_PEND until T(rel) fires a while afterwards, generating a new RLSD in a follow-up test, disrupting expectancies of that unrelated test. Since sccp_demo_user doesn't implement a Layer Manager, the recv() 0 from the socket doesn't automatically tear down the SCCP conn, since it could have several ASPs: """ 0: asp-asp-srv-client: ss7_asp_xua_srv_conn_rx_cb(): sctp_recvmsg() returned 0 (flags=0x80) ... asp-srv-client: connection closed XUA_ASP(asp-srv-client){ASP_ACTIVE}: Received Event SCTP-COMM_DOWN.ind XUA_ASP(asp-srv-client){ASP_ACTIVE}: state_chg to ASP_DOWN XUA_AS(as-srv-client){AS_ACTIVE}: Received Event ASPAS-ASP_DOWN.ind XUA_AS(as-srv-client){AS_ACTIVE}: state_chg to AS_PENDING Delivering N-PCSTATE.indication to SCCP User 'SCCP Management' Ignoring SCCP user primitive N-PCSTATE.indication [Here same 2 lines for SCCP User 'refuser', 'echo', 'callback', 'test_client_vty'] XUA_ASP(asp-srv-client){ASP_DOWN}: No Layer Manager, dropping M-ASP_DOWN.indication XUA_ASP(asp-srv-client){ASP_DOWN}: No Layer Manager, dropping M-SCTP_RELEASE.indication """ Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf --- M sccp/SCCP_Tests_RAW.ttcn 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/sccp/SCCP_Tests_RAW.ttcn b/sccp/SCCP_Tests_RAW.ttcn index f1f602c..5d5b0ab 100644 --- a/sccp/SCCP_Tests_RAW.ttcn +++ b/sccp/SCCP_Tests_RAW.ttcn @@ -252,6 +252,8 @@ log("Waiting for RLSD"); f_exp_sccp(tr_SCCP_RLSD(remote_lref, g_own_lref, hex2int('0D'H))); /* Cause: Expiration of Rx Inactivity Timer */ f_send_sccp(ts_SCCP_RLC(g_own_lref, remote_lref)); + /* Let some time for peer to receive the RLC */ + f_sleep(1.0); setverdict(pass); } @@ -325,6 +327,8 @@ self.stop; } } + /* Let some time for peer to receive the RLC */ + f_sleep(1.0); } private function f_tx_xudt_exp(SCCP_PAR_Address calling, SCCP_PAR_Address called, octetstring data) runs on SCCP_Test_RAW_CT { @@ -521,7 +525,8 @@ var template (present) integer cause := ?; f_exp_sccp(tr_SCCP_RLSD(remote_lref, g_own_lref, cause)); f_send_sccp(ts_SCCP_RLC(g_own_lref, remote_lref)); - + /* Let some time for peer to receive the RLC */ + f_sleep(1.0); setverdict(pass); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id7d5970bb0fe0e42fedcb56fe4a738a92ddd5bbf Gerrit-Change-Number: 39126 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[XS] Change in libosmo-abis[master]: ipaccess: Log ip_addr+port of srv_link failing to start

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39136?usp=email ) Change subject: ipaccess: Log ip_addr+port of srv_link failing to start ...................................................................... ipaccess: Log ip_addr+port of srv_link failing to start Change-Id: Ic879e4fac19311f952e71264fac6ea4239cc4409 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index a8e4cc4..5cb1123 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -981,7 +981,8 @@ osmo_stream_srv_link_set_accept_cb(oml_link, ipaccess_bsc_oml_accept_cb); if (osmo_stream_srv_link_open(oml_link)) { - LOGPIL(line, DLINP, LOGL_ERROR, "cannot open OML BTS link: %s\n", strerror(errno)); + LOGPIL(line, DLINP, LOGL_ERROR, "cannot open OML BTS link %s:%u (%s)\n", + ipa, IPA_TCP_PORT_OML, strerror(errno)); osmo_stream_srv_link_destroy(oml_link); return -EIO; } @@ -998,7 +999,8 @@ osmo_stream_srv_link_set_accept_cb(rsl_link, ipaccess_bsc_rsl_accept_cb); if (osmo_stream_srv_link_open(rsl_link)) { - LOGPIL(line, DLINP, LOGL_ERROR, "cannot open RSL BTS link: %s\n", strerror(errno)); + LOGPIL(line, DLINP, LOGL_ERROR, "cannot open RSL BTS link %s:%u (%s)\n", + ipa, IPA_TCP_PORT_RSL, strerror(errno)); osmo_stream_srv_link_destroy(rsl_link); return -EIO; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/39136?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic879e4fac19311f952e71264fac6ea4239cc4409 Gerrit-Change-Number: 39136 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[XS] Change in docker-playground[master]: ttcn3-remsim: Enable debug output of bankd

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email ) Change subject: ttcn3-remsim: Enable debug output of bankd ...................................................................... ttcn3-remsim: Enable debug output of bankd Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e --- M ttcn3-remsim-test/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/ttcn3-remsim-test/jenkins.sh b/ttcn3-remsim-test/jenkins.sh index 281b00d..068635b 100755 --- a/ttcn3-remsim-test/jenkins.sh +++ b/ttcn3-remsim-test/jenkins.sh @@ -32,6 +32,7 @@ $REPO_USER/osmo-remsim-$IMAGE_SUFFIX \ /bin/sh -c "pcscd; \ osmo-remsim-bankd \ + -d DMAIN,1:DST2,1:DRSPRO,1:DREST,1:DSLOTMAP,1:DBANKDW,1:DGSMTAP,1:DLINP,1 \ -i $SUB4_PREFIX.$SUBNET.10 \ >/data/osmo-remsim-bankd.log 2>&1" } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39129?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I8cd9d32b2612390bde31fa2814a51ecda20f920e Gerrit-Change-Number: 39129 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[S] Change in osmo-bsc[master]: Use correct bts_nr field during MO init

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39139?usp=email ) Change subject: Use correct bts_nr field during MO init ...................................................................... Use correct bts_nr field during MO init We want to transmit the BTS nr inside the E1 link, not the internal BTS number in osmo-bsc. Change-Id: I8a70c61cef74c0febeefae88dee575fbb4936d3e --- M src/osmo-bsc/bts.c M src/osmo-bsc/bts_sm.c M src/osmo-bsc/bts_trx.c 3 files changed, 8 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 9febe35..dd60ef8 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -225,7 +225,7 @@ bts->mo.fi = osmo_fsm_inst_alloc(&nm_bts_fsm, bts, bts, LOGL_INFO, NULL); osmo_fsm_inst_update_id_f(bts->mo.fi, "bts%d", bts->nr); - gsm_mo_init(&bts->mo, bts, NM_OC_BTS, bts->nr, 0xff, 0xff); + gsm_mo_init(&bts->mo, bts, NM_OC_BTS, bts->bts_nr, 0xff, 0xff); /* 3GPP TS 08.18, chapter 5.4.1: 0 is reserved for signalling */ bts->gprs.cell.bvci = 2; @@ -237,7 +237,7 @@ &bts->gprs.cell, LOGL_INFO, NULL); osmo_fsm_inst_update_id_f(bts->gprs.cell.mo.fi, "gprs-cell%d", bts->nr); gsm_mo_init(&bts->gprs.cell.mo, bts, NM_OC_GPRS_CELL, - bts->nr, 0xff, 0xff); + bts->bts_nr, 0xff, 0xff); /* init statistics */ bts->bts_ctrs = rate_ctr_group_alloc(bts, &bts_ctrg_desc, bts->nr); diff --git a/src/osmo-bsc/bts_sm.c b/src/osmo-bsc/bts_sm.c index d122369..c55c33c 100644 --- a/src/osmo-bsc/bts_sm.c +++ b/src/osmo-bsc/bts_sm.c @@ -75,7 +75,7 @@ bts_sm->gprs.nse.mo.fi = osmo_fsm_inst_alloc(&nm_gprs_nse_fsm, bts_sm, &bts_sm->gprs.nse, LOGL_INFO, NULL); osmo_fsm_inst_update_id_f(bts_sm->gprs.nse.mo.fi, "nse%d", bts_num); - gsm_mo_init(&bts_sm->gprs.nse.mo, bts, NM_OC_GPRS_NSE, bts->nr, 0xff, 0xff); + gsm_mo_init(&bts_sm->gprs.nse.mo, bts, NM_OC_GPRS_NSE, bts->bts_nr, 0xff, 0xff); memcpy(&bts_sm->gprs.nse.timer, bts_nse_timer_default, sizeof(bts_sm->gprs.nse.timer)); @@ -89,12 +89,12 @@ osmo_fsm_inst_update_id_f(bts_sm->gprs.nsvc[i].mo.fi, "nsvc%d", i); gsm_mo_init(&bts_sm->gprs.nsvc[i].mo, bts, NM_OC_GPRS_NSVC, - bts->nr, i, 0xff); + bts->bts_nr, i, 0xff); } memcpy(&bts_sm->gprs.nse.timer, bts_nse_timer_default, sizeof(bts_sm->gprs.nse.timer)); gsm_mo_init(&bts_sm->gprs.nse.mo, bts, NM_OC_GPRS_NSE, - bts->nr, 0xff, 0xff); + bts->bts_nr, 0xff, 0xff); return bts_sm; } diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c index 4d2588d..e3d7612 100644 --- a/src/osmo-bsc/bts_trx.c +++ b/src/osmo-bsc/bts_trx.c @@ -75,13 +75,13 @@ LOGL_INFO, NULL); osmo_fsm_inst_update_id_f(trx->mo.fi, "bts%d-trx%d", bts->nr, trx->nr); gsm_mo_init(&trx->mo, bts, NM_OC_RADIO_CARRIER, - bts->nr, trx->nr, 0xff); + bts->bts_nr, trx->nr, 0xff); trx->bb_transc.mo.fi = osmo_fsm_inst_alloc(&nm_bb_transc_fsm, trx, &trx->bb_transc, LOGL_INFO, NULL); osmo_fsm_inst_update_id_f(trx->bb_transc.mo.fi, "bts%d-trx%d", bts->nr, trx->nr); gsm_mo_init(&trx->bb_transc.mo, bts, NM_OC_BASEB_TRANSC, - bts->nr, trx->nr, 0xff); + bts->bts_nr, trx->nr, 0xff); for (k = 0; k < TRX_NR_TS; k++) { struct gsm_bts_trx_ts *ts = &trx->ts[k]; @@ -100,7 +100,7 @@ osmo_fsm_inst_update_id_f(ts->mo.fi, "bts%d-trx%d-ts%d", bts->nr, trx->nr, ts->nr); gsm_mo_init(&ts->mo, bts, NM_OC_CHANNEL, - bts->nr, trx->nr, ts->nr); + bts->bts_nr, trx->nr, ts->nr); ts->hopping.arfcns.data_len = sizeof(ts->hopping.arfcns_data); ts->hopping.arfcns.data = ts->hopping.arfcns_data; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8a70c61cef74c0febeefae88dee575fbb4936d3e Gerrit-Change-Number: 39139 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[S] Change in osmo-remsim[master]: bankd: Add -T and -e cmdline params

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email ) Change subject: bankd: Add -T and -e cmdline params ...................................................................... bankd: Add -T and -e cmdline params Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf --- M doc/manuals/chapters/remsim-bankd.adoc M src/bankd/bankd_main.c 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/doc/manuals/chapters/remsim-bankd.adoc b/doc/manuals/chapters/remsim-bankd.adoc index e87de52..b9db3d7 100644 --- a/doc/manuals/chapters/remsim-bankd.adoc +++ b/doc/manuals/chapters/remsim-bankd.adoc @@ -99,6 +99,16 @@ without knowledge of each other, and either of them might modify the card state (such as the currently selected file, validated PIN, etc.) in a way not expected by the other application. +*-g, --gsmtap-ip A.B.C.D*:: + Enable GSMTAP and send APDU traces to given IP. +*-G, --gsmtap-slot <0-1023>*:: + Limit tracing to given bank slot, only (default: all slots). +*-L, --disable-color*:: + Disable colors for logging to stderr. +*-T, --timestamp*:: + Prefix every log line with a timestamp. +*-e, --log-level number*:: + Set a global loglevel for all logging. ==== Examples diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index e9e4889..14c676d 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -303,6 +303,8 @@ " -g --gsmtap-ip A.B.C.D Enable GSMTAP and send APDU traces to given IP\n" " -G --gsmtap-slot <0-1023> Limit tracing to given bank slot, only (default: all slots)\n" " -L --disable-color Disable colors for logging to stderr\n" +" -T --timestamp Prefix every log line with a timestamp\n" +" -e --log-level number Set a global loglevel.\n" ); } @@ -328,10 +330,12 @@ { "gsmtap-ip", 1, 0, 'g' }, { "gsmtap-slot", 1, 0, 'G' }, { "disable-color", 0, 0, 'L' }, + { "timestamp", 0, 0, 'T' }, + { "log-level", 1, 0, 'e' }, { 0, 0, 0, 0 } }; - c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:L", long_options, &option_index); + c = getopt_long(argc, argv, "hVd:i:p:b:n:N:I:P:sg:G:LTe:", long_options, &option_index); if (c == -1) break; @@ -380,6 +384,12 @@ case 'L': log_set_use_color(osmo_stderr_target, 0); break; + case 'T': + log_set_print_timestamp(osmo_stderr_target, 1); + break; + case 'e': + log_set_log_level(osmo_stderr_target, atoi(optarg)); + break; } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c33c667be77578699f4a5fb70c8b74c67f6e2cf Gerrit-Change-Number: 39134 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[S] Change in osmo-remsim[master]: Several logging improvements

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email ) Change subject: Several logging improvements ...................................................................... Several logging improvements Improve logging in several places which proved to be usfeful while analyzing behavior of the program. Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0 --- M src/bankd/bankd_main.c M src/rspro_client_fsm.c M src/server/rspro_server.c 3 files changed, 14 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index cd68073..e9e4889 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -420,12 +420,15 @@ signal(SIGMAPADD, handle_sig_mapadd); signal(SIGUSR1, handle_sig_usr1); + LOGP(DMAIN, LOGL_INFO, "Reading PCSC slots...\n"); /* Np lock or mutex required for the pcsc_slot_names list, as this is only * read once during bankd initialization, when the worker threads haven't * started yet */ rc = bankd_pcsc_read_slotnames(g_bankd, "bankd_pcsc_slots.csv"); - if (rc) + if (rc) { + fprintf(stderr, "ERROR: failed reading bankd_pcsc_slots.csv file\n"); exit(1); + } /* Connection towards remsim-server */ rc = server_conn_fsm_alloc(g_bankd, srvc); @@ -436,6 +439,8 @@ osmo_fsm_inst_dispatch(srvc->fi, SRVC_E_ESTABLISH, NULL); /* create listening socket for inbound client connections */ + LOGP(DMAIN, LOGL_INFO, "Initiating listen TCP socket at %s:%d\n", + g_bind_ip ? g_bind_ip : "INADDR_ANY", g_bind_port); rc = osmo_sock_init(AF_INET, SOCK_STREAM, IPPROTO_TCP, g_bind_ip, g_bind_port, OSMO_SOCK_F_BIND); if (rc < 0) { fprintf(stderr, "Unable to create TCP socket at %s:%d: %s\n", @@ -446,6 +451,7 @@ /* initialize gsmtap, if required */ if (g_bankd->cfg.gsmtap_host) { + LOGP(DMAIN, LOGL_INFO, "Initiating GSMTAP\n"); rc = bankd_gsmtap_init(g_bankd->cfg.gsmtap_host); if (rc < 0) { fprintf(stderr, "Unable to open GSMTAP\n"); @@ -456,6 +462,7 @@ /* create worker threads: One per reader/slot! */ for (i = 0; i < g_bankd->srvc.bankd.num_slots; i++) { struct bankd_worker *w; + LOGP(DMAIN, LOGL_INFO, "Initiating worker %d\n", i); w = bankd_create_worker(g_bankd, i); if (!w) { fprintf(stderr, "Error creating bankd worker thread\n"); @@ -463,12 +470,10 @@ } } - while (1) { - if (terminate) - break; + while (!terminate) { osmo_select_main(0); } - + LOGP(DMAIN, LOGL_NOTICE, "Terminated\n"); talloc_free(g_bankd); exit(0); } diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 03dbe15..d847f3b 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -502,6 +502,7 @@ osmo_stream_cli_destroy(srvc->conn); srvc->conn = NULL; err_exit: + LOGPFSML(fi, LOGL_FATAL, "exit(1)\n"); exit(1); } diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 0936238..1cc1af1 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -780,6 +780,8 @@ static int ipa_keepalive_send_cb(struct osmo_ipa_ka_fsm_inst *ka_fi, struct msgb *msg, void *data) { struct osmo_stream_srv *srv = data; + struct rspro_client_conn *conn = osmo_stream_srv_get_data(srv); + LOGPFSML(conn->fi, LOGL_DEBUG, "Tx IPA PING\n"); osmo_stream_srv_send(srv, msg); return 0; } @@ -788,6 +790,7 @@ { struct osmo_stream_srv *peer = data; struct rspro_client_conn *conn = osmo_stream_srv_get_data(peer); + LOGPFSML(conn->fi, LOGL_NOTICE, "IPA PONG Timeout\n"); osmo_fsm_inst_dispatch(conn->fi, CLNTC_E_KA_TIMEOUT, NULL); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39132?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I4fa91ca8c8e576094d3a9598df5ad96b230bbde0 Gerrit-Change-Number: 39132 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

6 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email ) Change subject: s1gw: make f_ConnHdlr_rx_session_modify_req() more flexible ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52317e79ac02cb4e321b49c2cd824de28e25a1c6 Gerrit-Change-Number: 39076 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Dec 2024 10:11:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2024