November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: library/gsup: fix template param restriction for tr_GSUP

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email ) Change subject: library/gsup: fix template param restriction for tr_GSUP ...................................................................... Patch Set 1: (1 comment) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672/comment/a0404df7_c704… : PS1, Line 312: template GSUP_PDU tr_GSUP(template (present) GSUP_MessageType msgt := ?, template (present) here too please (see start of line). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89 Gerrit-Change-Number: 38672 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:52:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hlr: refactor f_SS_expect()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email ) Change subject: hlr: refactor f_SS_expect() ...................................................................... Patch Set 1: (4 comments) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/df8a34c0_52bc… : PS1, Line 740: Looks like we want to have this in a function in GSUP_Templates.ttcn maybe? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/a669e531_2f13… : PS1, Line 741: /* case a) SS Info is can be any value or not present */ "is can be" <-wrong https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/2bce2ed7_f89d… : PS1, Line 746: /* case b) SS Info is shall *not* be present */ "is shall" all this is gramaptically incorrect, remove the "is" please. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/a0efdf73_2dde… : PS1, Line 755: /* case c) SS Info is shall be present */ same -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:52:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hlr: use :memory: (volatile in-memory database)

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38670?usp=email ) Change subject: hlr: use :memory: (volatile in-memory database) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38670?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibb34a555e999693f00d12b49f936a20105f21c43 Gerrit-Change-Number: 38670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:49:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email ) Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS1: > FYI: this is still marked WIP while other non-WIP patches depend on it. […] This patch was introducing a regression to HLR_Tests, which is now fixed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873 Gerrit-Change-Number: 38584 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:48:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: hnbgw: Fix wrong map object retrieved from hashtable

by pespin

Attention is currently required from: fixeria, laforge, osmith. Hello fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38669?usp=email to look at the new patch set (#2). Change subject: hnbgw: Fix wrong map object retrieved from hashtable ...................................................................... hnbgw: Fix wrong map object retrieved from hashtable If several map objects (mapping between RUA and SCCP transports for a given Iu connection) ended up in the same hashtable bucket, then the first one was always returned by map_from_conn_id(). As a result, when such collisions happened (e.g. when a big number of connections were inserted) a user could see a Iu message coming from SCCP connection "A" end up being forwarded to an unrelated RUA connection "B". Related: SYS#6602 Fixes: f3caea850bc892551cd09bbaf49f798c172590c4 Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/69/38669/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 Gerrit-Change-Number: 38669 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hlr: refactor f_SS_expect()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email ) Change subject: hlr: refactor f_SS_expect() ...................................................................... hlr: refactor f_SS_expect() Prepare for follow-up patches reworking SS related GSUP templates. Avoid passing "omit" for parameter 'ss' of the receive templates because this will no longer work as expected. Clean up code flow. Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 --- M hlr/HLR_Tests.ttcn 1 file changed, 37 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/38671/1 diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn index 46b98c2..5344180 100644 --- a/hlr/HLR_Tests.ttcn +++ b/hlr/HLR_Tests.ttcn @@ -716,45 +716,20 @@ template SS_FacilityInformation facility := *, template octetstring destination_name := omit) runs on HLR_ConnHdlr return GSUP_PDU { - var GSUP_PDU ret; + var GSUP_IeValue ie; + var GSUP_PDU pdu; timer T := 3.0; - var boolean exp_ss := true; - if (istemplatekind(facility, "omit")) { - exp_ss := false; - } + T.start; alt { - [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value ret { - setverdict(fail, "Unexpected PROC_SS ERROR Cause"); + [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value pdu { + setverdict(fail, "Unexpected PROC_SS ERROR: ", pdu); mtc.stop; } - [not exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit, destination_name := destination_name)) -> value ret { - setverdict(pass); - } - [exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit)) -> value ret { - setverdict(fail, "Unexpected PROC_SS.res without SS IE"); - mtc.stop; - } -/* - [exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, decmatch facility, destination_name := destination_name)) -> value ret { - setverdict(pass); - } -*/ - - [exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, ?, destination_name := destination_name)) -> value ret { - var GSUP_IeValue ss_ie; - f_gsup_find_ie(ret, OSMO_GSUP_SS_INFO_IE, ss_ie); - var SS_FacilityInformation dec_fac := dec_SS_FacilityInformation(ss_ie.ss_info); - log("pattern: ", facility); - if (match(dec_fac, facility)) { - setverdict(pass); - } else { - setverdict(fail, "Unexpected PROC_SS.res with non-matching facility IE"); - mtc.stop; - } - } - [] GSUP.receive { - setverdict(fail, "Unexpected GSUP"); + [] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, + destination_name := destination_name)) -> value pdu; + [] GSUP.receive(GSUP_PDU:?) -> value pdu { + setverdict(fail, "Unexpected GSUP PDU: ", pdu); mtc.stop; } [] T.timeout { @@ -763,7 +738,34 @@ } } - return ret; + /* case a) SS Info is can be any value or not present */ + if (istemplatekind(facility, "*")) { + return pdu; /* skip the remaining SS Info checks */ + } + + /* case b) SS Info is shall *not* be present */ + if (istemplatekind(facility, "omit")) { + if (f_gsup_find_ie(pdu, OSMO_GSUP_SS_INFO_IE, ie)) { + setverdict(fail, "Unexpected PROC_SS.res with SS Info IE"); + mtc.stop; + } + return pdu; /* skip the remaining SS Info checks */ + } + + /* case c) SS Info is shall be present */ + if (not f_gsup_find_ie(pdu, OSMO_GSUP_SS_INFO_IE, ie)) { + setverdict(fail, "Unexpected PROC_SS.res without SS Info IE"); + mtc.stop; + } + + var SS_FacilityInformation dec_fac := dec_SS_FacilityInformation(ie.ss_info); + if (not match(dec_fac, facility)) { + setverdict(fail, "Unexpected PROC_SS.res with non-matching facility IE"); + mtc.stop; + } + + setverdict(pass); + return pdu; } function f_perform_CHECK_IMEI(hexstring imsi, hexstring imei, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/gsup: fix template param restriction for tr_GSUP

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email ) Change subject: library/gsup: fix template param restriction for tr_GSUP ...................................................................... library/gsup: fix template param restriction for tr_GSUP Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89 --- M library/GSUP_Templates.ttcn 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/38672/1 diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 21805cb..6ad1805 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -309,7 +309,8 @@ } } -template GSUP_PDU tr_GSUP(template GSUP_MessageType msgt := ?, template GSUP_IEs ies := *) := { +template GSUP_PDU tr_GSUP(template (present) GSUP_MessageType msgt := ?, + template (present) GSUP_IEs ies := ?) := { msg_type := msgt, ies := ies } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89 Gerrit-Change-Number: 38672 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: add src/dst name IEs to all SS templates

by fixeria

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38585?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: library/gsup: add src/dst name IEs to all SS templates ...................................................................... library/gsup: add src/dst name IEs to all SS templates This enables us to send/match OSMO_GSUP_{SOURCE,DESTINATION}_NAME IEs (if needed) and brings consistency to all SS related templates. Change-Id: I8d947313a99491d2e4790bc06db863fe09d8b5cf --- M library/GSUP_Templates.ttcn 1 file changed, 58 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/38585/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38585?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d947313a99491d2e4790bc06db863fe09d8b5cf Gerrit-Change-Number: 38585 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: improve formatting of SS templates

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38583?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: library/gsup: improve formatting of SS templates ...................................................................... library/gsup: improve formatting of SS templates Change-Id: I27aa67ded044a4a5362795bb791d883c4af55cd9 --- M library/GSUP_Templates.ttcn 1 file changed, 74 insertions(+), 82 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/38583/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27aa67ded044a4a5362795bb791d883c4af55cd9 Gerrit-Change-Number: 38583 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hlr: use :memory: (volatile in-memory database)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38670?usp=email ) Change subject: hlr: use :memory: (volatile in-memory database) ...................................................................... hlr: use :memory: (volatile in-memory database) This eliminates hlr.db* files and reduces chances of failures due to unclean state database when running TCs more than once. Change-Id: Ibb34a555e999693f00d12b49f936a20105f21c43 --- M hlr/osmo-hlr.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/38670/1 diff --git a/hlr/osmo-hlr.cfg b/hlr/osmo-hlr.cfg index a17881e..3f54c1b 100644 --- a/hlr/osmo-hlr.cfg +++ b/hlr/osmo-hlr.cfg @@ -15,6 +15,7 @@ ctrl bind 127.0.0.1 hlr + database :memory: gsup bind ip 127.0.0.1 euse foobar -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38670?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibb34a555e999693f00d12b49f936a20105f21c43 Gerrit-Change-Number: 38670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024