November 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: hlr: refactor f_SS_expect()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email ) Change subject: hlr: refactor f_SS_expect() ...................................................................... Patch Set 1: (1 comment) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/eeda84c6_dacd… : PS1, Line 740: > I don't think so. It's matching a specific message type on specific port. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:18:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hlr: refactor f_SS_expect()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email ) Change subject: hlr: refactor f_SS_expect() ...................................................................... Patch Set 1: (3 comments) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/cee635c9_d4c5… : PS1, Line 741: /* case a) SS Info is can be any value or not present */ > "is can be" <-wrong Acknowledged https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/202c0bc2_d18e… : PS1, Line 746: /* case b) SS Info is shall *not* be present */ > "is shall" all this is gramaptically incorrect, remove the "is" please. Acknowledged https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/ae0ddf4e_30e9… : PS1, Line 755: /* case c) SS Info is shall be present */ > same Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:08:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hlr: refactor f_SS_expect()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email ) Change subject: hlr: refactor f_SS_expect() ...................................................................... Patch Set 1: (1 comment) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/4496cf0f_3f90… : PS1, Line 740: > Looks like we want to have this in a function in GSUP_Templates. […] I don't think so. It's matching a specific message type on specific port. I don't see other use cases for it outside of HLR_Tests.ttcn. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:07:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/gsup: fix wrong IE order in f_gen_tr_ss_ies

by fixeria

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email ) Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies ...................................................................... Patch Set 3: (1 comment) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586/comment/72dcd2bf_5a54… : PS2, Line 1412: ies[idx] := *; > Right. […] This patch is not perfect, but at least it would make the templates match messages with the Message Class IE present. Though, the big problem of using `*` in record lists is that it allows none or **several** items, not just one :/ This may result in templates matching IEs that are expected to be `omit` by the API user... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1 Gerrit-Change-Number: 38586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:05:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/gsup: fix wrong IE order in f_gen_tr_ss_ies

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email ) Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1 Gerrit-Change-Number: 38586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:02:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/gsup: fix wrong IE order in f_gen_tr_ss_ies

by fixeria

Attention is currently required from: laforge, lynxis lazus. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email ) Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies ...................................................................... Patch Set 3: (1 comment) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586/comment/5a477918_0a41… : PS2, Line 1412: ies[idx] := *; > well, the comment says something about a specific IE type (OSMO_GSUP_MESSAGE_CLASS_IE) while the act […] Right. There's unfortunately no way to express that we optionally expect a specific kind of IE here, i.e. either OSMO_GSUP_MESSAGE_CLASS_IE or nothing. I tried several things: * a) `ies[idx] = tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_USSD) ifpresent` * b) `ies[idx] = (tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_USSD), omit)` * c) `ies[idx] = * length(0..1)` and none of this compiled. The a) used to work, but then was removed in TITAN [1]; the b) does not compile. The c) is permitted by the specs and would allow to at least limit number of IEs in this position (none or one), but TITAN does not implement this syntax [2]. [1] https://www.eclipse.org/forums/index.php/t/1103442/ [2] https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/743 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1 Gerrit-Change-Number: 38586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:01:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/gsup: fix wrong IE order in f_gen_tr_ss_ies

by pespin

Attention is currently required from: fixeria, laforge, lynxis lazus. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email ) Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies ...................................................................... Patch Set 3: (1 comment) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586/comment/a2082fb0_da58… : PS2, Line 1412: ies[idx] := *; > well, the comment says something about a specific IE type (OSMO_GSUP_MESSAGE_CLASS_IE) while the act […] Can't we do "(tr_GSUP_MSG_CLASS(?), omit)" or similar here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1 Gerrit-Change-Number: 38586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 16:00:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: add src/dst name IEs to all SS templates

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38585?usp=email ) Change subject: library/gsup: add src/dst name IEs to all SS templates ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38585?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d947313a99491d2e4790bc06db863fe09d8b5cf Gerrit-Change-Number: 38585 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:59:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email ) Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: I find this commit really difficult to review, with different stuff in it. Can we easily split all the template fixup from the change in logic which makes the test pass now? File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584/comment/c1c97a21_753f… : PS2, Line 1330: private function f_gen_ts_ss_ies(template (value) hexstring imsi, You could split this big chunk of changes and move all the "(present)" and "(value)" into another patch (like the previous one), but fine anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873 Gerrit-Change-Number: 38584 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:57:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/gsup: fix template param restriction for tr_GSUP

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email ) Change subject: library/gsup: fix template param restriction for tr_GSUP ...................................................................... Patch Set 1: (1 comment) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672/comment/08d8b885_32a9… : PS1, Line 323: template GSUP_PDU ts_GSUP(GSUP_MessageType msgt, GSUP_IEs ies := {}) := { this one also needs (value) btw. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89 Gerrit-Change-Number: 38672 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:53:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024