November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-hnbgw[master]: hnbgw: Fix wrong map object retrieved from hashtable

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38669?usp=email ) Change subject: hnbgw: Fix wrong map object retrieved from hashtable ...................................................................... hnbgw: Fix wrong map object retrieved from hashtable If several map objects (mapping between RUA and SCCP transports for a given Iu connection) ended up in the same hashtable bucket, then the first one was always returned by map_from_conn_id(). As a result, when such collisions happened (e.g. when a big number of connections were inserted) a user could see a Iu message coming from SCCP connection "A" end up being forwarded to an unrelated RUA connection "B". Related: SYS#6602 Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/69/38669/1 diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index b984a8e..a74b6d7 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -447,8 +447,10 @@ const struct osmo_prim_hdr *oph) { struct hnbgw_context_map *map; - hash_for_each_possible(hsu->hnbgw_context_map_by_conn_id, map, hnbgw_sccp_user_entry, conn_id) - return map; + hash_for_each_possible(hsu->hnbgw_context_map_by_conn_id, map, hnbgw_sccp_user_entry, conn_id) { + if (map->scu_conn_id == conn_id) + return map; + } LOGP(DRANAP, LOGL_ERROR, "Rx for unknown SCCP connection ID: %u: %s\n", conn_id, osmo_scu_prim_hdr_name_c(OTC_SELECT, oph)); return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 Gerrit-Change-Number: 38669 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: gprs/gsm_24_301: add include to be self contained

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38667?usp=email ) Change subject: gprs/gsm_24_301: add include to be self contained ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f853d00738b481d00c60aa6ad6764cf2c861904 Gerrit-Change-Number: 38667 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:21:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: gprs/gsm23003: add osmo_gummei_cmp

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38668?usp=email ) Change subject: gprs/gsm23003: add osmo_gummei_cmp ...................................................................... gprs/gsm23003: add osmo_gummei_cmp Change-Id: I85aab7fcb18f69cca1ce51c86291d1b9e4793a28 --- M include/osmocom/gsm/gsm23003.h M src/gsm/gsm23003.c M src/gsm/libosmogsm.map 3 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/68/38668/1 diff --git a/include/osmocom/gsm/gsm23003.h b/include/osmocom/gsm/gsm23003.h index 4070581..fb35d51 100644 --- a/include/osmocom/gsm/gsm23003.h +++ b/include/osmocom/gsm/gsm23003.h @@ -167,6 +167,7 @@ int osmo_rai_cmp(const struct osmo_routing_area_id *a, const struct osmo_routing_area_id *b); int osmo_cgi_cmp(const struct osmo_cell_global_id *a, const struct osmo_cell_global_id *b); int osmo_cgi_ps_cmp(const struct osmo_cell_global_id_ps *a, const struct osmo_cell_global_id_ps *b); +int osmo_gummei_cmp(const struct osmo_gummei *a, const struct osmo_gummei *b); int osmo_gen_home_network_domain(char *out, const struct osmo_plmn_id *plmn); int osmo_parse_home_network_domain(struct osmo_plmn_id *out, const char *in); diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c index 1eed41f..b7c6228 100644 --- a/src/gsm/gsm23003.c +++ b/src/gsm/gsm23003.c @@ -656,6 +656,30 @@ return 0; } +/* Compare two GUMMEI + * The order of comparison is MCC, MNC, MME GroupId, MME Code. + * \param a[in] "Left" side GUMMEI. + * \param b[in] "Right" side GUMMEI. + * \returns 0 if the GUMMEI are equal, -1 if a < b, 1 if a > b. */ +int osmo_gummei_cmp(const struct osmo_gummei *a, const struct osmo_gummei *b) +{ + int rc = osmo_plmn_cmp(&a->plmn, &b->plmn); + if (rc) + return rc; + + if (a->mme.code < b->mme.code) + return -1; + if (a->mme.code > b->mme.code) + return 1; + + if (a->mme.group_id < b->mme.group_id) + return -1; + if (a->mme.group_id > b->mme.group_id) + return 1; + + return 0; +} + /*! Generate TS 23.003 Section 19.2 Home Network Realm/Domain (text form) * \param out[out] caller-provided output buffer, at least 33 bytes long * \param plmn[in] Osmocom representation of PLMN ID (MCC + MNC) diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 3bc8309..6796c9a 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -502,6 +502,7 @@ osmo_gummei_name; osmo_gummei_name_buf; osmo_gummei_name_c; +osmo_gummei_cmp; osmo_mnc_from_str; osmo_mnc_cmp; osmo_plmn_cmp; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85aab7fcb18f69cca1ce51c86291d1b9e4793a28 Gerrit-Change-Number: 38668 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: gprs/gsm_24_301: add include to be self contained

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38667?usp=email ) Change subject: gprs/gsm_24_301: add include to be self contained ...................................................................... gprs/gsm_24_301: add include to be self contained Change-Id: I2f853d00738b481d00c60aa6ad6764cf2c861904 --- M include/osmocom/gprs/protocol/gsm_24_301.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/38667/1 diff --git a/include/osmocom/gprs/protocol/gsm_24_301.h b/include/osmocom/gprs/protocol/gsm_24_301.h index d4bcd87..5d1d00c 100644 --- a/include/osmocom/gprs/protocol/gsm_24_301.h +++ b/include/osmocom/gprs/protocol/gsm_24_301.h @@ -3,6 +3,10 @@ #pragma once /*! Tracking area TS 24.301, section 9.9.3.32 */ + +#include <stdbool.h> +#include <stdint.h> + struct osmo_eutran_tai { uint16_t mcc; uint16_t mnc; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2f853d00738b481d00c60aa6ad6764cf2c861904 Gerrit-Change-Number: 38667 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: gsup: fix wrong ordering of IEs

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email ) Change subject: gsup: fix wrong ordering of IEs ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I think in general it makes sense to ho have the Message class prior in the message, since the class may affect how other fields are used or present etc. @lynxis@fe80.eu please also have a look at this patch. it may also be worth looking at https://gitea.osmocom.org/erlang/osmo_gsup and its users. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5caa3101da310cddfa311d068ad889bca697b438 Gerrit-Change-Number: 38666 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:09:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: gsup: fix wrong ordering of IEs

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gsup: fix wrong ordering of IEs ...................................................................... gsup: fix wrong ordering of IEs GSUP protocol specification mandates specific IE ordering; however some message definitions are out of sync with the IE order produced by libosmocore's GSUP encoder. Change-Id: I5caa3101da310cddfa311d068ad889bca697b438 Fixes: 54343caa ("common/gsup.adoc: document Supplementary Services extension") Fixes: ce32ec2a ("gsup: Document ePDG Tunnel Req/Res/Err") Fixes: 92cf519c ("GSUP: document inter-MSC handover additions") --- M common/chapters/gsup.adoc 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/66/38666/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5caa3101da310cddfa311d068ad889bca697b438 Gerrit-Change-Number: 38666 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: gsup: fix wrong placement of Cause IE

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email ) Change subject: gsup: fix wrong placement of Cause IE ...................................................................... gsup: fix wrong placement of Cause IE GSUP protocol specification mandates specific IE ordering; however some message definitions are out of sync with the IE order produced by libosmocore's GSUP encoder. Change-Id: I5caa3101da310cddfa311d068ad889bca697b438 Fixes: 54343caa ("common/gsup.adoc: document Supplementary Services extension") Fixes: ce32ec2a ("gsup: Document ePDG Tunnel Req/Res/Err") --- M common/chapters/gsup.adoc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/66/38666/1 diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index f5cce14..b049330 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -643,9 +643,9 @@ |IEI|IE|Type|Presence|Format|Length | |Message Type|<<gsup-ie-msgtype>>|M|V|1 |01|IMSI|<<gsup-ie-imsi>>|M|TLV|2-10 +|02|Cause|<<gsup-ie-cause>>|M|TLV|3 |30|Session ID|<<gsup-ie-session-id>>|M|TLV|6 |31|Session State|<<gsup-ie-session-state>>|M|TLV|3 -|02|Cause|<<gsup-ie-cause>>|M|TLV|3 |=== [[gsup-msg-proc-supl-serv-res]] @@ -1114,8 +1114,8 @@ |IEI|IE|Type|Presence|Format|Length | |Message Type|<<gsup-ie-msgtype>>|M|V|1 |01|IMSI|<<gsup-ie-imsi>>|M|TLV|2-10 -|0a|Message Class|<<gsup-ie-message-class>>|M|TLV|3 |02|Cause|<<gsup-ie-cause>>|M|TLV|3 +|0a|Message Class|<<gsup-ie-message-class>>|M|TLV|3 |=== [[gsup-msg-epdg-tunnel-res]] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5caa3101da310cddfa311d068ad889bca697b438 Gerrit-Change-Number: 38666 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: osmo-*.cfg: enable gsmtap log

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38665?usp=email ) Change subject: osmo-*.cfg: enable gsmtap log ...................................................................... osmo-*.cfg: enable gsmtap log Now that jenkins uses the osmo-*.cfg files from osmo-ttcn3-hacks for the testsuites that were ported to testenv, make sure that these configs enable logging to gsmtap log as it was the case in docker-playground. This gives useful additional context in the pcap files. Change-Id: I8a1c734c0d34b81e70707b0ac6732a366b867bbe --- M bsc-nat/osmo-bsc-nat.cfg M bsc/osmo-bsc-sccplite.cfg M bsc/osmo-bsc-vamos.cfg M bsc/osmo-bsc.cfg M bsc/osmo-stp.cfg M gbproxy/osmo-gbproxy.cfg M gbproxy/osmo-gbproxy.fr.cfg M hlr/osmo-hlr.cfg M hnbgw/osmo-stp.cfg M hnodeb/osmo-hnodeb.cfg M msc/osmo-msc.cfg M msc/osmo-stp.cfg M pcap-client/osmo-pcap-client.cfg M sip/osmo-sip-connector.cfg M upf/osmo-upf.cfg 15 files changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/38665/1 diff --git a/bsc-nat/osmo-bsc-nat.cfg b/bsc-nat/osmo-bsc-nat.cfg index ec1a7c2..f7b51e5 100644 --- a/bsc-nat/osmo-bsc-nat.cfg +++ b/bsc-nat/osmo-bsc-nat.cfg @@ -2,6 +2,10 @@ ! OsmoBSCNAT (0.12.0.266-2daa9) configuration saved from vty !! ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging color 1 diff --git a/bsc/osmo-bsc-sccplite.cfg b/bsc/osmo-bsc-sccplite.cfg index c5ae4f6..f8dc619 100644 --- a/bsc/osmo-bsc-sccplite.cfg +++ b/bsc/osmo-bsc-sccplite.cfg @@ -3,6 +3,10 @@ !! password foo ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! stats interval 0 stats reporter statsd prefix TTCN3 diff --git a/bsc/osmo-bsc-vamos.cfg b/bsc/osmo-bsc-vamos.cfg index 9f91a11..bf369f6 100644 --- a/bsc/osmo-bsc-vamos.cfg +++ b/bsc/osmo-bsc-vamos.cfg @@ -3,6 +3,10 @@ !! password foo ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging print extended-timestamp 1 diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index 62a33f2..958db6a 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -3,6 +3,10 @@ !! password foo ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging print extended-timestamp 1 diff --git a/bsc/osmo-stp.cfg b/bsc/osmo-stp.cfg index 3d47bba..3a2df31 100644 --- a/bsc/osmo-stp.cfg +++ b/bsc/osmo-stp.cfg @@ -2,6 +2,10 @@ ! OsmoSTP (0.8.1) configuration saved from vty !! ! +log gsmtap 172.18.31.203 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging print extended-timestamp 1 diff --git a/gbproxy/osmo-gbproxy.cfg b/gbproxy/osmo-gbproxy.cfg index d269567..0fc9fc2 100644 --- a/gbproxy/osmo-gbproxy.cfg +++ b/gbproxy/osmo-gbproxy.cfg @@ -2,6 +2,9 @@ ! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty !! ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 log stderr logging filter all 1 logging color 1 diff --git a/gbproxy/osmo-gbproxy.fr.cfg b/gbproxy/osmo-gbproxy.fr.cfg index b7eb538..fd5ee8a 100644 --- a/gbproxy/osmo-gbproxy.fr.cfg +++ b/gbproxy/osmo-gbproxy.fr.cfg @@ -2,6 +2,9 @@ ! Osmocom Gb Proxy (0.9.0.404-6463) configuration saved from vty !! ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 log stderr logging level lns debug line vty diff --git a/hlr/osmo-hlr.cfg b/hlr/osmo-hlr.cfg index a17881e..e9fa8ce 100644 --- a/hlr/osmo-hlr.cfg +++ b/hlr/osmo-hlr.cfg @@ -1,6 +1,10 @@ ! ! OsmoHLR example configuration ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging color 1 diff --git a/hnbgw/osmo-stp.cfg b/hnbgw/osmo-stp.cfg index e4b80d4..ba3e3d0 100644 --- a/hnbgw/osmo-stp.cfg +++ b/hnbgw/osmo-stp.cfg @@ -1,6 +1,9 @@ ! ! OsmoSTP (0.8.1) configuration saved from vty !! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 ! log stderr logging filter all 1 diff --git a/hnodeb/osmo-hnodeb.cfg b/hnodeb/osmo-hnodeb.cfg index f05ec53..87c36f5 100644 --- a/hnodeb/osmo-hnodeb.cfg +++ b/hnodeb/osmo-hnodeb.cfg @@ -1,3 +1,7 @@ +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging color 1 diff --git a/msc/osmo-msc.cfg b/msc/osmo-msc.cfg index a886565..2fd83ad 100644 --- a/msc/osmo-msc.cfg +++ b/msc/osmo-msc.cfg @@ -2,6 +2,10 @@ ! OsmoMSC (1.1.2.66-629c4-dirty) configuration saved from vty !! ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging print extended-timestamp 1 diff --git a/msc/osmo-stp.cfg b/msc/osmo-stp.cfg index 772b6d1..bfdbb37 100644 --- a/msc/osmo-stp.cfg +++ b/msc/osmo-stp.cfg @@ -2,6 +2,10 @@ ! OsmoSTP (0.8.1) configuration saved from vty !! ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging print extended-timestamp 1 diff --git a/pcap-client/osmo-pcap-client.cfg b/pcap-client/osmo-pcap-client.cfg index 09201fc..33706d8 100644 --- a/pcap-client/osmo-pcap-client.cfg +++ b/pcap-client/osmo-pcap-client.cfg @@ -2,6 +2,9 @@ ! OsmoPCAPClient (UNKNOWN-dirty) configuration saved from vty !! ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 ! line vty no login diff --git a/sip/osmo-sip-connector.cfg b/sip/osmo-sip-connector.cfg index 59f89db..50763da 100644 --- a/sip/osmo-sip-connector.cfg +++ b/sip/osmo-sip-connector.cfg @@ -2,6 +2,10 @@ ! OsmoMNCC (1.1.0-dirty) configuration saved from vty !! ! +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 +! log stderr logging filter all 1 logging color 1 diff --git a/upf/osmo-upf.cfg b/upf/osmo-upf.cfg index c354d8d..74c1b59 100644 --- a/upf/osmo-upf.cfg +++ b/upf/osmo-upf.cfg @@ -1,3 +1,6 @@ +log gsmtap 127.0.0.1 + logging level set-all debug + logging filter all 1 log stderr logging filter all 1 logging color 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8a1c734c0d34b81e70707b0ac6732a366b867bbe Gerrit-Change-Number: 38665 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in pysim[master]: pySim-shell_test: add new testcase for card initialization

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/38658?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-shell_test: add new testcase for card initialization ...................................................................... pySim-shell_test: add new testcase for card initialization The card initialization normally takes place automatically. Nearly all testcases implicitly cover this code-path. However, it is also possible to skip the card initialization and do it at some later point. This is commonly the case for unprovisioned card that require some custom APDUs in a basic initialization step. When this step is done one would use the "equip" command to level up to the full featured mode. This patch adds a testcase for this scenario Related: OS#6367 Change-Id: I01a03fa07d8c62164453bd707c5943288ff1a972 --- A tests/pySim-shell_test/card_init/__init__.py A tests/pySim-shell_test/card_init/test.py A tests/pySim-shell_test/card_init/test_card_init.script 3 files changed, 62 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/58/38658/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38658?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01a03fa07d8c62164453bd707c5943288ff1a972 Gerrit-Change-Number: 38658 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ci[master]: osmo-depcheck: Remove libosmo-sccp-legacy dep libosmo-xua

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/38632?usp=email ) Change subject: osmo-depcheck: Remove libosmo-sccp-legacy dep libosmo-xua ...................................................................... osmo-depcheck: Remove libosmo-sccp-legacy dep libosmo-xua libosmo-xua was not really used anywhere and dropped here: https://gitea.osmocom.org/osmocom/libosmo-sccp-legacy/pulls/1 Change-Id: I83ef3576507cc615090afd5d80d985551c7aa5a7 --- M scripts/osmo-depcheck/config.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/scripts/osmo-depcheck/config.py b/scripts/osmo-depcheck/config.py index 39c79b4..19619b0 100644 --- a/scripts/osmo-depcheck/config.py +++ b/scripts/osmo-depcheck/config.py @@ -38,8 +38,7 @@ "libosmotrau"), "libosmo-sigtran": ("libosmo-sigtran"), "libosmo-sccp-legacy": ("libosmo-mtp", - "libosmo-sccp", - "libosmo-xua"), + "libosmo-sccp"), "osmo-ggsn": ("libgtp"), "osmo-hlr": ("libosmo-gsup-client"), "osmo-iuh": ("libosmo-ranap"), -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38632?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I83ef3576507cc615090afd5d80d985551c7aa5a7 Gerrit-Change-Number: 38632 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024