Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email ) Change subject: gsup: fix wrong ordering of IEs ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I think in general it makes sense to ho have the Message class prior in the message, since the class may affect how other fields are used or present etc. @lynxis@fe80.eu please also have a look at this patch. it may also be worth looking at https://gitea.osmocom.org/erlang/osmo_gsup and its users. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5caa3101da310cddfa311d068ad889bca697b438 Gerrit-Change-Number: 38666 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 15:09:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes