November 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_instance_get_pc_fmt()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38652?usp=email ) Change subject: sigtran: Add API osmo_ss7_instance_get_pc_fmt() ...................................................................... sigtran: Add API osmo_ss7_instance_get_pc_fmt() This allows getting the PC format of an osmo_ss7_instance without having to access its structs fields directly Change-Id: Ia7e259574f14969348d3bcaa1991247272958a7d --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7.c 3 files changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/52/38652/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index e732e2e..df47c0f 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -11,4 +11,4 @@ libosmo-sigtran add API osmo_sccp_{release,return,reset,error,refusal}_cause_name(s), osmo_sua_sccp_cause_name libosmo-sigtran add API osmo_ss7_route_get_dest_as() libosmo-sigtran Make private osmo_ss7_route -libosmo-sigtran add API osmo_ss7_instance_get_id(), osmo_ss7_instance_get_name() +libosmo-sigtran add API osmo_ss7_instance_get_id(), osmo_ss7_instance_get_name(), osmo_ss7_instance_get_pc_fmt() diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 34d0467..eaf3855 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -99,6 +99,8 @@ int osmo_ss7_instance_set_pc_fmt(struct osmo_ss7_instance *inst, uint8_t c0, uint8_t c1, uint8_t c2); +const struct osmo_ss7_pc_fmt * +osmo_ss7_instance_get_pc_fmt(const struct osmo_ss7_instance *inst); struct osmo_sccp_instance *osmo_ss7_ensure_sccp(struct osmo_ss7_instance *inst); diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 0512b6b..667d1ad 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -413,6 +413,12 @@ return 0; } +const struct osmo_ss7_pc_fmt * +osmo_ss7_instance_get_pc_fmt(const struct osmo_ss7_instance *inst) +{ + return &inst->cfg.pc_fmt; +} + /*! Allocate an SCCP instance, if not present yet. * \returns inst->sccp. */ struct osmo_sccp_instance *osmo_ss7_ensure_sccp(struct osmo_ss7_instance *inst) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia7e259574f14969348d3bcaa1991247272958a7d Gerrit-Change-Number: 38652 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo-python-tests[master]: Update osmopy module version to match released tag

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/38637?usp=email ) Change subject: Update osmopy module version to match released tag ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Sounds like a good chance to tag a new release? -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/38637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Idca3f28dad015e626d604e545a0f9b9c9e7bf979 Gerrit-Change-Number: 38637 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Nov 2024 16:28:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_instance_get_id()

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38648?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sigtran: Add API osmo_ss7_instance_get_id() ...................................................................... sigtran: Add API osmo_ss7_instance_get_id() This allows getting the ID of an osmo_ss7_instance without having to access its structs fields directly. Change-Id: Id7b6f23a1a223fb232238b624eb4f3295790bcb1 --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7.c 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/48/38648/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38648?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id7b6f23a1a223fb232238b624eb4f3295790bcb1 Gerrit-Change-Number: 38648 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

7 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_instance_get_name()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38651?usp=email ) Change subject: sigtran: Add API osmo_ss7_instance_get_name() ...................................................................... sigtran: Add API osmo_ss7_instance_get_name() This allows getting the name of an osmo_ss7_instance without having to access its structs fields directly. Change-Id: I521b0b140c600dbd8d32721329ea02668ceac576 --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7.c 3 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/51/38651/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 5ede826..e732e2e 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -11,4 +11,4 @@ libosmo-sigtran add API osmo_sccp_{release,return,reset,error,refusal}_cause_name(s), osmo_sua_sccp_cause_name libosmo-sigtran add API osmo_ss7_route_get_dest_as() libosmo-sigtran Make private osmo_ss7_route -libosmo-sigtran add API osmo_ss7_instance_get_id() +libosmo-sigtran add API osmo_ss7_instance_get_id(), osmo_ss7_instance_get_name() diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index d9d62a8..34d0467 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -95,6 +95,7 @@ void osmo_ss7_instance_destroy(struct osmo_ss7_instance *inst); uint32_t osmo_ss7_instance_get_id(const struct osmo_ss7_instance *inst); +const char *osmo_ss7_instance_get_name(const struct osmo_ss7_instance *inst); int osmo_ss7_instance_set_pc_fmt(struct osmo_ss7_instance *inst, uint8_t c0, uint8_t c1, uint8_t c2); diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index ff771cb..0512b6b 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -390,6 +390,11 @@ return inst->cfg.id; } +const char *osmo_ss7_instance_get_name(const struct osmo_ss7_instance *inst) +{ + return inst->cfg.name; +} + /*! \brief Set the point code format used in given SS7 instance */ int osmo_ss7_instance_set_pc_fmt(struct osmo_ss7_instance *inst, uint8_t c0, uint8_t c1, uint8_t c2) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38651?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I521b0b140c600dbd8d32721329ea02668ceac576 Gerrit-Change-Number: 38651 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: lb: Avoid using osmo_ss7_instance private field

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38649?usp=email ) Change subject: lb: Avoid using osmo_ss7_instance private field ...................................................................... lb: Avoid using osmo_ss7_instance private field We know the id because we just found/created it base don that id, so simply use it instead of accessing the library object field. Change-Id: Ib6d1f4898eb0a804ebda527fdd876d2ca4ec1e67 --- M src/osmo-bsc/lb.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/38649/1 diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 511a545..6743dba 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -450,13 +450,13 @@ OSMO_SCCP_SSN_SMLC_BSSAP_LE); /* Set up SCCP user and one ASP+AS */ - snprintf(inst_name, sizeof(inst_name), "Lb-%u-%s", cs7_inst->cfg.id, osmo_ss7_asp_protocol_name(used_proto)); + snprintf(inst_name, sizeof(inst_name), "Lb-%u-%s", bsc_gsmnet->smlc->cs7_instance, osmo_ss7_asp_protocol_name(used_proto)); LOGP(DLCS, LOGL_NOTICE, "Initializing SCCP connection for Lb/%s on cs7 instance %u\n", - osmo_ss7_asp_protocol_name(used_proto), cs7_inst->cfg.id); + osmo_ss7_asp_protocol_name(used_proto), bsc_gsmnet->smlc->cs7_instance); /* SS7 Protocol stack */ default_pc = osmo_ss7_pointcode_parse(NULL, BSC_DEFAULT_PC); - sccp = osmo_sccp_simple_client_on_ss7_id(tall_bsc_ctx, cs7_inst->cfg.id, inst_name, + sccp = osmo_sccp_simple_client_on_ss7_id(tall_bsc_ctx, bsc_gsmnet->smlc->cs7_instance, inst_name, default_pc, used_proto, 0, DEFAULT_ASP_LOCAL_IP, 0, DEFAULT_ASP_REMOTE_IP); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib6d1f4898eb0a804ebda527fdd876d2ca4ec1e67 Gerrit-Change-Number: 38649 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Use new libosmo-sigtran API osmo_ss7_instance_get_id()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email ) Change subject: Use new libosmo-sigtran API osmo_ss7_instance_get_id() ...................................................................... Use new libosmo-sigtran API osmo_ss7_instance_get_id() Depends: libosmo-sigtran.git Change-IdChange-Id Id7b6f23a1a223fb232238b624eb4f3295790bcb1 Change-Id: Ic0a468de0e8852ddd1ebd99f25a6400475af9a1f --- M TODO-RELEASE M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/lb.c M src/osmo-bsc/osmo_bsc_sigtran.c 4 files changed, 27 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/38650/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index c073b60..b5cd5cc 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,4 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmo-sigtran >2.0.1 Use API osmo_ss7_route_get_dest_as() \ No newline at end of file +libosmo-sigtran >2.0.1 Use API osmo_ss7_route_get_dest_as(), osmo_ss7_instance_get_id() diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 777807b..98a7792 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2967,16 +2967,18 @@ struct bsc_msc_data *msc = bsc_msc_data(vty); const char *bsc_addr_name = argv[0]; struct osmo_ss7_instance *ss7; + uint32_t ss7_id; ss7 = osmo_sccp_addr_by_name(&msc->a.bsc_addr, bsc_addr_name); if (!ss7) { vty_out(vty, "Error: No such SCCP addressbook entry: '%s'%s", bsc_addr_name, VTY_NEWLINE); return CMD_ERR_INCOMPLETE; } + ss7_id = osmo_ss7_instance_get_id(ss7); /* Prevent mixing addresses from different CS7/SS7 instances */ if (msc->a.cs7_instance_valid) { - if (msc->a.cs7_instance != ss7->cfg.id) { + if (msc->a.cs7_instance != ss7_id) { vty_out(vty, "Error: SCCP addressbook entry from mismatching CS7 instance: '%s'%s", bsc_addr_name, VTY_NEWLINE); @@ -2984,7 +2986,7 @@ } } - msc->a.cs7_instance = ss7->cfg.id; + msc->a.cs7_instance = ss7_id; msc->a.cs7_instance_valid = true; enforce_standard_ssn(vty, &msc->a.bsc_addr); msc->a.bsc_addr_name = talloc_strdup(msc, bsc_addr_name); @@ -2999,16 +3001,18 @@ struct bsc_msc_data *msc = bsc_msc_data(vty); const char *msc_addr_name = argv[0]; struct osmo_ss7_instance *ss7; + uint32_t ss7_id; ss7 = osmo_sccp_addr_by_name(&msc->a.msc_addr, msc_addr_name); if (!ss7) { vty_out(vty, "Error: No such SCCP addressbook entry: '%s'%s", msc_addr_name, VTY_NEWLINE); return CMD_ERR_INCOMPLETE; } + ss7_id = osmo_ss7_instance_get_id(ss7); /* Prevent mixing addresses from different CS7/SS7 instances */ if (msc->a.cs7_instance_valid) { - if (msc->a.cs7_instance != ss7->cfg.id) { + if (msc->a.cs7_instance != ss7_id) { vty_out(vty, "Error: SCCP addressbook entry from mismatching CS7 instance: '%s'%s", msc_addr_name, VTY_NEWLINE); @@ -3016,7 +3020,7 @@ } } - msc->a.cs7_instance = ss7->cfg.id; + msc->a.cs7_instance = ss7_id; msc->a.cs7_instance_valid = true; enforce_standard_ssn(vty, &msc->a.msc_addr); msc->a.msc_addr_name = talloc_strdup(msc, msc_addr_name); diff --git a/src/osmo-bsc/lb.c b/src/osmo-bsc/lb.c index 6743dba..d4f645a 100644 --- a/src/osmo-bsc/lb.c +++ b/src/osmo-bsc/lb.c @@ -618,18 +618,20 @@ bool smlc_set_cs7_instance(struct vty *vty, const char *from_vty_cmd, const char *from_addr, struct osmo_ss7_instance *ss7) { + uint32_t ss7_id = osmo_ss7_instance_get_id(ss7); + if (bsc_gsmnet->smlc->cs7_instance_valid) { - if (bsc_gsmnet->smlc->cs7_instance != ss7->cfg.id) { + if (bsc_gsmnet->smlc->cs7_instance != ss7_id) { LOGP(DLCS, LOGL_ERROR, "%s: expecting address from cs7 instance %u, but '%s' is from %u\n", - from_vty_cmd, bsc_gsmnet->smlc->cs7_instance, from_addr, ss7->cfg.id); + from_vty_cmd, bsc_gsmnet->smlc->cs7_instance, from_addr, ss7_id); vty_out(vty, "Error:" " %s: expecting address from cs7 instance %u, but '%s' is from %u%s", - from_vty_cmd, bsc_gsmnet->smlc->cs7_instance, from_addr, ss7->cfg.id, VTY_NEWLINE); + from_vty_cmd, bsc_gsmnet->smlc->cs7_instance, from_addr, ss7_id, VTY_NEWLINE); return false; } } else { - bsc_gsmnet->smlc->cs7_instance = ss7->cfg.id; + bsc_gsmnet->smlc->cs7_instance = ss7_id; bsc_gsmnet->smlc->cs7_instance_valid = true; LOGP(DLCS, LOGL_NOTICE, "Lb interface is using cs7 instance %u\n", bsc_gsmnet->smlc->cs7_instance); } diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index cdc5785..66d38bf 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -113,8 +113,9 @@ static struct bsc_msc_data *get_msc_by_pc(struct osmo_ss7_instance *cs7, uint32_t pc) { struct bsc_msc_data *msc; + uint32_t cs7_id = osmo_ss7_instance_get_id(cs7); llist_for_each_entry(msc, msc_list, entry) { - if (msc->a.cs7_instance != cs7->cfg.id) + if (msc->a.cs7_instance != cs7_id) continue; if ((msc->a.msc_addr.presence & OSMO_SCCP_ADDR_T_PC) == 0) continue; @@ -618,14 +619,15 @@ char inst_name[32]; enum osmo_ss7_asp_protocol used_proto = OSMO_SS7_ASP_PROT_NONE; int prev_msc_nr; + uint32_t inst_id = osmo_ss7_instance_get_id(inst); struct osmo_sccp_instance *sccp; struct bsc_sccp_inst *bsc_sccp; llist_for_each_entry(msc, msc_list, entry) { /* An MSC with invalid cs7 instance id defaults to cs7 instance 0 */ - if ((inst->cfg.id != msc->a.cs7_instance) - && !(inst->cfg.id == 0 && !msc->a.cs7_instance_valid)) + if ((inst_id != msc->a.cs7_instance) + && !(inst_id == 0 && !msc->a.cs7_instance_valid)) continue; /* This msc runs on this cs7 inst. Check the asp_proto. */ @@ -636,7 +638,7 @@ prev_msc_nr, msc->nr, osmo_ss7_asp_protocol_name(used_proto), osmo_ss7_asp_protocol_name(msc->a.asp_proto), - inst->cfg.id); + inst_id); return -EINVAL; } @@ -647,17 +649,17 @@ if (used_proto == OSMO_SS7_ASP_PROT_NONE) { /* This instance has no MSC associated with it */ - LOGP(DMSC, LOGL_ERROR, "cs7 instance %u has no MSCs configured to run on it\n", inst->cfg.id); + LOGP(DMSC, LOGL_ERROR, "cs7 instance %u has no MSCs configured to run on it\n", inst_id); continue; } - snprintf(inst_name, sizeof(inst_name), "A-%u-%s", inst->cfg.id, osmo_ss7_asp_protocol_name(used_proto)); + snprintf(inst_name, sizeof(inst_name), "A-%u-%s", inst_id, osmo_ss7_asp_protocol_name(used_proto)); LOGP(DMSC, LOGL_NOTICE, "Initializing SCCP connection for A/%s on cs7 instance %u\n", - osmo_ss7_asp_protocol_name(used_proto), inst->cfg.id); + osmo_ss7_asp_protocol_name(used_proto), inst_id); /* SS7 Protocol stack */ default_pc = osmo_ss7_pointcode_parse(NULL, BSC_DEFAULT_PC); - sccp = osmo_sccp_simple_client_on_ss7_id(tall_bsc_ctx, inst->cfg.id, inst_name, + sccp = osmo_sccp_simple_client_on_ss7_id(tall_bsc_ctx, inst_id, inst_name, default_pc, used_proto, 0, DEFAULT_ASP_LOCAL_IP, 0, DEFAULT_ASP_REMOTE_IP); @@ -673,8 +675,8 @@ char msc_name[32]; /* Skip MSCs that don't run on this cs7 instance */ - if ((inst->cfg.id != msc->a.cs7_instance) - && !(inst->cfg.id == 0 && !msc->a.cs7_instance_valid)) + if ((inst_id != msc->a.cs7_instance) + && !(inst_id == 0 && !msc->a.cs7_instance_valid)) continue; snprintf(msc_name, sizeof(msc_name), "msc-%d", msc->nr); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38650?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0a468de0e8852ddd1ebd99f25a6400475af9a1f Gerrit-Change-Number: 38650 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-sigtran[master]: sigtran: Add API osmo_ss7_instance_get_id()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38648?usp=email ) Change subject: sigtran: Add API osmo_ss7_instance_get_id() ...................................................................... sigtran: Add API osmo_ss7_instance_get_id() This allows getting the ID of an osmo_ss7_instance without having to access its structs fields directly. Change-Id: Id7b6f23a1a223fb232238b624eb4f3295790bcb1 --- M TODO-RELEASE M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7.c 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/48/38648/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 06ae923..4122d15 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -11,3 +11,4 @@ libosmo-sigtran add API osmo_sccp_{release,return,reset,error,refusal}_cause_name(s), osmo_sua_sccp_cause_name libosmo-sigtran add API osmo_ss7_route_get_dest_as() libosmo-sigtran Make private osmo_ss7_route +libosmo-sigtran add API osmo_ss7_instance_get_id() \ No newline at end of file diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 67f4e99..d9d62a8 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -93,6 +93,9 @@ struct osmo_ss7_instance * osmo_ss7_instance_find_or_create(void *ctx, uint32_t id); void osmo_ss7_instance_destroy(struct osmo_ss7_instance *inst); + +uint32_t osmo_ss7_instance_get_id(const struct osmo_ss7_instance *inst); + int osmo_ss7_instance_set_pc_fmt(struct osmo_ss7_instance *inst, uint8_t c0, uint8_t c1, uint8_t c2); diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 40bf0b1..ff771cb 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -385,6 +385,11 @@ talloc_free(inst); } +uint32_t osmo_ss7_instance_get_id(const struct osmo_ss7_instance *inst) +{ + return inst->cfg.id; +} + /*! \brief Set the point code format used in given SS7 instance */ int osmo_ss7_instance_set_pc_fmt(struct osmo_ss7_instance *inst, uint8_t c0, uint8_t c1, uint8_t c2) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38648?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id7b6f23a1a223fb232238b624eb4f3295790bcb1 Gerrit-Change-Number: 38648 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[S] Change in osmo-bts[master]: csd_v110: set E2 bit correctly for TCH/F4.8 NT

by falconia

falconia has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38304?usp=email ) Change subject: csd_v110: set E2 bit correctly for TCH/F4.8 NT ...................................................................... Abandoned A different patch has been merged, fixing the present issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e0ad58aad3361b3a2b0a47113bd065587636730 Gerrit-Change-Number: 38304 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[M] Change in libosmo-sigtran[master]: sigtran: Make osmo_ss7_asp_peer private

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38647?usp=email ) Change subject: sigtran: Make osmo_ss7_asp_peer private ...................................................................... sigtran: Make osmo_ss7_asp_peer private This struct object is only used internally so far, there's no need to make it public. Change-Id: I6729cc599af3a799d89bc0514d223c84f2233a4b --- M include/osmocom/sigtran/osmo_ss7.h M src/Makefile.am M src/osmo_ss7_asp.c M src/osmo_ss7_asp_peer.c M src/osmo_ss7_vty.c M src/osmo_ss7_xua_srv.c M src/sccp_user.c M src/ss7_asp.h A src/ss7_asp_peer.h M src/ss7_internal.h 10 files changed, 67 insertions(+), 55 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/47/38647/1 diff --git a/include/osmocom/sigtran/osmo_ss7.h b/include/osmocom/sigtran/osmo_ss7.h index 2d45733..67f4e99 100644 --- a/include/osmocom/sigtran/osmo_ss7.h +++ b/include/osmocom/sigtran/osmo_ss7.h @@ -250,14 +250,6 @@ * SS7 Application Server Processes ***********************************************************************/ -struct osmo_ss7_asp_peer { - char *host[OSMO_SOCK_MAX_ADDRS]; - size_t host_cnt; - uint16_t port; - /* index in "hosts" array marking the SCTP Primary Address, -1 if no explicit Primary Address set */ - int idx_primary; -}; - enum osmo_ss7_asp_admin_state { /*! no SCTP association with peer */ OSMO_SS7_ASP_ADM_S_SHUTDOWN, @@ -284,16 +276,6 @@ /*! Accept SSNM even if ASP is in AS-INACTIVE state */ #define OSMO_SS7_ASP_QUIRK_SNM_INACTIVE 0x00000004 -int osmo_ss7_asp_peer_snprintf(char* buf, size_t buf_len, struct osmo_ss7_asp_peer *peer); -void osmo_ss7_asp_peer_init(struct osmo_ss7_asp_peer *peer); -int osmo_ss7_asp_peer_set_hosts(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, - const char *const*hosts, size_t host_cnt); -int osmo_ss7_asp_peer_set_hosts2(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, - const char *const*hosts, size_t host_cnt, int idx_primary); -int osmo_ss7_asp_peer_add_host(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *host); -int osmo_ss7_asp_peer_add_host2(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *host, bool is_primary_addr); -int osmo_ss7_asp_peer_del_host(struct osmo_ss7_asp_peer *peer, const char *host); - struct osmo_ss7_asp * osmo_ss7_asp_find_by_name(struct osmo_ss7_instance *inst, const char *name); diff --git a/src/Makefile.am b/src/Makefile.am index 8071be8..1d09c0e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -5,6 +5,7 @@ noinst_HEADERS = \ sccp_internal.h \ ss7_asp.h \ + ss7_asp_peer.h \ ss7_internal.h \ ss7_link.h \ ss7_linkset.h \ diff --git a/src/osmo_ss7_asp.c b/src/osmo_ss7_asp.c index 1ee0f76..12a5d5f 100644 --- a/src/osmo_ss7_asp.c +++ b/src/osmo_ss7_asp.c @@ -410,16 +410,16 @@ * address are set on the remote side, IPv4 on the local * side must be set too */ if (ss7_ipv6_sctp_supported("::", true) && !(rem_has_v4 && !rem_has_v6)) - osmo_ss7_asp_peer_add_host(&asp->cfg.local, asp, "::"); + ss7_asp_peer_add_host(&asp->cfg.local, asp, "::"); else - osmo_ss7_asp_peer_add_host(&asp->cfg.local, asp, "0.0.0.0"); + ss7_asp_peer_add_host(&asp->cfg.local, asp, "0.0.0.0"); changed = true; } /* If no remote addr was set */ if (!asp->cfg.remote.host_cnt) { - osmo_ss7_asp_peer_add_host(&asp->cfg.remote, asp, "127.0.0.1"); + ss7_asp_peer_add_host(&asp->cfg.remote, asp, "127.0.0.1"); if (ss7_ipv6_sctp_supported("::1", false)) - osmo_ss7_asp_peer_add_host(&asp->cfg.remote, asp, "::1"); + ss7_asp_peer_add_host(&asp->cfg.remote, asp, "::1"); changed = true; } return changed; @@ -552,9 +552,9 @@ } rate_ctr_group_set_name(asp->ctrg, name); asp->inst = inst; - osmo_ss7_asp_peer_init(&asp->cfg.remote); + ss7_asp_peer_init(&asp->cfg.remote); asp->cfg.remote.port = remote_port; - osmo_ss7_asp_peer_init(&asp->cfg.local); + ss7_asp_peer_init(&asp->cfg.local); asp->cfg.local.port = local_port; asp->cfg.trans_proto = trans_proto; asp->cfg.proto = proto; @@ -617,8 +617,8 @@ uint8_t byte; OSMO_ASSERT(ss7_initialized); - osmo_ss7_asp_peer_snprintf(bufloc, sizeof(bufloc), &asp->cfg.local); - osmo_ss7_asp_peer_snprintf(bufrem, sizeof(bufrem), &asp->cfg.remote); + ss7_asp_peer_snprintf(bufloc, sizeof(bufloc), &asp->cfg.local); + ss7_asp_peer_snprintf(bufrem, sizeof(bufrem), &asp->cfg.remote); LOGPASP(asp, DLSS7, LOGL_INFO, "Restarting ASP %s, r=%s<->l=%s\n", asp->cfg.name, bufrem, bufloc); diff --git a/src/osmo_ss7_asp_peer.c b/src/osmo_ss7_asp_peer.c index 39a92b1..c31cdd9 100644 --- a/src/osmo_ss7_asp_peer.c +++ b/src/osmo_ss7_asp_peer.c @@ -37,6 +37,7 @@ #include <osmocom/sigtran/osmo_ss7.h> +#include "ss7_asp_peer.h" #include "ss7_internal.h" @@ -44,13 +45,13 @@ * SS7 Application Server Process peer ***********************************************************************/ -void osmo_ss7_asp_peer_init(struct osmo_ss7_asp_peer *peer) +void ss7_asp_peer_init(struct osmo_ss7_asp_peer *peer) { memset(peer, 0, sizeof(*peer)); peer->idx_primary = -1; } -int osmo_ss7_asp_peer_snprintf(char *buf, size_t buf_len, struct osmo_ss7_asp_peer *peer) +int ss7_asp_peer_snprintf(char *buf, size_t buf_len, struct osmo_ss7_asp_peer *peer) { int len = 0, offset = 0, rem = buf_len; int ret, i; @@ -90,7 +91,7 @@ * \param[in] host_cnt Number of strings in hosts * \param[in] idx_primary Index in "hosts" array marking the SCTP Primary Address, -1 if no explicit Primary Address set * \returns 0 on success; negative otherwise */ -int osmo_ss7_asp_peer_set_hosts2(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *const*hosts, size_t host_cnt, int idx_primary) +int ss7_asp_peer_set_hosts2(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *const*hosts, size_t host_cnt, int idx_primary) { int i = 0; @@ -118,9 +119,9 @@ * \param[in] hosts Array of strings containing IP addresses. * \param[in] host_cnt Number of strings in hosts * \returns 0 on success; negative otherwise */ -int osmo_ss7_asp_peer_set_hosts(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *const*hosts, size_t host_cnt) +int ss7_asp_peer_set_hosts(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *const*hosts, size_t host_cnt) { - return osmo_ss7_asp_peer_set_hosts2(peer, talloc_ctx, hosts, host_cnt, -1); + return ss7_asp_peer_set_hosts2(peer, talloc_ctx, hosts, host_cnt, -1); } /* Is string formatted IPv4/v6 addr considered IN(6)ADDR_ANY? */ @@ -139,7 +140,7 @@ * \param[in] host string containing an IP address. * \param[in] is_primary_addr whether this IP address is to be added as SCTP Primary Address * \returns 0 on success; negative otherwise */ -int osmo_ss7_asp_peer_add_host2(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, +int ss7_asp_peer_add_host2(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *host, bool is_primary_addr) { int i; @@ -212,7 +213,7 @@ * \param[in] peer Application Server Process peer the address is removed from. * \param[in] host string containing an IP address. * \returns 0 on success; negative otherwise */ -int osmo_ss7_asp_peer_del_host(struct osmo_ss7_asp_peer *peer, const char *host) +int ss7_asp_peer_del_host(struct osmo_ss7_asp_peer *peer, const char *host) { int i; struct osmo_sockaddr_str addr_str; @@ -257,10 +258,10 @@ * \param[in] talloc_ctx talloc context used to allocate new address. * \param[in] host string containing an IP address. * \returns 0 on success; negative otherwise */ -int osmo_ss7_asp_peer_add_host(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, +int ss7_asp_peer_add_host(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *host) { - return osmo_ss7_asp_peer_add_host2(peer, talloc_ctx, host, false); + return ss7_asp_peer_add_host2(peer, talloc_ctx, host, false); } bool ss7_asp_peer_match_host(const struct osmo_ss7_asp_peer *peer, const char *host, bool host_is_v6) diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 8dd9a4f..482e2f8 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -751,7 +751,7 @@ int fd = xs->server ? osmo_stream_srv_link_get_fd(xs->server) : -1; if (fd < 0) { - if (osmo_ss7_asp_peer_snprintf(buf, sizeof(buf), &xs->cfg.local) < 0) + if (ss7_asp_peer_snprintf(buf, sizeof(buf), &xs->cfg.local) < 0) snprintf(buf, sizeof(buf), "<error>"); } else { char hostbuf[OSMO_SOCK_MAX_ADDRS][INET6_ADDRSTRLEN]; @@ -965,7 +965,7 @@ int old_host_count = asp->cfg.local.host_cnt; int rc; - if (osmo_ss7_asp_peer_add_host2(&asp->cfg.local, asp, argv[0], is_primary) != 0) { + if (ss7_asp_peer_add_host2(&asp->cfg.local, asp, argv[0], is_primary) != 0) { vty_out(vty, "%% Failed adding host '%s' to set%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } @@ -1027,7 +1027,7 @@ } } - if (osmo_ss7_asp_peer_del_host(&asp->cfg.local, argv[0]) != 0) { + if (ss7_asp_peer_del_host(&asp->cfg.local, argv[0]) != 0) { vty_out(vty, "%% Failed deleting local address '%s' from set%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } @@ -1047,7 +1047,7 @@ int old_idx_primary = asp->cfg.remote.idx_primary; int rc; - if (osmo_ss7_asp_peer_add_host2(&asp->cfg.remote, asp, argv[0], is_primary) != 0) { + if (ss7_asp_peer_add_host2(&asp->cfg.remote, asp, argv[0], is_primary) != 0) { vty_out(vty, "%% Failed adding host '%s' to set%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } @@ -1084,7 +1084,7 @@ return CMD_WARNING; } - if (osmo_ss7_asp_peer_del_host(&asp->cfg.remote, argv[0]) != 0) { + if (ss7_asp_peer_del_host(&asp->cfg.remote, argv[0]) != 0) { vty_out(vty, "%% Failed deleting remote address '%s' from set%s", argv[0], VTY_NEWLINE); return CMD_WARNING; } @@ -1390,8 +1390,8 @@ if (!get_sockname_buf(buf_rem, sizeof(buf_rem), fd, trans_proto, false)) OSMO_STRLCPY_ARRAY(buf_rem, "<sockname-error>"); } else { - osmo_ss7_asp_peer_snprintf(buf_loc, sizeof(buf_loc), &asp->cfg.local); - osmo_ss7_asp_peer_snprintf(buf_rem, sizeof(buf_rem), &asp->cfg.remote); + ss7_asp_peer_snprintf(buf_loc, sizeof(buf_loc), &asp->cfg.local); + ss7_asp_peer_snprintf(buf_rem, sizeof(buf_rem), &asp->cfg.remote); } vty_out(vty, "%-12s %-12s %-13s %-4s %-4s %-9s %-23s %-23s%s", diff --git a/src/osmo_ss7_xua_srv.c b/src/osmo_ss7_xua_srv.c index db1481b..4962bfd 100644 --- a/src/osmo_ss7_xua_srv.c +++ b/src/osmo_ss7_xua_srv.c @@ -148,10 +148,10 @@ asp->cfg.remote.port = atoi(portbuf); asp->dyn_allocated = true; asp->server = srv; - osmo_ss7_asp_peer_set_hosts(&asp->cfg.local, asp, + ss7_asp_peer_set_hosts(&asp->cfg.local, asp, (const char * const*)oxs->cfg.local.host, oxs->cfg.local.host_cnt); - osmo_ss7_asp_peer_set_hosts(&asp->cfg.remote, asp, + ss7_asp_peer_set_hosts(&asp->cfg.remote, asp, &hostbuf_ptr, 1); osmo_ss7_asp_restart(asp); } @@ -279,7 +279,7 @@ uint8_t byte; const char *proto = get_value_string(osmo_ss7_asp_protocol_vals, xs->cfg.proto); - rc = osmo_ss7_asp_peer_snprintf(buf, sizeof(buf), &xs->cfg.local); + rc = ss7_asp_peer_snprintf(buf, sizeof(buf), &xs->cfg.local); if (rc < 0) { LOGP(DLSS7, LOGL_INFO, "Failed parsing %s Server osmo_ss7_asp_peer\n", proto); } else { @@ -316,7 +316,7 @@ int rc; OSMO_ASSERT(ss7_initialized); - rc = osmo_ss7_asp_peer_set_hosts(&xs->cfg.local, xs, local_hosts, local_host_cnt); + rc = ss7_asp_peer_set_hosts(&xs->cfg.local, xs, local_hosts, local_host_cnt); if (rc < 0) return rc; return osmo_stream_srv_link_set_addrs(xs->server, (const char **)xs->cfg.local.host, xs->cfg.local.host_cnt); @@ -327,7 +327,7 @@ { int rc; - rc = osmo_ss7_asp_peer_add_host(&xs->cfg.local, xs, local_host); + rc = ss7_asp_peer_add_host(&xs->cfg.local, xs, local_host); if (rc < 0) return rc; return osmo_stream_srv_link_set_addrs(xs->server, (const char **)xs->cfg.local.host, xs->cfg.local.host_cnt); @@ -338,7 +338,7 @@ { int rc; - rc = osmo_ss7_asp_peer_del_host(&xs->cfg.local, local_host); + rc = ss7_asp_peer_del_host(&xs->cfg.local, local_host); if (rc < 0) return rc; return osmo_stream_srv_link_set_addrs(xs->server, (const char **)xs->cfg.local.host, xs->cfg.local.host_cnt); diff --git a/src/sccp_user.c b/src/sccp_user.c index 3604883..d364eb5 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -645,9 +645,9 @@ /* Ensure that the ASP we use is set to role ASP. */ asp->cfg.role = OSMO_SS7_ASP_ROLE_ASP; if (default_local_ip) - osmo_ss7_asp_peer_set_hosts(&asp->cfg.local, asp, &default_local_ip, 1); + ss7_asp_peer_set_hosts(&asp->cfg.local, asp, &default_local_ip, 1); if (default_remote_ip) - osmo_ss7_asp_peer_set_hosts(&asp->cfg.remote, asp, &default_remote_ip, 1); + ss7_asp_peer_set_hosts(&asp->cfg.remote, asp, &default_remote_ip, 1); /* Make sure proper defaults are applied if app didn't provide specific default values */ ss7_asp_set_default_peer_hosts(asp); asp->simple_client_allocated = true; @@ -853,11 +853,11 @@ oxs = ss7_xua_server_find2(ss7, asp->cfg.trans_proto, prot, local_port); if (!oxs) goto out_asp; - if (osmo_ss7_asp_peer_set_hosts(&asp->cfg.local, asp, + if (ss7_asp_peer_set_hosts(&asp->cfg.local, asp, (const char* const*)oxs->cfg.local.host, oxs->cfg.local.host_cnt) < 0) goto out_asp; - if (osmo_ss7_asp_peer_add_host(&asp->cfg.remote, asp, remote_ip) < 0) + if (ss7_asp_peer_add_host(&asp->cfg.remote, asp, remote_ip) < 0) goto out_asp; asp->cfg.is_server = true; asp->cfg.role = OSMO_SS7_ASP_ROLE_SG; diff --git a/src/ss7_asp.h b/src/ss7_asp.h index 170482a..374cce8 100644 --- a/src/ss7_asp.h +++ b/src/ss7_asp.h @@ -9,6 +9,7 @@ #include <osmocom/sigtran/osmo_ss7.h> +#include "ss7_asp_peer.h" #include "ss7_internal.h" /*********************************************************************** diff --git a/src/ss7_asp_peer.h b/src/ss7_asp_peer.h new file mode 100644 index 0000000..bdd9b56 --- /dev/null +++ b/src/ss7_asp_peer.h @@ -0,0 +1,30 @@ +#pragma once + +#include <stdint.h> +#include <stdbool.h> +#include <unistd.h> + +/*********************************************************************** + * SS7 ASP Peer + ***********************************************************************/ + +struct osmo_ss7_asp_peer { + char *host[OSMO_SOCK_MAX_ADDRS]; + size_t host_cnt; + uint16_t port; + /* index in "hosts" array marking the SCTP Primary Address, -1 if no explicit Primary Address set */ + int idx_primary; +}; + +int ss7_asp_peer_snprintf(char *buf, size_t buf_len, struct osmo_ss7_asp_peer *peer); +void ss7_asp_peer_init(struct osmo_ss7_asp_peer *peer); +int ss7_asp_peer_set_hosts(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, + const char *const*hosts, size_t host_cnt); +int ss7_asp_peer_set_hosts2(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, + const char *const*hosts, size_t host_cnt, int idx_primary); +int ss7_asp_peer_add_host(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *host); +int ss7_asp_peer_add_host2(struct osmo_ss7_asp_peer *peer, void *talloc_ctx, const char *host, bool is_primary_addr); +int ss7_asp_peer_del_host(struct osmo_ss7_asp_peer *peer, const char *host); + +bool ss7_asp_peer_match_host(const struct osmo_ss7_asp_peer *peer, const char *host, bool host_is_v6); +int ss7_asp_peer_find_host(const struct osmo_ss7_asp_peer *peer, const char *host); diff --git a/src/ss7_internal.h b/src/ss7_internal.h index f326896..33d18a6 100644 --- a/src/ss7_internal.h +++ b/src/ss7_internal.h @@ -24,9 +24,6 @@ int ss7_asp_m3ua_tcp_srv_conn_rx_cb(struct osmo_stream_srv *conn, int res, struct msgb *msg); int ss7_asp_xua_srv_conn_closed_cb(struct osmo_stream_srv *srv); -bool ss7_asp_peer_match_host(const struct osmo_ss7_asp_peer *peer, const char *host, bool host_is_v6); -int ss7_asp_peer_find_host(const struct osmo_ss7_asp_peer *peer, const char *host); - int xua_tcp_segmentation_cb(struct msgb *msg); enum ss7_as_ctr { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6729cc599af3a799d89bc0514d223c84f2233a4b Gerrit-Change-Number: 38647 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: more tweaks for container shutdown logic

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38644?usp=email ) Change subject: testenv: more tweaks for container shutdown logic ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I71721fd41f044817e4021aea045a288f88506f76 Gerrit-Change-Number: 38644 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Nov 2024 15:50:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024