November 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: hlr: refactor f_SS_expect()

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: hlr: refactor f_SS_expect() ...................................................................... hlr: refactor f_SS_expect() Prepare for follow-up patches reworking SS related GSUP templates. Avoid passing "omit" for parameter 'ss' of the receive templates because this will no longer work as expected. Clean up code flow. Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 --- M hlr/HLR_Tests.ttcn 1 file changed, 37 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/38671/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: improve formatting of SS templates

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38583?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: library/gsup: improve formatting of SS templates ...................................................................... library/gsup: improve formatting of SS templates Change-Id: I27aa67ded044a4a5362795bb791d883c4af55cd9 --- M library/GSUP_Templates.ttcn 1 file changed, 74 insertions(+), 82 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/38583/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38583?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27aa67ded044a4a5362795bb791d883c4af55cd9 Gerrit-Change-Number: 38583 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/gsup: improve generic GSUP_PDU templates

by fixeria

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: library/gsup: improve generic GSUP_PDU templates ...................................................................... library/gsup: improve generic GSUP_PDU templates * Fix tr_GSUP: 'ies' cannot be omitted, so use '?' (not '*') * Add missing template restrictions ('value' / 'present') * Move GSUP_PDU templates after GSUP_IE templates Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89 --- M library/GSUP_Templates.ttcn 1 file changed, 16 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/38672/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89 Gerrit-Change-Number: 38672 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email ) Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I find this commit really difficult to review, with different stuff in it. […] I acknowledge that it's not easy to review this patch, but it's all related changes and splitting it further would require some more work and another round of testing... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873 Gerrit-Change-Number: 38584 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:08:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Parametrize UPF F-SEID

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38673?usp=email ) Change subject: hnbgw: Parametrize UPF F-SEID ...................................................................... hnbgw: Parametrize UPF F-SEID This is needed if we want to support several concurrent PFCP sessions. Change-Id: I8c32998c839f75ed93de639e48d08e1458a8032c --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/38673/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index f6bde48..9205599 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -195,23 +195,23 @@ } const OCT8 c_SEID0 := '0000000000000000'O; -const OCT8 c_SEID1 := '1111111111111111'O; type record PfcpParameters { /* whether we expect HNBGW to manage a UPF through PFCP: */ boolean pfcp_enabled, charstring pfcp_local_addr, Node_ID upf_node_id, - F_SEID up_f_seid, + F_SEID upf_f_seid, F_SEID hnbgw_f_seid optional } template (value) PfcpParameters t_PfcpParams(boolean pfcp_enabled := false, charstring pfcp_local_addr := "127.0.0.1", - charstring pfcp_upf_node_id := "\07osmocom\03org") := { + charstring pfcp_upf_node_id := "\07osmocom\03org", + uint64_t upf_f_seid := 1) := { pfcp_enabled := pfcp_enabled, pfcp_local_addr := pfcp_local_addr, upf_node_id := valueof(ts_PFCP_Node_ID_fqdn(pfcp_upf_node_id)), - up_f_seid := ts_PFCP_F_SEID_ipv4(f_inet_addr(pfcp_local_addr), c_SEID1), + upf_f_seid := ts_PFCP_F_SEID_ipv4(f_inet_addr(pfcp_local_addr), int2oct(upf_f_seid, 8)), hnbgw_f_seid := omit } @@ -551,10 +551,10 @@ } if (pfcp_teardown) { var PDU_PFCP m; - m := f_pfcp_expect(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.up_f_seid.seid)); + m := f_pfcp_expect(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.upf_f_seid.seid)); PFCP.send(ts_PFCP_Session_Del_Resp(m.sequence_number, g_pars.pfcp_pars.hnbgw_f_seid.seid)); /* ask PFCPEM to *not* route PDUs with this specific SEID to us */ - f_PFCPEM_unsubscribe_seid(c_SEID1); + f_PFCPEM_unsubscribe_seid(g_pars.pfcp_pars.upf_f_seid.seid); } tx := valueof(ts_RANAP_IuReleaseComplete()); @@ -787,7 +787,7 @@ /* Expect PFCP Session Establishment Request. */ m := f_pfcp_expect(tr_PFCP_Session_Est_Req()); /* Ask PFCPEM to route PDUs with to be indicated F-SEID to us. */ - f_PFCPEM_subscribe_seid(c_SEID1); + f_PFCPEM_subscribe_seid(g_pars.pfcp_pars.upf_f_seid.seid); /* We no longer expect to receive PFCP Session Establishment Request PDU(s). */ f_PFCPEM_unsubscribe_seid(c_SEID0); @@ -808,7 +808,7 @@ var template PDU_PFCP r := ts_PFCP_Session_Est_Resp(seq_nr := m.sequence_number, node_id := g_pars.pfcp_pars.upf_node_id, seid := g_pars.pfcp_pars.hnbgw_f_seid.seid, - f_seid := g_pars.pfcp_pars.up_f_seid, + f_seid := g_pars.pfcp_pars.upf_f_seid, created_pdr := {pdr1, pdr2}); PFCP.send(r); @@ -832,7 +832,7 @@ tx := valueof(ts_RANAP_RabAssResp(rab_smdl)); RUA.send(tx); - m := f_pfcp_expect(tr_PFCP_Session_Mod_Req(g_pars.pfcp_pars.up_f_seid.seid)); + m := f_pfcp_expect(tr_PFCP_Session_Mod_Req(g_pars.pfcp_pars.upf_f_seid.seid)); r := ts_PFCP_Session_Mod_Resp(m.sequence_number, g_pars.pfcp_pars.hnbgw_f_seid.seid); PFCP.send(r); diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index e15bba4..97ae334 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1449,7 +1449,7 @@ /* HNBGW tears down related PFCP sessions: */ if (g_pars.pfcp_pars.pfcp_enabled) { - var PDU_PFCP m := f_pfcp_expect(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.up_f_seid.seid)); + var PDU_PFCP m := f_pfcp_expect(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.upf_f_seid.seid)); PFCP.send(ts_PFCP_Session_Del_Resp(m.sequence_number, g_pars.pfcp_pars.hnbgw_f_seid.seid)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c32998c839f75ed93de639e48d08e1458a8032c Gerrit-Change-Number: 38673 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Increase ExpecTable size to 16

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38675?usp=email ) Change subject: RAN_Emulation: Increase ExpecTable size to 16 ...................................................................... RAN_Emulation: Increase ExpecTable size to 16 Use same size as other tables. This allow running HNBGW_Tests with 16 ConnHdlrs instead of 8. Change-Id: I0748da523d886a8097b9f35991b9044e6ca33f95 --- M library/RAN_Emulation.ttcnpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/38675/1 diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index 9f942f3..5eb14de 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -273,7 +273,7 @@ var ConnectionData ConnectionTable[16]; /* pending expected incoming connections */ - var ExpectData ExpectTable[8]; + var ExpectData ExpectTable[16]; /* tables for mapping inbound unitdata (like paging) */ var ImsiMapping ImsiTable[16]; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0748da523d886a8097b9f35991b9044e6ca33f95 Gerrit-Change-Number: 38675 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Add test TC_ps_rab_assignment_concurrent

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676?usp=email ) Change subject: hnbgw: Add test TC_ps_rab_assignment_concurrent ...................................................................... hnbgw: Add test TC_ps_rab_assignment_concurrent Related: SYS#6602 Change-Id: I053950373cec93ed8dbdfd6b8a71ffe31de3806f --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/38676/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 91bbb11..9301aac 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1506,6 +1506,30 @@ f_shutdown_helper(); } +/* Same as TC_ps_rab_assignment, but 16 subscribers in parallel. + * Currently 16 is the maximum we can create due to array sizes of RAN_Emulation.ttcn. + */ +testcase TC_ps_rab_assignment_concurrent() runs on test_CT { + var ConnHdlrList vc_conn_list := {}; + g_num_hnbs := 1; + f_init(); + f_sleep(1.0); + const integer num_conns := 16; + + for (var integer i := 0; i < num_conns; i := i + 1) { + var ConnHdlr vc_conn; + var TestHdlrParams pars := f_TestHdlrParams(i, ps_domain := true); + vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment), pars); + vc_conn_list := vc_conn_list & { vc_conn }; + } + + for (var integer i := 0; i < lengthof(vc_conn_list); i := i + 1) { + vc_conn_list[i].done; + } + + f_shutdown_helper(); +} + /* Default list of counters for a 'cn' entity to test the cnpool feature. */ const CounterNameVals counternames_cnpool := { { "cnpool:subscr:new", 0 }, @@ -2395,6 +2419,7 @@ execute(TC_cs_iu_release_req_rua_disconnect()); execute(TC_ps_iu_release_req_rua_disconnect()); execute(TC_ps_rab_assignment()); + execute(TC_ps_rab_assignment_concurrent()); execute( TC_mscpool_L3Compl_on_1_cnlink() ); execute( TC_mscpool_L3Complete_by_imsi_round_robin() ); diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index 70e29e6..338bf4e 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='54' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='55' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='HNBGW_Tests' name='TC_hnb_register' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate_reuse_sctp_assoc' time='MASKED'/> @@ -27,6 +27,7 @@ <testcase classname='HNBGW_Tests' name='TC_cs_iu_release_req_rua_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_iu_release_req_rua_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment_concurrent' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Compl_on_1_cnlink' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_imsi_round_robin' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_LU_by_tmsi_null_nri_0_round_robin' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I053950373cec93ed8dbdfd6b8a71ffe31de3806f Gerrit-Change-Number: 38676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: with-pfcp: Support running ConnHdlr concurrently

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38674?usp=email ) Change subject: hnbgw: with-pfcp: Support running ConnHdlr concurrently ...................................................................... hnbgw: with-pfcp: Support running ConnHdlr concurrently Use Mutex to serialize PFCP session establishment to workaround the "Req with SEID=0" dispatching problem. This same system is used in S1GW_Tests. Change-Id: Ie19ee0bd1b811e9381e3c245a4b1208de8afcbce --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn M hnbgw/gen_links.sh 3 files changed, 29 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/38674/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 9205599..e09c894 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -74,6 +74,8 @@ import from SCCPasp_Types all; import from SCCP_Templates all; +import from Mutex all; + /*********************************************************************** * code running inside per-UE ConnHdlr ***********************************************************************/ @@ -84,13 +86,15 @@ * MGCP_ConnHdlr (for the MGCP side, emulating the MGW) * StatsD_ConnHdlr (for the statsd interface, verifying counters) */ -type component ConnHdlr extends RAN_ConnHdlr, MGCP_ConnHdlr, RUA_ConnHdlr, PFCP_ConnHdlr, StatsD_ConnHdlr { +type component ConnHdlr +extends RAN_ConnHdlr, MGCP_ConnHdlr, RUA_ConnHdlr, PFCP_ConnHdlr, StatsD_ConnHdlr, MutexCT { var integer g_sccp_conn_id; var TestHdlrParams g_pars; timer g_Tguard; port TELNETasp_PT HNBGWVTY; } +type record of ConnHdlr ConnHdlrList; type record MgwResponse { integer resp, @@ -774,6 +778,15 @@ var RANAP_PDU rx; var PDU_PFCP m; + /* This code block cannot be executed by more than one component at a time because + * the S1AP RAB Ass Request triggers the IUT to send PFCP Session Establishment + * Request PDU(s), with need to be routed to the respective ConnHdlr component (us). + * As per 3GPP TS 29.244, section 7.2.2.4.2, these PFCP PDUs shall all have SEID=0, + * so that the PFCPEM component cannot route them unambiguously. This is why we + * need to ensure that only one ConnHdlr is triggering PFCP session establishment + * at the given moment of time. */ + f_Mutex_lock(__BFILE__, __LINE__); + /* Subscribe for PFCP Session Establishment Request PDU(s), which are * expected to have SEID set to 0, as per 3GPP TS 29.244, section 7.2.2.4.2. */ f_PFCPEM_subscribe_seid(c_SEID0); @@ -788,8 +801,11 @@ m := f_pfcp_expect(tr_PFCP_Session_Est_Req()); /* Ask PFCPEM to route PDUs with to be indicated F-SEID to us. */ f_PFCPEM_subscribe_seid(g_pars.pfcp_pars.upf_f_seid.seid); - /* We no longer expect to receive PFCP Session Establishment Request PDU(s). */ + /* We're done establishing PFCP sessions, so at this point we no longer expect to + * receive Session Establishment Request PDUs with SEID=0. Unregister and unlock + * the mutex, enabling other components to establish PFCP sessions after us. */ f_PFCPEM_unsubscribe_seid(c_SEID0); + f_Mutex_unlock(__BFILE__, __LINE__); var PFCP_Session_Establishment_Request serq := m.message_body.pfcp_session_establishment_request; /* Store HNBGW F-SEID for later: */ diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 97ae334..91bbb11 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -75,6 +75,7 @@ import from SCCPasp_Types all; import from ConnHdlr all; +import from Mutex all; const integer NUM_MSC := 4; const integer NUM_SGSN := 4; @@ -275,6 +276,8 @@ var CounterNameValsList g_ctr_hnb; var RanOps g_ran_ops := MSC_RanOps; + + var MutexDispCT vc_mutex_disp; } /* global altstep for global guard timer; */ @@ -488,6 +491,8 @@ T_guard.start(guard_timeout); activate(as_Tguard()); + vc_mutex_disp := f_MutexDisp_start(); + f_init_statsd("VirtHNBGW", vc_STATSD, mp_local_statsd_ip, mp_local_statsd_port); f_init_vty("VirtHNBGW"); f_ipa_ctrl_start_client(mp_hnbgw_ip, mp_hnbgw_ctrl_port); @@ -586,7 +591,8 @@ pfcp_pars := t_PfcpParams(pfcp_enabled := mp_enable_pfcp_tests, pfcp_local_addr := mp_pfcp_ip_local, - pfcp_upf_node_id := mp_pfcp_upf_node_id); + pfcp_upf_node_id := mp_pfcp_upf_node_id, + upf_f_seid := 1000 + imsi_suffix); pars := t_pars(imsi_suffix, ps_domain := ps_domain, expect_separate_sccp_cr := expect_separate_sccp_cr, @@ -637,13 +643,15 @@ connect(vc_conn:PFCP, vc_PFCP:CLIENT); connect(vc_conn:PFCP_PROC, vc_PFCP:CLIENT_PROC); + f_MutexDisp_connect(vc_mutex_disp, vc_conn); + return vc_conn; } private function f_start_handler_run(ConnHdlr vc_conn, void_fn fn, TestHdlrParams pars) runs on test_CT { var charstring id := testcasename(); // & int2str(pars.ran_idx); pars.hnb := g_hnb_cfg[pars.hnb_idx]; - vc_conn.start(f_handler_init(fn, id, pars)) + vc_conn.start(f_handler_init(fn, id, pars)); } function f_start_handler_with_pars(void_fn fn, template (value) TestHdlrParams pars) diff --git a/hnbgw/gen_links.sh b/hnbgw/gen_links.sh index 51ce602..de173f1 100755 --- a/hnbgw/gen_links.sh +++ b/hnbgw/gen_links.sh @@ -105,6 +105,7 @@ FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcnpp " FILES+="L3_Templates.ttcn L3_Common.ttcn " FILES+="SCTP_Templates.ttcn " +FILES+="Mutex.ttcn " gen_links $DIR $FILES ignore_pp_results -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie19ee0bd1b811e9381e3c245a4b1208de8afcbce Gerrit-Change-Number: 38674 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: hnbgw: Fix wrong map object retrieved from hashtable

by fixeria

Attention is currently required from: laforge, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38669?usp=email ) Change subject: hnbgw: Fix wrong map object retrieved from hashtable ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 Gerrit-Change-Number: 38669 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Nov 2024 17:28:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/gsup: fix template param restriction for tr_GSUP

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email ) Change subject: library/gsup: fix template param restriction for tr_GSUP ...................................................................... Patch Set 1: (2 comments) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672/comment/232375bf_ec9c… : PS1, Line 312: template GSUP_PDU tr_GSUP(template (present) GSUP_MessageType msgt := ?, > template (present) here too please (see start of line). Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672/comment/59fb2806_b3a0… : PS1, Line 323: template GSUP_PDU ts_GSUP(GSUP_MessageType msgt, GSUP_IEs ies := {}) := { > this one also needs (value) btw. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89 Gerrit-Change-Number: 38672 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 17:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024