November 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: s1ap_proxy: add E-RAB introspection API

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38684?usp=email ) Change subject: s1ap_proxy: add E-RAB introspection API ...................................................................... s1ap_proxy: add E-RAB introspection API Change-Id: I43dcfa613a4ee0de5b2f6619911fd92b1675acd6 --- M src/s1ap_proxy.erl M test/s1ap_proxy_test.erl 2 files changed, 33 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/84/38684/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 4452269..ea20106 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -42,6 +42,8 @@ terminate/2]). -export([start_link/0, process_pdu/2, + fetch_erab/2, + fetch_erab_list/1, shutdown/1]). -include_lib("kernel/include/logger.hrl"). @@ -92,6 +94,18 @@ gen_server:call(Pid, {?FUNCTION_NAME, PDU}). +%% Fetch a single E-RAB from the registry (by UID) +-spec fetch_erab(pid(), erab_uid()) -> {ok, pid()} | error. +fetch_erab(Pid, UID) -> + gen_server:call(Pid, {?FUNCTION_NAME, UID}). + + +%% Fetch all E-RABs from the registry in form of a list +-spec fetch_erab_list(pid()) -> [{erab_uid(), pid()}]. +fetch_erab_list(Pid) -> + gen_server:call(Pid, ?FUNCTION_NAME). + + -spec shutdown(pid()) -> ok. shutdown(Pid) -> gen_server:stop(Pid). @@ -111,6 +125,14 @@ {Reply, S1} = handle_pdu_bin(OrigData, S0), {reply, Reply, S1}; +handle_call({fetch_erab, UID}, _From, + #proxy_state{erabs = ERABs} = S) -> + {reply, dict:find(UID, ERABs), S}; + +handle_call(fetch_erab_list, _From, + #proxy_state{erabs = ERABs} = S) -> + {reply, dict:to_list(ERABs), S}; + handle_call(Info, From, #proxy_state{} = S) -> ?LOG_ERROR("unknown ~p() from ~p: ~p", [?FUNCTION_NAME, From, Info]), diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index cb562a2..9e94716 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -67,7 +67,9 @@ SetupRspExp = e_rab_setup_rsp_pdu(?ADDR_C2U, ?TEID_C2U), [?_assertEqual({forward, SetupReqExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn)), - ?_assertEqual({forward, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupRspIn))]. + ?_assertEqual({forward, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupRspIn)), + ?_assertMatch({ok, _}, s1ap_proxy:fetch_erab(Pid, {7, 9, 6})), + ?_assertMatch([_], s1ap_proxy:fetch_erab_list(Pid))]. test_e_rab_setup_req_fail(#{handler := Pid}) -> @@ -79,9 +81,8 @@ SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), SetupRspExp = e_rab_setup_rsp_fail_pdu(), - %% TODO: make sure that the E-RAB FSM has been terminated - - [?_assertEqual({reply, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn))]. + [?_assertEqual({reply, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn)), + ?_assertEqual([], s1ap_proxy:fetch_erab_list(Pid))]. test_e_rab_release_cmd(#{handler := Pid}) -> @@ -94,12 +95,12 @@ %% [eNB -> MME] E-RAB RELEASE RESPONSE ReleaseRsp = e_rab_release_rsp_pdu(), - %% TODO: make sure that the E-RAB FSM has been terminated - [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), + ?_assertMatch([_], s1ap_proxy:fetch_erab_list(Pid)), ?_assertEqual({forward, ReleaseCmd}, s1ap_proxy:process_pdu(Pid, ReleaseCmd)), - ?_assertEqual({forward, ReleaseRsp}, s1ap_proxy:process_pdu(Pid, ReleaseRsp))]. + ?_assertEqual({forward, ReleaseRsp}, s1ap_proxy:process_pdu(Pid, ReleaseRsp)), + ?_assertEqual([], s1ap_proxy:fetch_erab_list(Pid))]. test_e_rab_release_ind(#{handler := Pid}) -> @@ -111,6 +112,7 @@ ReleaseInd = e_rab_release_ind_pdu(), %% TODO: make sure that the E-RAB FSM has been terminated + %% FIXME: erab_fsm does not tear down immediately, but after a timeout [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), @@ -135,7 +137,8 @@ InitCtxSetupRspExp = initial_context_setup_rsp_pdu(?ADDR_C2U, ?TEID_C2U), [?_assertEqual({forward, InitCtxSetupReqExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupReqIn)), - ?_assertEqual({forward, InitCtxSetupRspExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupRspIn))]. + ?_assertEqual({forward, InitCtxSetupRspExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupRspIn)), + ?_assertMatch([_], s1ap_proxy:fetch_erab_list(Pid))]. %% ------------------------------------------------------------------ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I43dcfa613a4ee0de5b2f6619911fd92b1675acd6 Gerrit-Change-Number: 38684 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[L] Change in ...osmo-s1gw[master]: s1ap_proxy: turn this module into a gen_server

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38683?usp=email ) Change subject: s1ap_proxy: turn this module into a gen_server ...................................................................... s1ap_proxy: turn this module into a gen_server Change-Id: Id6e4c7ee29ae31edca658e1293601d38e5f43e63 --- M src/s1ap_proxy.erl M src/sctp_proxy.erl M test/s1ap_proxy_test.erl 3 files changed, 136 insertions(+), 118 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/83/38683/1 diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl index 62c3bf2..4452269 100644 --- a/src/s1ap_proxy.erl +++ b/src/s1ap_proxy.erl @@ -33,11 +33,16 @@ %% that of the covered work. -module(s1ap_proxy). +-behaviour(gen_server). --export([init/0, - deinit/1, +-export([init/1, + handle_info/2, + handle_call/3, + handle_cast/2, + terminate/2]). +-export([start_link/0, process_pdu/2, - handle_exit/2]). + shutdown/1]). -include_lib("kernel/include/logger.hrl"). @@ -71,26 +76,95 @@ -export_type([proxy_action/0]). + %% ------------------------------------------------------------------ %% public API %% ------------------------------------------------------------------ -%% Initialize per-connection data --spec init() -> proxy_state(). -init() -> - #proxy_state{erabs = dict:new()}. +-spec start_link() -> gen_server:start_ret(). +start_link() -> + gen_server:start_link(?MODULE, [], []). -%% De-initialize per-connection data --spec deinit(proxy_state()) -> ok. -deinit(_S) -> +-type process_pdu_result() :: {proxy_action(), binary()}. +-spec process_pdu(pid(), binary()) -> process_pdu_result(). +process_pdu(Pid, PDU) -> + gen_server:call(Pid, {?FUNCTION_NAME, PDU}). + + +-spec shutdown(pid()) -> ok. +shutdown(Pid) -> + gen_server:stop(Pid). + + +%% ------------------------------------------------------------------ +%% gen_server API +%% ------------------------------------------------------------------ + +init([]) -> + process_flag(trap_exit, true), + {ok, #proxy_state{erabs = dict:new()}}. + + +handle_call({process_pdu, OrigData}, _From, + #proxy_state{} = S0) -> + {Reply, S1} = handle_pdu_bin(OrigData, S0), + {reply, Reply, S1}; + +handle_call(Info, From, + #proxy_state{} = S) -> + ?LOG_ERROR("unknown ~p() from ~p: ~p", [?FUNCTION_NAME, From, Info]), + {reply, {error, not_implemented}, S}. + + +handle_cast(Info, #proxy_state{} = S) -> + ?LOG_ERROR("unknown ~p(): ~p", [?FUNCTION_NAME, Info]), + {noreply, S}. + + +handle_info({'EXIT', Pid, Reason}, + #proxy_state{erabs = ERABs} = S) -> + ?LOG_DEBUG("Child process ~p terminated with reason ~p", [Pid, Reason]), + Fun = fun(_Key, Val) -> Val =/= Pid end, + {noreply, S#proxy_state{erabs = dict:filter(Fun, ERABs)}}; + +handle_info(Info, #proxy_state{} = S) -> + ?LOG_ERROR("unknown ~p(): ~p", [?FUNCTION_NAME, Info]), + {noreply, S}. + + +terminate(Reason, #proxy_state{}) -> + ?LOG_NOTICE("Terminating, reason ~p", [Reason]), ok. -%% Process an S1AP PDU --type process_pdu_result() :: {{proxy_action(), binary()}, proxy_state()}. --spec process_pdu(binary(), proxy_state()) -> process_pdu_result(). -process_pdu(OrigData, S0) -> +%% ------------------------------------------------------------------ +%% private API +%% ------------------------------------------------------------------ + +-spec erab_uid(erab_id(), proxy_state()) -> erab_uid(). +erab_uid(ERABId, #proxy_state{mme_ue_id = MmeUeId, + enb_ue_id = EnbUeId}) -> + {MmeUeId, EnbUeId, ERABId}. + + +%% Encode an S1AP PDU +-spec encode_pdu(s1ap_pdu()) -> {ok, binary()} | + {error, {asn1, tuple()}}. +encode_pdu(Pdu) -> + 'S1AP-PDU-Descriptions':encode('S1AP-PDU', Pdu). + + +%% Decode an S1AP PDU +-spec decode_pdu(binary()) -> {ok, s1ap_pdu()} | + {error, {asn1, tuple()}}. +decode_pdu(Data) -> + 'S1AP-PDU-Descriptions':decode('S1AP-PDU', Data). + + +%% Process an S1AP PDU (binary) +-spec handle_pdu_bin(binary(), proxy_state()) -> {process_pdu_result(), proxy_state()}. +handle_pdu_bin(OrigData, S0) -> s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_ALL), try decode_pdu(OrigData) of {ok, PDU} -> @@ -127,38 +201,7 @@ end. -%% Handle an exit event --spec handle_exit(pid(), proxy_state()) -> proxy_state(). -handle_exit(Pid, #proxy_state{erabs = ERABs} = S) -> - Fun = fun(_Key, Val) -> Val =/= Pid end, - S#proxy_state{erabs = dict:filter(Fun, ERABs)}. - - -%% ------------------------------------------------------------------ -%% private API -%% ------------------------------------------------------------------ - --spec erab_uid(erab_id(), proxy_state()) -> erab_uid(). -erab_uid(ERABId, #proxy_state{mme_ue_id = MmeUeId, - enb_ue_id = EnbUeId}) -> - {MmeUeId, EnbUeId, ERABId}. - - -%% Encode an S1AP PDU --spec encode_pdu(s1ap_pdu()) -> {ok, binary()} | - {error, {asn1, tuple()}}. -encode_pdu(Pdu) -> - 'S1AP-PDU-Descriptions':encode('S1AP-PDU', Pdu). - - -%% Decode an S1AP PDU --spec decode_pdu(binary()) -> {ok, s1ap_pdu()} | - {error, {asn1, tuple()}}. -decode_pdu(Data) -> - 'S1AP-PDU-Descriptions':decode('S1AP-PDU', Data). - - -%% Process an S1AP PDU +%% Process an S1AP PDU (decoded) -spec handle_pdu(s1ap_pdu(), proxy_state()) -> {{proxy_action(), s1ap_pdu()}, proxy_state()} | {forward, proxy_state()}. diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index d0bdf08..b465ed1 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -78,12 +78,13 @@ init([Aid, MmeAddr, MmePort]) -> process_flag(trap_exit, true), + {ok, Pid} = s1ap_proxy:start_link(), {ok, connecting, #{enb_aid => Aid, mme_addr => MmeAddr, mme_port => MmePort, tx_queue => [], - priv => s1ap_proxy:init()}}. + handler => Pid}}. callback_mode() -> @@ -140,13 +141,13 @@ connected(enter, OldState, S0) -> ?LOG_INFO("State change: ~p -> ~p", [OldState, ?FUNCTION_NAME]), %% Send pending eNB -> MME messages (if any) - S1 = sctp_send_pending(S0), - {keep_state, S1}; + sctp_send_pending(S0), + {keep_state, S0}; %% Handle an eNB -> MME data forwarding request (forward) connected(cast, {send_data, Data}, S0) -> - S1 = sctp_send(Data, S0), - {keep_state, S1}; + sctp_send(Data, S0), + {keep_state, S0}; %% Handle an #sctp_assoc_change event (MME connection state) connected(info, {sctp, _Socket, MmeAddr, MmePort, @@ -168,24 +169,16 @@ #{sock := Sock, enb_aid := EnbAid, mme_aid := Aid, - priv := Priv} = S) -> + handler := Pid} = S) -> ?LOG_DEBUG("MME connection (id=~p, ~p:~p) -> eNB: ~p", [Aid, MmeAddr, MmePort, Data]), - {Action, NewPriv} = s1ap_proxy:process_pdu(Data, Priv), - case Action of + case s1ap_proxy:process_pdu(Pid, Data) of {forward, FwdData} -> sctp_server:send_data(EnbAid, FwdData); {reply, ReData} -> ok = sctp_client:send_data({Sock, Aid}, ReData) end, - {keep_state, S#{priv := NewPriv}}; - -%% Handle termination events of the child processes -connected(info, {'EXIT', Pid, Reason}, - #{priv := Priv} = S) -> - ?LOG_DEBUG("Child process ~p terminated with reason ~p", [Pid, Reason]), - NewPriv = s1ap_proxy:handle_exit(Pid, Priv), - {keep_state, S#{priv := NewPriv}}; + {keep_state, S}; %% Catch-all for other kinds of SCTP events connected(info, {sctp, _Socket, MmeAddr, MmePort, @@ -205,13 +198,12 @@ {ok, State, S}. -terminate(Reason, State, S) -> +terminate(Reason, State, #{handler := Pid} = S) -> ?LOG_NOTICE("Terminating in state ~p, reason ~p", [State, Reason]), + s1ap_proxy:shutdown(Pid), case S of #{sock := Sock, - mme_aid := Aid, - priv := Priv} -> - s1ap_proxy:deinit(Priv), + mme_aid := Aid} -> sctp_client:disconnect({Sock, Aid}), gen_sctp:close(Sock); #{sock := Sock} -> @@ -229,15 +221,13 @@ #{sock := Sock, enb_aid := EnbAid, mme_aid := Aid, - priv := Priv} = S) -> - {Action, NewPriv} = s1ap_proxy:process_pdu(Data, Priv), - case Action of + handler := Pid}) -> + case s1ap_proxy:process_pdu(Pid, Data) of {forward, FwdData} -> ok = sctp_client:send_data({Sock, Aid}, FwdData); {reply, ReData} -> sctp_server:send_data(EnbAid, ReData) - end, - S#{priv := NewPriv}. + end. %% Send pending messages to the MME diff --git a/test/s1ap_proxy_test.erl b/test/s1ap_proxy_test.erl index 28fe209..cb562a2 100644 --- a/test/s1ap_proxy_test.erl +++ b/test/s1ap_proxy_test.erl @@ -3,6 +3,7 @@ -include_lib("eunit/include/eunit.hrl"). -include("pfcp_mock.hrl"). + %% ------------------------------------------------------------------ %% setup functions %% ------------------------------------------------------------------ @@ -16,13 +17,14 @@ start() -> pfcp_mock:mock_all(), exometer_mock:mock_all(), - s1ap_proxy:init(). + {ok, Pid} = s1ap_proxy:start_link(), + #{handler => Pid}. -stop(S) -> +stop(#{handler := Pid}) -> + s1ap_proxy:shutdown(Pid), exometer_mock:unmock_all(), - pfcp_mock:unmock_all(), - s1ap_proxy:deinit(S). + pfcp_mock:unmock_all(). %% ------------------------------------------------------------------ @@ -50,107 +52,90 @@ %% actual testcases %% ------------------------------------------------------------------ -test_s1_setup_req(S0) -> +test_s1_setup_req(#{handler := Pid}) -> SetupReq = s1_setup_req_pdu(), %% Expect the PDU to be proxied unmodified - [?_assertEqual({{forward, SetupReq}, S0}, s1ap_proxy:process_pdu(SetupReq, S0))]. + [?_assertEqual({forward, SetupReq}, s1ap_proxy:process_pdu(Pid, SetupReq))]. -test_e_rab_setup(S0) -> +test_e_rab_setup(#{handler := Pid}) -> %% [eNB <- MME] E-RAB SETUP REQUEST SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), SetupReqExp = e_rab_setup_req_pdu(?ADDR_A2U, ?TEID_A2U), - {{forward, SetupReqOut}, S1} = s1ap_proxy:process_pdu(SetupReqIn, S0), - %% [eNB -> MME] E-RAB SETUP RESPONSE SetupRspIn = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), SetupRspExp = e_rab_setup_rsp_pdu(?ADDR_C2U, ?TEID_C2U), - {{forward, SetupRspOut}, _S2} = s1ap_proxy:process_pdu(SetupRspIn, S1), - [?_assertEqual(SetupReqExp, SetupReqOut), - ?_assertEqual(SetupRspExp, SetupRspOut)]. + [?_assertEqual({forward, SetupReqExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn)), + ?_assertEqual({forward, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupRspIn))]. -test_e_rab_setup_req_fail(S0) -> +test_e_rab_setup_req_fail(#{handler := Pid}) -> %% pfcp_peer:session_establish_req/3 responds with a reject PDU = pfcp_mock:pdu_rsp_reject(session_establishment_response, ?SEID_Loc), pfcp_mock:mock_req(session_establish_req, PDU), - %% the linked erab_fsm will terminate abnormally, so trap this - process_flag(trap_exit, true), %% eNB <- [S1GW <- MME] E-RAB SETUP REQUEST %% eNB -- [S1GW -> MME] E-RAB SETUP RESPONSE (failure) SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), SetupRspExp = e_rab_setup_rsp_fail_pdu(), - {{reply, SetupRspOut}, _S1} = s1ap_proxy:process_pdu(SetupReqIn, S0), %% TODO: make sure that the E-RAB FSM has been terminated - [?_assertEqual(SetupRspExp, SetupRspOut)]. + [?_assertEqual({reply, SetupRspExp}, s1ap_proxy:process_pdu(Pid, SetupReqIn))]. -test_e_rab_release_cmd(S0) -> +test_e_rab_release_cmd(#{handler := Pid}) -> %% [eNB <- MME] E-RAB SETUP REQUEST - SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), - {_, S1} = s1ap_proxy:process_pdu(SetupReqIn, S0), - + SetupReq = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), %% [eNB -> MME] E-RAB SETUP RESPONSE - SetupRspIn = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), - {_, S2} = s1ap_proxy:process_pdu(SetupRspIn, S1), - + SetupRsp = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), %% [eNB <- MME] E-RAB RELEASE COMMAND ReleaseCmd = e_rab_release_cmd_pdu(), - {{forward, ReleaseCmdOut}, S3} = s1ap_proxy:process_pdu(ReleaseCmd, S2), - %% [eNB -> MME] E-RAB RELEASE RESPONSE ReleaseRsp = e_rab_release_rsp_pdu(), - {{forward, ReleaseRspOut}, _S4} = s1ap_proxy:process_pdu(ReleaseRsp, S3), %% TODO: make sure that the E-RAB FSM has been terminated - [?_assertEqual(ReleaseCmd, ReleaseCmdOut), - ?_assertEqual(ReleaseRsp, ReleaseRspOut)]. + [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), + ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), + ?_assertEqual({forward, ReleaseCmd}, s1ap_proxy:process_pdu(Pid, ReleaseCmd)), + ?_assertEqual({forward, ReleaseRsp}, s1ap_proxy:process_pdu(Pid, ReleaseRsp))]. -test_e_rab_release_ind(S0) -> +test_e_rab_release_ind(#{handler := Pid}) -> %% [eNB <- MME] E-RAB SETUP REQUEST - SetupReqIn = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), - {_, S1} = s1ap_proxy:process_pdu(SetupReqIn, S0), - + SetupReq = e_rab_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), %% [eNB -> MME] E-RAB SETUP RESPONSE - SetupRspIn = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), - {_, S2} = s1ap_proxy:process_pdu(SetupRspIn, S1), - + SetupRsp = e_rab_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), %% [eNB -> MME] E-RAB RELEASE INDICATION ReleaseInd = e_rab_release_ind_pdu(), - {{forward, ReleaseIndOut}, _S3} = s1ap_proxy:process_pdu(ReleaseInd, S2), %% TODO: make sure that the E-RAB FSM has been terminated - [?_assertEqual(ReleaseInd, ReleaseIndOut)]. + [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupReq)), + ?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, SetupRsp)), + ?_assertEqual({forward, ReleaseInd}, s1ap_proxy:process_pdu(Pid, ReleaseInd))]. -test_e_rab_modify_ind(S0) -> +test_e_rab_modify_ind(#{handler := Pid}) -> %% [eNB -> MME] E-RAB MODIFICATION INDICATION ModifyIndIn = e_rab_modify_ind_pdu(?ADDR_U2A, ?TEID_U2A), %% XXX: not implemented, we should actually expect ?ADDR_C2U, ?TEID_C2U ModifyIndExp = e_rab_modify_ind_pdu(?ADDR_U2A, ?TEID_U2A), - {{forward, ModifyIndOut}, _S1} = s1ap_proxy:process_pdu(ModifyIndIn, S0), - [?_assertEqual(ModifyIndExp, ModifyIndOut)]. + [?_assertEqual({forward, ModifyIndExp}, s1ap_proxy:process_pdu(Pid, ModifyIndIn))]. -test_initial_context_setup(S0) -> + +test_initial_context_setup(#{handler := Pid}) -> %% [eNB <- MME] INITIAL CONTEXT SETUP REQUEST InitCtxSetupReqIn = initial_context_setup_req_pdu(?ADDR_U2C, ?TEID_U2C), InitCtxSetupReqExp = initial_context_setup_req_pdu(?ADDR_A2U, ?TEID_A2U), - {{forward, InitCtxSetupReqOut}, S1} = s1ap_proxy:process_pdu(InitCtxSetupReqIn, S0), - %% [eNB -> MME] INITIAL CONTEXT SETUP RESPONSE InitCtxSetupRspIn = initial_context_setup_rsp_pdu(?ADDR_U2A, ?TEID_U2A), InitCtxSetupRspExp = initial_context_setup_rsp_pdu(?ADDR_C2U, ?TEID_C2U), - {{forward, InitCtxSetupRspOut}, _S2} = s1ap_proxy:process_pdu(InitCtxSetupRspIn, S1), - [?_assertEqual(InitCtxSetupReqExp, InitCtxSetupReqOut), - ?_assertEqual(InitCtxSetupRspExp, InitCtxSetupRspOut)]. + [?_assertEqual({forward, InitCtxSetupReqExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupReqIn)), + ?_assertEqual({forward, InitCtxSetupRspExp}, s1ap_proxy:process_pdu(Pid, InitCtxSetupRspIn))]. %% ------------------------------------------------------------------ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id6e4c7ee29ae31edca658e1293601d38e5f43e63 Gerrit-Change-Number: 38683 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: hnbgw: Fix wrong map object retrieved from hashtable

by lynxis lazus

Attention is currently required from: laforge, osmith, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/38669?usp=email ) Change subject: hnbgw: Fix wrong map object retrieved from hashtable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/38669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I107f461bf5bcb92262422c893b23d190659f6f72 Gerrit-Change-Number: 38669 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 21:21:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email ) Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates ...................................................................... Patch Set 3: (1 comment) File library/GSUP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584/comment/d6d7239d_7254… : PS3, Line 1415: else if (istemplatekind(destination_name, "*")) TODO: separate commit -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia611ffa3845d48c5553c70f10981aa029d00d873 Gerrit-Change-Number: 38584 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 20:10:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: RUA_Emulation: Add missing msg component destination

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38680?usp=email ) Change subject: RUA_Emulation: Add missing msg component destination ...................................................................... RUA_Emulation: Add missing msg component destination Seen while running lots of components concurrently: "RUA_Emulation.ttcn:315 Dynamic test case error: Port CLIENT has more than one active connections. Message can be sent on it only with explicit addressing." Change-Id: Ief257969a451f2d11ad7619fb97af16d7dd7e199 --- M library/rua/RUA_Emulation.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/38680/1 diff --git a/library/rua/RUA_Emulation.ttcn b/library/rua/RUA_Emulation.ttcn index 26c2da7..8b28a98 100644 --- a/library/rua/RUA_Emulation.ttcn +++ b/library/rua/RUA_Emulation.ttcn @@ -312,7 +312,7 @@ } /* notify user of disconnect */ if (CLIENT.checkstate("Connected")) { - CLIENT.send(RUA_Disc_Ind:{cause}); + CLIENT.send(RUA_Disc_Ind:{cause}) to vc_conn; } f_conn_table_del(context_id); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ief257969a451f2d11ad7619fb97af16d7dd7e199 Gerrit-Change-Number: 38680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Parametrize MgcpParameters MGCP endpoint

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38677?usp=email ) Change subject: hnbgw: Parametrize MgcpParameters MGCP endpoint ...................................................................... hnbgw: Parametrize MgcpParameters MGCP endpoint This will be needed if we want to run several CS RAB ConnHdlrs in parallel. Change-Id: I4bb28dea22a6ea5b415d6ca16bde61b835d435bc --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/38677/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index e09c894..0d6b9cb 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -122,11 +122,17 @@ integer got_osmux_count } -template (value) MgcpParameters t_MgcpParams := { +private function f_mgcp_endp_str(integer endp_idx := 1) return charstring +{ + return "rtpbridge/" & int2str(endp_idx) & "@mgw"; +} + +template (value) MgcpParameters +t_MgcpParams(integer endp_idx := 1) := { got_crcx_count := 0, got_dlcx_count := 0, mgcp_call_id := omit, - mgcp_ep := "rtpbridge/1@mgw", + mgcp_ep := f_mgcp_endp_str(endp_idx), mgw_conn_ran := { resp := 1, mgw_rtp_ip := "127.1.2.1", @@ -258,6 +264,7 @@ integer tx_sccp_cr_data_len := 0, boolean expect_compl_l3_success := true, integer cn_idx := 0, + template (value) MgcpParameters mgcp_pars := t_MgcpParams(), template (value) PfcpParameters pfcp_pars := t_PfcpParams(), template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal, integer hnbgw_timer_x31 := 5, @@ -266,7 +273,7 @@ cn_idx := cn_idx, imsi := f_gen_imsi(imsi_suffix), ps_domain := ps_domain, - mgcp_pars := t_MgcpParams, + mgcp_pars := mgcp_pars, gtp_pars := t_GtpParams, hnb := omit, /* filled in later */ expect_separate_sccp_cr := expect_separate_sccp_cr, diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 9301aac..5258a11 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -587,8 +587,9 @@ template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal) runs on test_CT return TestHdlrParams { var template (value) TestHdlrParams pars; + var template (value) MgcpParameters mgcp_pars; var template (value) PfcpParameters pfcp_pars; - + mgcp_pars := t_MgcpParams(endp_idx := imsi_suffix); pfcp_pars := t_PfcpParams(pfcp_enabled := mp_enable_pfcp_tests, pfcp_local_addr := mp_pfcp_ip_local, pfcp_upf_node_id := mp_pfcp_upf_node_id, @@ -599,6 +600,7 @@ tx_sccp_cr_data_len := tx_sccp_cr_data_len, expect_compl_l3_success := expect_compl_l3_success, cn_idx := f_cn_idx(ps_domain, cn_nr), + mgcp_pars := mgcp_pars, pfcp_pars := pfcp_pars, rab_rel_cause := rab_rel_cause, hnbgw_timer_x31 := mp_hnbgw_timer_x31); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bb28dea22a6ea5b415d6ca16bde61b835d435bc Gerrit-Change-Number: 38677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678?usp=email ) Change subject: hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently ...................................................................... hnbgw: mgcp: Support running CS RAB ConnHdlr concurrently Use Mutex to serialize CRCX wildcard endpoint, in order to be able to properly steer the message to the good ConnHdlr. Change-Id: Ibd97a37d98abfa746b58db0ea8bb591e7c8dc638 --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 14 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/38678/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 0d6b9cb..753087f 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -687,6 +687,15 @@ var template RAB_SetupOrModifyList rab_sml; timer T := 5.0; + /* This code block cannot be executed by more than one component at a time because the + * S1AP RAB Ass Request triggers the IUT to send MGCP CRCX PDU(s), with need to be routed + * to the respective ConnHdlr component (us). This is why we need to ensure that only + * one ConnHdlr is triggering PFCP session establishment at the given moment of time. + */ + f_Mutex_lock(__BFILE__, __LINE__); + + f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); + /* Send RAB Assignment Request */ rab_sml := ts_RAB_SML(t_RAB_id(23), f_ts_RAB_TLA(g_pars.mgcp_pars.cn_rtp_ip), t_RAB_binding_port(g_pars.mgcp_pars.cn_rtp_port)); tx := valueof(ts_RANAP_RabAssReq(rab_sml)); @@ -697,11 +706,15 @@ alt { [] MGCP.receive(tr_CRCX) -> value mgcp_cmd { log("CRCX1", mgcp_cmd); + /* Unregister and unlock the mutex, enabling other components to + * establish MGCP sessions after us. */ + f_Mutex_unlock(__BFILE__, __LINE__); var template MgcpResponse mgcp_rsp := f_handle_crcx(g_pars.mgcp_pars, mgcp_cmd); MGCP.send(valueof(mgcp_rsp)); } [] T.timeout { - setverdict(fail, "Timeout waiting for MGCP"); + /* No need to f_Mutex_unlock since we are exiting anyway... */ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for MGCP"); } } T.stop; diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 5258a11..78f0a10 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1062,8 +1062,6 @@ var RANAP_PDU tx; timer T := 5.0; - f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); - f_statsd_reset(); tx := f_build_initial_ue(g_pars); @@ -1106,8 +1104,6 @@ var RANAP_PDU tx; timer T := 5.0; - f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); - f_statsd_reset(); tx := f_build_initial_ue(g_pars); @@ -1162,8 +1158,6 @@ var RANAP_PDU tx; timer T := 15.0; - f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); - f_statsd_reset(); tx := f_build_initial_ue(g_pars); @@ -1399,8 +1393,6 @@ var RANAP_PDU tx; timer T := 5.0; - f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); - tx := f_build_initial_ue(g_pars); f_iuh2iu_connect(tx); @@ -2324,8 +2316,6 @@ var RANAP_PDU tx; timer T := 5.0; - f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); - tx := f_build_initial_ue(g_pars); f_iuh2iu_connect(tx); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibd97a37d98abfa746b58db0ea8bb591e7c8dc638 Gerrit-Change-Number: 38678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_rab_assignment_concurrent

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38679?usp=email ) Change subject: hnbgw: Introduce test TC_rab_assignment_concurrent ...................................................................... hnbgw: Introduce test TC_rab_assignment_concurrent Related: SYS#6602 Change-Id: I1f717edbe4a758288d017861c4b77836c5811040 --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml 2 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/38679/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 78f0a10..aecd67c 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1056,11 +1056,10 @@ f_shutdown_helper(); } -friend function f_tc_rab_assignment(charstring id) runs on ConnHdlr { +private function f_tc_rab_assignment(charstring id) runs on ConnHdlr { const charstring hnb0_ctr_prefix := mp_statsd_prefix & "hnb.001-01-L2342-R0-S55-C1."; var MgcpCommand mgcp_cmd; var RANAP_PDU tx; - timer T := 5.0; f_statsd_reset(); @@ -1086,7 +1085,6 @@ f_cn_iu_release_procedure(mgcp_teardown := true); } - testcase TC_rab_assignment() runs on test_CT { var ConnHdlr vc_conn; g_num_hnbs := 1; @@ -1098,6 +1096,47 @@ f_shutdown_helper(); } +/* Same as TC_rab_assignment, but 16 subscribers in parallel. + * Currently 16 is the maximum we can create due to array sizes of RAN_Emulation.ttcn. + * Stats are removed since it's difficult to count with several conns concurrently doing stuff. + */ +private function f_tc_rab_assignment_concurrent(charstring id) runs on ConnHdlr { + const charstring hnb0_ctr_prefix := mp_statsd_prefix & "hnb.001-01-L2342-R0-S55-C1."; + var MgcpCommand mgcp_cmd; + var RANAP_PDU tx; + + f_statsd_reset(); + + tx := f_build_initial_ue(g_pars); + f_iuh2iu_connect(tx); + + f_create_rab_cs(); + + /* Wait some time with connection up */ + f_sleep(2.0); + + f_cn_iu_release_procedure(mgcp_teardown := true); +} +testcase TC_rab_assignment_concurrent() runs on test_CT { + var ConnHdlrList vc_conn_list := {}; + g_num_hnbs := 1; + f_init(); + f_sleep(1.0); + const integer num_conns := 16; + + for (var integer i := 0; i < num_conns; i := i + 1) { + var ConnHdlr vc_conn; + vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assignment_concurrent), f_TestHdlrParams(i)); + vc_conn_list := vc_conn_list & { vc_conn }; + } + + for (var integer i := 0; i < lengthof(vc_conn_list); i := i + 1) { + vc_conn_list[i].done; + } + + f_shutdown_helper(); +} + friend function f_tc_rab_assign_fail(charstring id) runs on ConnHdlr { const charstring hnb0_ctr_prefix := mp_statsd_prefix & "hnb.001-01-L2342-R0-S55-C1."; var MgcpCommand mgcp_cmd; @@ -2399,6 +2438,7 @@ execute(TC_ranap_cs_bidir()); execute(TC_ranap_ps_bidir()); execute(TC_rab_assignment()); + execute(TC_rab_assignment_concurrent()); execute(TC_rab_release()); execute(TC_rab_release_abnormal()); execute(TC_rab_assign_fail()); diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index 338bf4e..61acf6a 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -15,6 +15,7 @@ <testcase classname='HNBGW_Tests' name='TC_ranap_cs_bidir' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_bidir' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_rab_assignment' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_rab_assignment_concurrent' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_rab_release' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_rab_release_abnormal' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_rab_assign_fail' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1f717edbe4a758288d017861c4b77836c5811040 Gerrit-Change-Number: 38679 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/gsup: improve generic GSUP_PDU templates

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email ) Change subject: library/gsup: improve generic GSUP_PDU templates ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4ceaf60311f9e4ed57153e2f6d7cb793c637f89 Gerrit-Change-Number: 38672 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:50:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hlr: refactor f_SS_expect()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email ) Change subject: hlr: refactor f_SS_expect() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Nov 2024 18:49:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024