September 2023 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo_dia2gsup[master]: gsup: implement a (re-)connect the GSUP link if it fails
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285 ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:48:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: rebar3: define a release
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284 ) Change subject: rebar3: define a release ...................................................................... Patch Set 1: (2 comments) File README.md: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284/comment/c0777fd4_… PS1, Line 37: 1> osmo_dia2gsup:start(). That's after a new release, so when no release is done (ass seen below), this can still be used, so don't drop it please. File contrib/systemd/osmo_dia2gsup.service: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284/comment/a679e660_… PS1, Line 12: ExecStart=/usr/bin/osmo-dia2gsup forground are you sure this is correct? sounds like a typo for "foreground" -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I76cb16e28b5bc6fb231566be1bd7905235fdf56b Gerrit-Change-Number: 34284 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:31:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34283 ) Change subject: gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/server_cb.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34283/comment/0e352eb7_… PS1, Line 199: gsup_cause2dia(_) -> {[], [?DIAMETER_ERROR_UNABLE_TO_COMPLY]}. AFAIU you are missing the "EXP_RES" part here. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7f19bf1fb3676a1302f0d6d7d7450a3f201ba5bb Gerrit-Change-Number: 34283 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:29:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: server_cb: use a define for the VENDOR_3GPP code
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282 ) Change subject: server_cb: use a define for the VENDOR_3GPP code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9bd99998963624f7688b972cbb3908fae5686231 Gerrit-Change-Number: 34282 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:29:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: Translate GSUP Auth Info Answer error Cause in Diamater AIA
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: fixeria, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 ) Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @lynxis please feel free to take over and update the errors as you see fit, I didn't see the table you mentioned but I'm sure your proposals are fine. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 Gerrit-Change-Number: 34259 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:28:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names
by pespin 01 Sep '23

01 Sep '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34258 ) Change subject: Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names ...................................................................... Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names Change-Id: I77336cb2c76a516ecea5b46500da91fd4230176d --- M src/server_cb.erl 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/src/server_cb.erl b/src/server_cb.erl index 35dbb63..482ba9a 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -165,11 +165,17 @@ % 10.5.5.14 -define(GMM_CAUSE_IMSI_UNKNOWN, 16#02). --define(GMM_CAUSE_PLMN_NOTALLOWED, 16#0b). +-define(GMM_CAUSE_ILLEGAL_MS, 16#03). -define(GMM_CAUSE_GPRS_NOTALLOWED, 16#07). --define(GMM_CAUSE_INV_MAND_INFO, 16#60). +-define(GMM_CAUSE_PLMN_NOTALLOWED, 16#0b). +-define(GMM_CAUSE_LA_NOTALLOWED, 16#0c). +-define(GMM_CAUSE_ROAMING_NOTALLOWED, 16#0d). +-define(GMM_CAUSE_NO_SUIT_CELL_IN_LA, 16#0f). -define(GMM_CAUSE_NET_FAIL, 16#11). -% TODO: more values +-define(GMM_CAUSE_CONGESTION, 16#16). +-define(GMM_CAUSE_GSM_AUTH_UNACCEPT, 16#17). +-define(GMM_CAUSE_INV_MAND_INFO, 16#60). +-define(GMM_CAUSE_PROTO_ERR_UNSPEC, 16#6f). -define(EXP_RES(Foo), #'Experimental-Result'{'Vendor-Id'=fixme, 'Experimental-Result-Code'=Foo}). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I77336cb2c76a516ecea5b46500da91fd4230176d Gerrit-Change-Number: 34258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: MME_Tests: add new testcase TC_s1ap_tau_unknown_guti
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34281 ) Change subject: MME_Tests: add new testcase TC_s1ap_tau_unknown_guti ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9306fea69ac930b9642528e2fd32a7091147081e Gerrit-Change-Number: 34281 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:26:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add template for Tracking Area Update Reject
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34280 ) Change subject: NAS_Templates: add template for Tracking Area Update Reject ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34280 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id64e8a28e47235766efbef6df0114c3024cc2f47 Gerrit-Change-Number: 34280 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:25:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: MME_Tests: remove unusued timer variable
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34279 ) Change subject: MME_Tests: remove unusued timer variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d18cda38789e5a42536fd17b6641efa725f757b Gerrit-Change-Number: 34279 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:25:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_data_rtp_tch* for CSD
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072 ) Change subject: BTS_Tests: add TC_data_rtp_tch* for CSD ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33072 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9a0dc0fcf722f862d8dcf04660d4448662210f44 Gerrit-Change-Number: 33072 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:22:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0