September 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: decouple payload generation from f_rtpem_activate()
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34278 ) Change subject: BTS_Tests: decouple payload generation from f_rtpem_activate() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34278/comment/b38d21b1_eafa… PS1, Line 2610: friend function f_rtpem_activate(RtpemConfig cfg := c_RtpemDefaultCfg, so cfg is not changed here? only "in"? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9e823c33b1dbbadd57bc63df25b8ddf368d76232 Gerrit-Change-Number: 34278 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:22:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: server_cb: use a define for the VENDOR_3GPP code
by lynxis lazus 01 Sep '23

01 Sep '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282 ) Change subject: server_cb: use a define for the VENDOR_3GPP code ...................................................................... server_cb: use a define for the VENDOR_3GPP code Also use a proper variable name Change-Id: I9bd99998963624f7688b972cbb3908fae5686231 --- M src/server_cb.erl 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/82/34282/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index a6450dd..7f30d2b 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -6,6 +6,7 @@ -include_lib("diameter_3gpp_ts29_272.hrl"). -include_lib("osmo_gsup/include/gsup_protocol.hrl"). +-define(DIA_VENDOR_3GPP, 10415). %% diameter callbacks -export([peer_up/3, peer_down/3, pick_peer/4, prepare_request/3, prepare_retransmit/3, @@ -177,7 +178,7 @@ -define(GMM_CAUSE_INV_MAND_INFO, 16#60). -define(GMM_CAUSE_PROTO_ERR_UNSPEC, 16#6f). --define(EXP_RES(Foo), #'Experimental-Result'{'Vendor-Id'=10415, 'Experimental-Result-Code'=Foo}). +-define(EXP_RES(Exp), #'Experimental-Result'{'Vendor-Id'=?DIA_VENDOR_3GPP, 'Experimental-Result-Code'=Exp}). -type empty_or_intl() :: [] | [integer()]. -spec gsup_cause2dia(integer()) -> {empty_or_intl(), empty_or_intl()}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9bd99998963624f7688b972cbb3908fae5686231 Gerrit-Change-Number: 34282 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo_dia2gsup[master]: rebar3: define a release
by lynxis lazus 01 Sep '23

01 Sep '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284 ) Change subject: rebar3: define a release ...................................................................... rebar3: define a release Further with the release, rebar3 will also start the application when calling `rebar3 shell`. Change-Id: I76cb16e28b5bc6fb231566be1bd7905235fdf56b --- M README.md M contrib/systemd/osmo_dia2gsup.service M rebar.config 3 files changed, 27 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/84/34284/1 diff --git a/README.md b/README.md index 8d8dc01..76d7a95 100644 --- a/README.md +++ b/README.md @@ -27,20 +27,12 @@ ``` $ rebar3 shell -1> osmo_dia2gsup:start(). ``` Passing a config file: ``` $ rebar3 shell --config ./examples/sys.config -1> osmo_dia2gsup:start(). -``` - -Running it with one shell command: - -``` -$ rebar3 shell --config ./examples/sys.config --eval "osmo_dia2gsup:start()." ``` Running it as an escript: @@ -49,3 +41,8 @@ $ rebar3 escriptize $ ERL_FLAGS='-config ./examples/sys.config' _build/default/bin/osmo-dia2gsup ``` + +## Build a new release + +rebar3 release + diff --git a/contrib/systemd/osmo_dia2gsup.service b/contrib/systemd/osmo_dia2gsup.service index b57247b..d2347bd 100644 --- a/contrib/systemd/osmo_dia2gsup.service +++ b/contrib/systemd/osmo_dia2gsup.service @@ -9,7 +9,7 @@ Restart=always Environment="HOME=/var/lib/osmo_dia2gsup" ExecStartPre=/usr/bin/mkdir -p /var/lib/osmo_dia2gsup -ExecStart=/usr/bin/osmo-dia2gsup +ExecStart=/usr/bin/osmo-dia2gsup forground RestartSec=2 [Install] diff --git a/rebar.config b/rebar.config index 69013aa..3bda3e5 100644 --- a/rebar.config +++ b/rebar.config @@ -33,3 +33,12 @@ {escript_incl_apps, [osmo_dia2gsup]}. {escript_main_app, osmo_dia2gsup}. {escript_name, "osmo-dia2gsup"}. + +{relx, + [{release, {'osmo-dia2gsup', {git, long}}, + [osmo_dia2gsup]}, + {sys_config, "./config/sys.config"}, + {vm_args, "./config/vm.args"}, + {dev_mode, false}, + {include_erts, true}, + {extended_start_script, true}]}. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34284 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I76cb16e28b5bc6fb231566be1bd7905235fdf56b Gerrit-Change-Number: 34284 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo_dia2gsup[master]: gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY
by lynxis lazus 01 Sep '23

01 Sep '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34283 ) Change subject: gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY ...................................................................... gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY Change-Id: I7f19bf1fb3676a1302f0d6d7d7450a3f201ba5bb --- M src/server_cb.erl 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/83/34283/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index 7f30d2b..a800781 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -159,6 +159,7 @@ % permanent (only in Experimental-Result-Code) -define(DIAMETER_ERROR_USER_UNKNOWN, 5001). -define(DIAMETER_ERROR_ROAMING_NOT_ALLOWED, 5004). +-define(DIAMETER_ERROR_UNABLE_TO_COMPLY, 5012). -define(DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION, 5420). -define(DIAMETER_ERROR_RAT_NOT_ALLOWED, 5421). -define(DIAMETER_ERROR_EQUIPMENT_UNKNOWN, 5422). @@ -195,8 +196,7 @@ gsup_cause2dia(?GMM_CAUSE_GSM_AUTH_UNACCEPT) -> {[], [?EXP_RES(?DIAMETER_ERROR_USER_UNKNOWN)]}; gsup_cause2dia(?GMM_CAUSE_INV_MAND_INFO) -> {[], [?EXP_RES(?DIAMETER_ERROR_UNKOWN_SERVING_NODE)]}; gsup_cause2dia(?GMM_CAUSE_PROTO_ERR_UNSPEC) -> {[], [?EXP_RES(?DIAMETER_ERROR_UNKOWN_SERVING_NODE)]}; -% TODO: more values -gsup_cause2dia(_) -> {fixme, []}. +gsup_cause2dia(_) -> {[], [?DIAMETER_ERROR_UNABLE_TO_COMPLY]}. % get the value for a tiven key in Map1. If not found, try same key in Map2. If not found, return Default -spec twomap_get(atom(), map(), map(), any()) -> any(). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I7f19bf1fb3676a1302f0d6d7d7450a3f201ba5bb Gerrit-Change-Number: 34283 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[M] Change in ...osmo_dia2gsup[master]: gsup: implement a (re-)connect the GSUP link if it fails
by lynxis lazus 01 Sep '23

01 Sep '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285 ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... gsup: implement a (re-)connect the GSUP link if it fails Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d --- M src/gsup_client.erl M src/osmo_dia2gsup_sup.erl 2 files changed, 51 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/85/34285/1 diff --git a/src/gsup_client.erl b/src/gsup_client.erl index 047078b..967bf99 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -39,9 +39,13 @@ -include_lib("osmo_ss7/include/ipa.hrl"). -define(IPAC_PROTO_EXT_GSUP, {osmo, 5}). +-define(GSUP_TIMEOUT_MS, 5000). -record(gsupc_state, { - socket, + address, + port, + ccmoptions, + socket, ipa_pid }). @@ -54,43 +58,46 @@ %% our exported API %% ------------------------------------------------------------------ -start_link(ServerAddr, ServerPort, Options) -> - gen_server:start_link(?MODULE, [ServerAddr, ServerPort, Options], [{debug, [trace]}]). +start_link(ServerAddr, ServerPort, GsupName) -> + gen_server:start_link(?MODULE, [ServerAddr, ServerPort, GsupName], [{debug, [trace]}]). %% ------------------------------------------------------------------ %% gen_server Function Definitions %% ------------------------------------------------------------------ -init([Address, Port, Options]) -> +init([Address, Port, GsupName]) -> ipa_proto:init(), % register the GSUP codec with the IPA core; ignore result as we might be doing this multiple times ipa_proto:register_codec(?IPAC_PROTO_EXT_GSUP, fun gsup_protocol:encode/1, fun gsup_protocol:decode/1), - connect([Address, Port, Options]). - -connect([Address, Port, Options]) -> lager:info("Connecting to GSUP HLR on IP ~s port ~p~n", [Address, Port]), - CcmOptions = #ipa_ccm_options{ - serial_number="HSS-00-00-00-00-00-00", - unit_id="0/0/0", - mac_address="00:00:00:00:00:00", - location="00:00:00:00:00:00", - unit_type="00:00:00:00:00:00", - equipment_version="00:00:00:00:00:00", - sw_version="00:00:00:00:00:00", - unit_name="HSS-00-00-00-00-00-00" - }, - case ipa_proto:connect(Address, Port, Options) of + CcmOptions = #ipa_ccm_options{ + serial_number=GsupName, + unit_id="0/0/0", + mac_address="00:00:00:00:00:00", + location="00:00:00:00:00:00", + unit_type="00:00:00:00:00:00", + equipment_version="00:00:00:00:00:00", + sw_version="00:00:00:00:00:00", + unit_name=GsupName + }, + State = #gsupc_state{address = Address, port = Port, ccmoptions = CcmOptions, socket = [], ipa_pid = []}, + case connect(State) of + {ok, State2} -> {ok, State2}; + {error, _, State2} -> {ok, State2, ?GSUP_TIMEOUT_MS} + end. + +connect(State) -> + #gsupc_state{address = Address, port = Port, ccmoptions = Options} = State, + case ipa_proto:connect(Address, Port, []) of {ok, {Socket, IpaPid}} -> - ipa_proto:set_ccm_options(Socket, CcmOptions), + ipa_proto:set_ccm_options(Socket, Options), lager:info("connected!~n", []), true = ipa_proto:register_stream(Socket, ?IPAC_PROTO_EXT_GSUP, {process_id, self()}), ipa_proto:unblock(Socket), - {ok, #gsupc_state{socket=Socket, ipa_pid=IpaPid}}; - {error, Reason} -> - lager:error("Connecting to GSUP HLR on IP ~s port ~p failed: ~p~n", [Address, Port, Reason]), - lager:info("Reconnecting to GSUP HLR in 5s...~n", []), - timer:sleep(5000), - connect([Address, Port, Options]) + {ok, State#gsupc_state{socket=Socket, ipa_pid=IpaPid}}; + {error, Error} -> + lager:info("Failed to GSUP HLR on IP ~s port ~p ~p~n", [Address, Port, Error]), + {error, Error, State} end. % send a given GSUP message and synchronously wait for message type ExpRes or ExpErr @@ -102,10 +109,9 @@ receive {ipa, Socket, ?IPAC_PROTO_EXT_GSUP, GsupMsgRx = #{message_type := ExpRes, imsi := Imsi}} -> {reply, GsupMsgRx, State}; - {ipa, Socket, ?IPAC_PROTO_EXT_GSUP, GsupMsgRx = #{message_type := ExpErr, imsi := Imsi}} -> {reply, GsupMsgRx, State} - after 5000 -> + after ?GSUP_TIMEOUT_MS -> {reply, timeout, State} end. @@ -114,8 +120,14 @@ {noreply, S}. handle_info({ipa_closed, _}, S) -> - lager:error("GSUP connection has been closed, supervisor should reconnect us"), - {stop, ipa_closed, S}; + lager:error("GSUP connection has been closed, Reconnecting in 5sec."), + {noreply, S, ?GSUP_TIMEOUT_MS}; +handle_info(timeout, S) -> + case connect(S) of + {ok, State} -> {noreply, State}; + {error, _, State} -> {noreply, State, ?GSUP_TIMEOUT_MS} + end; + handle_info(Info, S) -> error_logger:error_report(["unknown handle_info", {module, ?MODULE}, {info, Info}, {state, S}]), {noreply, S}. diff --git a/src/osmo_dia2gsup_sup.erl b/src/osmo_dia2gsup_sup.erl index 17b5a14..03c780d 100644 --- a/src/osmo_dia2gsup_sup.erl +++ b/src/osmo_dia2gsup_sup.erl @@ -12,7 +12,7 @@ % GSUP side HlrIp = application:get_env(osmo_dia2gsup, hlr_ip, "127.0.0.1"), HlrPort = application:get_env(osmo_dia2gsup, hlr_port, 4222), - Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, []], [{debug, [trace]}]], + Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, "HSS-00-00-00-00-00-00"], [{debug, [trace]}]], GsupChild = {gsup_client, {gen_server, start_link, Args}, permanent, 2000, worker, [gsup_client]}, % DIAMETER side DiaServer = {osmo_dia2gsup,{osmo_dia2gsup,start_link,[]}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: f_rtpem_activate(): make RTP payload type configurable
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34277 ) Change subject: BTS_Tests: f_rtpem_activate(): make RTP payload type configurable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I84f576f578ffc48c8b5e545bc1700000eb693efb Gerrit-Change-Number: 34277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:19:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: library: RTP_Emulation: implement new RTPEM_MODE_LOOPBACK
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34276 ) Change subject: library: RTP_Emulation: implement new RTPEM_MODE_LOOPBACK ...................................................................... Patch Set 1: (1 comment) File library/RTP_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34276/comment/1a46d5a9_5203… PS1, Line 100: var boolean g_loopback := false; why aren't we simply storing RtpemMode received from the port? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iee8f736e1eebc357fc997353ee4b629d24dc09e7 Gerrit-Change-Number: 34276 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:19:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: Translate GSUP Auth Info Answer error Cause in Diamater AIA
by lynxis lazus 01 Sep '23

01 Sep '23

Attention is currently required from: fixeria, pespin, daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 ) Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ...................................................................... Patch Set 1: (10 comments) Patchset: PS1: Hi Pau, do you found the translation table in TS 29.272 Annex A rel 17? (Diameter to the NAS cause codes and Annex B for the SGSN NAS codes.) File src/server_cb.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/3522f28a_… PS1, Line 187: DIAMETER_ERROR_RAT_NOT_ALLOWED DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/37072e48_… PS1, Line 189: gsup_cause2dia(?GMM_CAUSE_LA_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_RAT_NOT_ALLOWED)]}; Maybe DIAMETER_AUTHORIZATION_REJECTED would be better. https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/bea8ea79_… PS1, Line 191: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/7aac8f68_… PS1, Line 192: DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE 29.272 rel 17: Annex A and Annex B can be used to translate those. IMHO: This should be unable_to_comply https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/792fb42a_… PS1, Line 193: gsup_cause2dia(?GMM_CAUSE_CONGESTION) -> {[], [?EXP_RES(?DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE)]}; I would send unable to comply here, even it is not defined. https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/bd2ed798_… PS1, Line 194: GMM_CAUSE_GSM_AUTH_UNACCEPT I would remove this. We should never get this error and we don't use it on the hlr so far. https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/a10c784f_… PS1, Line 195: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_MISSING_AVP https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/b994c2af_… PS1, Line 196: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_UNABLE_TO_COMPLY https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/85b97d0f_… PS1, Line 197: TODO: more values > This TODO can be removed I guess? not yet.I've a patch for this. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 Gerrit-Change-Number: 34259 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:12:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gm_12_21.h: Add cross-component parameter defaults (NSE timing)
by arehbein 01 Sep '23

01 Sep '23

Attention is currently required from: laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31877 ) Change subject: gm_12_21.h: Add cross-component parameter defaults (NSE timing) ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gsm/protocol/gsm_12_21.h: https://gerrit.osmocom.org/c/libosmocore/+/31877/comment/e1215fd0_2d3cbb28 PS2, Line 294: enum abis_nm_par_defaults { > it makes no sense to have this as enums, because they are not different types of the same thing nor […] What's the drawback of using an enum here? These defaults were hardcoded in existing code. When that wasn't the case I checked with the specs (I think I may even have done that here, not sure anymore though since it's been a while). For instance: ``` osmo-bsc$ ag -A10 rlc_cfg_default src/osmo-bsc/bts.c 126:static const struct gprs_rlc_cfg rlc_cfg_default = { 127- .parameter = { 128- [RLC_T3142] = 20, 129- [RLC_T3169] = 5, 130- [RLC_T3191] = 5, 131- [RLC_T3193] = 160, /* 10ms */ 132- [RLC_T3195] = 5, 133- [RLC_N3101] = 10, 134- [RLC_N3103] = 4, 135- [RLC_N3105] = 8, 136- [CV_COUNTDOWN] = 15, ``` and the same I think for NSE timers. I think we had had a short back and forth about this already, iirc I did put these or similar values in the respective header for the standard defining the timers, but you were against that saying it was more related to abis/O&M since it's values communicated over PCU IF and gave pointers to this header or something similar. Whatever it is... where would you put default values such as these, if not here? Should we add a centralised `gsm_data.h` to libosmocore that keeps shared values? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51d1fd8b596523ae2ac8fb6a186ce7a702334c27 Gerrit-Change-Number: 31877 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:00:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names
by lynxis lazus 01 Sep '23

01 Sep '23

Attention is currently required from: pespin, daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34258 ) Change subject: Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I77336cb2c76a516ecea5b46500da91fd4230176d Gerrit-Change-Number: 34258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 13:54:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0