September 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_bssgp_cfg from li...
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34294 to look at the new patch set (#2). Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_bssgp_cfg from libosmcore ...................................................................... oml: ipacc: Use new packed struct abis_nm_ipacc_att_bssgp_cfg from libosmcore This way it becomes a lot clearer what kind of content is expected to be transmitted over the wire. It is expected that in the future the bts->gprs.cell.timer will disappear and the values fed into struct abis_nm_ipacc_att_bssgp_cfg come from osmo_tdef, etc. Depends: libosmocore.git Change-Id Ibfd759cb8a252f801bb3a758ea7960072c96f254 Related: OS#5335 Change-Id: Ie659879c548b29a08eeb8bf3fc023bf3d7d52aa1 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 34 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/34294/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie659879c548b29a08eeb8bf3fc023bf3d7d52aa1 Gerrit-Change-Number: 34294 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_rlc_cfg from libo...
by pespin 01 Sep '23

01 Sep '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34296 ) Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_rlc_cfg from libosmcore ...................................................................... oml: ipacc: Use new packed struct abis_nm_ipacc_att_rlc_cfg from libosmcore This way it becomes a lot clearer what kind of content is expected to be transmitted over the wire. It is expected that in the future the nowadays hardcoded values will be fed into struct abis_nm_ipacc_att_ns_cfg come from osmo_tdef, etc. Change-Id: I4b4dfac9fd36378b20889fb90135be74f8968d5f Depends: libosmocore.git Change-Id I60e17dedd1fadce0f705616e3ed96cabb318bcec Related: OS#5335 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 43 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/34296/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index f6cdd0b..d78f23b 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -159,7 +159,9 @@ struct msgb *nanobts_gen_set_cell_attr(struct gsm_bts *bts) { struct msgb *msgb; - uint8_t buf[256]; + struct abis_nm_ipacc_att_rlc_cfg rlc_cfg; + struct abis_nm_ipacc_att_rlc_cfg_2 rlc_cfg_2; + uint8_t buf[2]; msgb = msgb_alloc(1024, "nanobts_attr_bts"); if (!msgb) return NULL; @@ -178,16 +180,18 @@ msgb_tl16v_put(msgb, NM_ATT_IPACC_BVCI, 2, buf); /* all timers in seconds, unless otherwise stated */ - buf[0] = 20; /* T3142 */ - buf[1] = 5; /* T3169 */ - buf[2] = 5; /* T3191 */ - buf[3] = 160; /* T3193 (units of 10ms) */ - buf[4] = 5; /* T3195 */ - buf[5] = 10; /* N3101 */ - buf[6] = 4; /* N3103 */ - buf[7] = 8; /* N3105 */ - buf[8] = 15; /* RLC CV countdown */ - msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG, 9, buf); + rlc_cfg = (struct abis_nm_ipacc_att_rlc_cfg){ + .t3142 = 20, /* T3142 */ + .t3169 = 5, /* T3169 */ + .t3191 = 5, /* T3191 */ + .t3193_10ms = 160, /* T3193 (units of 10ms) */ + .t3195 = 5, /* T3195 */ + .n3101 = 10, /* N3101 */ + .n3103 = 4, /* N3103 */ + .n3105 = 8, /* N3105 */ + .rlc_cv_countdown = 15, /* RLC CV countdown */ + }; + msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG, sizeof(rlc_cfg), (const uint8_t *)&rlc_cfg); if (bts->gprs.mode == BTS_GPRS_EGPRS) { buf[0] = 0x8f; @@ -198,18 +202,21 @@ } msgb_tl16v_put(msgb, NM_ATT_IPACC_CODING_SCHEMES, 2, buf); - buf[0] = 0; /* T downlink TBF extension (0..500, high byte) */ - buf[1] = 250; /* T downlink TBF extension (0..500, low byte) */ - buf[2] = 0; /* T uplink TBF extension (0..500, high byte) */ - buf[3] = 250; /* T uplink TBF extension (0..500, low byte) */ - buf[4] = 2; /* CS2 */ - msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG_2, 5, buf); + rlc_cfg_2 = (struct abis_nm_ipacc_att_rlc_cfg_2){ + .t_dl_tbf_ext_10ms = htons(250), /* 0..500 */ + .t_ul_tbf_ext_10ms = htons(250), /* 0..500 */ + .initial_cs = 2, /* CS2 */ + }; + msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG_2, sizeof(rlc_cfg_2), (const uint8_t *)&rlc_cfg_2); #if 0 /* EDGE model only, breaks older models. * Should inquire the BTS capabilities */ - buf[0] = 2; /* MCS2 */ - msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG_3, 1, buf); + struct abis_nm_ipacc_att_rlc_cfg_3 rlc_cfg_3; + rlc_cfg_3 = (struct abis_nm_ipacc_att_rlc_cfg_3){ + .initial_mcs = 2, /* MCS2 */ + }; + msgb_tl16v_put(msgb, NM_ATT_IPACC_RLC_CFG_3, sizeof(rlc_cfg_3), (const uint8_t *)&rlc_cfg_3); #endif return msgb; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4b4dfac9fd36378b20889fb90135be74f8968d5f Gerrit-Change-Number: 34296 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_ns_cfg from libos...
by pespin 01 Sep '23

01 Sep '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/34295 to look at the new patch set (#2). Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_ns_cfg from libosmcore ...................................................................... oml: ipacc: Use new packed struct abis_nm_ipacc_att_ns_cfg from libosmcore This way it becomes a lot clearer what kind of content is expected to be transmitted over the wire. It is expected that in the future the bts_sm->gprs.nse.timer will disappear and the values fed into struct abis_nm_ipacc_att_ns_cfg come from osmo_tdef, etc. Change-Id: I610ca34babc0b0ac9477622aa7b8360be8f3f59f Depends: libosmocore.git Change-Id Ie477b0e6d79e6d408e0004fd60307afc5feaa3b6 Related: OS#5335 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 31 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/34295/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I610ca34babc0b0ac9477622aa7b8360be8f3f59f Gerrit-Change-Number: 34295 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_ns_cfg from libos...
by pespin 01 Sep '23

01 Sep '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34295 ) Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_ns_cfg from libosmcore ...................................................................... oml: ipacc: Use new packed struct abis_nm_ipacc_att_ns_cfg from libosmcore This way it becomes a lot clearer what kind of content is expected to be transmitted over the wire. It is expected that in the future the bts_sm->gprs.nse.timer will disappear and the values feed into struct abis_nm_ipacc_att_ns_cfg come from osmo_tdef, etc. Change-Id: I610ca34babc0b0ac9477622aa7b8360be8f3f59f Depends: libosmocore.git Change-Id Ie477b0e6d79e6d408e0004fd60307afc5feaa3b6 Related: OS#5335 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 31 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/34295/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index ce368fd..f6cdd0b 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -112,7 +112,8 @@ struct msgb *nanobts_gen_set_nse_attr(struct gsm_bts_sm *bts_sm) { struct msgb *msgb; - uint8_t buf[256]; + uint8_t buf[2]; + struct abis_nm_ipacc_att_ns_cfg ns_cfg; struct abis_nm_ipacc_att_bssgp_cfg bssgp_cfg; struct gsm_bts *bts = gsm_bts_sm_get_bts(bts_sm); msgb = msgb_alloc(1024, "nanobts_attr_bts"); @@ -124,10 +125,17 @@ buf[1] = bts_sm->gprs.nse.nsei & 0xff; msgb_tl16v_put(msgb, NM_ATT_IPACC_NSEI, 2, buf); - /* all timers in seconds */ - OSMO_ASSERT(ARRAY_SIZE(bts_sm->gprs.nse.timer) < sizeof(buf)); - memcpy(buf, bts_sm->gprs.nse.timer, ARRAY_SIZE(bts_sm->gprs.nse.timer)); - msgb_tl16v_put(msgb, NM_ATT_IPACC_NS_CFG, 7, buf); + osmo_static_assert(ARRAY_SIZE(bts_sm->gprs.nse.timer) == 7, nse_timer_array_wrong_size); + ns_cfg = (struct abis_nm_ipacc_att_ns_cfg){ + .un_blocking_timer = bts_sm->gprs.nse.timer[0], + .un_blocking_retries = bts_sm->gprs.nse.timer[1], + .reset_timer = bts_sm->gprs.nse.timer[2], + .reset_retries = bts_sm->gprs.nse.timer[3], + .test_timer = bts_sm->gprs.nse.timer[4], + .alive_timer = bts_sm->gprs.nse.timer[5], + .alive_retries = bts_sm->gprs.nse.timer[6], + }; + msgb_tl16v_put(msgb, NM_ATT_IPACC_NS_CFG, sizeof(ns_cfg), (const uint8_t *)&ns_cfg); osmo_static_assert(ARRAY_SIZE(bts->gprs.cell.timer) == 11, cell_timer_array_wrong_size); bssgp_cfg = (struct abis_nm_ipacc_att_bssgp_cfg){ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I610ca34babc0b0ac9477622aa7b8360be8f3f59f Gerrit-Change-Number: 34295 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: oml: ipacc: Use new packed struct abis_nm_ipacc_att_bssgp_cfg from li...
by pespin 01 Sep '23

01 Sep '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34294 ) Change subject: oml: ipacc: Use new packed struct abis_nm_ipacc_att_bssgp_cfg from libosmcore ...................................................................... oml: ipacc: Use new packed struct abis_nm_ipacc_att_bssgp_cfg from libosmcore This way it becomes a lot clearer what kind of content is expected to be transmitted over the wire. It is expected that in the future the bts->gprs.cell.timer will disappear and the values feed into struct abis_nm_ipacc_att_bssgp_cfg come from osmo_tdef, etc. Depends: libosmocore.git Change-Id Ibfd759cb8a252f801bb3a758ea7960072c96f254 Related: OS#5335 Change-Id: Ie659879c548b29a08eeb8bf3fc023bf3d7d52aa1 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 34 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/94/34294/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index 62a6dfb..ce368fd 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -113,6 +113,7 @@ { struct msgb *msgb; uint8_t buf[256]; + struct abis_nm_ipacc_att_bssgp_cfg bssgp_cfg; struct gsm_bts *bts = gsm_bts_sm_get_bts(bts_sm); msgb = msgb_alloc(1024, "nanobts_attr_bts"); if (!msgb) @@ -128,9 +129,21 @@ memcpy(buf, bts_sm->gprs.nse.timer, ARRAY_SIZE(bts_sm->gprs.nse.timer)); msgb_tl16v_put(msgb, NM_ATT_IPACC_NS_CFG, 7, buf); - OSMO_ASSERT(ARRAY_SIZE(bts->gprs.cell.timer) < sizeof(buf)); - memcpy(buf, bts->gprs.cell.timer, ARRAY_SIZE(bts->gprs.cell.timer)); - msgb_tl16v_put(msgb, NM_ATT_IPACC_BSSGP_CFG, 11, buf); + osmo_static_assert(ARRAY_SIZE(bts->gprs.cell.timer) == 11, cell_timer_array_wrong_size); + bssgp_cfg = (struct abis_nm_ipacc_att_bssgp_cfg){ + .t1_s = bts->gprs.cell.timer[0], + .t1_blocking_retries = bts->gprs.cell.timer[1], + .t1_unblocking_retries = bts->gprs.cell.timer[2], + .t2_s = bts->gprs.cell.timer[3], + .t2_retries = bts->gprs.cell.timer[4], + .t3_100ms = bts->gprs.cell.timer[5], + .t3_retries = bts->gprs.cell.timer[6], + .t4_100ms = bts->gprs.cell.timer[7], + .t4_retries = bts->gprs.cell.timer[8], + .t5_s = bts->gprs.cell.timer[9], + .t5_retries = bts->gprs.cell.timer[10], + }; + msgb_tl16v_put(msgb, NM_ATT_IPACC_BSSGP_CFG, sizeof(bssgp_cfg), (const uint8_t *)&bssgp_cfg); return msgb; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie659879c548b29a08eeb8bf3fc023bf3d7d52aa1 Gerrit-Change-Number: 34294 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: oml: ipacc: Remove BSSGP value assignment being overwritten afterwards
by pespin 01 Sep '23

01 Sep '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34293 ) Change subject: oml: ipacc: Remove BSSGP value assignment being overwritten afterwards ...................................................................... oml: ipacc: Remove BSSGP value assignment being overwritten afterwards bts->gprs.cell.timer is initialized during BTS allocation from bts_cell_timer_default. Later on, during nanobts_gen_set_nse_attr(), the same default values are applied to an internal buffer and immedately later overwritten by the content of bts->gprs.cell.timer. Hence, drop the temporary assignment since it gets overwritten and is basically a NO-OP. This is only an intermediate one-step-at-a-time commit, since anyway that arrive has to be convertd to osmocom tdef, etc. Change-Id: I2a170093e62f726e594d3b9c456087f47d2b4198 --- M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 2 files changed, 36 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/93/34293/1 diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index bd61501..814ba41 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -117,8 +117,20 @@ return 0; } -static const uint8_t bts_cell_timer_default[] = - { 3, 3, 3, 3, 3, 10, 3, 10, 3, 10, 3 }; +static const uint8_t bts_cell_timer_default[11] = { + 3, /* blocking timer (T1) */ + 3, /* blocking retries */ + 3, /* unblocking retries */ + 3, /* reset timer (T2) */ + 3, /* reset retries */ + 10, /* suspend timer (T3) in 100ms */ + 3, /* suspend retries */ + 10, /* resume timer (T4) in 100ms */ + 3, /* resume retries */ + 10, /* capability update timer (T5) */ + 3, /* capability update retries */ +}; + static const struct gprs_rlc_cfg rlc_cfg_default = { .parameter = { [RLC_T3142] = 20, diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index 9fdbf43..62a6dfb 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -128,19 +128,6 @@ memcpy(buf, bts_sm->gprs.nse.timer, ARRAY_SIZE(bts_sm->gprs.nse.timer)); msgb_tl16v_put(msgb, NM_ATT_IPACC_NS_CFG, 7, buf); - /* all timers in seconds */ - buf[0] = 3; /* blockimg timer (T1) */ - buf[1] = 3; /* blocking retries */ - buf[2] = 3; /* unblocking retries */ - buf[3] = 3; /* reset timer (T2) */ - buf[4] = 3; /* reset retries */ - buf[5] = 10; /* suspend timer (T3) in 100ms */ - buf[6] = 3; /* suspend retries */ - buf[7] = 10; /* resume timer (T4) in 100ms */ - buf[8] = 3; /* resume retries */ - buf[9] = 10; /* capability update timer (T5) */ - buf[10] = 3; /* capability update retries */ - OSMO_ASSERT(ARRAY_SIZE(bts->gprs.cell.timer) < sizeof(buf)); memcpy(buf, bts->gprs.cell.timer, ARRAY_SIZE(bts->gprs.cell.timer)); msgb_tl16v_put(msgb, NM_ATT_IPACC_BSSGP_CFG, 11, buf); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34293 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2a170093e62f726e594d3b9c456087f47d2b4198 Gerrit-Change-Number: 34293 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_BSSGP_CFG values
by pespin 01 Sep '23

01 Sep '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34291 ) Change subject: gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_BSSGP_CFG values ...................................................................... gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_BSSGP_CFG values Change-Id: Ibfd759cb8a252f801bb3a758ea7960072c96f254 --- M include/osmocom/gsm/protocol/gsm_12_21.h 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/34291/1 diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index e9d5031..8f288bb 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -790,6 +790,21 @@ IPAC_BINF_CELL_ALLOC = (1 << 2), }; +/*! ip.access NM_ATT_IPACC_BSSGP_CFG value */ +struct abis_nm_ipacc_att_bssgp_cfg { + uint8_t t1_s; /* blocking timer (T1) */ + uint8_t t1_blocking_retries; /* blocking retries */ + uint8_t t1_unblocking_retries; /* unblocking retries */ + uint8_t t2_s; /* reset timer (T2) */ + uint8_t t2_retries; /* reset retries */ + uint8_t t3_100ms; /* suspend timer (T3) in 100ms */ + uint8_t t3_retries; /* suspend retries */ + uint8_t t4_100ms; /* resume timer (T4) in 100ms */ + uint8_t t4_retries; /* resume retries */ + uint8_t t5_s; /* capability update timer (T5) */ + uint8_t t5_retries; /* capability update retries */ +} __attribute__((packed)); + /*! ip.access NM_ATT_IPACC_RLC_CFG value */ struct abis_nm_ipacc_att_rlc_cfg { uint8_t t3142; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibfd759cb8a252f801bb3a758ea7960072c96f254 Gerrit-Change-Number: 34291 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_NS_CFG values
by pespin 01 Sep '23

01 Sep '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34292 ) Change subject: gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_NS_CFG values ...................................................................... gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_NS_CFG values Change-Id: Ie477b0e6d79e6d408e0004fd60307afc5feaa3b6 --- M include/osmocom/gsm/protocol/gsm_12_21.h 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/92/34292/1 diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index 8f288bb..9cc0aa8 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -790,6 +790,17 @@ IPAC_BINF_CELL_ALLOC = (1 << 2), }; +/*! ip.access NM_ATT_IPACC_NS_CFG value */ +struct abis_nm_ipacc_att_ns_cfg { + uint8_t un_blocking_timer; /* (un)blocking Timer (Tns-block) timeout */ + uint8_t un_blocking_retries; /* (un)blocking Timer (Tns-block) number of retries */ + uint8_t reset_timer; /* Reset Timer (Tns-reset) timeout */ + uint8_t reset_retries; /* Reset Timer (Tns-reset) number of retries */ + uint8_t test_timer; /* Test Timer (Tns-test) timeout */ + uint8_t alive_timer; /* Alive Timer (Tns-alive) timeout */ + uint8_t alive_retries; /* Alive Timer (Tns-alive) number of retries */ +} __attribute__((packed)); + /*! ip.access NM_ATT_IPACC_BSSGP_CFG value */ struct abis_nm_ipacc_att_bssgp_cfg { uint8_t t1_s; /* blocking timer (T1) */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34292 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie477b0e6d79e6d408e0004fd60307afc5feaa3b6 Gerrit-Change-Number: 34292 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: write_queue: Introduce API osmo_wqueue_set_max_length()
by pespin 01 Sep '23

01 Sep '23

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34242 ) Change subject: write_queue: Introduce API osmo_wqueue_set_max_length() ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia1b138ed622f5efaa761bd9fa062b25b598f356f Gerrit-Change-Number: 34242 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 0

[S] Change in libosmocore[master]: gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_RLC_CFG{,_2,_3...
by pespin 01 Sep '23

01 Sep '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34290 ) Change subject: gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_RLC_CFG{,_2,_3} values ...................................................................... gsm_12_21.h: Introduce packed structs for NM_ATT_IPACC_RLC_CFG{,_2,_3} values Change-Id: I60e17dedd1fadce0f705616e3ed96cabb318bcec --- M include/osmocom/gsm/protocol/gsm_12_21.h 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/34290/1 diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index 96a6f51..e9d5031 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -790,6 +790,36 @@ IPAC_BINF_CELL_ALLOC = (1 << 2), }; +/*! ip.access NM_ATT_IPACC_RLC_CFG value */ +struct abis_nm_ipacc_att_rlc_cfg { + uint8_t t3142; + uint8_t t3169; + uint8_t t3191; + uint8_t t3193_10ms; + uint8_t t3195; + uint8_t n3101; + uint8_t n3103; + uint8_t n3105; + uint8_t rlc_cv_countdown; +} __attribute__((packed)); + +/*! ip.access NM_ATT_IPACC_RLC_CFG_2 value */ +struct abis_nm_ipacc_att_rlc_cfg_2 { + /* T downlink TBF extension (0..500, network order) */ + uint16_t t_dl_tbf_ext_10ms; + /* T uplink TBF extension (0..500, network order) */ + uint16_t t_ul_tbf_ext_10ms; + /* Initial CS to use: CS1 -> 1, CS2 -> 2, CS3 -> 3, CS4 -> 4 */ + uint8_t initial_cs; +} __attribute__((packed)); + +/*! ip.access NM_ATT_IPACC_RLC_CFG_3 value */ +struct abis_nm_ipacc_att_rlc_cfg_3 { + /* Initial MCS to use when EGPRS is used: + * MCS1 -> 1, MCS2 -> 2, ..., MCS9 -> 9 */ + uint8_t initial_mcs; +} __attribute__((packed)); + /*! Osmocom NSVC address type for NM_ATT_OSMO_NS_LINK_CFG */ enum osmo_oml_nsvc_address_type { OSMO_NSVC_ADDR_UNSPEC = 0x00, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I60e17dedd1fadce0f705616e3ed96cabb318bcec Gerrit-Change-Number: 34290 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0