August 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: socket: Avoid aborting socket creation if setsockopt for ASCONF fails

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34228 ) Change subject: socket: Avoid aborting socket creation if setsockopt for ASCONF fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iff261c8592b6b3c4237c90c84b4e8e921e3c4a65 Gerrit-Change-Number: 34228 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 13:56:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in docker-playground[master]: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34215 ) Change subject: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test ...................................................................... Patch Set 5: Code-Review+2 (2 comments) File osmo_dia2gsup-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/25e310d9_24e… PS2, Line 19: rebar3 escriptize > I tried but $distro-erlang image is already changing the user to some non-root user which then doesn […] Ok, fine then. https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/6eb8b157_c98… PS2, Line 26: --config /data/osmo_dia2gsup.config > Ack Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 Gerrit-Change-Number: 34215 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 13:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmo-abis[master]: osmo_ortp: register a PayloadType for RTP_PT_CSDATA

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34223 ) Change subject: osmo_ortp: register a PayloadType for RTP_PT_CSDATA ...................................................................... osmo_ortp: register a PayloadType for RTP_PT_CSDATA Add a PayloadType definition for payload type 120 as per RFC 4040. Change-Id: I48e91d2c4e9124ee1b7eb88e26af24603aa69f25 Related: OS#1572 --- M src/trau/osmo_ortp.c 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c index b681888..015ac34 100644 --- a/src/trau/osmo_ortp.c +++ b/src/trau/osmo_ortp.c @@ -39,6 +39,7 @@ #include "config.h" +static PayloadType *payload_type_clearmode; static PayloadType *payload_type_efr; static PayloadType *payload_type_hr; static RtpProfile *osmo_pt_profile; @@ -266,6 +267,16 @@ { PayloadType *pt; + /* CLEARMODE as per RFC 4040 (chapter 3) */ + pt = payload_type_new(); + pt->type = PAYLOAD_OTHER; + pt->clock_rate = 8000; + pt->bits_per_sample = 8; + pt->mime_type = "CLEARMODE"; + pt->normal_bitrate = 64000; + pt->channels = 1; + payload_type_clearmode = pt; + /* EFR */ pt = payload_type_new(); pt->type = PAYLOAD_AUDIO_PACKETIZED; @@ -290,6 +301,7 @@ /* add the GSM specific payload types. They are all dynamically * assigned, but in the Osmocom GSM system we have allocated * them as follows: */ + rtp_profile_set_payload(osmo_pt_profile, RTP_PT_CSDATA, payload_type_clearmode); rtp_profile_set_payload(osmo_pt_profile, RTP_PT_GSM_EFR, payload_type_efr); rtp_profile_set_payload(osmo_pt_profile, RTP_PT_GSM_HALF, payload_type_hr); rtp_profile_set_payload(osmo_pt_profile, RTP_PT_AMR, &payload_type_amr); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I48e91d2c4e9124ee1b7eb88e26af24603aa69f25 Gerrit-Change-Number: 34223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in libosmo-abis[master]: osmo_ortp: register a PayloadType for RTP_PT_CSDATA

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34223 ) Change subject: osmo_ortp: register a PayloadType for RTP_PT_CSDATA ...................................................................... Patch Set 1: Code-Review+2 (2 comments) File src/trau/osmo_ortp.c: https://gerrit.osmocom.org/c/libosmo-abis/+/34223/comment/4873b6f0_8c7055b3 PS1, Line 42: static PayloadType *payload_type_clearmode; > I wonder why do we need all these static variables taking memory if they are not really used at all […] TBH, I have no idea. We can try getting rid of them in a separate patch. https://gerrit.osmocom.org/c/libosmo-abis/+/34223/comment/9e3017dd_72168a09 PS1, Line 307: rtp_profile_set_payload(osmo_pt_profile, RTP_PT_AMR, &payload_type_amr); > I'm unable to find where does payload_type_amr come from, I don't see it declared anywhere... […] It's provided by libortp: ``` include/ortp/payloadtype.h:ORTP_VAR_PUBLIC PayloadType payload_type_amr; ``` -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I48e91d2c4e9124ee1b7eb88e26af24603aa69f25 Gerrit-Change-Number: 34223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 13:34:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in osmo-bts[master]: csd_v110: handle empty/incomplete Uplink frames gracefully

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34219 ) Change subject: csd_v110: handle empty/incomplete Uplink frames gracefully ...................................................................... csd_v110: handle empty/incomplete Uplink frames gracefully Change-Id: I7cbf868df3ba5d390cea3d529eef26d18dbe55ab Related: OS#1572 --- M src/common/csd_v110.c M tests/csd/csd_test.c M tests/csd/csd_test.err 3 files changed, 90 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/common/csd_v110.c b/src/common/csd_v110.c index 230a6a7..5046d6e 100644 --- a/src/common/csd_v110.c +++ b/src/common/csd_v110.c @@ -87,9 +87,14 @@ if (OSMO_UNLIKELY(desc->num_blocks == 0)) return -ENOTSUP; - /* handle empty/incomplete frames gracefully */ - if (OSMO_UNLIKELY(data_len < (desc->num_blocks * desc->num_bits))) - return -ENODATA; + /* handle empty/incomplete Uplink frames gracefully */ + if (OSMO_UNLIKELY(data_len < (desc->num_blocks * desc->num_bits))) { + /* encode N idle frames as per 3GPP TS 44.021, section 8.1.6 */ + memset(&ra_bits[0], 0x01, sizeof(ra_bits)); + for (unsigned int i = 0; i < desc->num_blocks; i++) + memset(&ra_bits[i * 80], 0x00, 8); /* alignment pattern */ + goto ra1_ra2; + } /* RA1'/RA1: convert from radio rate to an intermediate data rate */ for (unsigned int i = 0; i < desc->num_blocks; i++) { @@ -117,6 +122,7 @@ osmo_v110_encode_frame(&ra_bits[i * 80], 80, &df); } +ra1_ra2: /* RA1/RA2: convert from an intermediate rate to 64 kbit/s */ if (desc->num_blocks == 4) { /* 4 * 80 bits (16 kbit/s) => 2 bits per octet */ diff --git a/tests/csd/csd_test.c b/tests/csd/csd_test.c index f24331d..466ff88 100644 --- a/tests/csd/csd_test.c +++ b/tests/csd/csd_test.c @@ -135,6 +135,17 @@ fprintf(stderr, "[!] Data mismatch @ %03u: D%u vs E%u\n", i, data_dec[i], data_enc[i]); } + + fprintf(stderr, "[i] Testing '%s' (IDLE)\n", tc->name); + + /* encode an idle RTP frame and print it */ + rc = csd_v110_rtp_encode(&lchan, &rtp[0], &data_enc[0], 0); + fprintf(stderr, "[i] csd_v110_rtp_encode() returns %d\n", rc); + if (rc != RFC4040_RTP_PLEN) + return; + /* print the encoded RTP frame (16 bytes per row) */ + for (unsigned int i = 0; i < sizeof(rtp) / 16; i++) + fprintf(stderr, " %s\n", osmo_hexdump(&rtp[i * 16], 16)); } int main(int argc, char **argv) diff --git a/tests/csd/csd_test.err b/tests/csd/csd_test.err index 94505dc..b862324 100644 --- a/tests/csd/csd_test.err +++ b/tests/csd/csd_test.err @@ -12,6 +12,18 @@ ff 7f 7f 7f bf bf bf bf ff 7f 7f 7f bf ff 7f 7f bf bf bf bf ff 7f 7f 7f bf bf bf bf ff 7f 7f 7f [i] csd_v110_rtp_decode() returns 240 +[i] Testing 'TCH/F9.6' (IDLE) +[i] csd_v110_rtp_encode() returns 160 + 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [i] Testing 'TCH/F4.8' (bitnum=120) [i] csd_v110_rtp_encode() returns 160 7f 7f 7f 7f 7f 7f 7f 7f ff 7f ff 7f ff 7f ff 7f @@ -25,6 +37,18 @@ ff 7f ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff 7f ff ff 7f ff 7f ff 7f ff [i] csd_v110_rtp_decode() returns 120 +[i] Testing 'TCH/F4.8' (IDLE) +[i] csd_v110_rtp_encode() returns 160 + 7f 7f 7f 7f 7f 7f 7f 7f ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + 7f 7f 7f 7f 7f 7f 7f 7f ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [i] Testing 'TCH/H4.8' (bitnum=240) [i] csd_v110_rtp_encode() returns 160 3f 3f 3f 3f bf bf bf bf ff 7f 7f 7f bf bf bf bf @@ -38,6 +62,18 @@ ff 7f 7f 7f bf bf bf bf ff 7f 7f 7f bf ff 7f 7f bf bf bf bf ff 7f 7f 7f bf bf bf bf ff 7f 7f 7f [i] csd_v110_rtp_decode() returns 240 +[i] Testing 'TCH/H4.8' (IDLE) +[i] csd_v110_rtp_encode() returns 160 + 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [i] Testing 'TCH/F2.4' (bitnum=72) [i] csd_v110_rtp_encode() returns 160 7f 7f 7f 7f 7f 7f 7f 7f ff 7f 7f ff ff 7f 7f ff @@ -51,6 +87,18 @@ ff 7f 7f ff ff 7f 7f ff ff 7f 7f ff ff 7f 7f ff ff 7f 7f ff ff 7f 7f ff ff 7f 7f ff ff 7f 7f ff [i] csd_v110_rtp_decode() returns 72 +[i] Testing 'TCH/F2.4' (IDLE) +[i] csd_v110_rtp_encode() returns 160 + 7f 7f 7f 7f 7f 7f 7f 7f ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + 7f 7f 7f 7f 7f 7f 7f 7f ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff [i] Testing 'TCH/H2.4' (bitnum=144) [i] csd_v110_rtp_encode() returns 160 3f 3f 3f 3f bf 7f bf 7f bf 7f bf 7f bf 7f bf 7f @@ -64,3 +112,15 @@ bf 7f bf 7f bf 7f bf 7f bf 7f bf 7f ff 3f 7f 7f bf 7f bf 7f bf 7f bf 7f bf 7f bf 7f bf 7f bf 7f [i] csd_v110_rtp_decode() returns 144 +[i] Testing 'TCH/H2.4' (IDLE) +[i] csd_v110_rtp_encode() returns 160 + 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + 3f 3f 3f 3f ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff 3f 3f 3f 3f ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff + ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7cbf868df3ba5d390cea3d529eef26d18dbe55ab Gerrit-Change-Number: 34219 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-bts[master]: csd_v110: fix comments in csd_v110_rtp_{en,de}code()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34217 ) Change subject: csd_v110: fix comments in csd_v110_rtp_{en,de}code() ...................................................................... csd_v110: fix comments in csd_v110_rtp_{en,de}code() Change-Id: I6fee665e587bfa76058187e13f0cdafaea991940 Related: OS#1572 --- M src/common/csd_v110.c 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/common/csd_v110.c b/src/common/csd_v110.c index 9fc7ad3..8fa4229 100644 --- a/src/common/csd_v110.c +++ b/src/common/csd_v110.c @@ -91,11 +91,11 @@ if (OSMO_UNLIKELY(data_len < (desc->num_blocks * desc->num_bits))) return -ENODATA; - /* RA1'/RA1: convert to an intermediate data rate */ + /* RA1'/RA1: convert from radio rate to an intermediate data rate */ for (unsigned int i = 0; i < desc->num_blocks; i++) { struct osmo_v110_decoded_frame df; - /* convert modified V.110 frames to normal V.110 frames */ + /* convert a V.110 36-/60-bit frame to a V.110 80-bit frame */ if (desc->num_bits == 60) osmo_csd_12k_6k_decode_frame(&df, &data[i * 60], 60); else /* desc->num_bits == 36 */ @@ -158,11 +158,11 @@ ra_bits[i] = (rtp[i] >> 7); } - /* RA1'/RA1: convert to an intermediate data rate */ + /* RA1'/RA1: convert from an intermediate rate to radio rate */ for (unsigned int i = 0; i < desc->num_blocks; i++) { struct osmo_v110_decoded_frame df; - /* convert modified V.110 frames to normal V.110 frames */ + /* convert a V.110 80-bit frame to a V.110 36-/60-bit frame */ osmo_v110_decode_frame(&df, &ra_bits[i * 80], 80); if (desc->num_bits == 60) osmo_csd_12k_6k_encode_frame(&data[i * 60], 60, &df); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6fee665e587bfa76058187e13f0cdafaea991940 Gerrit-Change-Number: 34217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-bts[master]: csd_v110: properly set E1/E2/E3 for non-transparent data

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34218 ) Change subject: csd_v110: properly set E1/E2/E3 for non-transparent data ...................................................................... csd_v110: properly set E1/E2/E3 for non-transparent data Change-Id: Ie38c12e462654cd9fe83a0420bc8ea8b476214b8 Related: OS#1572 --- M src/common/csd_v110.c 1 file changed, 21 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/common/csd_v110.c b/src/common/csd_v110.c index 8fa4229..230a6a7 100644 --- a/src/common/csd_v110.c +++ b/src/common/csd_v110.c @@ -102,9 +102,17 @@ osmo_csd_3k6_decode_frame(&df, &data[i * 36], 36); /* E1 .. E3 must set by out-of-band knowledge */ - df.e_bits[0] = e1e2e3_map[lchan->csd_mode][0]; - df.e_bits[1] = e1e2e3_map[lchan->csd_mode][1]; - df.e_bits[2] = e1e2e3_map[lchan->csd_mode][2]; + if (lchan->csd_mode == LCHAN_CSD_M_NT) { + /* non-transparent: as per 3GPP TS 48.020, Table 7 */ + df.e_bits[0] = 0; /* E1: as per 15.1.2, shall be set to 0 (for BSS-MSC) */ + df.e_bits[1] = (i >> 1) & 0x01; /* E2: 0 for Q1/Q2, 1 for Q3/Q4 */ + df.e_bits[2] = (i >> 0) & 0x01; /* E3: 0 for Q1/Q3, 1 for Q2/Q4 */ + } else { + /* transparent: as per 3GPP TS 44.021, Figure 4 */ + df.e_bits[0] = e1e2e3_map[lchan->csd_mode][0]; /* E1 */ + df.e_bits[1] = e1e2e3_map[lchan->csd_mode][1]; /* E2 */ + df.e_bits[2] = e1e2e3_map[lchan->csd_mode][2]; /* E3 */ + } osmo_v110_encode_frame(&ra_bits[i * 80], 80, &df); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie38c12e462654cd9fe83a0420bc8ea8b476214b8 Gerrit-Change-Number: 34218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: socket: Avoid aborting socket creation if setsockopt for ASCONF fails

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34228 ) Change subject: socket: Avoid aborting socket creation if setsockopt for ASCONF fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iff261c8592b6b3c4237c90c84b4e8e921e3c4a65 Gerrit-Change-Number: 34228 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 13:10:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in docker-playground[master]: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34215 ) Change subject: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 Gerrit-Change-Number: 34215 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 12:44:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs: Add nightly job for ttcn3-dia2gsup-test

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34214 ) Change subject: jobs: Add nightly job for ttcn3-dia2gsup-test ...................................................................... jobs: Add nightly job for ttcn3-dia2gsup-test Related: OS#5757 Change-Id: Icb1a18da0daea1b481b4633eed2de817bfd5a15a --- M jobs/ttcn3-testsuites.yml 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 14e1d6f..8568068 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -126,6 +126,8 @@ description: | Test open5gs-mme email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com + - ttcn3-dia2gsup-test: + timer: 30 14 * * * # debian latest stable - nplab-m3ua-test-latest: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icb1a18da0daea1b481b4633eed2de817bfd5a15a Gerrit-Change-Number: 34214 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023