August 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: dia2gsup: Fix logfile name

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34229 ) Change subject: dia2gsup: Fix logfile name ...................................................................... dia2gsup: Fix logfile name Change-Id: I26e480ee8358476dcda72d51c3d135a0806ca82b --- M osmo_dia2gsup-master/Dockerfile 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/34229/1 diff --git a/osmo_dia2gsup-master/Dockerfile b/osmo_dia2gsup-master/Dockerfile index f8f535b..08c1e82 100644 --- a/osmo_dia2gsup-master/Dockerfile +++ b/osmo_dia2gsup-master/Dockerfile @@ -23,6 +23,6 @@ COPY osmo_dia2gsup.config /data/osmo_dia2gsup.config WORKDIR /data -CMD ["/bin/sh", "-c", "ERL_FLAGS='-config /data/osmo_dia2gsup.config' /tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup > /data/osmo_dia2gsup.config.log 2>&1"] +CMD ["/bin/sh", "-c", "ERL_FLAGS='-config /data/osmo_dia2gsup.config' /tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup > /data/osmo_dia2gsup.log 2>&1"] #EXPOSE -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I26e480ee8358476dcda72d51c3d135a0806ca82b Gerrit-Change-Number: 34229 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Attempt reconnecting if connect fails

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 ) Change subject: gsup: Attempt reconnecting if connect fails ...................................................................... gsup: Attempt reconnecting if connect fails Related: OS#5657 Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0 --- M src/gsup_client.erl 1 file changed, 25 insertions(+), 12 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Verified diff --git a/src/gsup_client.erl b/src/gsup_client.erl index 50a9bf6..047078b 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -65,17 +65,20 @@ ipa_proto:init(), % register the GSUP codec with the IPA core; ignore result as we might be doing this multiple times ipa_proto:register_codec(?IPAC_PROTO_EXT_GSUP, fun gsup_protocol:encode/1, fun gsup_protocol:decode/1), + connect([Address, Port, Options]). + +connect([Address, Port, Options]) -> lager:info("Connecting to GSUP HLR on IP ~s port ~p~n", [Address, Port]), - CcmOptions = #ipa_ccm_options{ - serial_number="HSS-00-00-00-00-00-00", - unit_id="0/0/0", - mac_address="00:00:00:00:00:00", - location="00:00:00:00:00:00", - unit_type="00:00:00:00:00:00", - equipment_version="00:00:00:00:00:00", - sw_version="00:00:00:00:00:00", - unit_name="HSS-00-00-00-00-00-00" - }, + CcmOptions = #ipa_ccm_options{ + serial_number="HSS-00-00-00-00-00-00", + unit_id="0/0/0", + mac_address="00:00:00:00:00:00", + location="00:00:00:00:00:00", + unit_type="00:00:00:00:00:00", + equipment_version="00:00:00:00:00:00", + sw_version="00:00:00:00:00:00", + unit_name="HSS-00-00-00-00-00-00" + }, case ipa_proto:connect(Address, Port, Options) of {ok, {Socket, IpaPid}} -> ipa_proto:set_ccm_options(Socket, CcmOptions), @@ -85,11 +88,11 @@ {ok, #gsupc_state{socket=Socket, ipa_pid=IpaPid}}; {error, Reason} -> lager:error("Connecting to GSUP HLR on IP ~s port ~p failed: ~p~n", [Address, Port, Reason]), + lager:info("Reconnecting to GSUP HLR in 5s...~n", []), timer:sleep(5000), - {stop, Reason} + connect([Address, Port, Options]) end. - % send a given GSUP message and synchronously wait for message type ExpRes or ExpErr handle_call({transceive_gsup, GsupMsgTx, ExpRes, ExpErr}, _From, State) -> Socket = State#gsupc_state.socket, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0 Gerrit-Change-Number: 34199 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Log connect failures

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34198 ) Change subject: gsup: Log connect failures ...................................................................... gsup: Log connect failures Change-Id: I273d37aa75cfacbc7c3302d035c2391d9bdd9b2e --- M src/gsup_client.erl 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gsup_client.erl b/src/gsup_client.erl index d18138a..50a9bf6 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -83,9 +83,10 @@ true = ipa_proto:register_stream(Socket, ?IPAC_PROTO_EXT_GSUP, {process_id, self()}), ipa_proto:unblock(Socket), {ok, #gsupc_state{socket=Socket, ipa_pid=IpaPid}}; - {error, econnrefused} -> + {error, Reason} -> + lager:error("Connecting to GSUP HLR on IP ~s port ~p failed: ~p~n", [Address, Port, Reason]), timer:sleep(5000), - {stop, connrefused} + {stop, Reason} end. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I273d37aa75cfacbc7c3302d035c2391d9bdd9b2e Gerrit-Change-Number: 34198 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Attempt reconnecting if connect fails

by laforge

Attention is currently required from: pespin, daniel, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 ) Change subject: gsup: Attempt reconnecting if connect fails ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0 Gerrit-Change-Number: 34199 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 28 Aug 2023 15:39:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: gsup: Log connect failures

by laforge

Attention is currently required from: pespin, daniel, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34198 ) Change subject: gsup: Log connect failures ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34198 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I273d37aa75cfacbc7c3302d035c2391d9bdd9b2e Gerrit-Change-Number: 34198 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 28 Aug 2023 15:37:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in docker-playground[master]: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34215 ) Change subject: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test ...................................................................... Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test - Add a docker container to run osmo_dia2gsup from git master. - Add infrastructure to run the osmo-dia2gsup container against osmo-ttcn3-hacks.git/dia2gsup testsuite. Related: OS#5757 Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 --- M jenkins-common.sh M make/Makefile A osmo_dia2gsup-master/Dockerfile A osmo_dia2gsup-master/Makefile A osmo_dia2gsup-master/osmo_dia2gsup.config A ttcn3-dia2gsup-test/DIA2GSUP_Tests.cfg A ttcn3-dia2gsup-test/Dockerfile A ttcn3-dia2gsup-test/Makefile A ttcn3-dia2gsup-test/jenkins.sh A ttcn3-dia2gsup-test/osmo_dia2gsup.config 10 files changed, 143 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/jenkins-common.sh b/jenkins-common.sh index f069ffc..72eaec2 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -315,6 +315,7 @@ "$VOL_BASE_DIR" \ -name '*.cfg' -o \ -name '*.conf' -o \ + -name '*.config' -o \ -name '*.confmerge' -o \ -name '*.inc' -o \ -name '*.scm' -o \ diff --git a/make/Makefile b/make/Makefile index d3bd727..126fd94 100644 --- a/make/Makefile +++ b/make/Makefile @@ -23,6 +23,7 @@ OSMO_BSC_BRANCH?=master OSMO_BTS_BRANCH?=master OSMO_CBC_BRANCH?=master +OSMO_DIA2GSUP_BRANCH?=master OSMO_GBPROXY_BRANCH?=master OSMO_GGSN_BRANCH?=master OSMO_GSM_TESTER_BRANCH?=master @@ -103,6 +104,7 @@ --build-arg OSMO_BSC_BRANCH=$(OSMO_BSC_BRANCH) \ --build-arg OSMO_BTS_BRANCH=$(OSMO_BTS_BRANCH) \ --build-arg OSMO_CBC_BRANCH=$(OSMO_CBC_BRANCH) \ + --build-arg OSMO_DIA2GSUP_BRANCH=$(OSMO_DIA2GSUP_BRANCH) \ --build-arg OSMO_GBPROXY_BRANCH=$(OSMO_GBPROXY_BRANCH) \ --build-arg OSMO_GGSN_BRANCH=$(OSMO_GGSN_BRANCH) \ --build-arg OSMO_GSM_TESTER_BRANCH=$(OSMO_GSM_TESTER_BRANCH) \ diff --git a/osmo_dia2gsup-master/Dockerfile b/osmo_dia2gsup-master/Dockerfile new file mode 100644 index 0000000..f8f535b --- /dev/null +++ b/osmo_dia2gsup-master/Dockerfile @@ -0,0 +1,28 @@ +ARG USER +ARG DISTRO +FROM $USER/$DISTRO-erlang +# Arguments used after FROM must be specified again +ARG DISTRO + +WORKDIR /tmp + +ARG OSMO_DIA2GSUP_BRANCH="master" + +RUN git clone https://gerrit.osmocom.org/erlang/osmo_dia2gsup.git +ADD https://gerrit.osmocom.org/plugins/gitiles/erlang/osmo_dia2gsup/+/$OSMO_DIA… /tmp/commit-osmo_dia2gsup + +RUN cd osmo_dia2gsup && \ + git fetch && git checkout $OSMO_DIA2GSUP_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_DIA2GSUP_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + rebar3 compile && \ + rebar3 escriptize + +VOLUME /data + +COPY osmo_dia2gsup.config /data/osmo_dia2gsup.config + +WORKDIR /data +CMD ["/bin/sh", "-c", "ERL_FLAGS='-config /data/osmo_dia2gsup.config' /tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup > /data/osmo_dia2gsup.config.log 2>&1"] + +#EXPOSE diff --git a/osmo_dia2gsup-master/Makefile b/osmo_dia2gsup-master/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/osmo_dia2gsup-master/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/osmo_dia2gsup-master/osmo_dia2gsup.config b/osmo_dia2gsup-master/osmo_dia2gsup.config new file mode 100644 index 0000000..dc0b876 --- /dev/null +++ b/osmo_dia2gsup-master/osmo_dia2gsup.config @@ -0,0 +1,12 @@ +[{osmo_dia2gsup, [ + {hlr_ip, "172.18.10.103"}, + {hlr_port, 4222}, + + {diameter_ip, "172.18.10.20"}, + {diameter_port, 3868}, + {diameter_proto, sctp}, + + {origin_host, "hss.localdomain"}, + {origin_realm, "localdomain"}, + {vendor_id, 0} +]}]. diff --git a/ttcn3-dia2gsup-test/DIA2GSUP_Tests.cfg b/ttcn3-dia2gsup-test/DIA2GSUP_Tests.cfg new file mode 100644 index 0000000..ce68c1f --- /dev/null +++ b/ttcn3-dia2gsup-test/DIA2GSUP_Tests.cfg @@ -0,0 +1,17 @@ +[ORDERED_INCLUDE] +"/osmo-ttcn3-hacks/Common.cfg" +"/osmo-ttcn3-hacks/dia2gsup/DIA2GSUP_Tests.default" + +[LOGGING] + +[TESTPORT_PARAMETERS] + +[MODULE_PARAMETERS] +DIA2GSUP_Tests.mp_hlr_ip := "172.18.10.103" +DIA2GSUP_Tests.mp_s6_local_ip := "172.18.10.103" +DIA2GSUP_Tests.mp_hss_ip := "172.18.10.20" + +[MAIN_CONTROLLER] + +[EXECUTE] +DIA2GSUP_Tests.control diff --git a/ttcn3-dia2gsup-test/Dockerfile b/ttcn3-dia2gsup-test/Dockerfile new file mode 100644 index 0000000..ff93371 --- /dev/null +++ b/ttcn3-dia2gsup-test/Dockerfile @@ -0,0 +1,14 @@ +ARG REGISTRY +ARG USER +FROM $REGISTRY/$USER/debian-bookworm-titan + +ARG OSMO_TTCN3_BRANCH="master" + +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-ttcn3-hacks/+/$OSMO_TTCN3_B… /tmp/commit +RUN ttcn3-docker-prepare "$OSMO_TTCN3_BRANCH" dia2gsup + +VOLUME /data + +COPY DIA2GSUP_Tests.cfg /data/DIA2GSUP_Tests.cfg + +CMD ttcn3-docker-run dia2gsup DIA2GSUP_Tests diff --git a/ttcn3-dia2gsup-test/Makefile b/ttcn3-dia2gsup-test/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/ttcn3-dia2gsup-test/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/ttcn3-dia2gsup-test/jenkins.sh b/ttcn3-dia2gsup-test/jenkins.sh new file mode 100755 index 0000000..d8acc43 --- /dev/null +++ b/ttcn3-dia2gsup-test/jenkins.sh @@ -0,0 +1,41 @@ +#!/bin/sh + +. ../jenkins-common.sh +IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" +docker_images_require \ + "osmo_dia2gsup-$IMAGE_SUFFIX" \ + "ttcn3-dia2gsup-test" + +set_clean_up_trap +set -e + +mkdir $VOL_BASE_DIR/dia2gsup-tester +cp DIA2GSUP_Tests.cfg $VOL_BASE_DIR/dia2gsup-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/dia2gsup-tester/DIA2GSUP_Tests.cfg" + +mkdir $VOL_BASE_DIR/dia2gsup +cp osmo_dia2gsup.config $VOL_BASE_DIR/dia2gsup/ + +network_create +network_replace_subnet_in_configs + +echo Starting container with osmo_dia2gsup +docker run --rm \ + $(docker_network_params $SUBNET 20) \ + --ulimit core=-1 \ + -v $VOL_BASE_DIR/dia2gsup:/data \ + --name ${BUILD_TAG}-dia2gsup -d \ + $DOCKER_ARGS \ + $REPO_USER/osmo_dia2gsup-$IMAGE_SUFFIX + +echo Starting container with DIA2GSUP testsuite +docker run --rm \ + $(docker_network_params $SUBNET 103) \ + --ulimit core=-1 \ + -e "TTCN3_PCAP_PATH=/data" \ + -e "OSMO_SUT_HOST=172.18.$SUBNET.20" \ + -e "OSMO_SUT_PORT=4258" \ + -v $VOL_BASE_DIR/dia2gsup-tester:/data \ + --name ${BUILD_TAG}-ttcn3-dia2gsup-test \ + $DOCKER_ARGS \ + $REPO_USER/ttcn3-dia2gsup-test diff --git a/ttcn3-dia2gsup-test/osmo_dia2gsup.config b/ttcn3-dia2gsup-test/osmo_dia2gsup.config new file mode 100644 index 0000000..dc0b876 --- /dev/null +++ b/ttcn3-dia2gsup-test/osmo_dia2gsup.config @@ -0,0 +1,12 @@ +[{osmo_dia2gsup, [ + {hlr_ip, "172.18.10.103"}, + {hlr_port, 4222}, + + {diameter_ip, "172.18.10.20"}, + {diameter_port, 3868}, + {diameter_proto, sctp}, + + {origin_host, "hss.localdomain"}, + {origin_realm, "localdomain"}, + {vendor_id, 0} +]}]. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 Gerrit-Change-Number: 34215 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: sigtran: Document SCTP (peer) primary address configuration

by pespin

Attention is currently required from: osmith, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 ) Change subject: sigtran: Document SCTP (peer) primary address configuration ...................................................................... Patch Set 1: (4 comments) File common/chapters/sigtran.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/d6b9ea60_776c… PS1, Line 366: , > very long sentence, break it here? "…as backups. […] Done https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/afbf824d_e799… PS1, Line 407: s.T > missing space Done https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/fc3fc09c_19f9… PS1, Line 423: handhsake > handshake Done https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/5d54f9d7_4765… PS1, Line 426: assoc > use the full word instead of the abbreviation? same with spec below Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I8737ca3033293391c999395e2db1fe19cac3e911 Gerrit-Change-Number: 34225 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 15:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: sigtran: Document SCTP (peer) primary address configuration

by pespin

Attention is currently required from: laforge, pespin, dexter. Hello osmith, Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 to look at the new patch set (#2). Change subject: sigtran: Document SCTP (peer) primary address configuration ...................................................................... sigtran: Document SCTP (peer) primary address configuration Related: OS#6076 Related: SYS#6501 Change-Id: I8737ca3033293391c999395e2db1fe19cac3e911 --- M common/chapters/sigtran.adoc 1 file changed, 95 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/25/34225/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I8737ca3033293391c999395e2db1fe19cac3e911 Gerrit-Change-Number: 34225 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_proto: add confirm flag to struct gsm_pcu_if_pch

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34190 ) Change subject: pcuif_proto: add confirm flag to struct gsm_pcu_if_pch ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia202862aafc1f0cb6601574ef61eb9155de11f04 Gerrit-Change-Number: 34190 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 14:34:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: socket: Avoid aborting socket creation if setsockopt for ASCONF fails

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34228 ) Change subject: socket: Avoid aborting socket creation if setsockopt for ASCONF fails ...................................................................... socket: Avoid aborting socket creation if setsockopt for ASCONF fails Avoid aborting the entire socket creation, since those sockopt are fairly new in the kernel (v5.4), and the feature can still be enabled in older versions system-wide with sysctl. The worst it can happen is that the ability to submit address updates (such as Peer Primary Address) doesn't work, which is not really critical. Related: SYS#6501 Change-Id: Iff261c8592b6b3c4237c90c84b4e8e921e3c4a65 --- M src/core/socket.c 1 file changed, 20 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/core/socket.c b/src/core/socket.c index 02d05e2..3c2ba50 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -850,7 +850,8 @@ LOGP(DLGLOBAL, LOGL_ERROR, "cannot setsockopt(SCTP_AUTH_SUPPORTED) socket: %s:%u: %s\n", strbuf, local_port, strerror(err)); - goto ret_close; + /* do not fail, some features such as Peer Primary Address won't be available + * unless configured system-wide through sysctl */ } rc = setsockopt_sctp_asconf_supported(sfd); @@ -860,7 +861,8 @@ LOGP(DLGLOBAL, LOGL_ERROR, "cannot setsockopt(SCTP_ASCONF_SUPPORTED) socket: %s:%u: %s\n", strbuf, local_port, strerror(err)); - goto ret_close; + /* do not fail, some features such as Peer Primary Address won't be available + * unless configured system-wide through sysctl */ } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iff261c8592b6b3c4237c90c84b4e8e921e3c4a65 Gerrit-Change-Number: 34228 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023