August 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: dahdi: Add missing msg->l2h

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34035 ) Change subject: dahdi: Add missing msg->l2h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieec5e2e6bacc4bce465c29b2148537e8b2218a00 Gerrit-Change-Number: 34035 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 01 Aug 2023 13:39:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: repo-install-test: add debian12

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34037 ) Change subject: repo-install-test: add debian12 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I51fa3c5212b5e29f4c2804384781693e8de2c097 Gerrit-Change-Number: 34037 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 13:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add missing msg->l2h

by jolly

Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34035 ) Change subject: dahdi: Add missing msg->l2h ...................................................................... Patch Set 1: (2 comments) File src/input/dahdi.c: https://gerrit.osmocom.org/c/libosmo-abis/+/34035/comment/d5cce9c9_64d4a754 PS1, Line 319: return ret; > msgb leak here. Fixed in another patch. https://gerrit.osmocom.org/c/libosmo-abis/+/34035/comment/00284afd_64db3a2a PS1, Line 322: LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); > msgb leak here. Fixed in another patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieec5e2e6bacc4bce465c29b2148537e8b2218a00 Gerrit-Change-Number: 34035 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 10:44:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: repo-install-test: add debian12

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34037 ) Change subject: repo-install-test: add debian12 ...................................................................... repo-install-test: add debian12 Related: OS#6057 Change-Id: I51fa3c5212b5e29f4c2804384781693e8de2c097 --- M ansible/roles/qemu/files/qemu-create-vms.sh M ansible/roles/qemu/tasks/main.yml M jobs/repo-install-test.yml M scripts/repo-install-test.sh A scripts/repo-install-test/blacklist_debian12.txt M scripts/repo-install-test/run-inside.sh 6 files changed, 106 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/34037/1 diff --git a/ansible/roles/qemu/files/qemu-create-vms.sh b/ansible/roles/qemu/files/qemu-create-vms.sh index 8cceba8..a6ee8e7 100755 --- a/ansible/roles/qemu/files/qemu-create-vms.sh +++ b/ansible/roles/qemu/files/qemu-create-vms.sh @@ -10,6 +10,7 @@ alma-8.5 debian-10 debian-11 + debian-12 " TEMP_SCRIPT="$(mktemp)" @@ -53,13 +54,22 @@ ;; esac + EXTRA_ARGS="" + case "$distro" in + debian-12) + # repo-install-test runs out of space with the default size + EXTRA_ARGS="--size 8G" + ;; + esac + virt-builder \ "$distro" \ -o "/opt/qemu/$distro.qcow2" \ --format qcow2 \ --root-password password:root \ --run "$TEMP_SCRIPT" \ - --verbose + --verbose \ + $EXTRA_ARGS if [ -z "$KEEP_CACHE" ]; then virt-builder --delete-cache @@ -68,8 +78,8 @@ rm "$TEMP_SCRIPT" -# Marker for ansible main.yml to skipt the script -touch /opt/qemu/.qemu-create-vms-done-v1 +# Marker for ansible main.yml to skip the script +touch /opt/qemu/.qemu-create-vms-done-v2 echo echo "Done!" diff --git a/ansible/roles/qemu/tasks/main.yml b/ansible/roles/qemu/tasks/main.yml index c296f8f..96b3150 100644 --- a/ansible/roles/qemu/tasks/main.yml +++ b/ansible/roles/qemu/tasks/main.yml @@ -13,7 +13,7 @@ - name: run qemu-create-vms.sh ansible.builtin.script: qemu-create-vms.sh args: - creates: /opt/qemu/.qemu-create-vms-done-v1 + creates: /opt/qemu/.qemu-create-vms-done-v2 - name: add jenkins to the kvm group user: diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index 5172091..eba2a79 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -10,6 +10,8 @@ feeds: !!python/tuple [nightly, latest] - debian11: feeds: !!python/tuple [nightly, latest] + - debian12: + feeds: !!python/tuple [nightly, latest] - job-template: name: Osmocom-repo-install-{distro} diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh index 676354a..246d5e5 100755 --- a/scripts/repo-install-test.sh +++ b/scripts/repo-install-test.sh @@ -16,6 +16,7 @@ centos8 debian10 debian11 + debian12 " IMG_DIR="/opt/qemu" TEST_DIR="scripts/repo-install-test" @@ -51,6 +52,9 @@ debian11) ret="$IMG_DIR/debian-11.qcow2" ;; + debian12) + ret="$IMG_DIR/debian-12.qcow2" + ;; *) set +x echo "ERROR: script error, missing img path for $DISTRO" >&2 diff --git a/scripts/repo-install-test/blacklist_debian12.txt b/scripts/repo-install-test/blacklist_debian12.txt new file mode 100644 index 0000000..4c9dbde --- /dev/null +++ b/scripts/repo-install-test/blacklist_debian12.txt @@ -0,0 +1,72 @@ +# These packages will not get explicitly installed in this test. +# Package lines must have nothing but the package (no comment, +# no additional space etc). + +# OpenBSC +# This is legacy, we aren't really interested in testing openbsc.git +# derived packages. Packages are found in openbsc/debian/control. +openbsc-dev +osmo-bsc-mgcp +osmo-bsc-mgcp-dbg +osmocom-bs11-utils +osmocom-bs11-utils-dbg +osmocom-bsc-nat +osmocom-bsc-nat-dbg +osmocom-bsc-sccplite +osmocom-bsc-sccplite-dbg +osmocom-ipaccess-utils +osmocom-ipaccess-utils-dbg +osmocom-nitb +osmocom-nitb-dbg + +# Causing conflicts, not relevant for the test +liblimesuite20.10-1-dbgsym +liblimesuite22.09-1-dbgsym +liborcania1.2 +liborcania1.2-dbgsym +liborcania2.1 +liborcania2.1-dbgsym +libulfius2.5 +libulfius2.5-dbgsym +libulfius2.7 +libulfius2.7-dbgsym +libyder2.0-dbgsym +limesuite-dbgsym +soapysdr0.7-module-lms7 +soapysdr0.7-module-lms7-dbgsym + +# Depends on specific verions 0.5.4.38.0847 of rtl-sdr, which we won't install +librtlsdr0-dbgsym +rtl-sdr-dbgsym + +# Depends on mongodb, which was droppend from debian 10 onwards +open5gs +open5gs-amf +open5gs-amf-dbgsym +open5gs-ausf +open5gs-ausf-dbgsym +open5gs-common +open5gs-common-dbgsym +open5gs-dbg +open5gs-hss +open5gs-hss-dbgsym +open5gs-mme +open5gs-mme-dbgsym +open5gs-nrf +open5gs-nrf-dbgsym +open5gs-pcf +open5gs-pcf-dbgsym +open5gs-pcrf +open5gs-pcrf-dbgsym +open5gs-sgwc +open5gs-sgwc-dbgsym +open5gs-sgwu +open5gs-sgwu-dbgsym +open5gs-smf +open5gs-smf-dbgsym +open5gs-udm +open5gs-udm-dbgsym +open5gs-udr +open5gs-udr-dbgsym +open5gs-upf +open5gs-upf-dbgsym diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index 319e822..b45d76d 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -54,6 +54,9 @@ debian11) echo "Debian_11" ;; + debian12) + echo "Debian_12" + ;; *) echo "ERROR: unknown obsdir for '$DISTRO'." >&2 exit 1 @@ -256,7 +259,7 @@ "Depends: osmocom-" \ "but it is not going to be installed" ;; - debian11) + debian11|debian12) find_patterns_or_exit \ /tmp/out \ "Conflicts: osmocom-" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34037 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I51fa3c5212b5e29f4c2804384781693e8de2c097 Gerrit-Change-Number: 34037 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

9 months, 1 week

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmo-gsm-tester-runner: build debian-buster-jenkins

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34022 ) Change subject: jobs/osmo-gsm-tester-runner: build debian-buster-jenkins ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS1: > I think we should at least keep _run-virtual working for now. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f7468a402d82e3b6ee03b4f792ae7e3aae3942b Gerrit-Change-Number: 34022 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Aug 2023 09:48:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add msgb_free() to prevent memeory leaks

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34036 ) Change subject: dahdi: Add msgb_free() to prevent memeory leaks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I862dfa80dc195639552f99ec0734ec94290a7bb5 Gerrit-Change-Number: 34036 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 01 Aug 2023 09:13:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add missing msg->l2h

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34035 ) Change subject: dahdi: Add missing msg->l2h ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/input/dahdi.c: https://gerrit.osmocom.org/c/libosmo-abis/+/34035/comment/2de66266_7fc71b58 PS1, Line 319: return ret; msgb leak here. https://gerrit.osmocom.org/c/libosmo-abis/+/34035/comment/5d030de9_a57644d7 PS1, Line 322: LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); msgb leak here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieec5e2e6bacc4bce465c29b2148537e8b2218a00 Gerrit-Change-Number: 34035 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 01 Aug 2023 09:12:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34034 ) Change subject: dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2c544594eb187110861ab2564323654a2dc6e85a Gerrit-Change-Number: 34034 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 01 Aug 2023 09:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add msgb_free() to prevent memeory leaks

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34036 ) Change subject: dahdi: Add msgb_free() to prevent memeory leaks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I862dfa80dc195639552f99ec0734ec94290a7bb5 Gerrit-Change-Number: 34036 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 01 Aug 2023 07:58:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add missing msg->l2h

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34035 ) Change subject: dahdi: Add missing msg->l2h ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieec5e2e6bacc4bce465c29b2148537e8b2218a00 Gerrit-Change-Number: 34035 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 01 Aug 2023 07:58:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34034 ) Change subject: dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty ...................................................................... dahdi: Disable OSMO_FD_WRITE if HDLC/RAW write queue is empty Not doing so will cause 100% CPU usage, because the write functions are constantly called if their queue is empty. Change-Id: I2c544594eb187110861ab2564323654a2dc6e85a --- M src/input/dahdi.c 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/34/34034/1 diff --git a/src/input/dahdi.c b/src/input/dahdi.c index acf1f94..b4e6657 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -277,8 +277,10 @@ /* get the next msg for this timeslot */ msg = e1inp_tx_ts(e1i_ts, NULL); - if (!msg) + if (!msg) { + osmo_fd_write_disable(bfd); return; + } if (msgb_tailroom(msg) >= 2) { /* two bytes of space for the FCS added by DAHDI in the kernel */ @@ -402,8 +404,10 @@ /* get the next msg for this timeslot */ msg = e1inp_tx_ts(e1i_ts, NULL); - if (!msg) + if (!msg) { + osmo_fd_write_disable(bfd); return 0; + } if (msg->len != D_BCHAN_TX_GRAN) { /* This might lead to a transmit underrun, as we call tx -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34034 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2c544594eb187110861ab2564323654a2dc6e85a Gerrit-Change-Number: 34034 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add missing msg->l2h

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34035 ) Change subject: dahdi: Add missing msg->l2h ...................................................................... dahdi: Add missing msg->l2h l2h is now set in all receive functions after putting received data to the msgb. Change-Id: Ieec5e2e6bacc4bce465c29b2148537e8b2218a00 --- M src/input/dahdi.c 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/35/34035/1 diff --git a/src/input/dahdi.c b/src/input/dahdi.c index b4e6657..2120575 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -181,11 +181,12 @@ LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); return ret; } - msgb_put(msg, ret - 2); if (ret <= 3) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); return ret; } + msgb_put(msg, ret - 2); + msg->l2h = msg->data; return e1inp_rx_ts_lapd(e1i_ts, msg); } @@ -317,11 +318,12 @@ LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); return ret; } - msgb_put(msg, ret - 2); if (ret <= 3) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); return ret; } + msgb_put(msg, ret - 2); + msg->l2h = msg->data; return e1inp_rx_ts(e1i_ts, msg, 0, 0); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34035 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ieec5e2e6bacc4bce465c29b2148537e8b2218a00 Gerrit-Change-Number: 34035 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

9 months, 1 week

1
0
0 0

[S] Change in libosmo-abis[master]: dahdi: Add msgb_free() to prevent memeory leaks

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34036 ) Change subject: dahdi: Add msgb_free() to prevent memeory leaks ...................................................................... dahdi: Add msgb_free() to prevent memeory leaks Change-Id: I862dfa80dc195639552f99ec0734ec94290a7bb5 --- M src/input/dahdi.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/36/34036/1 diff --git a/src/input/dahdi.c b/src/input/dahdi.c index 2120575..7838866 100644 --- a/src/input/dahdi.c +++ b/src/input/dahdi.c @@ -179,10 +179,12 @@ handle_dahdi_exception(e1i_ts); else if (ret < 0) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + msgb_free(msg); return ret; } if (ret <= 3) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + msgb_free(msg); return ret; } msgb_put(msg, ret - 2); @@ -316,10 +318,12 @@ handle_dahdi_exception(e1i_ts); else if (ret < 0) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + msgb_free(msg); return ret; } if (ret <= 3) { LOGPITS(e1i_ts, DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno)); + msgb_free(msg); return ret; } msgb_put(msg, ret - 2); @@ -377,6 +381,7 @@ ret = read(bfd->fd, msg->data, D_TSX_ALLOC_SIZE); if (ret < 0 || ret != D_TSX_ALLOC_SIZE) { LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "read error %d %s\n", ret, strerror(errno)); + msgb_free(msg); return ret; } @@ -446,6 +451,7 @@ ret = read(bfd->fd, msg->data, D_TSX_ALLOC_SIZE); if (ret < 0 || ret != D_TSX_ALLOC_SIZE) { LOGPITS(e1i_ts, DLINP, LOGL_DEBUG, "read error %d %s\n", ret, strerror(errno)); + msgb_free(msg); return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34036 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I862dfa80dc195639552f99ec0734ec94290a7bb5 Gerrit-Change-Number: 34036 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

9 months, 1 week

1
0
0 0

2024

2023

2022

gerrit-log August 2023