August 2023 - gerrit-log - lists.osmocom.org

[M] Change in docker-playground[master]: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test

by pespin

Attention is currently required from: osmith, fixeria. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/34215 to look at the new patch set (#5). Change subject: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test ...................................................................... Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test - Add a docker container to run osmo_dia2gsup from git master. - Add infrastructure to run the osmo-dia2gsup container against osmo-ttcn3-hacks.git/dia2gsup testsuite. Related: OS#5757 Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 --- M jenkins-common.sh M make/Makefile A osmo_dia2gsup-master/Dockerfile A osmo_dia2gsup-master/Makefile A osmo_dia2gsup-master/osmo_dia2gsup.config A ttcn3-dia2gsup-test/DIA2GSUP_Tests.cfg A ttcn3-dia2gsup-test/Dockerfile A ttcn3-dia2gsup-test/Makefile A ttcn3-dia2gsup-test/jenkins.sh A ttcn3-dia2gsup-test/osmo_dia2gsup.config 10 files changed, 143 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/15/34215/5 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 Gerrit-Change-Number: 34215 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[M] Change in docker-playground[master]: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34215 ) Change subject: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test ...................................................................... Patch Set 4: (5 comments) File osmo_dia2gsup-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/b08337ce_0eb… PS2, Line 19: rebar3 escriptize > Maybe copy the resulting `osmo-dia2gsup` to `/usr/local/bin` here, so that it's easier to call it? I tried but $distro-erlang image is already changing the user to some non-root user which then doesn't have rights to copy stuff to /usr/local/bin. I didn't want to go the way to change that and all dependent images, so I'm just running the binary from the local path since anyway it's only used in this container. https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/256626d8_924… PS2, Line 26: --config /data/osmo_dia2gsup.config > You're passing the config file twice. […] Ack File ttcn3-dia2gsup-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/0bb5d4bd_6c7… PS2, Line 1: > ws Ack File ttcn3-dia2gsup-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/a763f9cc_577… PS2, Line 6: debian-bookworm-erlang > This looks like a dependency of `osmo_dia2gsup-$IMAGE_SUFFIX`, and should not be listed here if so. […] Ack https://gerrit.osmocom.org/c/docker-playground/+/34215/comment/7f2acb00_cf6… PS2, Line 31: /bin/sh -c "ERL_FLAGS='-config /data/osmo_dia2gsup.config' /tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup --config /data/osmo_dia2gsup.config >/data/osmo_dia2gsup.log 2>&1" > This line is already specified in `CMD` of the respective Dockerfile, why duplicating it here? Ack -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 Gerrit-Change-Number: 34215 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 12:28:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in docker-playground[master]: debian-*-erlang: Install libsctp to enable sctp support in erlang apps

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34200 ) Change subject: debian-*-erlang: Install libsctp to enable sctp support in erlang apps ...................................................................... debian-*-erlang: Install libsctp to enable sctp support in erlang apps The current "--enable-sctp" flag when building erlang consists of supporting SCTP if the libsctp library is found at runtime, by dynamically linking to it only when SCTP features are requested. The erlang package in debian only lists libsctp as a Build-Depends, but it is not installed by default, so apps wishing to use SCTP will fail: """ [error] CRASH REPORT Process <0.155.0> with 0 neighbours crashed with reason: no match of right hand value {error,{shutdown,{open,eprotonosupport} """ Installing the libsctp library fixes the issue. Related: OS#5757 Change-Id: I5ca332f9064c16491116608577b3f68379d840e6 --- M debian-bookworm-erlang/Dockerfile M debian-bullseye-erlang/Dockerfile 2 files changed, 24 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian-bookworm-erlang/Dockerfile b/debian-bookworm-erlang/Dockerfile index 0c13fd5..811500e 100644 --- a/debian-bookworm-erlang/Dockerfile +++ b/debian-bookworm-erlang/Dockerfile @@ -46,6 +46,7 @@ apt-get update && \ apt-get install -y --no-install-recommends \ libpcap-dev \ + libsctp1 \ && \ apt-get clean diff --git a/debian-bullseye-erlang/Dockerfile b/debian-bullseye-erlang/Dockerfile index 9477ebc..9a90c0c 100644 --- a/debian-bullseye-erlang/Dockerfile +++ b/debian-bullseye-erlang/Dockerfile @@ -37,6 +37,7 @@ RUN apt-get update && \ apt-get -y install \ libpcap-dev \ + libsctp1 \ && \ apt-get clean -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5ca332f9064c16491116608577b3f68379d840e6 Gerrit-Change-Number: 34200 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[L] Change in libosmo-netif[master]: stream tests: Eliminate timestamps from output

by pespin

Attention is currently required from: arehbein, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34224 ) Change subject: stream tests: Eliminate timestamps from output ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: I'm sorry but I just have the feeling that you are now just simply giving an excuse saying they are a burden because you don't know why suddenly timestamps are changing. I'm not finding this acceptable. Furthermore, I'm not even understanding if they are changing already in master or only as a result of your next patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c Gerrit-Change-Number: 34224 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 12:23:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in docker-playground[master]: debian-*-erlang: Install libsctp to enable sctp support in erlang apps

by osmith

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34200 ) Change subject: debian-*-erlang: Install libsctp to enable sctp support in erlang apps ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5ca332f9064c16491116608577b3f68379d840e6 Gerrit-Change-Number: 34200 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 12:17:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in docker-playground[master]: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test

by pespin

Attention is currently required from: osmith. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/34215 to look at the new patch set (#4). Change subject: Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test ...................................................................... Introduce osmo-dia2gsup-master, ttcn3-dia2gsup-test - Add a docker container to run osmo_dia2gsup from git master. - Add infrastructure to run the osmo-dia2gsup container against osmo-ttcn3-hacks.git/dia2gsup testsuite. Related: OS#5757 Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 --- M jenkins-common.sh M make/Makefile A osmo_dia2gsup-master/Dockerfile A osmo_dia2gsup-master/Makefile A osmo_dia2gsup-master/osmo_dia2gsup.config A ttcn3-dia2gsup-test/DIA2GSUP_Tests.cfg A ttcn3-dia2gsup-test/Dockerfile A ttcn3-dia2gsup-test/Makefile A ttcn3-dia2gsup-test/jenkins.sh A ttcn3-dia2gsup-test/osmo_dia2gsup.config 10 files changed, 146 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/15/34215/4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I646096d5a010df02af75aefa33b023b55997a6d7 Gerrit-Change-Number: 34215 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[S] Change in docker-playground[master]: debian-*-erlang: Install libsctp to enable sctp support in erlang apps

by pespin

Attention is currently required from: pespin, daniel. Hello osmith, Jenkins Builder, fixeria, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/34200 to look at the new patch set (#4). Change subject: debian-*-erlang: Install libsctp to enable sctp support in erlang apps ...................................................................... debian-*-erlang: Install libsctp to enable sctp support in erlang apps The current "--enable-sctp" flag when building erlang consists of supporting SCTP if the libsctp library is found at runtime, by dynamically linking to it only when SCTP features are requested. The erlang package in debian only lists libsctp as a Build-Depends, but it is not installed by default, so apps wishing to use SCTP will fail: """ [error] CRASH REPORT Process <0.155.0> with 0 neighbours crashed with reason: no match of right hand value {error,{shutdown,{open,eprotonosupport} """ Installing the libsctp library fixes the issue. Related: OS#5757 Change-Id: I5ca332f9064c16491116608577b3f68379d840e6 --- M debian-bookworm-erlang/Dockerfile M debian-bullseye-erlang/Dockerfile 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/00/34200/4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5ca332f9064c16491116608577b3f68379d840e6 Gerrit-Change-Number: 34200 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: sigtran: Document SCTP (peer) primary address configuration

by osmith

Attention is currently required from: laforge, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 ) Change subject: sigtran: Document SCTP (peer) primary address configuration ...................................................................... Patch Set 1: (4 comments) File common/chapters/sigtran.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/29e58d0d_7353… PS1, Line 366: , very long sentence, break it here? "…as backups. They are only used…" https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/ce4fc54a_b5f3… PS1, Line 407: s.T missing space https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/f02391a7_f2fe… PS1, Line 423: handhsake handshake https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/b388e6d6_d7d5… PS1, Line 426: assoc use the full word instead of the abbreviation? same with spec below -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I8737ca3033293391c999395e2db1fe19cac3e911 Gerrit-Change-Number: 34225 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 12:13:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmo-abis[master]: osmo_ortp: register a PayloadType for RTP_PT_CSDATA

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34223 ) Change subject: osmo_ortp: register a PayloadType for RTP_PT_CSDATA ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/trau/osmo_ortp.c: https://gerrit.osmocom.org/c/libosmo-abis/+/34223/comment/e3d2f363_d5075621 PS1, Line 42: static PayloadType *payload_type_clearmode; I wonder why do we need all these static variables taking memory if they are not really used at all after create_payload_types() finishes.... https://gerrit.osmocom.org/c/libosmo-abis/+/34223/comment/4894211b_e31f4e59 PS1, Line 307: rtp_profile_set_payload(osmo_pt_profile, RTP_PT_AMR, &payload_type_amr); I'm unable to find where does payload_type_amr come from, I don't see it declared anywhere... :/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I48e91d2c4e9124ee1b7eb88e26af24603aa69f25 Gerrit-Change-Number: 34223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 12:13:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: socket: Avoid aborting socket creation if setsockopt for ASCONF fails

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34228 ) Change subject: socket: Avoid aborting socket creation if setsockopt for ASCONF fails ...................................................................... socket: Avoid aborting socket creation if setsockopt for ASCONF fails Avoid aborting the entire socket creation, since those sockopt are fairly new in the kernel (v5.4), and the feature can still be enabled in older versions system-wide with sysctl. The worst it can happen is that the ability to submit address updates (such as Peer Primary Address) doesn't work, which is not really critical. Related: SYS#6501 Change-Id: Iff261c8592b6b3c4237c90c84b4e8e921e3c4a65 --- M src/core/socket.c 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/28/34228/1 diff --git a/src/core/socket.c b/src/core/socket.c index 02d05e2..3c2ba50 100644 --- a/src/core/socket.c +++ b/src/core/socket.c @@ -850,7 +850,8 @@ LOGP(DLGLOBAL, LOGL_ERROR, "cannot setsockopt(SCTP_AUTH_SUPPORTED) socket: %s:%u: %s\n", strbuf, local_port, strerror(err)); - goto ret_close; + /* do not fail, some features such as Peer Primary Address won't be available + * unless configured system-wide through sysctl */ } rc = setsockopt_sctp_asconf_supported(sfd); @@ -860,7 +861,8 @@ LOGP(DLGLOBAL, LOGL_ERROR, "cannot setsockopt(SCTP_ASCONF_SUPPORTED) socket: %s:%u: %s\n", strbuf, local_port, strerror(err)); - goto ret_close; + /* do not fail, some features such as Peer Primary Address won't be available + * unless configured system-wide through sysctl */ } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iff261c8592b6b3c4237c90c84b4e8e921e3c4a65 Gerrit-Change-Number: 34228 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023