osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/34206 )
Change subject: libosmocore: use --disable-uring
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/34206
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Gerrit-Change-Id: I92335090e49de82384ac3ff837cbad48fcc5c3f5
Gerrit-Change-Number: 34206
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Aug 2023 10:24:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34203 )
Change subject: scripts/osmocom-api-doxygen: check ssh early
......................................................................
scripts/osmocom-api-doxygen: check ssh early
Check for working SSH right at the start of the job, so we don't need to
wait 2 minutes until it has built everything to find it out.
Change-Id: Id93c15d38a49859dc63d39f70f051a7df871c398
---
M scripts/osmocom-api-doxygen.sh
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/scripts/osmocom-api-doxygen.sh b/scripts/osmocom-api-doxygen.sh
index 765b7fb..cfa5e61 100755
--- a/scripts/osmocom-api-doxygen.sh
+++ b/scripts/osmocom-api-doxygen.sh
@@ -1,4 +1,6 @@
#!/bin/sh -ex
+SSH_CMD="ssh -o UserKnownHostsFile=/build/contrib/known_hosts -p 48"
+
# Repositories for which doxygen documentation will be generated and
# uploaded, also dependencies which need to be built
repos_api="
@@ -13,6 +15,9 @@
# Source common.sh from osmo-ci.git for osmo_git_clone_url()
. scripts/common.sh
+# Check early that SSH works
+$SSH_CMD api(a)ftp.osmocom.org -T -- true
+
# Put git repos and install data in a subdir, so it isn't in the root
# of the cloned osmo-ci.git repository
mkdir _osmocom_api
@@ -45,7 +50,7 @@
rsync \
-avz \
--delete \
- -e "ssh -o UserKnownHostsFile=/build/contrib/known_hosts -p 48" \
+ -e "$SSH_CMD" \
./"$i"/doc/ \
api@ftp.osmocom.org:web-files/latest/"$i"/
done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34203
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id93c15d38a49859dc63d39f70f051a7df871c398
Gerrit-Change-Number: 34203
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: merged
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34202 )
Change subject: jobs/osmocom-api: run inside docker
......................................................................
jobs/osmocom-api: run inside docker
Run the osmocom-api job inside docker, so all depends are available
(fixes that it currently fails because liburing isn't available for
libosmocore).
Use the contrib/known_hosts file, instead of writing an own copy during
the job.
Change-Id: I6e831c71c4c88772c3e4232fcb1a9e2c1c73d997
---
M jobs/osmocom-api.yml
A scripts/osmocom-api-doxygen.sh
2 files changed, 76 insertions(+), 56 deletions(-)
Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/jobs/osmocom-api.yml b/jobs/osmocom-api.yml
index 238340c..294ccaa 100644
--- a/jobs/osmocom-api.yml
+++ b/jobs/osmocom-api.yml
@@ -35,59 +35,12 @@
wipe-workspace: true
builders:
- shell: |
- # Repositories for which doxygen documentation will be generated and
- # uploaded, also dependencies which need to be built
- repos_api="
- libosmocore
- libosmo-abis
- libosmo-dsp
- libosmo-netif
- libosmo-sccp
- osmo-gmr"
-
- # Source common.sh from osmo-ci.git for osmo_git_clone_url()
- . scripts/common.sh
-
- # Put git repos and install data in a subdir, so it isn't in the root
- # of the cloned osmo-ci.git repository
- mkdir _osmocom_api
- cd _osmocom_api
-
- # Prepare pkgconfig path
- export PKG_CONFIG_PATH=$PWD/install/lib/pkgconfig
- mkdir -p "$PKG_CONFIG_PATH"
-
- # Prepare known_hosts
- cat > known_hosts <<EOF
- [ftp.osmocom.org]:48 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDDgQ9HntlpWNmh953a2Gc8NysKE4orOatVT1wQkyzhARnfYUerRuwyNr1GqMyBKdSI9amYVBXJIOUFcpV81niA7zQRUs66bpIMkE9/rHxBd81SkorEPOIS84W4vm3SZtuNqa+fADcqe88Hcb0ZdTzjKILuwi19gzrQyME2knHY71EOETe9Yow5RD2hTIpB5ecNxI0LUKDq+Ii8HfBvndPBIr0BWYDugckQ3Bocf+yn/tn2/GZieFEyFpBGF/MnLbAAfUKIdeyFRX7ufaiWWz5yKAfEhtziqdAGZaXNaLG6gkpy3EixOAy6ZXuTAk3b3Y0FUmDjhOHllbPmTOcKMry9
- [ftp.osmocom.org]:48 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBPdWn1kEousXuKsZ+qJEZTt/NSeASxCrUfNDW3LWtH+d8Ust7ZuKp/vuyG+5pe5pwpPOgFu7TjN+0lVjYJVXH54=
- [ftp.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX
- EOF
-
- # Clone and build the repositories
- for i in $repos_api; do
- git clone "$(osmo_git_clone_url "$i")"
- cd "$i"
- autoreconf -fi
- ./configure \
- --prefix=$PWD/../install \
- --with-systemdsystemunitdir=no
- make $PARALLEL_MAKE install
- cd ..
- done
-
- # Upload all docs
- for i in $repos_api; do
- if ! [ -d "$i"/doc ]; then
- # e.g. libosmo-abis is built as dependency for others but doesn't
- # have its own doxygen documentation as of writing
- continue
- fi
-
- rsync \
- -avz \
- --delete \
- -e "ssh -o 'UserKnownHostsFile=known_hosts' -p 48" \
- ./"$i"/doc/ \
- api@ftp.osmocom.org:web-files/latest/"$i"/
- done
+ docker run \
+ --rm=true \
+ -e SSH_AUTH_SOCK=/ssh-agent \
+ -u build \
+ -v "$PWD:/build" \
+ -v $(readlink -f $SSH_AUTH_SOCK):/ssh-agent \
+ -w /build \
+ "$USER/debian-bookworm-build" \
+ scripts/osmocom-api-doxygen.sh
diff --git a/scripts/osmocom-api-doxygen.sh b/scripts/osmocom-api-doxygen.sh
new file mode 100755
index 0000000..765b7fb
--- /dev/null
+++ b/scripts/osmocom-api-doxygen.sh
@@ -0,0 +1,51 @@
+#!/bin/sh -ex
+# Repositories for which doxygen documentation will be generated and
+# uploaded, also dependencies which need to be built
+repos_api="
+ libosmocore
+ libosmo-abis
+ libosmo-dsp
+ libosmo-netif
+ libosmo-sccp
+ osmo-gmr
+"
+
+# Source common.sh from osmo-ci.git for osmo_git_clone_url()
+. scripts/common.sh
+
+# Put git repos and install data in a subdir, so it isn't in the root
+# of the cloned osmo-ci.git repository
+mkdir _osmocom_api
+cd _osmocom_api
+
+# Prepare pkgconfig path
+export PKG_CONFIG_PATH=$PWD/install/lib/pkgconfig
+mkdir -p "$PKG_CONFIG_PATH"
+
+# Clone and build the repositories
+for i in $repos_api; do
+ git clone "$(osmo_git_clone_url "$i")"
+ cd "$i"
+ autoreconf -fi
+ ./configure \
+ --prefix=$PWD/../install \
+ --with-systemdsystemunitdir=no
+ make $PARALLEL_MAKE install
+ cd ..
+done
+
+# Upload all docs
+for i in $repos_api; do
+ if ! [ -d "$i"/doc ]; then
+ # e.g. libosmo-abis is built as dependency for others but doesn't
+ # have its own doxygen documentation as of writing
+ continue
+ fi
+
+ rsync \
+ -avz \
+ --delete \
+ -e "ssh -o UserKnownHostsFile=/build/contrib/known_hosts -p 48" \
+ ./"$i"/doc/ \
+ api@ftp.osmocom.org:web-files/latest/"$i"/
+done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34202
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6e831c71c4c88772c3e4232fcb1a9e2c1c73d997
Gerrit-Change-Number: 34202
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: osmith, pespin, daniel.
Hello osmith, Jenkins Builder, fixeria, daniel,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/34200
to look at the new patch set (#3).
Change subject: debian-*-erlang: Install on libsctp-dev to enable sctp support in erlang apps
......................................................................
debian-*-erlang: Install on libsctp-dev to enable sctp support in erlang apps
The current "--enable-sctp" flag when building erlang consists of
supporting SCTP if the libsctp library is found at runtime, by
dynamically linking to it only when SCTP features are requested.
The erlang package in debian only lists libsctp as a Build-Depends, but
it is not installed by default, so apps wishing to use SCTP will fail:
"""
[error] CRASH REPORT Process <0.155.0> with 0 neighbours crashed with reason: no match of right hand value {error,{shutdown,{open,eprotonosupport}
"""
Installing the libsctp library fixes the issue.
Related: OS#5757
Change-Id: I5ca332f9064c16491116608577b3f68379d840e6
---
M debian-bookworm-erlang/Dockerfile
M debian-bullseye-erlang/Dockerfile
2 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/00/34200/3
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34200
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I5ca332f9064c16491116608577b3f68379d840e6
Gerrit-Change-Number: 34200
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, daniel, lynxis lazus.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199 )
Change subject: gsup: Attempt reconnecting if connect fails
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I need this one to have TTCN3 test passing since osmo_dia2gsup starts before the TTCN3 GSUP server starts.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34199
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: erlang/osmo_dia2gsup
Gerrit-Branch: master
Gerrit-Change-Id: I47b6db0f0267bbd4c80fbac9d51a8647862827a0
Gerrit-Change-Number: 34199
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 28 Aug 2023 09:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34218 )
Change subject: csd_v110: properly set E1/E2/E3 for non-transparent data
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34218
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie38c12e462654cd9fe83a0420bc8ea8b476214b8
Gerrit-Change-Number: 34218
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Aug 2023 08:59:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: arehbein, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34224 )
Change subject: stream tests: Eliminate timestamps from output
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
Removing time from test output just because you don't know why it changes it not a valid rationale.
Either there's a known reason requiring and justifying this change, or you need to fix whatever it doing that.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c
Gerrit-Change-Number: 34224
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Aug 2023 08:48:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment