Attention is currently required from: pespin, fixeria, daniel.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 )
Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................
Patch Set 20:
(1 comment)
Patchset:
PS19:
> I have added a patch eliminating timestamp logging in the test: […]
*timestamp behavior of the second half of the test
to be more exact.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 20
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 27 Aug 2023 22:26:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, fixeria, daniel.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33198 )
Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................
Patch Set 20:
(2 comments)
Patchset:
PS19:
> But if that's unrelated to this patch and it shows up as a result of rebase, better submit a precedi […]
I have added a patch eliminating timestamp logging in the test:
https://gerrit.osmocom.org/c/libosmo-netif/+/34224
I don't know what the cause is, but it appears recent changes to libosmocore or libosmo-netif have changed the timestamp behavior which used to be predictable.
Patchset:
PS20:
After adapting `stream_test.err` to some of the new logs (locally), a connectivity issue (it's not just the logging, a lag that I didn't have before comes along with the following output) has appeared
```
unable to connect socket: 127.0.0.11:1111: Cannot assign requested address
no suitable remote addr found for: 127.0.0.11:1111
CLICONN(,){WAIT_RECONNECT} retrying reconnect in 5 seconds...
Cannot open stream client
```
It's not any patches in libosmocore causing this new behavior (I tried an older libosmocore patch, that didn't change anything), so I took a look at libosmo-netif and saw a couple of recent changes, probably something there.
A workaround for this was changing the port for the stream client tests from 1111 to 1112 (similarly to how I had to change the local port from 8967 to something else in order for osmo time not becoming unpredictable...).
But I do wonder if this shouldn't be addressed (somehow after destroying the client, and reopening the server link, the same port remains blocked for a noticeable amount of time, apart from the error log).
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 20
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 27 Aug 2023 22:19:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: arehbein, fixeria, daniel.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33198
to look at the new patch set (#20).
Change subject: stream: Add client-side (segmentation) support for IPA
......................................................................
stream: Add client-side (segmentation) support for IPA
With this commit, IPA segmentation is taken care of by setting the
segmentation callback provided by libosmo-netif.
The ipa-stream-server example needs to prepend IPA headers now because
those are stripped by the segm. cb on both sides.
Depends: libosmocore.git I3a639e6896cc3b3fc8e9b2e1a58254710efa0d3f
Related: OS#5753, OS#5751
Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
---
M examples/ipa-stream-client.c
M examples/ipa-stream-server.c
M include/osmocom/netif/stream.h
M src/stream_cli.c
M tests/stream/stream_test.c
M tests/stream/stream_test.err
M tests/stream/stream_test.ok
7 files changed, 337 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/98/33198/20
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33198
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 20
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/34222 )
Change subject: add the gnuradio 3.10 demodulator and receiver from telive
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34222
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I81f20fa115822b3ad642b638f6414d8249a8ac6a
Gerrit-Change-Number: 34222
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sun, 27 Aug 2023 19:57:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-tetra/+/34222
to look at the new patch set (#2).
Change subject: add the gnuradio 3.10 demodulator and receiver from telive
......................................................................
add the gnuradio 3.10 demodulator and receiver from telive
Change-Id: I81f20fa115822b3ad642b638f6414d8249a8ac6a
---
A src/demod/simdemod3.grc
A src/demod/simdemod3.py
A src/demod/telive_1ch_simple_gr310_udp.grc
A src/demod/telive_1ch_simple_gr310_udp.py
A src/receiver1udp
5 files changed, 2,115 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/22/34222/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/34222
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I81f20fa115822b3ad642b638f6414d8249a8ac6a
Gerrit-Change-Number: 34222
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset