August 2023 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: debian-bookworm-build: add curl

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/34226 to look at the new patch set (#2). Change subject: debian-bookworm-build: add curl ...................................................................... debian-bookworm-build: add curl Add curl, as required by the coverity job to submit the API request. Change-Id: I70eb2b94d0eda4b371d674e1087b4dc13397dcdf --- M debian-bookworm-build/Dockerfile 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/26/34226/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70eb2b94d0eda4b371d674e1087b4dc13397dcdf Gerrit-Change-Number: 34226 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/coverity: fix path to home dir

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34227 ) Change subject: jobs/coverity: fix path to home dir ...................................................................... jobs/coverity: fix path to home dir Fix for: ./jenkins.sh: line 35: /home/build/osmo-ci/coverity/get_token.sh: No such file or directory Fixes: 56bc906e ("coverity: run inside docker") Change-Id: I87fadd2dffcfaa04eaa942dfb8a496334cb722d5 --- M jobs/coverity.yml 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/27/34227/1 diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 7c4b0e8..a2663a8 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -17,7 +17,7 @@ -e PARALLEL_MAKE="$PARALLEL_MAKE" \ -u build \ -v "$PWD:/build" \ - -v "/home/osmo-ci/coverity:/home/osmo-ci/coverity:ro" \ + -v "$HOME/osmo-ci/coverity:/home/build/osmo-ci/coverity:ro" \ -v "/opt/coverity:/opt/coverity:ro" \ -w /build/coverity \ "$USER/debian-bookworm-build" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I87fadd2dffcfaa04eaa942dfb8a496334cb722d5 Gerrit-Change-Number: 34227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in docker-playground[master]: debian-bookwrom-build: add curl

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/34226 ) Change subject: debian-bookwrom-build: add curl ...................................................................... debian-bookwrom-build: add curl Add curl, as required by the coverity job to submit the API request. Change-Id: I70eb2b94d0eda4b371d674e1087b4dc13397dcdf --- M debian-bookworm-build/Dockerfile 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/26/34226/1 diff --git a/debian-bookworm-build/Dockerfile b/debian-bookworm-build/Dockerfile index cebff09..b0effe1 100644 --- a/debian-bookworm-build/Dockerfile +++ b/debian-bookworm-build/Dockerfile @@ -65,6 +65,7 @@ cmake \ coccinelle \ cppcheck \ + curl \ dahdi-source \ dblatex \ dbus \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70eb2b94d0eda4b371d674e1087b4dc13397dcdf Gerrit-Change-Number: 34226 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in osmo-bts[master]: pcuif_proto: use confirm flag in struct gsm_pcu_if_pch

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34191 ) Change subject: pcuif_proto: use confirm flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3364d2268bdef9c4d2feeb8e3d51a64e34bca68c Gerrit-Change-Number: 34191 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 11:12:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcuif_proto: add confirm flag to struct gsm_pcu_if_pch

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34190 ) Change subject: pcuif_proto: add confirm flag to struct gsm_pcu_if_pch ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia202862aafc1f0cb6601574ef61eb9155de11f04 Gerrit-Change-Number: 34190 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 11:06:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in docker-playground[master]: debian-*-erlang: Install on libsctp-dev to enable sctp support in erl...

by osmith

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34200 ) Change subject: debian-*-erlang: Install on libsctp-dev to enable sctp support in erlang apps ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/34200/comment/9049b811_6c8… PS3, Line 7: libsctp-dev libsctp -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34200 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5ca332f9064c16491116608577b3f68379d840e6 Gerrit-Change-Number: 34200 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 11:01:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs: Add nightly job for ttcn3-dia2gsup-test

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34214 ) Change subject: jobs: Add nightly job for ttcn3-dia2gsup-test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icb1a18da0daea1b481b4633eed2de817bfd5a15a Gerrit-Change-Number: 34214 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 10:49:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmo-abis[master]: osmo_ortp: register a PayloadType for RTP_PT_CSDATA

by osmith

Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/34223 ) Change subject: osmo_ortp: register a PayloadType for RTP_PT_CSDATA ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/34223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I48e91d2c4e9124ee1b7eb88e26af24603aa69f25 Gerrit-Change-Number: 34223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 10:47:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: sigtran: Document SCTP (peer) primary address configuration

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 ) Change subject: sigtran: Document SCTP (peer) primary address configuration ...................................................................... sigtran: Document SCTP (peer) primary address configuration Related: OS#6076 Related: SYS#6501 Change-Id: I8737ca3033293391c999395e2db1fe19cac3e911 --- M common/chapters/sigtran.adoc 1 file changed, 95 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/25/34225/1 diff --git a/common/chapters/sigtran.adoc b/common/chapters/sigtran.adoc index 51ef65e..3f819a3 100644 --- a/common/chapters/sigtran.adoc +++ b/common/chapters/sigtran.adoc @@ -358,6 +358,90 @@ multiple `local-ip` VTY commands within one `asp` (SCTP client role) or within one `listen m3ua 2905` (SCTP server role). +==== SCTP Primary Address + +SCTP has the concept of "primary address" in an association. The primary address +is a remote address selected from those announced by the peer, and it is the +"active" one chosen to transmit user data. The other remote addresses, that are not +used, are kept as backups, and only used to transmit user data whenever the SCTP +implementation decides to change the primary address, be it due to user policy +configuration change or due to the previous primary link becoming unusable. Only +confirmed remote addresses (through HEARTBEAT mechanism) are electable to be +used as primary address. + +By default, the Linux kernel SCTP stack implementation will probably take the +first remote address provided at connect() time in order to start the initial +handshake, and continue with next provided remote addresses if the first one +fails to confirm the handshake. The remote address which successfully confirmed +the handshake is then used as a primary address (since it's likely the only +confirmed so far), and will be kept until the link is considered down. + +Some deployment setups may have requirements on preferred links to be used when +transmitting data (eg. network setups with primary and secondary paths). This +can be accomplished by explicitly notifying the kernel to use one of the remote +addresses through the SCTP_PRIMARY_ADDR sockopt, plus monitoring the address +availability changes on the socket and re-enforcing the primary address when it +becomes available again. This is supported in the Osmocom SIGTRAN stack by using +the `primary` parameter in one of the `remote-ip` commands under the `asp` node: + +---- +cs7 instance 0 + asp my-asp 2905 0 m3ua + remote-ip 10.11.12.13 + remote-ip 16.17.18.19 primary <1> + ... +---- +<1> Use 16.17.18.19 as primary address for the SCTP association. User data will +be in general transmitted over this path. + +==== SCTP Peer Primary Address + +The SCTP extension ASCONF (RFC5061) allows, when negotiated and supported by +both peers, to dynamically announce to the peer the addition or deletion of IP +addresses to the association. It also allows one peer announcing to the other +peer the desired IP address it should be using as a primary address when sending +data to it. + +In the Linux kernel SCTP stack, this is accomplished by setting the sockopt +SCTP_SET_PEER_PRIMARY_ADDR, which will trigger an ASCONF SCTP message to the +peer with the provided local IP address.This is supported in the Osmocom SIGTRAN +stack by using the `primary` parameter in one of the `local-ip` commands under +the `asp` node: + +---- +cs7 instance 0 + asp my-asp 2905 0 m3ua + local-ip 10.11.12.13 + local-ip 16.17.18.19 primary <1> + ... +---- +<1> Announce 16.17.18.19 to the peer as the primary address to be used when +transmitting user data to us. + +In order to be able to use this feature, the SCTP association peer must support +the ASCONF extension. The extension support is negotiation during the INIT +handhsake of the association. Furthermore, for ASCONF features to work properly, +the assoc also needs to announce/use the AUTH extension, as per RFC5061 section +4.2.7. Otherwise, the peer receiving an SCTP INIT with +ExtensionFeatures=ASCONF,ASCONF_ACK but without AUTH, will reject the assoc with +an ABORT since it's not complying with spec (this behavior can be tweaked +through sysctl "net.sctp.addip_noauth_enable"). + +As of the time of writing this documentation (linux 6.4.12) and since basically +ever, those extensions are runtime-disabled by default. They can be enabled per +socket using the kernel sockopts SCTP_ASCONF_SUPPORTED and SCTP_AUTH_SUPPORTED, +and that's what the Osmocom stack is currently doing for all SCTP sockets. +However, those sockopts are farily new (linux v5.4), which means user running +older kernels will see in the logs setting those sockopts fail, but connection +will keep ongoing, simply without those features available (so setting `primary` +in the configuration won't have any effect here). +On those older kernels, if this feature is still desired, it can be used +by means of enabling the SCTP extensions in all socket system-wide through sysctl: +---- +net.sctp.auth_enable=1 +net.sctp.addip_enable=1 +---- + ==== SCTP role The _SCTP role_ defines which of the two L4 protocol roles SCTP assumes: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I8737ca3033293391c999395e2db1fe19cac3e911 Gerrit-Change-Number: 34225 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in meta-telephony[201705]: libosmocore: use --disable-uring

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/34206 ) Change subject: libosmocore: use --disable-uring ...................................................................... libosmocore: use --disable-uring Disable it as the library is not available in OE packaging, and kernels are probably too old to make use of this feature. Related: OS#5751 Change-Id: I92335090e49de82384ac3ff837cbad48fcc5c3f5 --- M recipes-osmocom/libosmocore/libosmocore_git.bb 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved osmith: Verified diff --git a/recipes-osmocom/libosmocore/libosmocore_git.bb b/recipes-osmocom/libosmocore/libosmocore_git.bb index 292596f..8bd37de 100644 --- a/recipes-osmocom/libosmocore/libosmocore_git.bb +++ b/recipes-osmocom/libosmocore/libosmocore_git.bb @@ -24,7 +24,7 @@ RREPLACES_libosmogsm = "DONOTREPLACElibosmocore" RREPLACES_libosmovty = "DONOTREPLACElibosmocore" -EXTRA_OECONF += "--disable-pcsc" +EXTRA_OECONF += "--disable-pcsc --disable-uring" # OS#4062: Some gcc version (< 7.3.0) on ARM generate wrong code for __thread # variables that crash at runtime. It seems, due to some unknown reason, that we -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/34206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I92335090e49de82384ac3ff837cbad48fcc5c3f5 Gerrit-Change-Number: 34206 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023