August 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: ASCI: Update commit hash of titan.ProtocolModules.MobileL3_v13.4.0

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34232 ) Change subject: ASCI: Update commit hash of titan.ProtocolModules.MobileL3_v13.4.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2833750a8cf1def74f92a5a50f0d271891cee05f Gerrit-Change-Number: 34232 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 29 Aug 2023 09:16:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: ASCI: Add tests for voice group/broadcast calls at MSC

by jolly

Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 to look at the new patch set (#3). Change subject: ASCI: Add tests for voice group/broadcast calls at MSC ...................................................................... ASCI: Add tests for voice group/broadcast calls at MSC Related: OS#4854 Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.cfg M msc/MSC_Tests.ttcn A msc/MSC_Tests_ASCI.ttcn 4 files changed, 699 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/33979/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 Gerrit-Change-Number: 33979 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ASCI: Update commit hash of titan.ProtocolModules.MobileL3_v13.4.0

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34232 ) Change subject: ASCI: Update commit hash of titan.ProtocolModules.MobileL3_v13.4.0 ...................................................................... ASCI: Update commit hash of titan.ProtocolModules.MobileL3_v13.4.0 After fixing GCC and BCC transaction ID, the new head is: b6602eb357673f097ea1a1d22edd568ecd239da1 Related: OS#4854 Change-Id: I2833750a8cf1def74f92a5a50f0d271891cee05f --- M deps/Makefile 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/34232/1 diff --git a/deps/Makefile b/deps/Makefile index c9aa1cf..0c8688f 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -104,7 +104,7 @@ titan.ProtocolModules.MAP_commit= R.2.A-1-g79c6a3d titan.ProtocolModules.M2PA_commit= R.2.A-5-ga75b589 titan.ProtocolModules.M3UA_commit= c496d298876fed55c2b730278b7ee77982555563 -titan.ProtocolModules.MobileL3_v13.4.0_commit= 76a3557f69834b6171652aaeaeef220444c35ba7 +titan.ProtocolModules.MobileL3_v13.4.0_commit= b6602eb357673f097ea1a1d22edd568ecd239da1 titan.ProtocolModules.NAS_EPS_15.2.0.1_commit= R.1.A-2-g2ba853c titan.ProtocolModules.NS_v7.3.0_commit= R.2.A-6-gf73f195 titan.ProtocolModules.RTP_commit= R.5.A-4-g83ee83a -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2833750a8cf1def74f92a5a50f0d271891cee05f Gerrit-Change-Number: 34232 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: sigtran: Document SCTP (peer) primary address configuration

by osmith

Attention is currently required from: laforge, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 ) Change subject: sigtran: Document SCTP (peer) primary address configuration ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File common/chapters/sigtran.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225/comment/1eef76f0_0758… PS1, Line 426: assoc > Done spec is still abbreviated, not sure if on purpose -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/34225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I8737ca3033293391c999395e2db1fe19cac3e911 Gerrit-Change-Number: 34225 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Aug 2023 09:04:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[L] Change in libosmo-netif[master]: stream tests: Eliminate timestamps from output

by pespin

Attention is currently required from: arehbein, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34224 ) Change subject: stream tests: Eliminate timestamps from output ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I didn't see any reason as to why it should be my patch introducing the differing behavior, because […] Simply and plain for me: I just submitted a test patch based on libosmo-netif master and it's passing tests fine: https://gerrit.osmocom.org/c/libosmo-netif/+/34231 which means whatever problem you are having, it may be a local problem or something related to your patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c Gerrit-Change-Number: 34224 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 29 Aug 2023 08:49:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmo-netif[master]: TEST: DONT MERGE

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34231 ) Change subject: TEST: DONT MERGE ...................................................................... TEST: DONT MERGE Change-Id: I5e220f6fd3a30ca921a2dea915275fcd4ae30ac4 --- A bla M include/osmocom/netif/ipa.h 2 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/31/34231/1 diff --git a/bla b/bla new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/bla diff --git a/include/osmocom/netif/ipa.h b/include/osmocom/netif/ipa.h index 1923253..75c0933 100644 --- a/include/osmocom/netif/ipa.h +++ b/include/osmocom/netif/ipa.h @@ -23,7 +23,7 @@ uint8_t proto_ext; } __attribute__ ((packed)); -#define OSMO_IPA_MSGB_CB(__msg) ((struct osmo_ipa_msgb_cb *)&((__msg)->cb[0])) +#define OSMO_IPA_MSGB_CB(__msg) ((struct osmo_ipa_msgb_cb *)&((__msg)->cb[0])) #define osmo_ipa_msgb_cb_proto(__x) OSMO_IPA_MSGB_CB(__x)->proto #define osmo_ipa_msgb_cb_proto_ext(__x) OSMO_IPA_MSGB_CB(__x)->proto_ext -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5e220f6fd3a30ca921a2dea915275fcd4ae30ac4 Gerrit-Change-Number: 34231 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in docker-playground[master]: dia2gsup: Fix logfile name

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34229 ) Change subject: dia2gsup: Fix logfile name ...................................................................... dia2gsup: Fix logfile name Change-Id: I26e480ee8358476dcda72d51c3d135a0806ca82b --- M osmo_dia2gsup-master/Dockerfile 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/osmo_dia2gsup-master/Dockerfile b/osmo_dia2gsup-master/Dockerfile index f8f535b..08c1e82 100644 --- a/osmo_dia2gsup-master/Dockerfile +++ b/osmo_dia2gsup-master/Dockerfile @@ -23,6 +23,6 @@ COPY osmo_dia2gsup.config /data/osmo_dia2gsup.config WORKDIR /data -CMD ["/bin/sh", "-c", "ERL_FLAGS='-config /data/osmo_dia2gsup.config' /tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup > /data/osmo_dia2gsup.config.log 2>&1"] +CMD ["/bin/sh", "-c", "ERL_FLAGS='-config /data/osmo_dia2gsup.config' /tmp/osmo_dia2gsup/_build/default/bin/osmo-dia2gsup > /data/osmo_dia2gsup.log 2>&1"] #EXPOSE -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I26e480ee8358476dcda72d51c3d135a0806ca82b Gerrit-Change-Number: 34229 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[L] Change in libosmo-netif[master]: stream tests: Eliminate timestamps from output

by arehbein

Attention is currently required from: pespin, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34224 ) Change subject: stream tests: Eliminate timestamps from output ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm sorry but I just have the feeling that you are now just simply giving an excuse saying they are […] I didn't see any reason as to why it should be my patch introducing the differing behavior, because I didn't change any of the patch logic in between leaving for vacation and working on it again now without 'random' times. I tried resetting libosmocore to an older patch (pre-'my vacation'), but that didn't fix it. So I looked around a bit and isolated the only other changes have been made to libosmo-netif recently. I eliminated those changes and it works now. The result can be found on the branch `arehbein/stream_tests_timestamp_behavior`. It's a result of resetting `master` to `8355b65d` and applying the patch for client-side IPA segm. support as well as IPA-mode for sending messages. ``` $ git branch arehbein/libosmo-netif_segm_cb_changes arehbein/osmo_io_ipa arehbein/stream_tests_no_timestamps * arehbein/stream_tests_timestamp_behavior ``` ``` $ git log --pretty=format:"%h %an %x09%s" arehbein/stream_tests_timestamp_behavior..master # Commits on master, but not on ... aede0106 arehbein stream test: Fix test output check f990b307 arehbein stream: Add server-side (segmentation) support for IPA 74b62628 Pau Espin Pedrol stream: Use new flag OSMO_SOCK_F_SCTP_ASCONF_SUPPORTED for SCTP sockets 18c160a0 Pau Espin Pedrol stream_cli: Forward SCTP MSG_NOTIFICATION to upper layers deafe50c Pau Espin Pedrol stream: Refactor sctp_recvmsg_wrapper() logging a49a2b4d Pau Espin Pedrol stream_srv: Log SCTP REMOTE_ERROR events bcfa37ad Pau Espin Pedrol stream_srv: sctp: Log error cause of COMM_LOST event 7d143015 Pau Espin Pedrol sctp: Document relevant RFC specs 48f9a3c2 Pau Espin Pedrol stream_cli: Proper handling of send() socket errors 3ee52742 Pau Espin Pedrol stream_srv: Handle ESHUTDOWN and other write() errors destroying the socket a69a958a Pau Espin Pedrol stream: Append data to current tail of message upon recv() b8fb6954 Pau Espin Pedrol stream_srv: Improve logging lines accepting new connections 7e68ac2c Pau Espin Pedrol stream_srv: call setsockopt(SO_NOSIGPIPE) also in srv sockets f42d4c3b Pau Espin Pedrol stream_srv: Use LOGSLNK() to print log line 1f7c44a1 Pau Espin Pedrol stream_cli: Increase log level of established conn to INFO ``` ``` $ git log --pretty=format:"%h %an %x09%s" master..arehbein/stream_tests_timestamp_behavior # Commits on ..., but not on master b4caa60f arehbein stream: Add and use IPA send function 7dc6be89 arehbein stream: Add client-side (segmentation) support for IPA 4d7172fa arehbein stream: Add server-side (segmentation) support for IPA ``` The commits titled `stream: Add server-side (segmentation) support for IPA` only differ in positional data in one spot as well as in reference hashes pertaining to git data. The last commit on `arehbein/stream_tests....` doesn't make a difference (tried that with `git rebase` and breaking before the patch is applied). There are a couple of changes one could look at, is it really worth going through them all with git bisect, adding my commits on top (including resolving merge conflicts) and checking if timestamps go 'random' to find out what causes a minor fluctuation in select-loop iterations that are needed to achieve the same end result? Especially considering that the reason is most likely some logic running over variable amounts of select loop iterations. What difference does it make, or what would the consequential action be? I have stated a reason why we shouldn't need timestamps, as well. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c Gerrit-Change-Number: 34224 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 20:10:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in docker-playground[master]: dia2gsup: Fix logfile name

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34229 ) Change subject: dia2gsup: Fix logfile name ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I26e480ee8358476dcda72d51c3d135a0806ca82b Gerrit-Change-Number: 34229 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Aug 2023 19:27:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: DIAMETER: Origin-State-Id in DWR and DWA messages is optional

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34230 ) Change subject: DIAMETER: Origin-State-Id in DWR and DWA messages is optional ...................................................................... DIAMETER: Origin-State-Id in DWR and DWA messages is optional Change-Id: I02e6f97a308f1752711aafed39c1d7534a382c70 --- M library/DIAMETER_Templates.ttcn 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/34230/1 diff --git a/library/DIAMETER_Templates.ttcn b/library/DIAMETER_Templates.ttcn index 85725fc..63db7fc 100644 --- a/library/DIAMETER_Templates.ttcn +++ b/library/DIAMETER_Templates.ttcn @@ -1678,8 +1678,8 @@ ete_id := ete_id, avps := superset( tr_AVP_OriginHost(orig_host), - tr_AVP_OriginRealm(orig_realm), - tr_AVP_OriginStateId(state_id) + tr_AVP_OriginRealm(orig_realm) + /* tr_AVP_OriginStateId(state_id) is optional */ )); /* RFC 6733, section 5.5.2 "Device-Watchdog-Answer" */ @@ -1714,8 +1714,8 @@ avps := superset( tr_AVP_ResultCode(DIAMETER_SUCCESS), tr_AVP_OriginHost(orig_host), - tr_AVP_OriginRealm(orig_realm), - tr_AVP_OriginStateId(state_id) + tr_AVP_OriginRealm(orig_realm) + /* tr_AVP_OriginStateId(state_id) is optional */ )); function f_DIAMETER_get_avp(PDU_DIAMETER pdu, template (present) AVP_Code avp_code) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I02e6f97a308f1752711aafed39c1d7534a382c70 Gerrit-Change-Number: 34230 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023