April 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-gprs[master]: sm: Fill gmmsm.establish_req.attach_with_imsi

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32491 ) Change subject: sm: Fill gmmsm.establish_req.attach_with_imsi ...................................................................... sm: Fill gmmsm.establish_req.attach_with_imsi Change-Id: Ie4fbadc1c3a32375ccae84a4d54366d59ab7fe2f --- M src/sm/sm.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/91/32491/1 diff --git a/src/sm/sm.c b/src/sm/sm.c index 0f39708..4fa35df 100644 --- a/src/sm/sm.c +++ b/src/sm/sm.c @@ -26,6 +26,7 @@ #include <osmocom/core/talloc.h> #include <osmocom/core/tdef.h> #include <osmocom/gsm/protocol/gsm_04_08_gprs.h> +#include <osmocom/gsm/gsm48.h> #include <osmocom/gprs/sndcp/sndcp_prim.h> @@ -190,6 +191,7 @@ gmm_prim_tx = osmo_gprs_gmm_prim_alloc_gmmsm_establish_req(sme->sess_id); gmm_prim_tx->gmmsm.establish_req.attach_type = OSMO_GPRS_GMM_ATTACH_TYPE_GPRS; + gmm_prim_tx->gmmsm.establish_req.attach_with_imsi = (ms->gmm.ptmsi == GSM_RESERVED_TMSI); gmm_prim_tx->gmmsm.establish_req.ptmsi = ms->gmm.ptmsi; OSMO_STRLCPY_ARRAY(gmm_prim_tx->gmmsm.establish_req.imsi, ms->gmm.imsi); OSMO_STRLCPY_ARRAY(gmm_prim_tx->gmmsm.establish_req.imei, ms->gmm.imei); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32491 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie4fbadc1c3a32375ccae84a4d54366d59ab7fe2f Gerrit-Change-Number: 32491 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: doc/examples/modem: Update modem.cfg with new features

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32490 ) Change subject: doc/examples/modem: Update modem.cfg with new features ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/32490/comment/97f4ee4d_a82e1fb6 PS2, Line 12: contrainsted constrained 🚂 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6060c833de2eef7591b7a4f149d9e148455db970 Gerrit-Change-Number: 32490 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: vty: Move imei related commands to common/

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32488 ) Change subject: layer23: vty: Move imei related commands to common/ ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3c71586c0eb437ce63beaae5adf8fac6c27e2896 Gerrit-Change-Number: 32488 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:21:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Forward GMM primitives up to SM layer

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32484 ) Change subject: layer23: modem: Forward GMM primitives up to SM layer ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5c5416775ccce4a1cbc70c8f6ba4fc25ace12d6f Gerrit-Change-Number: 32484 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:20:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in osmocom-bb[master]: layer23: Move testsim node to common/

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32419 ) Change subject: layer23: Move testsim node to common/ ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife34403a715809b43e7a4cd5ce4dec8616fc08af Gerrit-Change-Number: 32419 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:19:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in osmocom-bb[master]: layer23: vty: Move sim related commands to common/

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32441 ) Change subject: layer23: vty: Move sim related commands to common/ ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32441/comment/d72941cb_04077fb2 PS2, Line 1140: prefix, osmo_hexdump(set->test_ki, 12), VTY_NEWLINE); > ah I fixed it in the wrong patch. I'll redo. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9e95732255c248b000f1045c395a15217d10db78 Gerrit-Change-Number: 32441 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:18:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Use subscriber information and events to trigger GMMREG Attach

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32442 ) Change subject: layer23: Use subscriber information and events to trigger GMMREG Attach ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1c7cc120ff4098c0b845e13a6e5e5db8b7e18376 Gerrit-Change-Number: 32442 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:17:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in osmocom-bb[master]: layer23: vty: Move sim related commands to common/

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32441 ) Change subject: layer23: vty: Move sim related commands to common/ ...................................................................... Patch Set 2: (1 comment) File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32441/comment/716cf0d6_78ba3551 PS2, Line 1140: prefix, osmo_hexdump(set->test_ki, 12), VTY_NEWLINE); > this seems unrelated ah I fixed it in the wrong patch. I'll redo. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32441 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9e95732255c248b000f1045c395a15217d10db78 Gerrit-Change-Number: 32441 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:14:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: Use subscriber information and events to trigger GMMREG Attach

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32442 to look at the new patch set (#5). Change subject: layer23: Use subscriber information and events to trigger GMMREG Attach ...................................................................... layer23: Use subscriber information and events to trigger GMMREG Attach Change-Id: I1c7cc120ff4098c0b845e13a6e5e5db8b7e18376 --- M src/host/layer23/include/osmocom/bb/modem/gmm.h M src/host/layer23/include/osmocom/bb/modem/sm.h M src/host/layer23/src/modem/app_modem.c M src/host/layer23/src/modem/gmm.c M src/host/layer23/src/modem/sm.c M src/host/layer23/src/modem/vty.c 6 files changed, 161 insertions(+), 65 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/42/32442/5 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1c7cc120ff4098c0b845e13a6e5e5db8b7e18376 Gerrit-Change-Number: 32442 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Forward GMM primitives up to SM layer

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32484 to look at the new patch set (#4). Change subject: layer23: modem: Forward GMM primitives up to SM layer ...................................................................... layer23: modem: Forward GMM primitives up to SM layer Change-Id: I5c5416775ccce4a1cbc70c8f6ba4fc25ace12d6f --- M src/host/layer23/src/modem/gmm.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/84/32484/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5c5416775ccce4a1cbc70c8f6ba4fc25ace12d6f Gerrit-Change-Number: 32484 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023