April 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-mgw[master]: mgcp_codec: fix codec decision

by neels

Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32218 ) Change subject: mgcp_codec: fix codec decision ...................................................................... Patch Set 8: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6c3291f825488e5d8ce136aeb18450156794aeb5 Gerrit-Change-Number: 32218 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:32:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in osmo-mgw[master]: mgcp_codec: fix codec decision

by neels

Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32218 ) Change subject: mgcp_codec: fix codec decision ...................................................................... Patch Set 8: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/1201c686_7e648bb6 PS8, Line 12: againt agent? Patchset: PS8: I'm having difficulties reviewing: I need to manually figure out whether mgcp_codec_decide() has changed. Is it possible / easy to add a separate patch that only moves the function, and then I can easily see here what parts of it changed? I wrote some review below but I haven't completely read and understood this patch yet. Would be great if you could clarify a bit, thanks! File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/6aec06cc_12a92977 PS8, Line 386: codecs_assigned = rtp_end->codecs_assigned; : OSMO_ASS (lets put these two lines inside the 'if { ...' below) https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/17e03822_c386cb44 PS8, Line 400: e (add a comma "in case of foo, barize") https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/5a2c0fd7_f9f5d8ec PS8, Line 401: * a tentative decision is made. i fail to understand: 1) Decide for both sides? The MGW has two lists of pt-nr to codec. It gets a specific pt-nr in an RTP packet on one side, and needs to decide what the pt-nr for this codec is on the other side. So how can there be a decision on both sides? 2) destination connection? RTP is UDP, there is no connection? do you mean to say "in case no destination endpoint is set up"? 3) how do codec choices matter when there is no destination side? this only makes sense to run when both sides of RTP are set up and ready? File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/762637cd_27599f00 PS8, Line 511: rtp_hdr->payload_type = (uint8_t) conn_dst->end.codec->payload_type; this looks wrong. There should not be one specific payload type on an endpoint. There should always be a list of possible payload types. This function should get as input the payload type number of one specific RTP packet that arrived, plus the list of pt-to-codec from the src side, and also the destination endpoint. 1. This should look up the codec that src-pt-nr means, in the source endpoint cfg. 2. Then should find this codec in the destination endpoint list and patch the matching pt-nr into this particular RTP packet. What confuses me is that it seems this is what the function was doing before this patch, and now it is changed to sort of pick one specific codec from conn_dst->end that has been decided on beforehand? (which would be wrong AFAIK) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6c3291f825488e5d8ce136aeb18450156794aeb5 Gerrit-Change-Number: 32218 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:32:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: publish-manuals-for-tags: enable IU/PFCP VTY cmds

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32434 ) Change subject: publish-manuals-for-tags: enable IU/PFCP VTY cmds ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > patchset 3 is the same as 1, as discussed in chat. […] if they were enabled by default, then we wouldn't have this problem of missing commands in the VTY reference =) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3 Gerrit-Change-Number: 32434 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:53:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master,gerrit: use PFCP var for osmo-hnbgw

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32432 ) Change subject: jobs/master,gerrit: use PFCP var for osmo-hnbgw ...................................................................... Patch Set 1: -Code-Review (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/32432/comment/883c5c4e_6ec4b0bc PS1, Line 380: (PFCP == "--disable-pfcp" && WITH_MANUALS == "0") (IMHO it should be consistent with WITH_MANUALS, i.e. WITH_PFCP = [0|1], also prevents typos in incoming $PFCP which could be *anything* in this patch) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a4e25e0c179c0d408c3728a28eb75bbfa086f48 Gerrit-Change-Number: 32432 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:51:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: contrib/jenkins.sh: add PFCP variable

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 ) Change subject: contrib/jenkins.sh: add PFCP variable ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430/comment/f6675a84_583b3e40 PS2, Line 9: PFCP=${PFCP:-"--enable-pfcp"} IMHO it should rather be consistent with 'WITH_MANUALS': WITH_PFCP=[0|1] and add '--enable-pfcp' below in 'if PFCP == 1' https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430/comment/3e421e93_fd6b66d0 PS2, Line 48: = += here so that WITH_MANUALS == 1 does not lose the --enable-pfcp again -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e Gerrit-Change-Number: 32430 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:50:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: publish-manuals-for-tags: enable IU/PFCP VTY cmds

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32434 ) Change subject: publish-manuals-for-tags: enable IU/PFCP VTY cmds ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32434 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9685857348e3b38f13acc1429c7a49fb9e5d92f3 Gerrit-Change-Number: 32434 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:45:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master,gerrit: use PFCP var for osmo-hnbgw

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32432 ) Change subject: jobs/master,gerrit: use PFCP var for osmo-hnbgw ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a4e25e0c179c0d408c3728a28eb75bbfa086f48 Gerrit-Change-Number: 32432 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:44:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/master,gerrit: build manuals with IU

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/32433 ) Change subject: jobs/master,gerrit: build manuals with IU ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32433 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib9c47796b582add90ef72376b4c0368a29d89b15 Gerrit-Change-Number: 32433 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 18:43:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add penalty time control

by matanp

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32498 ) Change subject: ctrl: Add penalty time control ...................................................................... ctrl: Add penalty time control Change-Id: Idfdd54dec72fb5f52eee22df018161d75b8c48c8 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 68 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/98/32498/1 diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index a971fab..57b8756 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -737,6 +737,64 @@ CTRL_CMD_DEFINE(bts_cell_reselection_offset, "cell-reselection-offset"); +static int verify_bts_penalty_time(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + int penalty_time; + + if (strcmp(value, "reserved") == 0) + return 0; + + penalty_time = atoi(value); + + if (penalty_time < 20 || penalty_time > 620) { + cmd->reply = "Value is out of range"; + return 1; + } else if (penalty_time % 20 != 0) { + cmd->reply = "Value must be a multiple of 20"; + return 1; + } + + return 0; +} + +static int get_bts_penalty_time(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + + if (!bts->si_common.cell_ro_sel_par.present) { + cmd->reply = "0"; + return CTRL_CMD_REPLY; + } + + if (bts->si_common.cell_ro_sel_par.penalty_time == 31) { + cmd->reply = "reserved"; + return CTRL_CMD_REPLY; + } + + cmd->reply = talloc_asprintf(cmd, "%u", (bts->si_common.cell_ro_sel_par.penalty_time * 20) + 20); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + return CTRL_CMD_REPLY; +} + +static int set_bts_penalty_time(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + bts->si_common.cell_ro_sel_par.present = 1; + + if (strcmp(cmd->value, "reserved") == 0) + bts->si_common.cell_ro_sel_par.penalty_time = 31; + else + bts->si_common.cell_ro_sel_par.penalty_time = (atoi(cmd->value) - 20) / 20; + + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE(bts_penalty_time, "penalty-time"); + int bsc_bts_ctrl_cmds_install(void) { int rc = 0; @@ -760,6 +818,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_earfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_uarfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_offset); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_penalty_time); rc |= neighbor_ident_ctrl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfdd54dec72fb5f52eee22df018161d75b8c48c8 Gerrit-Change-Number: 32498 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Store P-TMSI allocated by the network

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32496 ) Change subject: layer23: modem: Store P-TMSI allocated by the network ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32496 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ide686230336d68153db59e76dd97b7e7c6f500d8 Gerrit-Change-Number: 32496 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 25 Apr 2023 17:40:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023