Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323 )
Change subject: sccp: allow separate cs7 for IuPS and IuCS
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
What I am missing here is dding a new .cfg file to doc/examples/ showcasing this new possible setup. It also helps in reviewing the patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32323
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iea1824f1c586723d989c80a909bae16bd2866e08
Gerrit-Change-Number: 32323
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 09:38:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32274 )
Change subject: TODO-RELEASE: add note on osmo-sip-connector and SDP
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> no, not correct. […]
The word I used *depends* I meant in the sense of using the new feature, and the main point was that it will need >1.6.0, which is the kind of informative text useful for people reading what's needed in order to have the new feature.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32274
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I37fb5e18f06a5379d0320ee7d47885c9283cbd06
Gerrit-Change-Number: 32274
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Apr 2023 09:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32277 )
Change subject: ctrl: drop deprecated neighbor resolution interface
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
File src/osmo-bsc/neighbor_ident_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32277/comment/fed041ef_3b1f6fea
PS8, Line 553: /* This and the following: Add/Remove a CGI-PS as neighbor */
why are you dropping this? This code is independent from the inteface you are removing.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I93e25856eede4b2f5aa36d8a16714b43d37b4fd0
Gerrit-Change-Number: 32277
Gerrit-PatchSet: 8
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Apr 2023 09:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32277 )
Change subject: ctrl: drop deprecated neighbor resolution interface
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
You need to also drop it from TTCN3 tests, there are some tests optionally being able to use/test that interface.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32277
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I93e25856eede4b2f5aa36d8a16714b43d37b4fd0
Gerrit-Change-Number: 32277
Gerrit-PatchSet: 8
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Apr 2023 09:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment